On Wed, 16 Oct 2024 01:50:02 GMT, David Holmes wrote:
>>> Personally I think it is foolish to trust this compiler and rather than
>>> dropping the optimisation level for the one file we've been lucky enough to
>>> know has been compiled incorrectly, we should issue a fatal error if this
>>> co
On Tue, 15 Oct 2024 12:16:28 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch? Previously it's
>> https://github.com/openjdk/jdk/pull/18605.
>> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>>
>> Thanks!
>>
>> ## Test
>> ### tests:
>> * test/jdk/jdk/incubator/v
On Tue, 15 Oct 2024 22:16:27 GMT, Sean Mullan wrote:
>> src/java.desktop/share/classes/java/awt/Robot.java line 433:
>>
>>> 431: * then a {@code SecurityException} may be thrown,
>>> 432: * or the content of the returned {@code Color} is undefined.
>>> 433: *
>>
>> This text sho
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Tue, 15 Oct 2024 21:30:13 GMT, Volodymyr Paprotski wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix aarch64.ad
>
> src/hotspot/cpu/x86/c2_stubGenerator_x86_64_string.cpp line 414:
>
>> 412: // to the valid
On Tue, 15 Oct 2024 22:09:54 GMT, Volodymyr Paprotski wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix aarch64.ad
>
> src/hotspot/cpu/x86/c2_stubGenerator_x86_64_string.cpp line 1659:
>
>> 1657: Label L_moreT
On Tue, 15 Oct 2024 22:31:27 GMT, Volodymyr Paprotski wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix aarch64.ad
>
> src/hotspot/cpu/x86/c2_stubGenerator_x86_64_string.cpp line 1634:
>
>> 1632:
>> 1633:
>> 1
On Tue, 15 Oct 2024 18:45:37 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
On Tue, 15 Oct 2024 18:45:37 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
On Tue, 15 Oct 2024 19:31:45 GMT, Magnus Ihse Bursie wrote:
>>> After thinking a bit more on this, I concluded that we cannot automatically
>>> extract a proper set of ld flags from what's being passed to the individual
>>> libraries. The LDFLAGS needed by the monolithic static library needs to
On Tue, 15 Oct 2024 18:57:11 GMT, Phil Race wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main chan
> Hi,
> Can you help to review the patch? Previously it's
> https://github.com/openjdk/jdk/pull/18605.
> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>
> Thanks!
>
> ## Test
> ### tests:
> * test/jdk/jdk/incubator/vector/
> * test/hotspot/jtreg/compiler/vectorapi/
>
> ### opti
On Wed, 16 Oct 2024 06:28:03 GMT, Alan Bateman wrote:
>> Thanks, will fix.
>
> SecurityManager::getClassContext hasn't been needed since JDK 9 but we
> decided to keep the implementation in case there are older versions of
> logging libraries that extend SecurityManager so they can call this me
On Wed, 16 Oct 2024 13:46:24 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 16 Oct 2024 13:02:32 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
On Wed, 16 Oct 2024 13:46:24 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 16 Oct 2024 15:39:08 GMT, Magnus Ihse Bursie wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove usage of TIDY_HOME, replace with TIDY
>> Revert changes to RunTestsPrebuiltSpec.gmk
>> Add TEST_DEPS
On Wed, 16 Oct 2024 13:02:52 GMT, Nizar Benalla wrote:
>> Can I get a review for this patch that adds the necessary changes for local
>> support of the `tidy` library.
>>
>> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
>> on Linux and MacOs systems.
>>
>> This
On Tue, 15 Oct 2024 19:35:20 GMT, Erik Joelsson wrote:
>> I may need suggestions, I pushed the last changes to the other PR
>> [f5aeddd](https://github.com/openjdk/jdk/pull/21272/commits/f5aeddd8a2b142934558d75b5b81823ddeefd6e0).
>>
>> I need a way to set `TIDY` without using configure, so that
On Wed, 16 Oct 2024 12:15:51 GMT, Ludovic Henry wrote:
>> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 8218:
>>
>>> 8216:
>>> 8217: snprintf(ebuf, sizeof(ebuf), "%sdx_%ssve",
>>> VectorSupport::mathname[op], ulf);
>>> 8218:
>>> StubRoutines::_vector_d_math[VectorSupp
On Wed, 16 Oct 2024 12:13:32 GMT, Coleen Phillimore wrote:
> We're seeing failures in our nightly testing for tests
> runtime/cds/appcds/SharedBaseAddress.java and
> runtime/cds/SharedBaseAddress.java which I'm tracking in this bug
> [JDK-8340212](https://bugs.openjdk.org/browse/JDK-8340212)
>
On Wed, 16 Oct 2024 09:31:12 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
> Please review this change that adds a new test root `docs` dedicated to
> testing the documentation, which has been a work in progress for a while.
> Tests for links, encoding, HTML, accessibility will be later added in
> following PRs.
>
> We also define a new make target `test-docs` meant
On Wed, 16 Oct 2024 10:29:58 GMT, Fei Gao wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update make/autoconf/flags-cflags.m4
>>
>> Co-authored-by: Magnus Ihse Bursie
>
> src/hotspot/cpu/aarch64/stubGenerator_a
On Wed, 16 Oct 2024 16:19:51 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
On Wed, 16 Oct 2024 15:31:49 GMT, ExE Boss wrote:
>> SecurityManager::getClassContext hasn't been needed since JDK 9 but we
>> decided to keep the implementation in case there are older versions of
>> logging libraries that extend SecurityManager so they can call this method.
>> What we have c
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote:
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main change
> Please review this change that adds a new test root `docs` dedicated to
> testing the documentation, which has been a work in progress for a while.
> Tests for links, encoding, HTML, accessibility will be later added in
> following PRs.
>
> We also define a new make target `test-docs` meant
On Tue, 15 Oct 2024 18:45:37 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
> Can I get a review for this patch that adds the necessary changes for local
> support of the `tidy` library.
>
> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
> on Linux and MacOs systems.
>
> This dependency is primarily going to be used to test the generated
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Wed, 16 Oct 2024 20:14:07 GMT, Sean Mullan wrote:
>> We've had logging library maintainers on the core-libs-dev several times in
>> the last 7+ years so I hope there is good awareness of StackWalker.
>> SM.getClassContext is legacy, shouldn't be any reason to use it in 2024.
>
> Ok, I'll als
On Wed, 16 Oct 2024 13:02:52 GMT, Nizar Benalla wrote:
>> Can I get a review for this patch that adds the necessary changes for local
>> support of the `tidy` library.
>>
>> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
>> on Linux and MacOs systems.
>>
>> This
On Wed, 16 Oct 2024 15:53:33 GMT, Alan Bateman wrote:
>> **SLF4J** currently depends on this method when logger name mismatch
>> detection is enabled.
>>
>>
>>
>> See also:
>> - https://github.com/qos-ch/slf4j/pul
On Wed, 16 Oct 2024 16:04:21 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 16 Oct 2024 06:58:40 GMT, Alan Bateman wrote:
>> Ok, I will revert it.
>
> The description for the SecurityException thrown by these methods were
> adjusted to "if access to the screen is denied by desktop environment". If
> you bring back the paragraphs that were removed then you might
On Wed, 16 Oct 2024 13:28:47 GMT, Weijun Wang wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 16 Oct 2024 16:19:51 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote:
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main change
On Wed, 16 Oct 2024 13:02:52 GMT, Nizar Benalla wrote:
>> Can I get a review for this patch that adds the necessary changes for local
>> support of the `tidy` library.
>>
>> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
>> on Linux and MacOs systems.
>>
>> This
41 matches
Mail list logo
