Re: RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-10 Thread Chen Liang
On Fri, 11 Oct 2024 03:14:40 GMT, SendaoYan wrote: > Hi all, > On alinux3(alibaba cloud linux version 3) system, the /tmp disk partition is > mounted as tmpfs filesystem type, this filesystem type doesn't support create > time(birth time). > This PR is a REDO PR of https://github.com/openjdk/jd

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v2]

2024-10-10 Thread Nizar Benalla
On Thu, 10 Oct 2024 18:16:59 GMT, Erik Joelsson wrote: >> Nizar Benalla has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update after review comments > > make/conf/jib-profiles.js line 1048: > >> 1046: var runTestPrebuiltSrcFullE

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v3]

2024-10-10 Thread Nizar Benalla
On Thu, 10 Oct 2024 18:11:23 GMT, Erik Joelsson wrote: >> Nizar Benalla has updated the pull request incrementally with one additional >> commit since the last revision: >> >> typos - remove a few mentions of doccheck > > make/conf/jib-profiles.js line 1004: > >> 1002: var testOnlyProfil

Re: RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode [v3]

2024-10-10 Thread Axel Boldt-Christmas
> This is the implementation task for `JEP 490: ZGC: Remove the > Non-Generational Mode`. See the JEP for details. > [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The incremental we

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500

2024-10-10 Thread SendaoYan
On Fri, 11 Oct 2024 02:38:40 GMT, Fei Yang wrote: > So I tried following change, seems to work: This change works for native gcc13 and native gcc14. Size of vector_math_rvv.o build from gcc14 -rw-r--r-- 1 yansendao yansendao 5.0M Oct 11 13:31 ./linux-riscv64-server-release/support/native/jdk.

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500 [v2]

2024-10-10 Thread SendaoYan
On Thu, 10 Oct 2024 10:04:32 GMT, Hamlin Li wrote: >> SendaoYan has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - chech gcc and clang verison to determine #include or not >> - chech gcc and clang verison to determine #include or not >

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500 [v2]

2024-10-10 Thread Fei Yang
On Fri, 11 Oct 2024 04:02:53 GMT, SendaoYan wrote: >> Hi all, >> The file >> `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c` >> introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880) >> native build fails by fedora OS shipped gcc13. >> Gcc13 doesn't hav

RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-10 Thread SendaoYan
Hi all, On alinux3(alibaba cloud linux version 3) system, the /tmp disk partition is mounted as tmpfs filesystem type, this filesystem type doesn't support create time(birth time). This PR is a REDO PR of https://github.com/openjdk/jdk/pull/20687, the diffrent is delete `#include ` and add `#def

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500 [v2]

2024-10-10 Thread SendaoYan
> Hi all, > The file > `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c` > introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880) > native build fails by fedora OS shipped gcc13. > Gcc13 doesn't have `__riscv_v_intrinsic` macro by default, and do have > `_

Re: RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-10 Thread Chen Liang
On Fri, 11 Oct 2024 03:14:40 GMT, SendaoYan wrote: > Hi all, > On alinux3(alibaba cloud linux version 3) system, the /tmp disk partition is > mounted as tmpfs filesystem type, this filesystem type doesn't support create > time(birth time). > This PR is a REDO PR of https://github.com/openjdk/jd

Re: RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-10 Thread SendaoYan
On Fri, 11 Oct 2024 04:43:06 GMT, Chen Liang wrote: > Build and tier 1 jobs for Linux pass on Oracle's internal CI. Thanks. - PR Comment: https://git.openjdk.org/jdk/pull/21462#issuecomment-2406602280

Re: RFR: 8339570: Add Tidy build support for JDK tests [v2]

2024-10-10 Thread Nizar Benalla
> Can I get a review for this patch that adds the necessary changes for local > support of the `tidy` library. > > The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` > on Linux and MacOs systems. > > This dependency is primarily going to be used to test the generated

Re: RFR: 8311530: Deprecate jdk.jsobject module for removal [v3]

2024-10-10 Thread Kevin Rushforth
> Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it > with JavaFX instead. > > See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR > openjdk/jfx#1529 for the JavaFX PR that will include the module with JavaFX. > That PR describes the needed test scenarios

Re: RFR: 8335989: Implement Module Import Declarations (Second Preview)

2024-10-10 Thread Jan Lahoda
On Wed, 9 Oct 2024 19:22:01 GMT, Jan Lahoda wrote: > This is a current patch for module imports declarations, second preview. At > least the JEP number and preview revision will need to be updated in > `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is > ready to rece

Re: RFR: 8335989: Implement Module Import Declarations (Second Preview) [v2]

2024-10-10 Thread Jan Lahoda
> This is a current patch for module imports declarations, second preview. At > least the JEP number and preview revision will need to be updated in > `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is > ready to receive feedback. > > The main changes are: > - `require

Re: RFR: 8339570: Add Tidy build support for JDK tests [v3]

2024-10-10 Thread Nizar Benalla
> Can I get a review for this patch that adds the necessary changes for local > support of the `tidy` library. > > The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` > on Linux and MacOs systems. > > This dependency is primarily going to be used to test the generated

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500

2024-10-10 Thread Fei Yang
On Thu, 10 Oct 2024 07:37:43 GMT, SendaoYan wrote: > Hi all, > The file > `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c` > introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880) > native build fails by fedora OS shipped gcc13. > Gcc13 doesn't have `__r

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500

2024-10-10 Thread SendaoYan
On Thu, 10 Oct 2024 09:01:22 GMT, Hamlin Li wrote: > What we can do is to test if rvv intrinsic is really supported as we expect, > e.g. if "#include " is right, if it's true then we can still > add `-march=rv64gcv` flag, otherwise do not add the flag. Do you mind to > construct such a patch?

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500

2024-10-10 Thread Hamlin Li
On Thu, 10 Oct 2024 07:37:43 GMT, SendaoYan wrote: > Hi all, > The file > `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c` > introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880) > native build fails by fedora OS shipped gcc13. > Gcc13 doesn't have `__r

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v4]

2024-10-10 Thread Nizar Benalla
> Please review this change that adds a new test root `docs` dedicated to > testing the documentation, which has been a work in progress for a while. > Tests for links, encoding, HTML, accessibility will be later added in > following PRs. > > We also define a new make target `test-docs` meant

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v4]

2024-10-10 Thread Erik Joelsson
On Thu, 10 Oct 2024 21:57:57 GMT, Nizar Benalla wrote: >> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following P

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500

2024-10-10 Thread Fei Yang
On Thu, 10 Oct 2024 07:37:43 GMT, SendaoYan wrote: > Hi all, > The file > `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c` > introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880) > native build fails by fedora OS shipped gcc13. > Gcc13 doesn't have `__r

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v39]

2024-10-10 Thread Roberto CastaƱeda Lozano
On Tue, 8 Oct 2024 16:30:47 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> previ

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500

2024-10-10 Thread Hamlin Li
On Thu, 10 Oct 2024 07:37:43 GMT, SendaoYan wrote: > Hi all, > The file > `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c` > introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880) > native build fails by fedora OS shipped gcc13. > Gcc13 doesn't have `__r

Re: RFR: 8339570: Add Tidy build support for JDK tests [v3]

2024-10-10 Thread Erik Joelsson
On Thu, 10 Oct 2024 13:55:40 GMT, Nizar Benalla wrote: > I made a few changes based on the review comments. After a few iterations, I > now define module as `"tidy-html-" + input.target_os`. The dependency is > indeed multi arch so only one is needed for macos. When it's not too much work, we

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v3]

2024-10-10 Thread Erik Joelsson
On Thu, 10 Oct 2024 00:16:40 GMT, Nizar Benalla wrote: >> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following P

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500

2024-10-10 Thread Hamlin Li
On Thu, 10 Oct 2024 13:15:42 GMT, Fei Yang wrote: > FYI: I witnessed some different kinds of compile errors about libsleef while > building with GCC version 13.2.0 (Ubuntu 13.2.0-23ubuntu4) shipped with > Ubuntu 24.04.1 LTS riscv64. Seems that GCC-13 doesn't have a good support for > these RVV

Re: RFR: 8339570: Add Tidy build support for JDK tests [v3]

2024-10-10 Thread Nizar Benalla
On Thu, 10 Oct 2024 13:05:48 GMT, Nizar Benalla wrote: >> Can I get a review for this patch that adds the necessary changes for local >> support of the `tidy` library. >> >> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` >> on Linux and MacOs systems. >> >> This

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500

2024-10-10 Thread Fei Yang
On Thu, 10 Oct 2024 13:56:23 GMT, Hamlin Li wrote: > > FYI: I witnessed some different kinds of compile errors about libsleef > > while building with GCC version 13.2.0 (Ubuntu 13.2.0-23ubuntu4) shipped > > with Ubuntu 24.04.1 LTS riscv64. Seems that GCC-13 doesn't have a good > > support for

Re: RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500

2024-10-10 Thread Hamlin Li
On Thu, 10 Oct 2024 14:02:08 GMT, Fei Yang wrote: > FYI: I see they claim LLVM 17+ from the page: That's great, then it should be fine to just check the compiler version and enable `-march=rv64gcv` conditaionally. - PR Comment: https://git.openjdk.org/jdk/pull/21442#issuecomment-2

Re: RFR: 8339570: Add Tidy build support for JDK tests [v4]

2024-10-10 Thread Nizar Benalla
> Can I get a review for this patch that adds the necessary changes for local > support of the `tidy` library. > > The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` > on Linux and MacOs systems. > > This dependency is primarily going to be used to test the generated

RFR: 8341880: RISC-V: riscv_vector.h native build fails with gcc13 after JDK-8320500

2024-10-10 Thread SendaoYan
Hi all, The file `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c` introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880) native build fails by fedora OS shipped gcc13. Gcc13 doesn't have `__riscv_v_intrinsic` macro by default, and do have `__riscv_v_intrin