On Thu, 10 Oct 2024 13:05:48 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Can I get a review for this patch that adds the necessary changes for local >> support of the `tidy` library. >> >> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` >> on Linux and MacOs systems. >> >> This dependency is primarily going to be used to test the generated >> documentation. >> >> This patch is meant to be integrated before #21272. >> >> Note: we need to be a very specific revision of `tidy` and cannot use any of >> the available artifacts, as older versions do not recognize some HTML 5 >> elements. >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional > commit since the last revision: > > define the module as tidy-html + target_platform, as the linux binary is > not multi arch I made a few changes based on the review comments, I still define module as `module: "tidy-html-" + input.target_platform` but the dependency is now provided for linux-aarch64 too ------------- PR Comment: https://git.openjdk.org/jdk/pull/21341#issuecomment-2405167127