On Tue, 24 Sep 2024 19:09:29 GMT, Hamlin Li wrote:
>> Then why would we put a constraint on the number of supported argument
>> vector registers here (v8-v15 instead of v8-v23)? Could we just support all
>> of them, i.e., v8-v23 to comply with the RISC-V psABI?
>
> There is no strong reason, ju
On Tue, 24 Sep 2024 19:12:53 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks!
>>
>> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
>> the sleef source (in particular the generated sleef inline headers). We use
>> sleef api to vectorize
Currently the [security tab](https://github.com/openjdk/jdk/security) on the
GitHub repos is empty with no clear information or links on where to report
security vulnerabilities.
https://github.com/user-attachments/assets/4fd68f9f-46d8-4c06-ad71-52747c8f5cf2";>
I've made an exact copy of https:
> Hi,
> Can you help to review this patch?
> Thanks!
>
> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
> the sleef source (in particular the generated sleef inline headers). We use
> sleef api to vectorize the math operations in vector api.
>
> On machine with vec
On Tue, 24 Sep 2024 13:08:50 GMT, George Adams wrote:
>> Since JDK17 there has been a dependency on metal in the macOS builds which
>> is only available as part of the full Xcode IDE (rather than command-line
>> tools). We currently recommend only installing the command-line tools in the
>> bu
On Tue, 24 Sep 2024 19:20:11 GMT, George Adams wrote:
>> Currently the [security tab](https://github.com/openjdk/jdk/security) on the
>> GitHub repos is empty with no clear information or links on where to report
>> security vulnerabilities.
>>
>> > src="https://github.com/user-attachments/ass
On Tue, 24 Sep 2024 11:21:33 GMT, George Adams wrote:
> Since JDK17 there has been a dependency on metal in the macOS builds which is
> only available as part of the full Xcode IDE (rather than command-line
> tools). We currently recommend only installing the command-line tools in the
> buildi
On Tue, 24 Sep 2024 12:53:08 GMT, Erik Joelsson wrote:
>> Since JDK17 there has been a dependency on metal in the macOS builds which
>> is only available as part of the full Xcode IDE (rather than command-line
>> tools). We currently recommend only installing the command-line tools in the
>> b
On Tue, 24 Sep 2024 12:55:17 GMT, Erik Joelsson wrote:
> You can make it a link using markdown `[]()` syntax.
yeah I'll do that
-
PR Review Comment: https://git.openjdk.org/jdk/pull/21154#discussion_r1773293082
On Tue, 24 Sep 2024 12:54:49 GMT, George Adams wrote:
>> doc/building.html line 618:
>>
>>> 616: The oldest supported version of Xcode is 13.0.
>>> 617: You will need to download Xcode either from the App Store or
>>> specific
>>> 618: versions can be easily located via >> href="https://xcodere
On Tue, 24 Sep 2024 12:56:10 GMT, George Adams wrote:
>> You can make it a link using markdown `[]()` syntax.
>
>> You can make it a link using markdown `[]()` syntax.
>
> yeah I'll do that
I will approve once this is fixed, looks good
-
PR Review Comment: https://git.openjdk.org/
> Since JDK17 there has been a dependency on metal in the macOS builds which is
> only available as part of the full Xcode IDE (rather than command-line
> tools). We currently recommend only installing the command-line tools in the
> building.md doc which is incorrect.
>
> See
> https://github
On Tue, 24 Sep 2024 12:59:15 GMT, Julian Waters wrote:
>>> You can make it a link using markdown `[]()` syntax.
>>
>> yeah I'll do that
>
> I will approve once this is fixed, looks good
updated PTAL
-
PR Review Comment: https://git.openjdk.org/jdk/pull/21154#discussion_r1773305793
On Tue, 24 Sep 2024 13:06:16 GMT, George Adams wrote:
>> Since JDK17 there has been a dependency on metal in the macOS builds which
>> is only available as part of the full Xcode IDE (rather than command-line
>> tools). We currently recommend only installing the command-line tools in the
>> bu
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Tue, 24 Sep 2024 05:25:38 GMT, Robbin Ehn wrote:
>> src/hotspot/cpu/riscv/assembler_riscv.hpp line 51:
>>
>>> 49: n_int_register_parameters_c = 8, // x10, x11, ... x17 (c_rarg0,
>>> c_rarg1, ...)
>>> 50: n_float_register_parameters_c = 8, // f10, f11, ... f17 (c_farg0,
>>> c_f
On Fri, 20 Sep 2024 15:26:36 GMT, Roman Kennke wrote:
>> I tried to reproduce for a few hours now using a custom testcase, with no
>> success.
>> I am pretty sure that this can happen, that is why I added this code.
>> Originally I had an assert there asserting that index is not used. I do
>>
On Tue, 24 Sep 2024 14:52:39 GMT, Hamlin Li wrote:
>> Ah, I think I missed that. I was reading psABI spec 1.0 release. Thanks for
>> this info.
>
> Thanks Robbin for helping explaining!
>
> minor correction: v1-v7/v24-v31 = callee saved
Yes, sorry what I meant, updated.
-
PR Revi
On Tue, 24 Sep 2024 13:28:47 GMT, George Adams wrote:
> Currently the [security tab](https://github.com/openjdk/jdk/security) on the
> GitHub repos is empty with no clear information or links on where to report
> security vulnerabilities.
>
> src="https://github.com/user-attachments/assets/4f
> Hi,
> Can you help to review this patch?
> Thanks!
>
> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
> the sleef source (in particular the generated sleef inline headers). We use
> sleef api to vectorize the math operations in vector api.
>
> On machine with vec
On Tue, 24 Sep 2024 15:12:29 GMT, Fei Yang wrote:
>> Yes, sorry what I meant, updated.
>
> Then why would we put a constraint on the number of supported argument vector
> registers here (v8-v15 instead of v8-v23)? Could we just support all of them,
> i.e., v8-v23 to comply with the RISC-V psABI
> Currently the [security tab](https://github.com/openjdk/jdk/security) on the
> GitHub repos is empty with no clear information or links on where to report
> security vulnerabilities.
>
> src="https://github.com/user-attachments/assets/4fd68f9f-46d8-4c06-ad71-52747c8f5cf2";>
>
> I've added a
On Tue, 24 Sep 2024 17:18:57 GMT, George Adams wrote:
>> Since JDK17 there has been a dependency on metal in the macOS builds which
>> is only available as part of the full Xcode IDE (rather than command-line
>> tools). We currently recommend only installing the command-line tools in the
>> bu
On Tue, 24 Sep 2024 16:31:00 GMT, Erik Joelsson wrote:
> My personal opinion is that one should always try to avoid
> duplicating/forking documentation, so if we are to create a security.md file
> to populate the security tab in GitHub, then it should only contain a link to
> the official docu
On Tue, 24 Sep 2024 11:21:33 GMT, George Adams wrote:
> Since JDK17 there has been a dependency on metal in the macOS builds which is
> only available as part of the full Xcode IDE (rather than command-line
> tools). We currently recommend only installing the command-line tools in the
> buildi
On Tue, 24 Sep 2024 14:57:48 GMT, Robbin Ehn wrote:
>> Thanks Robbin for helping explaining!
>>
>> minor correction: v1-v7/v24-v31 = callee saved
>
> Yes, sorry what I meant, updated.
Then why would we put a constraint on the number of supported argument vector
registers here (v8-v15 instead o
On Tue, 24 Sep 2024 05:57:08 GMT, Robbin Ehn wrote:
>> src/hotspot/cpu/riscv/riscv.ad line 10078:
>>
>>> 10076: match(CallLeafVector);
>>> 10077:
>>> 10078: effect(USE meth);
>>
>> It's possible for the runtime call to clobber rFlagsReg `cr` (aka `t1`). So
>> safer to add `KILL cr` to the
On Tue, 24 Sep 2024 06:59:58 GMT, Fei Yang wrote:
>> Note in the RISC-V ELF psABI there is a convention variant for v-regs.
>> If you add function attribute riscv_vector_cc it should be used for C/C++.
>> (I never tested it)
>> v0 = first vector mask argument
>> v8-v23 = args/rets
>> v1-v7/v24-v
On Tue, 24 Sep 2024 03:47:41 GMT, Fei Yang wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refine comment
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 6063:
>
>> 6061:
>> 6062: void generate_vector_math_
On Fri, 20 Sep 2024 18:11:43 GMT, Coleen Phillimore wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'lilliput/JEP-450-temporary-fix-branch-2'
>> into JDK-8305895-v4
>> - review feed
On Tue, 24 Sep 2024 13:28:47 GMT, George Adams wrote:
> Currently the [security tab](https://github.com/openjdk/jdk/security) on the
> GitHub repos is empty with no clear information or links on where to report
> security vulnerabilities.
>
> src="https://github.com/user-attachments/assets/4f
> Since JDK17 there has been a dependency on metal in the macOS builds which is
> only available as part of the full Xcode IDE (rather than command-line
> tools). We currently recommend only installing the command-line tools in the
> building.md doc which is incorrect.
>
> See
> https://github
On Tue, 24 Sep 2024 13:28:47 GMT, George Adams wrote:
> Currently the [security tab](https://github.com/openjdk/jdk/security) on the
> GitHub repos is empty with no clear information or links on where to report
> security vulnerabilities.
>
> src="https://github.com/user-attachments/assets/4f
On Tue, 24 Sep 2024 17:18:57 GMT, George Adams wrote:
>> Since JDK17 there has been a dependency on metal in the macOS builds which
>> is only available as part of the full Xcode IDE (rather than command-line
>> tools). We currently recommend only installing the command-line tools in the
>> bu
On Tue, 24 Sep 2024 22:25:29 GMT, Mark Reinhold wrote:
>> George Adams has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> switch to link to website
>
> SECURITY.md line 3:
>
>> 1: # OpenJDK Vulnerabilities
>> 2:
>> 3: Please follow the pr
> Currently the [security tab](https://github.com/openjdk/jdk/security) on the
> GitHub repos is empty with no clear information or links on where to report
> security vulnerabilities.
>
> src="https://github.com/user-attachments/assets/4fd68f9f-46d8-4c06-ad71-52747c8f5cf2";>
>
> I've added a
Since JDK17 there has been a dependency on metal in the macOS builds which is
only available as part of the full Xcode IDE (rather than command-line tools).
We currently recommend only installing the command-line tools in the
building.md doc which is incorrect.
See
https://github.com/openjdk/j
37 matches
Mail list logo
