Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v2]

2024-09-23 Thread Ludovic Henry
On Mon, 23 Sep 2024 07:30:59 GMT, Hamlin Li wrote: >> Hi, >> Can you help to review this patch? >> Thanks! >> >> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added >> the sleef source (in particular the generated sleef inline headers). We use >> sleef api to vectorize

Re: RFR: 8311530: Deprecate jdk.jsobject module for removal

2024-09-23 Thread Kevin Rushforth
On Mon, 12 Aug 2024 17:22:47 GMT, Kevin Rushforth wrote: > Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it > with JavaFX instead. > > See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR > openjdk/jfx#1529 for the JavaFX PR that will include the module

Re: RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names

2024-09-23 Thread Andrew John Hughes
On Fri, 20 Sep 2024 16:09:13 GMT, Florian Weimer wrote: > 8340552: Harden TzdbZoneRulesCompiler against missing zone names Change looks good to me too. It should help catch issues at build time rather than when the data is used by the JDK. Please bump the copyright header as @naotoj mentions.

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v3]

2024-09-23 Thread Ludovic Henry
On Mon, 23 Sep 2024 16:25:02 GMT, Hamlin Li wrote: >> Hi, >> Can you help to review this patch? >> Thanks! >> >> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added >> the sleef source (in particular the generated sleef inline headers). We use >> sleef api to vectorize

Re: RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names [v2]

2024-09-23 Thread Florian Weimer
> 8340552: Harden TzdbZoneRulesCompiler against missing zone names Florian Weimer has updated the pull request incrementally with one additional commit since the last revision: Update copyright year - Changes: - all: https://git.openjdk.org/jdk/pull/21112/files - new: https:/

Re: RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names

2024-09-23 Thread Florian Weimer
On Fri, 20 Sep 2024 16:09:13 GMT, Florian Weimer wrote: > 8340552: Harden TzdbZoneRulesCompiler against missing zone names 920211592d3 should have the current copyright year. This isn't really testable because after a refactoring, the error condition this is guarding against can not happen. Up

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v3]

2024-09-23 Thread Hamlin Li
> Hi, > Can you help to review this patch? > Thanks! > > This patch is based on https://github.com/openjdk/jdk/pull/20781 which added > the sleef source (in particular the generated sleef inline headers). We use > sleef api to vectorize the math operations in vector api. > > On machine with vec

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v2]

2024-09-23 Thread Hamlin Li
On Mon, 23 Sep 2024 07:30:59 GMT, Hamlin Li wrote: >> Hi, >> Can you help to review this patch? >> Thanks! >> >> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added >> the sleef source (in particular the generated sleef inline headers). We use >> sleef api to vectorize

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v2]

2024-09-23 Thread Hamlin Li
On Mon, 23 Sep 2024 09:09:46 GMT, Ludovic Henry wrote: >> Hamlin Li has updated the pull request incrementally with one additional >> commit since the last revision: >> >> modify cflags style > > src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c line 24: > >> 22: */ >> 23

Re: RFR: 8311530: Deprecate jdk.jsobject module for removal [v2]

2024-09-23 Thread Kevin Rushforth
> Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it > with JavaFX instead. > > See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR > openjdk/jfx#1529 for the JavaFX PR that will include the module with JavaFX. > That PR describes the needed test scenarios

Re: RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names [v2]

2024-09-23 Thread Justin Lu
On Mon, 23 Sep 2024 15:28:48 GMT, Florian Weimer wrote: >> 8340552: Harden TzdbZoneRulesCompiler against missing zone names > > Florian Weimer has updated the pull request incrementally with one additional > commit since the last revision: > > Update copyright year LGTM. I agree that this is

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v2]

2024-09-23 Thread Hamlin Li
> Hi, > Can you help to review this patch? > Thanks! > > This patch is based on https://github.com/openjdk/jdk/pull/20781 which added > the sleef source (in particular the generated sleef inline headers). We use > sleef api to vectorize the math operations in vector api. > > On machine with vec

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v2]

2024-09-23 Thread Hamlin Li
On Fri, 20 Sep 2024 12:34:38 GMT, Erik Joelsson wrote: >> Thanks. I'm sorry too, I'm not familiar with the build system. >> What you expected could be something like below? >> >> diff --git a/make/modules/jdk.incubator.vector/Lib.gmk >> b/make/modules/jdk.incubator.vector/Lib.gmk >> index 5e522

Re: RFR: 8340574: Drop stackMapTable.cpp to -O1 for MacOS on XCode 16 to work around JDK-8340341

2024-09-23 Thread Erik Joelsson
On Sun, 22 Sep 2024 09:46:43 GMT, Thomas Stuefe wrote: > Trivial change to drop the optimization level (for both fastdebug and > release) of stackMapTable.cpp to O1 on MacOS with Xcode 16. > > This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which > prevents building on Ma

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v2]

2024-09-23 Thread Erik Joelsson
On Mon, 23 Sep 2024 07:30:59 GMT, Hamlin Li wrote: >> Hi, >> Can you help to review this patch? >> Thanks! >> >> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added >> the sleef source (in particular the generated sleef inline headers). We use >> sleef api to vectorize

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v4]

2024-09-23 Thread Hamlin Li
> Hi, > Can you help to review this patch? > Thanks! > > This patch is based on https://github.com/openjdk/jdk/pull/20781 which added > the sleef source (in particular the generated sleef inline headers). We use > sleef api to vectorize the math operations in vector api. > > On machine with vec

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v3]

2024-09-23 Thread Hamlin Li
On Mon, 23 Sep 2024 16:40:55 GMT, Ludovic Henry wrote: >> Hamlin Li has updated the pull request incrementally with one additional >> commit since the last revision: >> >> comment > > src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c line 31: > >> 29: // bridge functions b

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v4]

2024-09-23 Thread Fei Yang
On Mon, 23 Sep 2024 19:32:10 GMT, Hamlin Li wrote: >> Hi, >> Can you help to review this patch? >> Thanks! >> >> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added >> the sleef source (in particular the generated sleef inline headers). We use >> sleef api to vectorize

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v4]

2024-09-23 Thread Robbin Ehn
On Tue, 24 Sep 2024 03:50:29 GMT, Fei Yang wrote: >> Hamlin Li has updated the pull request incrementally with one additional >> commit since the last revision: >> >> refine comment > > src/hotspot/cpu/riscv/riscv.ad line 10078: > >> 10076: match(CallLeafVector); >> 10077: >> 10078: eff

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v4]

2024-09-23 Thread Robbin Ehn
On Tue, 24 Sep 2024 03:45:32 GMT, Fei Yang wrote: >> Hamlin Li has updated the pull request incrementally with one additional >> commit since the last revision: >> >> refine comment > > src/hotspot/cpu/riscv/assembler_riscv.hpp line 51: > >> 49: n_int_register_parameters_c = 8, // x1