Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v4]

2025-04-05 Thread Magnus Ihse Bursie
On Mon, 17 Mar 2025 16:35:12 GMT, Ioi Lam wrote: >> I modified TestSetupAOT.java to exercise more functionalities in the JDK so >> that we can have a more substantial AOT cache when running tests with >> `AOT_JDK=true`. E.g: >> >> >> make test JTREG=AOT_JDK=true \ >> TEST=open/test/jdk/ja

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v3]

2025-04-04 Thread Ioi Lam
On Mon, 17 Mar 2025 16:07:09 GMT, Leonid Mesnik wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed windows path problem > > Marked as reviewed by lmesnik (Reviewer). Thanks @lmesnik @erikj79 @vnkozlov for the review

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v4]

2025-03-17 Thread Erik Joelsson
On Mon, 17 Mar 2025 16:35:12 GMT, Ioi Lam wrote: >> I modified TestSetupAOT.java to exercise more functionalities in the JDK so >> that we can have a more substantial AOT cache when running tests with >> `AOT_JDK=true`. E.g: >> >> >> make test JTREG=AOT_JDK=true \ >> TEST=open/test/jdk/ja

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v4]

2025-03-17 Thread Ioi Lam
> I modified TestSetupAOT.java to exercise more functionalities in the JDK so > that we can have a more substantial AOT cache when running tests with > `AOT_JDK=true`. E.g: > > > make test JTREG=AOT_JDK=true \ > TEST=open/test/jdk/java/util/TimeZone/ListTimeZones.java > > > Before: the ge

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v3]

2025-03-17 Thread Leonid Mesnik
On Sat, 15 Mar 2025 20:36:09 GMT, Ioi Lam wrote: >> I modified TestSetupAOT.java to exercise more functionalities in the JDK so >> that we can have a more substantial AOT cache when running tests with >> `AOT_JDK=true`. E.g: >> >> >> make test JTREG=AOT_JDK=true \ >> TEST=open/test/jdk/ja

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v3]

2025-03-17 Thread Erik Joelsson
On Sat, 15 Mar 2025 20:36:09 GMT, Ioi Lam wrote: >> I modified TestSetupAOT.java to exercise more functionalities in the JDK so >> that we can have a more substantial AOT cache when running tests with >> `AOT_JDK=true`. E.g: >> >> >> make test JTREG=AOT_JDK=true \ >> TEST=open/test/jdk/ja

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v3]

2025-03-15 Thread Ioi Lam
> I modified TestSetupAOT.java to exercise more functionalities in the JDK so > that we can have a more substantial AOT cache when running tests with > `AOT_JDK=true`. E.g: > > > make test JTREG=AOT_JDK=true \ > TEST=open/test/jdk/java/util/TimeZone/ListTimeZones.java > > > Before: the ge

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v2]

2025-03-15 Thread Ioi Lam
On Fri, 14 Mar 2025 23:43:53 GMT, Erik Joelsson wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments from @erikj79 and @lmesnik > > make/test/BuildTestSetupAOT.gmk line 62: > >> 60: JavacBenchAp

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v2]

2025-03-14 Thread Ioi Lam
> I modified TestSetupAOT.java to exercise more functionalities in the JDK so > that we can have a more substantial AOT cache when running tests with > `AOT_JDK=true`. E.g: > > > make test JTREG=AOT_JDK=true \ > TEST=open/test/jdk/java/util/TimeZone/ListTimeZones.java > > > Before: the ge

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v2]

2025-03-14 Thread Leonid Mesnik
On Sat, 15 Mar 2025 02:08:33 GMT, Ioi Lam wrote: >> I modified TestSetupAOT.java to exercise more functionalities in the JDK so >> that we can have a more substantial AOT cache when running tests with >> `AOT_JDK=true`. E.g: >> >> >> make test JTREG=AOT_JDK=true \ >> TEST=open/test/jdk/ja

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v2]

2025-03-14 Thread Ioi Lam
On Fri, 14 Mar 2025 23:21:59 GMT, Leonid Mesnik wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments from @erikj79 and @lmesnik > > make/RunTests.gmk line 738: > >> 736: $1_AOT_JDK_CACHE := $$($1_TEST_SUPP

Re: RFR: 8352084: Add more test code in TestSetupAOT.java

2025-03-14 Thread Erik Joelsson
On Fri, 14 Mar 2025 20:13:57 GMT, Ioi Lam wrote: > I modified TestSetupAOT.java to exercise more functionalities in the JDK so > that we can have a more substantial AOT cache when running tests with > `AOT_JDK=true`. E.g: > > > make test JTREG=AOT_JDK=true \ > TEST=open/test/jdk/java/util

Re: RFR: 8352084: Add more test code in TestSetupAOT.java

2025-03-14 Thread Leonid Mesnik
On Fri, 14 Mar 2025 20:13:57 GMT, Ioi Lam wrote: > I modified TestSetupAOT.java to exercise more functionalities in the JDK so > that we can have a more substantial AOT cache when running tests with > `AOT_JDK=true`. E.g: > > > make test JTREG=AOT_JDK=true \ > TEST=open/test/jdk/java/util

Re: RFR: 8352084: Add more test code in TestSetupAOT.java

2025-03-14 Thread Vladimir Kozlov
On Fri, 14 Mar 2025 20:13:57 GMT, Ioi Lam wrote: > I modified TestSetupAOT.java to exercise more functionalities in the JDK so > that we can have a more substantial AOT cache when running tests with > `AOT_JDK=true`. E.g: > > > make test JTREG=AOT_JDK=true \ > TEST=open/test/jdk/java/util

RFR: 8352084: Add more test code in TestSetupAOT.java

2025-03-14 Thread Ioi Lam
I modified TestSetupAOT.java to exercise more functionalities in the JDK so that we can have a more substantial AOT cache when running tests with `AOT_JDK=true`. E.g: make test JTREG=AOT_JDK=true \ TEST=open/test/jdk/java/util/TimeZone/ListTimeZones.java Before: the generated AOT cache wa