On Sat, 15 Mar 2025 20:36:09 GMT, Ioi Lam <ik...@openjdk.org> wrote:
>> I modified TestSetupAOT.java to exercise more functionalities in the JDK so
>> that we can have a more substantial AOT cache when running tests with
>> `AOT_JDK=true`. E.g:
>>
>>
>> make test JTREG=AOT_JDK=true \
>> TEST=open/test/jdk/java/util/TimeZone/ListTimeZones.java
>>
>>
>> Before: the generated AOT cache was about 20 MB, with 2245 classes and 125
>> resolved indies
>> After: the generated AOT cache is about 34 MB, with 4703 classes and 912
>> resolved indies
>>
>> I verified with Mach5 tiers 4, 5, 6, 10 with all tests tasks that have the
>> label `.*aot.jdkcache.*`
>
> Ioi Lam has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Fixed windows path problem
make/RunTests.gmk line 758:
> 756: $$(call ExecuteWithLog, $$($1_AOT_JDK_OUTPUT_DIR), ( \
> 757: cd $$($1_AOT_JDK_OUTPUT_DIR); \
> 758: $$(FIXPATH) $(JAR_CMD) --extract --file
> $(TEST_IMAGE_DIR)/setup_aot/TestSetupAOT.jar; \
The variable `JAR` already has fixpath prefixed when needed.
Suggestion:
$$(JAR) --extract --file
$(TEST_IMAGE_DIR)/setup_aot/TestSetupAOT.jar; \
make/test/BuildTestSetupAOT.gmk line 57:
> 55: # Copy to hotspot jtreg test image
> 56: $(eval $(call SetupCopyFiles, COPY_SETUP_AOT, \
> 57: SRC := $(SETUP_AOT_SUPPORT), \
With just one file being copied, the SRC argument can be omitted. It will
default to the directory of the first file in FILES.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24067#discussion_r1998658649
PR Review Comment: https://git.openjdk.org/jdk/pull/24067#discussion_r1998668399
