Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-20 Thread Erik Joelsson
On Wed, 13 Nov 2024 23:15:47 GMT, Calvin Cheung wrote: >> With this change, the compact object headers related CDS archives >> (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by >> default. If the user needs them, the user can specify the >> `--enable-cds-archive-coh=ye

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-19 Thread Calvin Cheung
On Thu, 14 Nov 2024 05:18:05 GMT, Ioi Lam wrote: >> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @iklam comment > > Test changes look good. Thanks @iklam, @coleenp, @erikj79 for the review. - PR Comment: h

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v3]

2024-11-19 Thread Erik Joelsson
On Tue, 19 Nov 2024 22:50:37 GMT, Calvin Cheung wrote: >> With this change, the compact object headers related CDS archives >> (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by >> default. If the user needs them, the user can specify the >> `--enable-cds-archive-coh=ye

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-19 Thread Calvin Cheung
On Tue, 19 Nov 2024 14:18:59 GMT, Erik Joelsson wrote: > I'm a bit unsure what was actually agreed in the bug discussion. Are wanting > to disable this by default for OpenJDK, requiring anyone who wants it enabled > to add a new configure option, or are we only intending to change the > config

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v3]

2024-11-19 Thread Calvin Cheung
> With this change, the compact object headers related CDS archives > (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by > default. If the user needs them, the user can specify the > `--enable-cds-archive-coh=yes` build configure option. > This change also modified the Te

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-14 Thread Coleen Phillimore
On Wed, 13 Nov 2024 23:15:47 GMT, Calvin Cheung wrote: >> With this change, the compact object headers related CDS archives >> (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by >> default. If the user needs them, the user can specify the >> `--enable-cds-archive-coh=ye

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-13 Thread Ioi Lam
On Wed, 13 Nov 2024 23:15:47 GMT, Calvin Cheung wrote: >> With this change, the compact object headers related CDS archives >> (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by >> default. If the user needs them, the user can specify the >> `--enable-cds-archive-coh=ye

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-13 Thread Calvin Cheung
On Wed, 13 Nov 2024 19:43:54 GMT, Ioi Lam wrote: > I think it's best to avoid modifying the test JVM. It could be used in > parallel by another jtreg process, and it could also be in a read-only > directory. > > I would suggest checking for the existence of the COH files, and skip the > test

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-13 Thread Calvin Cheung
> With this change, the compact object headers related CDS archives > (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by > default. If the user needs them, the user can specify the > `--enable-cds-archive-coh=yes` build configure option. > This change also modified the Te

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives

2024-11-13 Thread Ioi Lam
On Tue, 12 Nov 2024 23:27:27 GMT, Calvin Cheung wrote: > With this change, the compact object headers related CDS archives > (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by > default. If the user needs them, the user can specify the > `--enable-cds-archive-coh=yes` b

RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives

2024-11-12 Thread Calvin Cheung
With this change, the compact object headers related CDS archives (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by default. If the user needs them, the user can specify the `--enable-cds-archive-coh=yes` build configure option. This change also modified the TestDefaultA