On Tue, 19 Nov 2024 14:18:59 GMT, Erik Joelsson <er...@openjdk.org> wrote:
> I'm a bit unsure what was actually agreed in the bug discussion. Are wanting > to disable this by default for OpenJDK, requiring anyone who wants it enabled > to add a new configure option, or are we only intending to change the > configuration for Oracle builds? If the latter, we should just add the option > `--disable-cds-archive-coh` to `jib-profiles.js` for the relevant build > profiles. Per our off-line discussion, I went with the latter approach and have changed the `jib-profiles.js`. > make/autoconf/jdk-options.m4 line 730: > >> 728: else >> 729: AC_MSG_RESULT([yes]) >> 730: AVAILABLE=false > > This does not look correct. The `CHECK_AVAILABLE` block is meant to check if > the preconditions for enabling this feature are met. Those preconditions > should not change here. All you should need to do is change the default. I've reverted the changes to jdk-optinos.m4. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22051#issuecomment-2486878962 PR Review Comment: https://git.openjdk.org/jdk/pull/22051#discussion_r1849133781
