> I modified TestSetupAOT.java to exercise more functionalities in the JDK so
> that we can have a more substantial AOT cache when running tests with
> `AOT_JDK=true`. E.g:
>
>
> make test JTREG=AOT_JDK=true \
> TEST=open/test/jdk/java/util/TimeZone/ListTimeZones.java
>
>
> Before: the ge
On Mon, 10 Mar 2025 15:38:45 GMT, Matthias Baesken wrote:
> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that
> are most likely not needed any more and could be removed.
make/modules/java.management/Lib.gmk line 33:
> 31: ## Build libmanagement
> 32:
> #
On Wed, 5 Mar 2025 22:59:06 GMT, Jiangli Zhou wrote:
> Please review this PR that excludes `libjsig` from being statically linked
> with `static-jdk` `java` launcher by default. Please see details in
> https://bugs.openjdk.org/browse/JDK-8351309 description and comments. Thanks
It seems we agr
On Tue, 11 Mar 2025 15:59:09 GMT, Erik Joelsson wrote:
> I think what Kevin is after is having this explanation made clear in the bug
> and PR description so that it's made clear what the change is and intends to
> do.
I changed the description in the JBS issue a bit.
-
PR Commen
Alternative approach to #24012
This keeps the current handling of *.pdb vs *.stripped.pdb which allows
debugging at the cost of a little hack in jlink.
-
Commit messages:
- JDK-8351842
Changes: https://git.openjdk.org/jdk/pull/24057/files
Webrev: https://webrevs.openjdk.org/?rep
On Fri, 7 Mar 2025 20:46:32 GMT, Mikael Vidstedt wrote:
> Background (from JBS):
>
> Recent versions of Xcode, most likely starting with Xcode 15, do not produce
> deterministic binaries/libraries out of the box. In particular, the UUID data
> in the LC_UUID load command is not stable.
>
> Af
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by Greg Lew
On Thu, 6 Mar 2025 12:46:25 GMT, David Holmes wrote:
> Abstracting this out seems reasonable to me, though I should say I thought we
> already used `-pthread` rather than `-lpthread`.
I noticed there were a few places that used `-pthread` by default. I left these
alone in this PR.
---
On Fri, 14 Mar 2025 02:02:58 GMT, Sergey Bylokhov wrote:
>> make/modules/java.desktop/lib/ClientLibraries.gmk line 249:
>>
>>> 247: DISABLED_WARNINGS_clang_dgif_lib.c := sign-compare, \
>>> 248: DISABLED_WARNINGS_clang_gzwrite.c := format-nonliteral, \
>>> 249: DISABLED_WARNING
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote:
> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
> possible to parameterize this for platforms that use different flags for
> enabling posix threads.
>
> This work is a continuation of the work done by Greg Lewis in
On Mon, 10 Mar 2025 09:49:44 GMT, Aleksey Shipilev wrote:
>> This PR implements JEP 503: Remove the 32-bit x86 Port.
>>
>> The JEP is proposed to target 25, we would not integrate until JEP is ready.
>> Reviews are appreciated meanwhile.
>>
>> This is only the removal of obvious 32-bit x86 par
On Fri, 14 Mar 2025 23:43:53 GMT, Erik Joelsson wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments from @erikj79 and @lmesnik
>
> make/test/BuildTestSetupAOT.gmk line 62:
>
>> 60: JavacBenchAp
On Fri, 14 Mar 2025 17:57:31 GMT, Magnus Ihse Bursie wrote:
> No, it doesn't -- only libjvm.so. .jsa files complicate the situation. Hm.
Aha. Importing CDS archives without regenerating them is futile, IIRC: they
would never load properly, CDS would get disabled, and we would just carry dead
w
On Tue, 4 Mar 2025 16:52:16 GMT, Aleksey Shipilev wrote:
> This PR implements JEP 503: Remove the 32-bit x86 Port.
>
> The JEP is proposed to target 25, we would not integrate until JEP is ready.
> Reviews are appreciated meanwhile.
>
> This is only the removal of obvious 32-bit x86 parts, mos
On Mon, 10 Mar 2025 11:03:30 GMT, Kim Barrett wrote:
> > As for the coding style (indentation), I followed the official style guides
> > to define this.
> > For C++ we have
> > https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md#whitespace
> > which states:
> > > Indentation levels
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote:
> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
> possible to parameterize this for platforms that use different flags for
> enabling posix threads.
>
> This work is a continuation of the work done by Greg Lewis in
On Fri, 14 Mar 2025 16:32:39 GMT, Aleksey Shipilev wrote:
> This change copies `libjvm.so` _and_ sibling `.jsa` files, right?
No, it doesn't -- only libjvm.so. .jsa files complicate the situation. Hm.
Maybe we should point to an import JVM directory, and copy it with all its
files, and not jus
> Please review this PR that excludes `libjsig` from being statically linked
> with `static-jdk` `java` launcher by default. Please see details in
> https://bugs.openjdk.org/browse/JDK-8351309 description and comments. Thanks
Jiangli Zhou has updated the pull request incrementally with two addit
On Fri, 14 Mar 2025 11:15:26 GMT, Matthias Baesken wrote:
> On Linux there are some special settings for LIBVERIFY_OPTIMIZATION that are
> most likely not needed any more and could be removed.
> The removal (on Linux) brings the lib optimization level de facto from LOW to
> HIGH.
What testing
On Fri, 14 Mar 2025 11:48:59 GMT, Magnus Ihse Bursie wrote:
> Given all of this, is there any possibility at all for
> --enable-linkable-runtime to handle both full and stripped pdb files, or do
> we need to accept that this is an inherent limitation for the linkable
> runtime?
Yes, I think t
20 matches
Mail list logo
