On Mon, 10 Mar 2025 11:03:30 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
> > As for the coding style (indentation), I followed the official style guides > > to define this. > > For C++ we have > > https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md#whitespace > > which states: > > > Indentation levels are two columns. > > The HotSpot Style Guide applies to HotSpot native code. It doesn't apply to > native code in the rest of the JDK. (For one thing, HotSpot is (almost?) > entirely C++, while much of the native code in the rest of the JDK is C. And > even a casual perusal will find large swaths of HSG violations in non-HotSpot > code.) We could consider adding a separate .editorconfig file in `src/hotspot` with these C++ rules. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23693#issuecomment-2710518183
