On Fri, 14 Mar 2025 02:02:58 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> make/modules/java.desktop/lib/ClientLibraries.gmk line 249: >> >>> 247: DISABLED_WARNINGS_clang_dgif_lib.c := sign-compare, \ >>> 248: DISABLED_WARNINGS_clang_gzwrite.c := format-nonliteral, \ >>> 249: DISABLED_WARNINGS_clang_png.c := unused-function, \ >> >> This warning was disabled to fix the following build issue on linux and >> macOS. >> >> >> open/src/java.desktop/share/native/libsplashscreen/libpng/png.c:1558:1: >> error: 'png_icc_profile_error' defined but not used [-Werror=unused-function] >> [2025-03-12T23:57:44,575Z] 1558 | png_icc_profile_error(png_const_structrp >> png_ptr, png_const_charp name, >> [2025-03-12T23:57:44,575Z] | ^~~~~~~~~~~~~~~~~~~~~ > > Might this be a bug in PNG? All usages of this function are now guarded by > "PNG_READ_iCCP_SUPPORTED"? It would be useful to report this upstream. In libconfig.h Ln#120 the undef is commented out - `/*#undef PNG_READ_iCCP_SUPPORTED*/` but I don't see it defined. @prrace do we define it in libconfig.h and remove the warning from disabled section in ClientLibraries.gmk? In Updating.txt , I see a note on libconfig.h, it is heavily modified for JDK and a define stmt can be added on need basis. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24021#discussion_r1996000410
