[PATCH 1/2] chips/busses.c: use boolean instead of an int

2013-11-14 Thread Marin Ramesa
* chips/busses.c (found): Constrain range of values to a boolean. --- chips/busses.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/chips/busses.c b/chips/busses.c index 89afa97..e555856 100644 --- a/chips/busses.c +++ b/chips/busses.c @@ -69,7 +69,7 @@ boolean_t conf

[PATCH 2/2] chips/busses.c: remove register qualifiers

2013-11-14 Thread Marin Ramesa
* chips/busses.c: Remove register qualifiers. --- chips/busses.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/chips/busses.c b/chips/busses.c index e555856..f9f6f1b 100644 --- a/chips/busses.c +++ b/chips/busses.c @@ -65,9 +65,9 @@ boolean_t configure_bus_master(

[RFC] cleanup of #includes

2013-11-14 Thread Justus Winter
Hi :) I've been playing with include-what-you-use [0] (iwyu in Debian). Unfortunately iwyu depends on clang-3.{3,4} which is not currently avaliable on Debian/Hurd, so I'm using a horrible^Wingenious hack that runs iwyu on Linux while the actual build runs on Hurd. 0: https://code.google.com/p/in

[PATCH] libihash: cleanup the #includes

2013-11-14 Thread Justus Winter
* libihash/ihash.c: Cleanup #includes. --- libihash/ihash.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/libihash/ihash.c b/libihash/ihash.c index fe9eaed..e813f63 100644 --- a/libihash/ihash.c +++ b/libihash/ihash.c @@ -25,14 +25,12 @@ #include #endif

Re: [RFC] cleanup of #includes

2013-11-14 Thread Svante Signell
On Thu, 2013-11-14 at 12:41 +0100, Justus Winter wrote: > Hi :) > > As an example of a patch generated here is a patch that fixes the > includes in libihash/ihash.c. > > 1. Do you consider the comment describing which symbols are pulled >from the header as noise or worthwile information? Ve

Re: [RFC] cleanup of #includes

2013-11-14 Thread Richard Braun
On Thu, Nov 14, 2013 at 12:41:30PM +0100, Justus Winter wrote: > 1. Do you consider the comment describing which symbols are pulled >from the header as noise or worthwile information? Noise. > 2. Do you consider it too noisy to include mach-shortcuts.h instead of >mach.h for stuff like ma

Re: [RFC] cleanup of #includes

2013-11-14 Thread Neal H. Walfield
At Thu, 14 Nov 2013 13:56:30 +0100, Svante Signell wrote: > > 1. Do you consider the comment describing which symbols are pulled > >from the header as noise or worthwile information? > > Very useful! No. This information gets out of date. Neal

Re: [RFC] cleanup of #includes

2013-11-14 Thread Svante Signell
On Thu, 2013-11-14 at 14:26 +0100, Neal H. Walfield wrote: > At Thu, 14 Nov 2013 13:56:30 +0100, > Svante Signell wrote: > > > 1. Do you consider the comment describing which symbols are pulled > > >from the header as noise or worthwile information? > > > > Very useful! > > No. This informat

Re: [RFC] cleanup of #includes

2013-11-14 Thread Neal H. Walfield
At Thu, 14 Nov 2013 14:38:04 +0100, Svante Signell wrote: > > On Thu, 2013-11-14 at 14:26 +0100, Neal H. Walfield wrote: > > At Thu, 14 Nov 2013 13:56:30 +0100, > > Svante Signell wrote: > > > > 1. Do you consider the comment describing which symbols are pulled > > > >from the header as noise

Small cleanup of i386 source

2013-11-14 Thread Marin Ramesa
Hello, Attached is a gzipped series of 33 patches which do various cleanups of i386 source. Cleanups include: 1. Removal of register qualifiers. 2. Qualification of constants with const. 3. Addition of comments after endifs. 4. Stylistic fixes. 5. Removal of unused variables. i386_cleanup.tar.

[PATCH 2/2] i386/i386/vm_tuning.h: remove file

2013-11-14 Thread Marin Ramesa
* i386/Makefrag.am: Remove i386/i386/vm_tuning.h. * i386/i386/vm_tuning.h: Remove file. * vm/vm_pageout.c: Don't include i386/i386/vm_tuning.h. --- i386/Makefrag.am | 1 - i386/i386/vm_tuning.h | 35 --- vm/vm_pageout.c | 1 - 3 files changed, 37 delet

[PATCH 1/2] i386/i386at: add ifndefs

2013-11-14 Thread Marin Ramesa
* i386/i386at/kd_queue.h: Add ifndef. * i386/i386at/kdsoft.h: Likewise. * i386/i386at/lprreg.h: Likewise. * i386/i386at/rtc.h: Likewise. --- i386/i386at/kd_queue.h | 5 + i386/i386at/kdsoft.h | 5 + i386/i386at/lprreg.h | 5 + i386/i386at/rtc.h | 5 + 4 files change

Re: [PATCH 1/2] i386/i386at: add ifndefs

2013-11-14 Thread Marin Ramesa
On 14.11.2013 21:04:04, Marin Ramesa wrote: > +#ifndef _KDSOFT_H This is a typo. This should be "+#ifndef _KDSOFT_H_".

Re: [PATCH 03/12] vm/vm_fault.c: qualify constant with const

2013-11-14 Thread Samuel Thibault
Marin Ramesa, le Wed 13 Nov 2013 16:40:40 +0100, a écrit : > * vm/vm_fault.c: Qualify constant with const. Mmm, one could want to change it dynamically. > --- > vm/vm_fault.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/vm/vm_fault.c b/vm/vm_fault.c > index 7e84961..

Re: [PATCH 01/12] vm/memory_object.c: remove register qualifiers

2013-11-14 Thread Samuel Thibault
Applied the rest, thanks! Samuel

Re: [PATCH 1/2] chips/busses.c: use boolean instead of an int

2013-11-14 Thread Samuel Thibault
Applied, thanks! Samuel

Re: [PATCH 1/2] i386/i386at: add ifndefs

2013-11-14 Thread Samuel Thibault
Applied, thanks! Samuel

Re: [RFC] cleanup of #includes

2013-11-14 Thread Samuel Thibault
Neal H. Walfield, le Thu 14 Nov 2013 14:42:22 +0100, a écrit : > Identifying and removing unused headers, however, is fine. Yes, that's mostly what I'd expect as patches. Samuel

Re: Small cleanup of i386 source

2013-11-14 Thread Samuel Thibault
> -int cpuspeed = 4; > +const int cpuspeed = 4; > -int simple_lock_pause_loop = 100; > +const int simple_lock_pause_loop = 100; Well, these should really be computed dynamically. I have applied almost all the rest, thanks! Samuel

Re: Small cleanup of i386 source

2013-11-14 Thread Samuel Thibault
> - register unsigned long _temp__ asm("esp"); \ > + unsigned long _temp__ asm("esp"); \ I'll rather keep those, at least as documentation. Samuel