On Thu, 2013-11-14 at 12:41 +0100, Justus Winter wrote: > Hi :) > > As an example of a patch generated here is a patch that fixes the > includes in libihash/ihash.c. > > 1. Do you consider the comment describing which symbols are pulled > from the header as noise or worthwile information?
Very useful! > 2. Do you consider it too noisy to include mach-shortcuts.h instead of > mach.h for stuff like mach_port_allocate? No, otherwise you need to check which header files are included by mach.h, to find the declaration of it in mach/mach_port.h.
