Re: [RFC] cleanup of #includes

2013-11-14 Thread Samuel Thibault
Neal H. Walfield, le Thu 14 Nov 2013 14:42:22 +0100, a écrit : > Identifying and removing unused headers, however, is fine. Yes, that's mostly what I'd expect as patches. Samuel

Re: [RFC] cleanup of #includes

2013-11-14 Thread Neal H. Walfield
At Thu, 14 Nov 2013 14:38:04 +0100, Svante Signell wrote: > > On Thu, 2013-11-14 at 14:26 +0100, Neal H. Walfield wrote: > > At Thu, 14 Nov 2013 13:56:30 +0100, > > Svante Signell wrote: > > > > 1. Do you consider the comment describing which symbols are pulled > > > >from the header as noise

Re: [RFC] cleanup of #includes

2013-11-14 Thread Svante Signell
On Thu, 2013-11-14 at 14:26 +0100, Neal H. Walfield wrote: > At Thu, 14 Nov 2013 13:56:30 +0100, > Svante Signell wrote: > > > 1. Do you consider the comment describing which symbols are pulled > > >from the header as noise or worthwile information? > > > > Very useful! > > No. This informat

Re: [RFC] cleanup of #includes

2013-11-14 Thread Neal H. Walfield
At Thu, 14 Nov 2013 13:56:30 +0100, Svante Signell wrote: > > 1. Do you consider the comment describing which symbols are pulled > >from the header as noise or worthwile information? > > Very useful! No. This information gets out of date. Neal

Re: [RFC] cleanup of #includes

2013-11-14 Thread Richard Braun
On Thu, Nov 14, 2013 at 12:41:30PM +0100, Justus Winter wrote: > 1. Do you consider the comment describing which symbols are pulled >from the header as noise or worthwile information? Noise. > 2. Do you consider it too noisy to include mach-shortcuts.h instead of >mach.h for stuff like ma

Re: [RFC] cleanup of #includes

2013-11-14 Thread Svante Signell
On Thu, 2013-11-14 at 12:41 +0100, Justus Winter wrote: > Hi :) > > As an example of a patch generated here is a patch that fixes the > includes in libihash/ihash.c. > > 1. Do you consider the comment describing which symbols are pulled >from the header as noise or worthwile information? Ve

[RFC] cleanup of #includes

2013-11-14 Thread Justus Winter
Hi :) I've been playing with include-what-you-use [0] (iwyu in Debian). Unfortunately iwyu depends on clang-3.{3,4} which is not currently avaliable on Debian/Hurd, so I'm using a horrible^Wingenious hack that runs iwyu on Linux while the actual build runs on Hurd. 0: https://code.google.com/p/in