Re: Hurd GSoC 2013 projects

2013-06-01 Thread Yue Lu
Hi Justus. On Sun, Jun 2, 2013 at 3:12 AM, Justus Winter < 4win...@informatik.uni-hamburg.de> wrote: > Hi Yue Lu, as someone who was frustrated by gdb on the Hurd in the > past, your project is highly appreciated. May I ask how you like to be > addressed? I'm fuzzy about what your first and what

Re: Hurd GSoC 2013 projects

2013-06-01 Thread Yue Lu
Hi all. On Sat, Jun 1, 2013 at 5:00 PM, Thomas Schwinge wrote: > Copyright assignment. As goverened by the Free Software Foundation, the > GNU Hurd (as well as GCC and GDB, for these two GSoC projects) requires > copyright assignment for any non-trivial patches that you contribute. I have a li

Re: utils/x.c : remove unused variable

2013-06-01 Thread Samuel Thibault
Miguel Figueiredo, le Sat 01 Jun 2013 23:56:45 +0100, a écrit : > 2013-06-01 - Miguel Figueiredo > > * utils/x.c : remove unused variable Applied, thanks! Samuel

utils/x.c : remove unused variable

2013-06-01 Thread Miguel Figueiredo
2013-06-01 - Miguel Figueiredo * utils/x.c : remove unused variable -- Melhores cumprimentos/Best regards, Miguel Figueiredo diff --git a/utils/x.c b/utils/x.c index e4e272f..7bbc8ac 100644 --- a/utils/x.c +++ b/utils/x.c @@ -168,7 +168,6 @@ void verify_passwd (const char *name, const char *pa

Re: mach-defpager/default-pager.c : remove unused variable

2013-06-01 Thread Samuel Thibault
Miguel Figueiredo, le Sat 01 Jun 2013 23:15:14 +0100, a écrit : > 2013-06-01 Miguel Figueiredo > > * mach-defpager/default-pager.c : remove unused variable Applied, thanks. Samuel

mach-defpager/default-pager.c : remove unused variable

2013-06-01 Thread Miguel Figueiredo
2013-06-01 Miguel Figueiredo * mach-defpager/default-pager.c : remove unused variable -- Melhores cumprimentos/Best regards, Miguel Figueiredo diff --git a/mach-defpager/default_pager.c b/mach-defpager/default_pager.c index ec875d4..b445590 100644 --- a/mach-defpager/default_pager.c +++ b/mach

Re: libthreads/cprocs.c (remove unsused variables)

2013-06-01 Thread Samuel Thibault
Miguel Figueiredo, le Sat 01 Jun 2013 22:41:00 +0100, a écrit : > 2013-06-01 Miguel Figueiredo > > * libthreads/cprocs.c : remove unsused variables Applied, thanks. Samuel

libthreads/cprocs.c (remove unsused variables)

2013-06-01 Thread Miguel Figueiredo
2013-06-01 Miguel Figueiredo * libthreads/cprocs.c : remove unsused variables -- Melhores cumprimentos/Best regards, Miguel Figueiredo diff --git a/libthreads/cprocs.c b/libthreads/cprocs.c index 7f63fc0..5459d7d 100644 --- a/libthreads/cprocs.c +++ b/libthreads/cprocs.c @@ -341,7 +341,6 @@ vo

Re: libstore/decode.c (store_std_leaf_decode): remove unused variable

2013-06-01 Thread Samuel Thibault
Miguel Figueiredo, le Sat 01 Jun 2013 22:18:06 +0100, a écrit : > @@ -49,7 +49,6 @@ store_std_leaf_decode (struct store_enc *enc, > return EINVAL; > >/* Read encoded ints. */ > - type = enc->ints[enc->cur_int++]; Nope, this has a side effect :) I'd rather keep this code as such, at l

libstore/decode.c (store_std_leaf_decode): remove unused variable

2013-06-01 Thread Miguel Figueiredo
2013-06-01 Miguel Figueiredo * libstore/decode.c (store_std_leaf_decode): remove unused variable -- Melhores cumprimentos/Best regards, Miguel Figueiredo diff --git a/libstore/decode.c b/libstore/decode.c index 64405ec..52aed74 100644 --- a/libstore/decode.c +++ b/libstore/decode.c @@ -35,7 +3

Re: libcons/vcons-move-mouse.c (cons_vcons_move_mouse): add missing break

2013-06-01 Thread Samuel Thibault
Miguel Figueiredo, le Sat 01 Jun 2013 20:56:25 +0100, a écrit : > 2013-06-01 Miguel Figueiredo > > libcons/vcons-move-mouse.c (cons_vcons_move_mouse): add missing break; Indeed, thanks! Samuel

libcons/vcons-move-mouse.c (cons_vcons_move_mouse): add missing break

2013-06-01 Thread Miguel Figueiredo
2013-06-01 Miguel Figueiredo libcons/vcons-move-mouse.c (cons_vcons_move_mouse): add missing break; -- Melhores cumprimentos/Best regards, Miguel Figueiredo diff --git a/libcons/vcons-move-mouse.c b/libcons/vcons-move-mouse.c index 6c74d9f..d61067c 100644 --- a/libcons/vcons-move-mouse.c +++ b

Re: Hurd GSoC 2013 projects

2013-06-01 Thread Samuel Thibault
Justus Winter, le Sat 01 Jun 2013 21:12:36 +0200, a écrit : > > Next steps. It's now the community bonding period, in which you're to > > continue interacting with the projects' community, and slowly begin > > working towards your GSoC projects (subject to first finishing your > > university work,

Re: Hurd GSoC 2013 projects

2013-06-01 Thread Justus Winter
Hi everyone :) Quoting Thomas Schwinge (2013-06-01 11:00:40) > First, congratulations again for getting your applications accepted! In > no particular order: 陆岳 (Yue Lu) »Improve the GDB Port for GNU Hurd«, > ; Hi Yue L

Re: init/init.c (start_child): don't free before it's used

2013-06-01 Thread Samuel Thibault
Miguel Figueiredo, le Sat 01 Jun 2013 19:31:21 +0100, a écrit : > 2013-06-01 Miguel Figueiredo > > * init/init.c (start_child): don't free before it's used D'oh. Applied, thanks! Samuel

init/init.c (start_child): don't free before it's used

2013-06-01 Thread Miguel Figueiredo
2013-06-01 Miguel Figueiredo * init/init.c (start_child): don't free before it's used -- Melhores cumprimentos/Best regards, Miguel Figueiredo diff --git a/init/init.c b/init/init.c index edfe123..930408e 100644 --- a/init/init.c +++ b/init/init.c @@ -1068,14 +1068,13 @@ start_child (const cha

Re: exec/exec.c (check_section): remove unused variable

2013-06-01 Thread Samuel Thibault
Miguel Figueiredo, le Sat 01 Jun 2013 19:06:55 +0100, a écrit : > 2013-06-01 Miguel Figueiredo > > * exec/exec.c (check_section): remove unused variable Applied, thanks.

exec/exec.c (check_section): remove unused variable

2013-06-01 Thread Miguel Figueiredo
2013-06-01 Miguel Figueiredo * exec/exec.c (check_section): remove unused variable -- Melhores cumprimentos/Best regards, Miguel Figueiredo diff --git a/exec/exec.c b/exec/exec.c index a4f2f74..30a5e00 100644 --- a/exec/exec.c +++ b/exec/exec.c @@ -86,7 +86,6 @@ static void check_section (bfd

Re: console-client/xkb/compose.c (read_composefile): fclose

2013-06-01 Thread Samuel Thibault
Miguel Figueiredo, le Sat 01 Jun 2013 11:05:10 +0100, a écrit : > 2013-06-01 Miguel Figueiredo > > * console-client/xkb/compose.c (read_composefile): fclose > > iiuc parse_composefile always returns 0 and this makes the if(err) not > executing the fclose. > cppcheck reported this as memory leak.

Re: hurd/console-client/trans.c (console_setup_node): remove unsused variable

2013-06-01 Thread Samuel Thibault
Miguel Figueiredo, le Sat 01 Jun 2013 10:39:41 +0100, a écrit : > 2013-06-01 Miguel Figueiredo > > * console-client/trans.c (console_setup_node): remove unused variable Applied, thanks. Samuel

console-client/xkb/compose.c (read_composefile): fclose

2013-06-01 Thread Miguel Figueiredo
2013-06-01 Miguel Figueiredo * console-client/xkb/compose.c (read_composefile): fclose iiuc parse_composefile always returns 0 and this makes the if(err) not executing the fclose. cppcheck reported this as memory leak. -- Melhores cumprimentos/Best regards, Miguel Figueiredo diff --git a/co

hurd/console-client/trans.c (console_setup_node): remove unsused variable

2013-06-01 Thread Miguel Figueiredo
2013-06-01 Miguel Figueiredo * console-client/trans.c (console_setup_node): remove unused variable -- Melhores cumprimentos/Best regards, Miguel Figueiredo diff --git a/console-client/trans.c b/console-client/trans.c index 6949af5..8219f97 100644 --- a/console-client/trans.c +++ b/console-cli

Hurd GSoC 2013 projects

2013-06-01 Thread Thomas Schwinge
Hi! "Finally", some administrativa for the Hurd GSoC 2013 projects. Everyone loves administrativa, I know. ;-) First, congratulations again for getting your applications accepted! In no particular order: 陆岳 (Yue Lu) »Improve the GDB Port for GNU Hurd«,

Re: hurd/console/console.c (netfs_get_dirents): remove unused variable

2013-06-01 Thread Samuel Thibault
Miguel Figueiredo, le Sat 01 Jun 2013 08:44:45 +0100, a écrit : > diff --git a/console/console.c b/console/console.c > index 0577ea0..f598565 100644 > --- a/console/console.c > +++ b/console/console.c > @@ -809,10 +809,7 @@ netfs_get_dirents (struct iouser *cred, struct node *dir, >err = ((void

hurd/console/console.c (netfs_get_dirents): remove unused variable

2013-06-01 Thread Miguel Figueiredo
2013-06-01 Miguel Figueiredo * hurd/console/console.c (netfs_get_dirents): Remove unused variable -- Melhores cumprimentos/Best regards, Miguel Figueiredo diff --git a/console/console.c b/console/console.c index 0577ea0..f598565 100644 --- a/console/console.c +++ b/console/console.c @@ -809,10