[PATCH] Fix real-floating argument functions in C++ mode

2016-11-14 Thread Pedro Alves
On 11/12/2016 05:30 PM, Paul Eggert wrote: > Thanks, I installed your two recent patches. Thanks! > I don't know C++ well; > perhaps Bruno or another reviewer can double-check if they have the time. > > I noticed that with the patches installed, the command './gnulib-tool > --test --with-c++-te

Re: [libvirt] [PATCH] build: update to latest gnulib

2016-11-14 Thread Eric Blake
[adding gnulib] On 11/14/2016 04:23 AM, Daniel P. Berrange wrote: > On Sat, Nov 12, 2016 at 02:58:03PM -0600, Eric Blake wrote: >> In particular, pull in gnulib's fix for the broken SIZE_MAX on s390. >> >> * .gnulib e89b4a7...5ddd9d7 (73): >> > strerror_r-posix: Fix override of AC_FUNC_STRERROR

Re: [libvirt] [PATCH] build: update to latest gnulib

2016-11-14 Thread Pádraig Brady
On 14/11/16 19:51, Eric Blake wrote: > [adding gnulib] > > On 11/14/2016 04:23 AM, Daniel P. Berrange wrote: >> On Sat, Nov 12, 2016 at 02:58:03PM -0600, Eric Blake wrote: >>> In particular, pull in gnulib's fix for the broken SIZE_MAX on s390. > >>> >>> * .gnulib e89b4a7...5ddd9d7 (73): >>> >

Re: [PATCH] support for quarter from strftime (%q)

2016-11-14 Thread Bruno Haible
Hi Pádraig, > add to strptime() > also for consistency. Therefore I did that in the attached, > added a test, and pushed. If users of the 'strptime' module should be able to rely on the %q feature, it requires also a change in doc/posix-functions/strptime.texi and m4/strptime.m4, modules/strptim

Re: [PATCH] Fix real-floating argument functions in C++ mode

2016-11-14 Thread Pedro Alves
On 11/14/2016 06:16 PM, Pedro Alves wrote: > On 11/12/2016 05:30 PM, Paul Eggert wrote: >> Thanks, I installed your two recent patches. > > Thanks! > >> I don't know C++ well; >> perhaps Bruno or another reviewer can double-check if they have the time. >> >> I noticed that with the patches insta

Re: [PATCH] strerror_r-posix: Fix override of AC_FUNC_STRERROR_R

2016-11-14 Thread Eric Blake
On 11/12/2016 02:50 PM, Eric Blake wrote: > On 11/04/2016 05:50 PM, Bruno Haible wrote: >> Hi Eric, >> >> Thanks for noticing and fixing this faster than I could. >> >>> A better approach is to replace the autoconf macro with a version >>> of our own that doesn't probe anything, so that the AC_DEFI

Re: [PATCH] support for quarter from strftime (%q)

2016-11-14 Thread Pádraig Brady
On 14/11/16 21:10, Bruno Haible wrote: > Hi Pádraig, > >> add to strptime() >> also for consistency. Therefore I did that in the attached, >> added a test, and pushed. > > If users of the 'strptime' module should be able to rely on the %q feature, > it requires also a change in doc/posix-functio

Re: [PATCH] Fix real-floating argument functions in C++ mode

2016-11-14 Thread Pedro Alves
On 11/14/2016 09:19 PM, Pedro Alves wrote: > Let me try that and send a new patch. Here's an simpler implementation, IMO. I went ahead and added the _GL_BEGIN_NAMESPACE/_GL_END_NAMESPACE macros to c++defs.h as I'm fairly sure they'll end up being useful in more places. Passes same testing as be

[PATCH] strerror_r-posix: Another fix, for HAVE_DECL_STRERROR_R on mingw

2016-11-14 Thread Eric Blake
Commit 5ddd9d7 improved strerror_r on glibc systems (where STRERROR_R_CHAR_P was defined twice with different values), but missed mingw systems (where HAVE_DECL_STRERROR_R is now defined twice with different values). Avoid the AC_CHECK_DECLS[_ONCE] and AC_CHECK_FUNCS[_ONCE] m4 macros that call AC_

[PATCH] C++: "#define timeval rpl_timeval" -> typedef in GNULIB_NAMESPACE

2016-11-14 Thread Pedro Alves
Working on making GDB use GNULIB_NAMESPACE, I got this: ../../src/gdb/remote-fileio.c: In function 'void remote_fileio_func_fstat(char*)': ../../src/gdb/remote-fileio.c:958:43: error: no match for call to '(const gnulib::_gl_gettimeofday_wrapper) (timeval*, NULL)' if (!gnulib::gettimeo

[PATCH] obstack: port to gcc -fcheck-pointer-bounds

2016-11-14 Thread Paul Eggert
Problem found by 'make check' failure on bleeding-edge coreutils on an MPX-enabled CPU (Intel Core i3-7100U) running GCC (Ubuntu 6.2.0-5ubuntu12), configured via "./configure --enable-gcc-warnings CFLAGS='-mmpx -fcheck-pointer-bounds -g3 -O2' LDFLAGS='-static-libmpx -static-libmpxwrappers'". * lib/

[PATCH] strftime: don't use __THROW

2016-11-14 Thread Jim Meyering
I've just pushed the attached, to avoid new warnings when attempting to build coreutils with the latest from gnulib: From c3b131294aa42b7997cc9b9a0bbb2934aa27fd6c Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 13 Nov 2016 18:15:36 -0800 Subject: [PATCH] strftime: don't use __THROW Each us

Re: [PATCH] support for quarter from strftime (%q)

2016-11-14 Thread Bruno Haible
Pádraig Brady wrote: > It's not worth replacing strptime to support %q, at least until it's > available in glibc. OK. > Currently there is no strptime unit test. Ah, right. Sorry for the noise then. Bruno