On 14/11/16 21:10, Bruno Haible wrote: > Hi Pádraig, > >> add to strptime() >> also for consistency. Therefore I did that in the attached, >> added a test, and pushed. > > If users of the 'strptime' module should be able to rely on the %q feature, > it requires also a change in doc/posix-functions/strptime.texi and > m4/strptime.m4, modules/strptime, etc. Because so far, on platforms where > strptime exists and does not support %q, this code will *not* override it: > if test $HAVE_STRPTIME = 0; then > AC_LIBOBJ([strptime]) > gl_PREREQ_STRPTIME > fi > > Or was it meant to be an undocumented feature? Then the unit test should > be conditionalized.
Currently there is no strptime unit test. It's not worth replacing strptime to support %q, at least until it's available in glibc. In retrospect I probably should have not added it to gnulib until it hits glibc. I was just adding it to keep more in sync (assuming the %q patch would eventually land in glibc). nstrftime() is another story as that's generally replaced already, and %q is much more useful there. thanks, Pádraig.
