Re: Native windows boot-time

2024-05-24 Thread Collin Funk
On 5/24/24 8:56 PM, Bruno Haible wrote: > readutmp now needs a module dependency on gettimetoday, right? Oops, yes. Because readutmp doesn't use boot-time as a dependency, instead it uses the boot-time-aux.h file. I've pushed the attached patch. CollinFrom ff1594abd5d7d4a74bc3f7f089eaf101bcab863

Re: Native windows boot-time

2024-05-24 Thread Bruno Haible
Collin Funk wrote: > I've fixed those in the attached patch and pushed it. Thanks. readutmp now needs a module dependency on gettimetoday, right? Bruno

Re: Native windows boot-time

2024-05-24 Thread Collin Funk
Hi Bruno, On 5/24/24 3:50 PM, Bruno Haible wrote: > - In line 393 the #endif is misindented. > - The readutmp module is a second user of boot-time-aux.h. It should also > make a call to get_windows_boot_time_fallback. Ah, now I see why those functions are in a header file. I've fixed those in t

Re: Native windows boot-time

2024-05-24 Thread Bruno Haible
Hi Collin, > I wrote this patch just now. Any thoughts? - In line 393 the #endif is misindented. - The readutmp module is a second user of boot-time-aux.h. It should also make a call to get_windows_boot_time_fallback. Other than that, it's OK to push. > I've only tested it with a mingw compil

Re: Native windows boot-time

2024-05-24 Thread Collin Funk
Hi Bruno, On 5/24/24 4:44 AM, Bruno Haible wrote: > The longer the API is available, the better. Gnulib supports > Windows XP as the minimum. For modules used by Emacs ('boot-time' in > particular) it should run even on Windows 2000. > > Which means that the code needs to fetch a pointer to the p

Re: Native windows boot-time

2024-05-24 Thread Collin Funk
Hi Bruno, On 5/24/24 4:44 AM, Bruno Haible wrote: >> Does the get_windows_boot_time () not work on Native Windows? The >> Mingw and MSVC actions fail it. > > There's apparently a difference between a full installation of > Windows 10 and the image that they use in the Microsoft Azure cloud. Ah,

Re: Native windows boot-time

2024-05-24 Thread Bruno Haible
Hi Collin, > Does the get_windows_boot_time () not work on Native Windows? The > Mingw and MSVC actions fail it. There's apparently a difference between a full installation of Windows 10 and the image that they use in the Microsoft Azure cloud. > I'm thinking that it could be implemented using G