Hi Collin, > I wrote this patch just now. Any thoughts?
- In line 393 the #endif is misindented. - The readutmp module is a second user of boot-time-aux.h. It should also make a call to get_windows_boot_time_fallback. Other than that, it's OK to push. > I've only tested it with a mingw compiler and wine so far. That's good enough. The CI will test it on "real" Windows. > I wasn't sure the proper way to get the current time. I didn't want to > depend on timespec_get since that would bring in more dependencies for > non-Windows systems (like linking with -lrt). The resolution isn't > needed either since GetTickCount64 has a resolution of 10-16 ms [1]. Depending on gettimeofday, like you did, is a reasonable compromise. gettimeofday itself is implemented in Gnulib, based on GetSystemTimeAsFileTime and some 64-bit arithmetic. There's no point in duplicating this 64-bit arithmetic in boot-time-aux.h. Bruno
