Hi Collin,

> Does the get_windows_boot_time () not work on Native Windows? The
> Mingw and MSVC actions fail it.

There's apparently a difference between a full installation of
Windows 10 and the image that they use in the Microsoft Azure cloud.

> I'm thinking that it could be implemented using GetTickCount64 ().

Good point. You can see in lib/boot-time-aux.h that we have
implementations that are stable across suspend/resume and
fallback implementations that don't have this guarantee. Since a CI
machine is never suspended/resumed, this fallback would be useful.

> The Windows documentation says [1]:
> 
>     Retrieves the number of milliseconds that have elapsed since the
>     system was started.
> 
> So I'm thinking that should fix the issue.

Yes, it should be usable for the fallback.

> What Windows versions does Gnulib care about? Apparently this one only
> exists on Vista and later. [1]

The longer the API is available, the better. Gnulib supports
Windows XP as the minimum. For modules used by Emacs ('boot-time' in
particular) it should run even on Windows 2000.

Which means that the code needs to fetch a pointer to the particular
Windows API function at runtime, through GetProcAddress. See lib/isatty.c
as an example.

Would you like to give it a try?

        Bruno

> [1] 
> https://learn.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-gettickcount64




Reply via email to