Re: Emacs 28.1 doesn't compile on Mac OS 10.7.5

2022-05-24 Thread Mattias Engdegård
17 apr. 2022 kl. 13.33 skrev Eli Zaretskii : >> Thank you! This particular change should be back-ported to emacs-28 once >> master has caught up with gnulib again. > > If you are talking about a single change in lib/* files for this > particular problem, I'm fine with that. Yes, that's the idea

Re: Emacs 28.1 doesn't compile on Mac OS 10.7.5

2022-04-17 Thread Paul Eggert
On 4/17/22 02:13, Mattias Engdegård wrote: I suppose it wouldn't hurt for an old Mac OS X expert to check the other uses of __clang_major__ in Emacs.<0001-verify-port-to-Mac-OS-10.7.5.patch> I'm no expert, old or not, but I would prefer doing the minimum necessary to keep builds working. If th

Re: Emacs 28.1 doesn't compile on Mac OS 10.7.5

2022-04-17 Thread Jeffrey Walton
On Sun, Apr 17, 2022 at 10:33 AM Ryan Schmidt wrote: > > On Apr 17, 2022, at 02:54, Paul Eggert wrote: > > > On 4/16/22 20:28, Jeffrey Walton wrote: > >> maybe you should define a couple of macros > >> like GNULIB_LLVM_CLANG_VER and GNULIB_APPLE_CLANG_VER > > > > I hope we don't need to do that. T

Re: Emacs 28.1 doesn't compile on Mac OS 10.7.5

2022-04-17 Thread Ryan Schmidt
On Apr 17, 2022, at 02:54, Paul Eggert wrote: > On 4/16/22 20:28, Jeffrey Walton wrote: >> maybe you should define a couple of macros >> like GNULIB_LLVM_CLANG_VER and GNULIB_APPLE_CLANG_VER > > I hope we don't need to do that. This is software archaeology (Mac OS X > 10.7.5 is so old that neith

Re: Emacs 28.1 doesn't compile on Mac OS 10.7.5

2022-04-17 Thread Po Lu
Mattias Engdegård writes: > Thank you! This particular change should be back-ported to emacs-28 > once master has caught up with gnulib again. As long as someone backports the MS-DOS code at the same time. I don't want to update the code on the release branch for a gnulib update, especially sin

Re: Emacs 28.1 doesn't compile on Mac OS 10.7.5

2022-04-17 Thread Eli Zaretskii
> Feedback-ID: matti...@acm.or > From: Mattias Engdegård > Date: Sun, 17 Apr 2022 11:13:43 +0200 > Cc: dpo...@macports.org, Gnulib bugs , > Filipp Gunbin , Emacs-Devel > > 17 apr. 2022 kl. 04.21 skrev Paul Eggert : > > > > On 4/15/22 09:22, Mattias Engdegård wrote: > >> Paul, would you conside

Re: Emacs 28.1 doesn't compile on Mac OS 10.7.5

2022-04-17 Thread Werner LEMBERG
>> maybe you should define a couple of macros like >> GNULIB_LLVM_CLANG_VER and GNULIB_APPLE_CLANG_VER > > I hope we don't need to do that. This is software archaeology (Mac > OS X 10.7.5 is so old that neither the Subject: line nor my patch > got its name right, and nobody mentioned the mistake

Re: Emacs 28.1 doesn't compile on Mac OS 10.7.5

2022-04-17 Thread Mattias Engdegård
17 apr. 2022 kl. 11.32 skrev Po Lu : > Or maybe we could just install the single change to gnulib for old > versions of Mac OS X, but I don't know if that's okay. That would indeed be the plan, to address this particular build regression only.

Re: Emacs 28.1 doesn't compile on Mac OS 10.7.5

2022-04-17 Thread Mattias Engdegård
17 apr. 2022 kl. 04.21 skrev Paul Eggert : > > On 4/15/22 09:22, Mattias Engdegård wrote: >> Paul, would you consider something like that patch (repeated here) for >> gnulib? > > Sure, I installed the attached into Gnulib master on Savannah. Thank you! This particular change should be back-port

Re: Emacs 28.1 doesn't compile on Mac OS 10.7.5

2022-04-17 Thread Paul Eggert
On 4/16/22 20:28, Jeffrey Walton wrote: maybe you should define a couple of macros like GNULIB_LLVM_CLANG_VER and GNULIB_APPLE_CLANG_VER I hope we don't need to do that. This is software archaeology (Mac OS X 10.7.5 is so old that neither the Subject: line nor my patch got its name right, and

Re: Emacs 28.1 doesn't compile on Mac OS 10.7.5

2022-04-16 Thread Jeffrey Walton
On Sat, Apr 16, 2022 at 10:21 PM Paul Eggert wrote: > > On 4/15/22 09:22, Mattias Engdegård wrote: > > Paul, would you consider something like that patch (repeated here) for > > gnulib? > > Sure, I installed the attached into Gnulib master on Savannah. > > I suppose it wouldn't hurt for an old Ma

Re: Emacs 28.1 doesn't compile on Mac OS 10.7.5

2022-04-16 Thread Paul Eggert
On 4/15/22 09:22, Mattias Engdegård wrote: Paul, would you consider something like that patch (repeated here) for gnulib? Sure, I installed the attached into Gnulib master on Savannah. I suppose it wouldn't hurt for an old Mac OS X expert to check the other uses of __clang_major__ in Emacs.Fr