On 4/17/22 02:13, Mattias Engdegård wrote:
I suppose it wouldn't hurt for an old Mac OS X expert to check the other uses of
__clang_major__ in Emacs.<0001-verify-port-to-Mac-OS-10.7.5.patch>
I'm no expert, old or not, but I would prefer doing the minimum necessary to
keep builds working. If that means slightly suboptimal code or diagnostics for
long-obsolete OS X versions then so be it.
Yes, quite right. My only worry was whether Emacs has incorrect uses of
__clang_major__ that cause incorrect user-visible behavior on some
macOS versions. I'm not worried about suboptimal code or bogus warnings.
Perhaps I'm worrying too much. Not being an old Mac OS X expert (pun was
intended :-) I don't know. If someone reading this email is such an
expert and cares about old macOS ports I hope they can spare a few
minutes to check.