Re: new syntax-check rule for @acronym?

2010-03-26 Thread jemarch
> This hangs for non-GNU projects, like libvirt, that have no .texi > documentation. We really need to make progress on the patch to refactor > maint.mk rules per Jose's ideas: > http://lists.gnu.org/archive/html/bug-gnulib/2010-02/msg00242.html > which would conveniently fix this

Re: new syntax-check rule for @acronym?

2010-03-26 Thread jemarch
> +# Don't use Texinfo @acronym{} as it is not a good idea. > +sc_texinfo_acronym: > + @grep -nE '@acronym{' \ > + $$($(VC_LIST_EXCEPT) | grep -E '\.texi$$') && \ > +{ echo '$(ME): found use of Texinfo @acronym{}' 1>&

Re: [patch] Avoid some of the sc_ rules to freeze

2010-02-25 Thread jemarch
> I suggest to use the following solution that works properly in all > cases while avoiding the code duplication (in the spirit of > _prohibit_regexp): Good idea. I heavily expanded the _prohibit_regexp macro to accept more arguments and renamed it to _sc_search_regexp. Using the ne

Re: [patch] Avoid some of the sc_ rules to freeze

2010-02-22 Thread jemarch
> define _sc_maybe_matching_files > dummy=; : so we do not need a semicolon before each use; \ > test "x$$re" != x || { echo '$(ME): re not defined' 1>&2; exit 1; }; \ > if test -n "$$matching"; then matching='yes'; fi\ > files=$$($(VC_LIST_EXCEPT) | grep

Re: [patch] Avoid some of the sc_ rules to freeze

2010-02-22 Thread jemarch
Would it be better to just add /dev/null as a parameter to grep? I.E. like: @grep -nE 'error \(EXIT_SUCCESS,'\ $$($(VC_LIST_EXCEPT) /dev/null | grep -E '\.[chly]$$')&& \ { echo '$(ME): found error (EXIT_SUCCESS' 1>&2; exit 1

[patch] Avoid some of the sc_ rules to freeze

2010-02-21 Thread jemarch
Hi. Just another little patch to avoid some of the sc_* rules to freeze if the filtering of VC_LIST_EXCEPT gives an empty string (for example, 'make sc_error_exit_success' freezes if there are not source files in ${srcdir}/). I found this problem due to the bazaar issue in vc-list-files. 2010-

[patch] vc-list-files and bazaar

2010-02-21 Thread jemarch
Hi. Just a tiny patch to make build-aux/vc-list-files to work properly with GNU Bazaar. 2010-02-21 Jose E. Marchesi * build-aux/vc-list-files: Invoke bazaar to generate a recursive list of versioned files based on 'dir' (usage of -R in 'bzr ls'). diff --git a/build-aux/vc-li

Re: make 'list' and 'oset' modules usable in libraries

2009-12-16 Thread jemarch
Hi Bruno. José Marchesi reported that the 'list' and 'oset' container data structures are not really usable in libraries, because they call xalloc_die() when an out-of-memory condition occurs. An xalloc_die() that calls exit() is not usable in a library. An xalloc_die() that calls set

Re: Generating code coverage reports

2008-10-28 Thread jemarch
> Does that make sense? Oh, I am not that familiar with how the profiling code actually works, thanks for explaining. I haven't found anything in gnupdf that works around the problem, so maybe gnupdf is affected as well, but I am not certain. The stats stored in the .gcda files a

Re: [pdf-devel] Generating code coverage reports

2008-10-28 Thread jemarch
Hi Simon. I was inspired by gnupdf's code coverage reports: http://www.gnupdf.org/prmgt/coverage/ So I looked into how to integrate a script to generate them for some of my projects. I couldn't think of how to implement this as a gnulib module, but I wrote rules for maintainer-m

Re: pmccabe2html: support inline stylesheets

2008-10-13 Thread jemarch
Jose, after this patch you'll need to supply a new parameter css=filename or css_url=url to provide the stylesheet. Do you think this approach is good? I like it. It allows the use of an external css file or to embed css information from a file, or both.

Re: Project management and code quality tools

2008-10-08 Thread jemarch
What happened here was that I took pmccabe2html from GNUPDF, made it project-independent (small changes but possibly more than 10 lines), and put it into gnulib. Jose is already using gnulib, so it is probably simpler for him to pull pmccabe2html from gnulib and send patches for pm

Re: Project management and code quality tools

2008-10-07 Thread jemarch
>> I think it is a really good idea. If the scripts are distributed in >> gnulib more GNU packages will be using them and improving them. > >Thanks for feedback, I have pushed the module into gnulib. > > Nice. Then we will start using the gnulib version :) Great.

Re: Project management and code quality tools

2008-10-07 Thread jemarch
> I think it is a really good idea. If the scripts are distributed in > gnulib more GNU packages will be using them and improving them. Thanks for feedback, I have pushed the module into gnulib. Nice. Then we will start using the gnulib version :)

Re: Project management and code quality tools

2008-10-07 Thread jemarch
> "documentation". The scripts generating all the stuff are in the > 'prmgt/' directory in the libgnupdf sources distribution. I have taken a closer look at your prmgt/ directory, and I really like your efforts. I want to use this in my projects, and the simplest for me would be t

Re: syntax-check hits on gnulib itself

2008-09-03 Thread jemarch
> I ran 'make syntax-check' (from gnulib's maint.mk) and it detected some > problems in code in gnulib itself These are not problems in the code. You better avoid to apply this coding conventions checker against a file that is written with different coding conventions. Just a litt

Typo in maint.mk

2008-08-28 Thread jemarch
Hi hackers. Just a little note. There are two references in maint.mk to Makefile.cfg (in comments). It seems that it should read cfg.mk instead. --- top/maint.mk.orig 2008-07-27 16:21:51.0 +0200 +++ top/maint.mk2008-08-29 01:28:43.0 +0200 @@ -21,10 +21,10 @@ # List o

Re: mingw bug and localename

2008-05-27 Thread jemarch
> #define SUBLANG_TIBETAN_PRC0x01 > #define SUBLANG_TIBETAN_BHUTAN 0x01 > > So the fail is explained: both sublanguage codes has the same > value. Thanks for reporting it. I don't know how long time the mingw guys will need to fix their problem, so I'm applying t

mingw bug and localename

2008-05-27 Thread jemarch
Hello. We are happily using gnulib in the GNU PDF Library (http://www.gnupdf.org). I just found a problem while using the localename module just after a git update of the library. _It is a mingw32 bug_, present in the latest mingw release, and I already reported it, but I include the informatio

maint.mk: avoid to match non-cast expressions in free calls

2007-09-20 Thread jemarch
ut it doesnt work when used in the `sc_cast_of_argument_to_free' in `maint.mk'. Executing grep -nE '\&2; \ exit 1; } || : in the command line also works. I am somewhat lost :) [EMAIL PROTECTED]:~/gnu/src/gnulib/build-aux$ cvs diff -u maint.mk cvs d