Re: [PATCH] match GNU/kOpenSolaris in Glibc checks

2008-12-29 Thread Robert Millan
On Tue, Dec 30, 2008 at 03:27:05AM +0100, Bruno Haible wrote: > The right order is: > 1) Get the canonical system triple approved by RMS, > 2) Get config.guess and config.sub patches accepted. > 3) Update libtool, binutils, gcc, gnulib etc. Btw, things have changed recently. There's now:

Re: [PATCH] match GNU/kOpenSolaris in Glibc checks

2008-12-29 Thread Robert Millan
On Tue, Dec 30, 2008 at 04:17:53AM +0100, Bruno Haible wrote: > Hi Robert, > > > > The patch is not correct, AFAIK: There is also a triple > > > i386-unknown-netbsd-gnu, > > > which differs from i386-unknown-knetbsd-gnu in the choice of its libc: it > > > uses > > > NetBSD's libc instead of GNU

Re: [PATCH] match GNU/kOpenSolaris in Glibc checks

2008-12-29 Thread Bruno Haible
Hi Robert, > > The patch is not correct, AFAIK: There is also a triple > > i386-unknown-netbsd-gnu, > > which differs from i386-unknown-knetbsd-gnu in the choice of its libc: it > > uses > > NetBSD's libc instead of GNU libc. > > The latest updates that can be found for this port date from 2002

Re: Fix gl_MULTIARCH to work around autoconf bug

2008-12-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 12/29/2008 5:55 PM: > Yes, it would be good if you could apply the workaround, probably with a > comment such as: > > AC_DEFUN([gl_MULTIARCH], > [ > dnl This AC_REQUIRE is not necessary in theory. It works around a bug

Re: [PATCH] match GNU/kOpenSolaris in Glibc checks

2008-12-29 Thread Robert Millan
On Tue, Dec 30, 2008 at 03:27:05AM +0100, Bruno Haible wrote: > > I propose using a generic '*-gnu' match (I notice some of the checks in > > gnulib do it this way already). > > The patch is not correct, AFAIK: There is also a triple > i386-unknown-netbsd-gnu, > which differs from i386-unknown-kn

Re: m4 quoting improvements

2008-12-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 12/29/2008 10:59 AM: > - AC_DEFINE(AFS, 1, [Define if you have the Andrew File System.]) > + AC_DEFINE([AFS], 1, [Define if you have the Andrew File System.]) Do you want to also quote [1]? It cannot be confused

Re: [PATCH] match GNU/kOpenSolaris in Glibc checks

2008-12-29 Thread Bruno Haible
Hello Robert, > I adjusted some of the Glibc checks to match GNU/kOpenSolaris [1]. Because the > checks are always the same for all Glibc-based systems, and having to wait > for files to propagate to every package out there is a PITA, I agree this is a problem when you work outside of the scope o

Re: Fix gl_MULTIARCH to work around autoconf bug

2008-12-29 Thread Bruno Haible
Hi Eric, Thank you for tackling this bug report so rapidly. I'm glad that you were able to reduce the test case to a minimal one. > I've tested that before this patch, > gnulib-tool --create-testdir --dir=... vasnprintf-posix > > references $APPLE_UNIVERSAL_BUILD prior to its definition, and aft

Fix gl_MULTIARCH to work around autoconf bug

2008-12-29 Thread Eric Blake
Bruno, okay to apply in response to your bug report? http://lists.gnu.org/archive/html/bug-autoconf/2008-12/msg00039.html I've tested that before this patch, gnulib-tool --create-testdir --dir=... vasnprintf-posix references $APPLE_UNIVERSAL_BUILD prior to its definition, and after the patch, th

Re: some buglet in gnulib-tool func_update_ignorelist

2008-12-29 Thread Bruno Haible
Hello Ralf, > bootstrap on the branch-1.4 branch of M4 showed this sed error > during 'gnulib-tool --update', with a dirty gnulib tree from last week: > > Updating file build-aux/announce-gen (backup in build-aux/announce-gen~) > Updating file build-aux/gnupload (backup in build-aux/gnupload~) >

Re: work around Solaris 8 'join' bug

2008-12-29 Thread Bruno Haible
Hello Ralf, > Quoting autoconf.info: > > | `join' > | Solaris 8 `join' has bugs when the second operand is standard > | input, and when standard input is a pipe. For example, the > | following shell script causes Solaris 8 `join' to loop forever: > | > | cat >file <<'EO

Re: m4 quoting improvements

2008-12-29 Thread Bruno Haible
Hi Jim, > Barring objections (yes, I know I'll have to filter out > files that are imported from other projects, like gettext) Looks reasonable (except that the ChangeLog entry indicates that no one except Ralf has actually looked at the diffs). I'm committing a bit more aggressive quoting patche

sed, SIGPIPE, cmp -s [Re: [PATCH 3/4] gnulib-tool: abort loops early where possible.

2008-12-29 Thread Jim Meyering
Ralf Wildenhues wrote: > * gnulib-tool (func_modules_add_dummy, func_emit_lib_Makefile_am) > (func_emit_tests_Makefile_am, func_import): Abort loops early if > we already know the answer. Hi Ralf, Not that I've reviewed it in detail, but this looks ok. Also, it induces no change in coreutils bui

Re: parse-duration.c

2008-12-29 Thread Ralf Wildenhues
Hi Bruce, * Bruce Korb wrote on Sat, Dec 27, 2008 at 11:36:56PM CET: > > So, I've now had another gander now, too. > > A small doc tweak and coding aesthetics issue: > > This should probably be applied. I don't have "push" privs on the > repository. What should I do? Thanks. - Bruce I'm not a

Re: m4 quoting improvements

2008-12-29 Thread Ralf Wildenhues
Hi Jim, * Jim Meyering wrote on Mon, Dec 29, 2008 at 06:59:59PM CET: > > This is just a first coarse/automated pass; I'm sure there > are many more places where it's appropriate to add quotes. FWIW, the diffs all look good at first glance. (Of course I am not to approve them.) Cheers, and than

[PATCH 3/4] gnulib-tool: abort loops early where possible.

2008-12-29 Thread Ralf Wildenhues
* gnulib-tool (func_modules_add_dummy, func_emit_lib_Makefile_am) (func_emit_tests_Makefile_am, func_import): Abort loops early if we already know the answer. --- Sorry, I forgot a couple of instances. Updated patch. Cheers, Ralf gnulib-tool | 20 1 files changed, 8 ins

WEOF on Irix 5.3

2008-12-29 Thread Eric Blake
Tom G. Christensen reported on the bug-m4 list: | This snapshot fails to build on IRIX 5.3: | source='btowc.c' object='btowc.o' libtool=no \ | DEPDIR=.deps depmode=sgi /bin/ksh ../build-aux/depcomp \ | cc -I. -I/usr/tgcware/include -g -c -o btowc.o btowc.c | cfe: Error: btowc.c

Re: [PATCH] setsockopt: Add support for timeouts on W32

2008-12-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 12/25/2008 5:35 PM: > Regarding 'restrict', > I never use this keyword because AFAIK, omitting it has no effect on > correct programs; its presence is only a hint to the user that uses of > the functions with daring overlap

Re: [PATCH] setsockopt: Add support for timeouts on W32

2008-12-29 Thread Paolo Bonzini
> Looks all fine to me, but it's Simon and Paolo who have to decide on this. > Good point. The prototypes should have socklen_t. Both are ok. > Here is another proposed > patch, also for consideration by Simon and Paolo. - Regarding 'restrict', > I never use this keyword because AFAIK, omitting