-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Jim Meyering on 12/29/2008 10:59 AM: > - AC_DEFINE(AFS, 1, [Define if you have the Andrew File System.]) > + AC_DEFINE([AFS], 1, [Define if you have the Andrew File System.])
Do you want to also quote [1]? It cannot be confused with a macro name, but we still might as well be consistent. I see that your third patch touches some second arguments, but not numbers. > AC_MSG_RESULT(yes)], > [ AC_MSG_RESULT(no)] ) > @@ -42,7 +42,7 @@ AC_DEFUN([gl_ARGP], > AC_MSG_CHECKING(whether program_invocation_short_name is defined) Time for a fifth regexp, for the text of AC_MSG_*? > - AC_DEFINE_UNQUOTED(NAME_OF_RANDOM_DEVICE, "$NAME_OF_RANDOM_DEVICE", > + AC_DEFINE_UNQUOTED([NAME_OF_RANDOM_DEVICE], "$NAME_OF_RANDOM_DEVICE", > [defined to the name of the (strong) random device]) Unlike [1] above, ["$NAME_OF_RANDOM_DEVICE"] would prevent an accidental macro invocation. It looks like the regex in your third patch missed this. > - dnl Note: AC_STRUCT_ST_BLOCKS does AC_LIBOBJ(fileblocks). > + dnl Note: AC_STRUCT_ST_BLOCKS does AC_LIBOBJ([fileblocks]). A no-op change, but still seems reasonable for consistency. Overall, I'm in favor of this patch series. - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAklZjroACgkQ84KuGfSFAYCUjgCgoEeV7r/0Oj6kdtVUuHcRcphv AkQAn3HJ9HWzRegF2AzfUErcJuwLePHo =drp2 -----END PGP SIGNATURE-----
