Re: [blink-dev] Re: Intent to Ship: Escape "<" and ">" in attributes on serialization

2025-05-14 Thread Reilly Grant
Enterprises tend not to run beta-channel. They also tend to turn off metrics and crash reporting. A slow rollout as Alex is suggesting will hopefully catch issues early but we also need to be ready to react to urgent regressions as this reaches 100% on stable-channel. Reilly Grant | Software Engine

Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-14 Thread Rune Lillesveen
On Tue, May 13, 2025 at 9:20 AM Rune Lillesveen wrote: > On Tue, May 13, 2025 at 8:34 AM Rune Lillesveen > wrote: > >> On Tue, May 13, 2025 at 7:43 AM Domenic Denicola >> wrote: >> >>> I'm very slightly worried about the cases which we seem to accept, but >>> the latest on the CSSWG thread sugg

[blink-dev] Re: Intent to Ship: Update QuotaExceededError to a DOMException derived interface

2025-05-14 Thread Alex Russell
Sorry, I misunderstood which way this change was being proposed. LGTM1 On Tuesday, May 13, 2025 at 6:24:02 PM UTC-7 Domenic Denicola wrote: > On Wed, May 14, 2025 at 3:21 AM Alex Russell > wrote: > >> Thanks for flipping the bits, Ayu. >> >> Domenic: it seems like this is part of a longer-runni

Re: [blink-dev] Re: Intent to Ship: Update QuotaExceededError to a DOMException derived interface

2025-05-14 Thread Daniel Bratell
LGTM2 /Daniel On 2025-05-14 17:22, Alex Russell wrote: Sorry, I misunderstood which way this change was being proposed. LGTM1 On Tuesday, May 13, 2025 at 6:24:02 PM UTC-7 Domenic Denicola wrote: On Wed, May 14, 2025 at 3:21 AM Alex Russell wrote: Thanks for flipping the bits

Re: [blink-dev] Intent to Ship: Deprecate asynchronous range removal for Media Source Extensions

2025-05-14 Thread Philip Jägenstedt
LGTM3, and we have a feature flag / kill switch if this breaks something more than expected. On Wed, May 14, 2025 at 5:10 PM Chris Harrelson wrote: > LGTM2 to change the behavior. > > On Tue, May 13, 2025 at 12:11 PM Daniel Bratell > wrote: > >> LGTM1 to change the behaviour. >> >> /Daniel >> O

Re: [blink-dev] Re: Intent to Ship: Support async attribute for SVG

2025-05-14 Thread Philip Jägenstedt
On Wed, May 14, 2025 at 4:45 PM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > > > On Wednesday, May 14, 2025 at 10:19:43 AM UTC+2 Chromestatus wrote: > > Contact emails viralipur...@microsoft.com > > Explainer None > > Specification https://svgwg.org/svg2-draft/interact.html#ScriptEleme

Re: [blink-dev] Re: Intent to Ship: Update QuotaExceededError to a DOMException derived interface

2025-05-14 Thread Ayu Ishii
Thank you for all the reviews! (And apologies for the delayed review bits!) Best, Ayu On Wednesday, May 14, 2025 at 8:26:35 AM UTC-7 Chris Harrelson wrote: > Looks good to me, once the Testing dimension is filled out on > chromestatus.com. > > On Wed, May 14, 2025 at 8:23 AM Daniel Bratell >

Re: [EXTERNAL] Re: [blink-dev] Intent to Ship: On-device Web Speech API

2025-05-14 Thread 'Evan Liu' via blink-dev
It would definitely be better to make this change before the feature ships, but it's up to y'all Blink owners if you think this should be a blocker for this intent. The Audio Working Group is meeting tomorrow morning so hopefully we'll be able to reach a consensus then! On Wed, May 14, 2025 at 8:0

[blink-dev] Intent to Ship: Support async attribute for SVG

2025-05-14 Thread Chromestatus
Contact emails viralipur...@microsoft.com Explainer None Specification https://svgwg.org/svg2-draft/interact.html#ScriptElement:~:text=%E2%80%98script%E2%80%99%20element-,SVG%202%20Requirement%3A,Consider%20allowing%20async/defer%20on%20%E2%80%98script%E2%80%99.,-Resolution%3A Design docs ht

Re: [blink-dev] Re: Intent to Ship: Update QuotaExceededError to a DOMException derived interface

2025-05-14 Thread Domenic Denicola
On Thu, May 15, 2025 at 12:26 AM Vladimir Levin wrote: > Hi, > > I'm looking at https://github.com/search?q=QuotaExceededError&type=code > it seems like there are already classes with that name, which I believe > shouldn't be a problem. > Notably the majority of cases I can find are in React Nat

Re: [blink-dev] Intent to Ship: Crash Reporting API: is_top_level & visibility_state

2025-05-14 Thread Domenic Denicola
LGTM1 On Thu, May 15, 2025 at 4:08 AM Dominic Farolino wrote: > Thanks for pointing this oversight out! It's been addressed in the spec, > and the impl > is up > for review and looking good. So I'm hopeful that reviews here can

[blink-dev] Re: Intent to Ship: Support async attribute for SVG

2025-05-14 Thread Yoav Weiss (@Shopify)
On Wednesday, May 14, 2025 at 10:19:43 AM UTC+2 Chromestatus wrote: Contact emails viralipur...@microsoft.com Explainer None Specification https://svgwg.org/svg2-draft/interact.html#ScriptElement:~: text=%E2%80%98script%E2%80%99%20element-,SVG%202%20Requirement%3A,Consider% 20allowing%20asyn

Re: [EXTERNAL] Re: [blink-dev] Intent to Ship: On-device Web Speech API

2025-05-14 Thread Yoav Weiss (@Shopify)
On Wednesday, May 7, 2025 at 8:50:12 PM UTC+2 ev...@google.com wrote: Hi all, Thanks for the thorough review! I've opened a GitHub issue for the remaining request. Hopefully we'll settle on an option before the next Audio Working Group

Re: [blink-dev] Re: Intent to Ship: Update QuotaExceededError to a DOMException derived interface

2025-05-14 Thread Chris Harrelson
Looks good to me, once the Testing dimension is filled out on chromestatus.com. On Wed, May 14, 2025 at 8:23 AM Daniel Bratell wrote: > LGTM2 > > /Daniel > On 2025-05-14 17:22, Alex Russell wrote: > > Sorry, I misunderstood which way this change was being proposed. LGTM1 > > On Tuesday, May 13,

Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-14 Thread Philip Jägenstedt
On Wed, May 14, 2025 at 5:21 PM Rune Lillesveen wrote: > On Tue, May 13, 2025 at 9:20 AM Rune Lillesveen > wrote: > >> On Tue, May 13, 2025 at 8:34 AM Rune Lillesveen >> wrote: >> >>> On Tue, May 13, 2025 at 7:43 AM Domenic Denicola >>> wrote: >>> I'm very slightly worried about the cases

Re: [blink-dev] Re: Intent to Ship: Update QuotaExceededError to a DOMException derived interface

2025-05-14 Thread Vladimir Levin
Hi, I'm looking at https://github.com/search?q=QuotaExceededError&type=code it seems like there are already classes with that name, which I believe shouldn't be a problem. I do see some patterns that check explicitly for QuotaExceededError string and some examples handle that as a "success" as

[blink-dev] Intent to Prototype: Show true window position on Android

2025-05-14 Thread 'Bartosz Chomiński' via blink-dev
Contact emailschomins...@google.com ExplainerNone Specificationhttps://www.w3.org/TR/cssom-view-1/#dom-window-screenx Summary Chrome on Android accurately reports the browser window's position using window.screenX and window.screenY. Currently Chrome incorrectly assumes all browser windows on A

Re: [blink-dev] Intent to Ship: Deprecate asynchronous range removal for Media Source Extensions

2025-05-14 Thread Chris Harrelson
LGTM2 to change the behavior. On Tue, May 13, 2025 at 12:11 PM Daniel Bratell wrote: > LGTM1 to change the behaviour. > > /Daniel > On 2025-05-13 20:30, Dale Curtis wrote: > > The plan is to land the change right away given the low usage and long > shipped state on other UAs. > > - dale > > On T

Re: [blink-dev] Intent to Ship: Modulepreload Referrer Header Fix

2025-05-14 Thread Chris Harrelson
Please also fill out the Privacy, Security, Enterprise, Debuggability and Testing sections in the chromestatus entry. On Tue, May 13, 2025 at 9:51 PM Domenic Denicola wrote: > > > On Wed, May 14, 2025 at 5:10 AM Chromestatus < > ad...@cr-status.appspotmail.com> wrote: > >> Contact emails hjanusc

Re: [blink-dev] Intent to Ship: Crash Reporting API: is_top_level & visibility_state

2025-05-14 Thread Dominic Farolino
Thanks for pointing this oversight out! It's been addressed in the spec, and the impl is up for review and looking good. So I'm hopeful that reviews here can proceed now. On Wed, May 14, 2025 at 12:53 AM Domenic Denicola wrote:

Re: [blink-dev] Intent to Ship: Pass 'Sec-Purpose: prefetch' header with

2025-05-14 Thread Yoav Weiss (@Shopify)
LGTM3 On Tuesday, May 13, 2025 at 8:22:16 PM UTC+2 Alex Russell wrote: > LGTM2 > > On Tuesday, May 13, 2025 at 11:21:54 AM UTC-7 dan...@microsoft.com wrote: > >> LGTM1 >> >> On Monday, May 12, 2025 at 3:00:13 PM UTC-7 stev...@microsoft.com wrote: >> >>> Yes, thanks for the reminder. This is my fi