LGTM3, and we have a feature flag / kill switch if this breaks something more than expected.
On Wed, May 14, 2025 at 5:10 PM Chris Harrelson <chris...@chromium.org> wrote: > LGTM2 to change the behavior. > > On Tue, May 13, 2025 at 12:11 PM Daniel Bratell <bratel...@gmail.com> > wrote: > >> LGTM1 to change the behaviour. >> >> /Daniel >> On 2025-05-13 20:30, Dale Curtis wrote: >> >> The plan is to land the change right away given the low usage and long >> shipped state on other UAs. >> >> - dale >> >> On Tue, May 13, 2025 at 10:57 AM Daniel Bratell <bratel...@gmail.com> >> wrote: >> >>> Do you just want to deprecate it (i.e. add some warning when used) or do >>> you want to do the change right away? Doing the change right away seems >>> reasonable. >>> >>> /Daniel >>> On 2025-05-13 18:44, Chromestatus wrote: >>> >>> Contact emails dalecur...@chromium.org >>> >>> Explainer None >>> >>> Specification https://w3c.github.io/media-source >>> >>> Summary >>> >>> The Media Source standard long ago changed to disallow ambiguously >>> defined behavior involving asynchronous range removals: * >>> SourceBuffer.abort() no longer aborts SourceBuffer.remove() operations * >>> Setting MediaSource.duration can no longer truncate currently buffered >>> media Exceptions will be thrown in both of these cases now. Safari and >>> Firefox have long shipped this behavior, Chromium is the last browser >>> remaining with the old behavior. Use counters show ~0.001%-0.005% of page >>> loads hit the deprecated behavior. Primarily small Russian sites. If a site >>> hits this issue, playback may now break. Usage of abort() cancelling >>> removals is increasing, so it's prudent to resolve this deprecation before >>> more incompatible usage appears. >>> >>> >>> Blink component Internals>Media>Source >>> <https://issues.chromium.org/issues?q=customfield1222907:%22Internals%3EMedia%3ESource%22> >>> >>> TAG review None >>> >>> TAG review status Not applicable >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> >>> Safari and Firefox have long shipped this behavior, Chromium is the last >>> browser remaining with the old behavior. Use counters show ~0.001%-0.005% >>> of page loads hit the deprecated behavior. Primarily small Russian sites. >>> If a site hits this issue, playback may now break. >>> >>> >>> *Gecko*: Shipped/Shipping ( >>> https://searchfox.org/mozilla-central/rev/e703d3fbd6da82cdda1256016a80abb1f245fedd/dom/media/mediasource/MediaSource.cpp#666) >>> Ships both abort() and setDuration() restrictions. >>> >>> *WebKit*: Shipped/Shipping ( >>> https://github.com/WebKit/WebKit/blob/1afe2bf63106ce2c22fe78926d629780c2b6fd6a/Source/WebCore/Modules/mediasource/MediaSource.cpp#L732) >>> Ships both abort() and setDuration() restrictions. >>> >>> *Web developers*: No signals Bug has 25 +1s so developers are hitting >>> this discrepancy, but no direct feedback. >>> >>> *Other signals*: >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> Yes. WebView based players using Media Source Extensions will be >>> affected. >>> >>> >>> Debuggability >>> >>> Clear exceptions are thrown when this issue occurs. >>> >>> >>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>> Linux, ChromeOS, Android, and Android WebView)? Yes >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ? Yes >>> >>> https://wpt.fyi/results/media-source/mediasource-duration.html >>> https://wpt.fyi/results/media-source/mediasource-remove.html >>> >>> >>> Flag name on about://flags MediaSourceNewAbortAndDuration >>> >>> Finch feature name MediaSourceNewAbortAndDuration >>> >>> Rollout plan Will ship enabled for all users >>> >>> Requires code in //chrome? False >>> >>> Tracking bug https://issues.chromium.org/issues/40474569 >>> >>> Measurement >>> https://chromestatus.com/metrics/feature/timeline/popularity/1428 >>> (0.004970% of page loads) >>> https://chromestatus.com/metrics/feature/timeline/popularity/1429 >>> (0.001454% of page loads) Usage of abort() cancelling removals is >>> increasing, so it's prudent to resolve this deprecation before more >>> incompatible usage appears. >>> >>> Estimated milestones >>> Shipping on desktop 138 >>> Shipping on Android 138 >>> Shipping on WebView 138 >>> >>> Anticipated spec changes >>> >>> Open questions about a feature may be a source of future web compat or >>> interop issues. Please list open issues (e.g. links to known github issues >>> in the project for the feature specification) whose resolution may >>> introduce web compat/interop risk (e.g., changing to naming or structure of >>> the API in a non-backward-compatible way). >>> None >>> >>> Link to entry on the Chrome Platform Status >>> https://chromestatus.com/feature/5190983595327488?gate=5206078123671552 >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com>. >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/682376d1.170a0220.2aa17e.00d4.GAE%40google.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/682376d1.170a0220.2aa17e.00d4.GAE%40google.com?utm_medium=email&utm_source=footer> >>> . >>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/cab5a03d-4f22-465c-8c0b-94ab790db0e6%40gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/cab5a03d-4f22-465c-8c0b-94ab790db0e6%40gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-RkG%2Bv_PcAHvzmWNzHFDR_oyO5zrhk0xMiTE%2BP1YqktA%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-RkG%2Bv_PcAHvzmWNzHFDR_oyO5zrhk0xMiTE%2BP1YqktA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYfvSPsfT3inYPkic1JKE-NgyhqOj0ajyHbJEdpF3troVg%40mail.gmail.com.
