Re: [blink-dev] Re: Intent to Ship: IP Protection in Incognito using published Masked Domain list

2025-07-16 Thread Philip Jägenstedt
LGTM3 On Wed, Jul 16, 2025 at 5:29 PM Alex Russell wrote: > Mike Taylor was kind enough to answer all my questions regarding > non-Google browsers in today's API OWNERS meeting. LGTM2. > > On Wednesday, July 16, 2025 at 8:28:24 AM UTC-7 Chris Harrelson wrote: > >> LGTM1 >> >> On Wed, Jul 16, 202

Re: [blink-dev] Re: Intent to Ship: Script Blocking in Incognito

2025-07-16 Thread Philip Jägenstedt
LGTM2 On Wed, Jul 16, 2025 at 5:55 PM Chris Harrelson wrote: > Ok, thanks for clarifying. > > LGTM1 > > On Wed, Jul 16, 2025 at 8:51 AM 'Zainab Rizvi' via blink-dev < > blink-dev@chromium.org> wrote: > >> Hi Chris! We will have a few UI indicators when a resource is blocked: >> >> 1. The "eye" i

Re: [blink-dev] Re: Intent to Ship: CSS find-in-page highlight pseudos

2025-07-16 Thread Philip Jägenstedt
On testing in WPT, can you look into a WebDriver BiDi command for triggering find-in-page? That would enable testing this. On Wed, Jul 16, 2025 at 5:11 PM Philip Jägenstedt wrote: > Thank you for filing https://github.com/w3ctag/design-reviews/issues/1120! > Since it was just two da

Re: [blink-dev] Re: Intent to Ship: CSS find-in-page highlight pseudos

2025-07-16 Thread Philip Jägenstedt
Thank you for filing https://github.com/w3ctag/design-reviews/issues/1120! Since it was just two days ago, let's give it some time before proceeding. +Jeffrey Yasskin if the TAG can expedite this, it would be great :) On Mon, Jul 14, 2025 at 1:43 PM Stephen Chenney wrote: > On Sun, Jul 13, 2025

Re: [blink-dev] Re: Intent to Ship: Secure Payment Confirmation: UX Refresh

2025-07-09 Thread Philip Jägenstedt
Sorry, I didn't read the WPT PRs you linked. I see that the tests already depend on test_driver.add_virtual_authenticator(). Is there anything blocking testing here, or is it OK if shipping this is conditional on the tests being landed? On Wed, Jul 9, 2025 at 5:17 PM Philip Jägenstedt

Re: [blink-dev] Re: Intent to Ship: Secure Payment Confirmation: UX Refresh

2025-07-09 Thread Philip Jägenstedt
Hey Stephen, Is WebAuthn virtual authenticators the DevTools feature mentioned in https://developer.chrome.com/docs/devtools/webauthn? If you need powerful test automation for WebAuthn, have you had a look at what's currently possible with WebDriver BiDi and testdriver.js? Recently

Re: [blink-dev] Intent to Ship: Support font-variation-settings descriptor in @font-face rule

2025-07-09 Thread Philip Jägenstedt
LGTM1, I'm happy to see this ship too. I took a look at all tests with font-variation-settings in the path, and see that calc-in-font-variation-settings.html

Re: [blink-dev] Intent to Ship: Support font-feature-settings descriptor in @font-face rule

2025-07-05 Thread Philip Jägenstedt
LGTM1, thank you for addressing this pain point for developers! The scope of this intent is font-feature-settings, but now that https://chromium-review.googlesource.com/c/chromium/src/+/6582382 has been merged, do you want to ship support for font-feature-settings and font-variation-settings toget

Re: [blink-dev] Re: [EXTERNAL] Re: Intent to Ship: Support font-feature-settings descriptor in @font-face rule

2025-07-02 Thread Philip Jägenstedt
Hi Sejal, It's great to the progress on this, I believe it's one of the most highly upvoted font-related features. https://chromestatus.com/feature/5102801981800448 still doesn't show up in the list of features to review/approve, please feel free to reach out off list if you can't find the right

Re: [blink-dev] Re: Intent to Ship: Insert CJK inter-script spacing: the CSS `text-autospace` property

2025-07-02 Thread Philip Jägenstedt
LGTM2 We discussed this in the API owners meeting today (present: Chris, Yoav, Vlad, Jeffrey, Daniel, Alex, me) and think it makes sense to ship matching the initial value that Safari already shipped. At that point we expect https://github.com/w3c/csswg-drafts/issues/12386 to be resolved to match

Re: [blink-dev] Intent to Ship: Uint8Array to/from base64 and hex

2025-07-02 Thread Philip Jägenstedt
LGTM3 On Wed, Jul 2, 2025 at 4:51 PM Yoav Weiss (@Shopify) wrote: > LGTM2 > > On Wed, Jul 2, 2025 at 4:38 PM Daniel Bratell wrote: > >> LGTM1 >> >> /Daniel >> On 2025-06-27 00:27, Rezvan Mahdavi Hezaveh wrote: >> >> Contact emails rez...@chromium.org, s...@chromium.org >> >> Explainer None >> >

Re: [blink-dev] Intent to Ship: CSS env variable for OS-level font scale

2025-05-30 Thread Philip Jägenstedt
LGTM2 Thank Philip and David for elaborating on the differences between mobile and desktop platform that have led to this approach, and Domenic for your summary of the situation. Thinking about the longer term, I think it's important that the addition of env(preferred-text-scale) and yet other me

Re: [blink-dev] Intent to Ship: 'request-close' Invoker Command

2025-05-28 Thread Philip Jägenstedt
LGTM3 On Wed, May 28, 2025 at 5:23 PM Chris Harrelson wrote: > LGTM2 > > On Tue, May 27, 2025 at 7:35 AM Yoav Weiss (@Shopify) < > yoavwe...@chromium.org> wrote: > >> LGTM1 >> This seems like a small and useful addition to invoker commands. Thanks >> for adding it. >> >> On Fri, May 23, 2025, 07

Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-14 Thread Philip Jägenstedt
On Wed, May 14, 2025 at 5:21 PM Rune Lillesveen wrote: > On Tue, May 13, 2025 at 9:20 AM Rune Lillesveen > wrote: > >> On Tue, May 13, 2025 at 8:34 AM Rune Lillesveen >> wrote: >> >>> On Tue, May 13, 2025 at 7:43 AM Domenic Denicola >>> wrote: >>> I'm very slightly worried about the cases

Re: [blink-dev] Re: Intent to Ship: Support async attribute for SVG

2025-05-14 Thread Philip Jägenstedt
On Wed, May 14, 2025 at 4:45 PM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > > > On Wednesday, May 14, 2025 at 10:19:43 AM UTC+2 Chromestatus wrote: > > Contact emails viralipur...@microsoft.com > > Explainer None > > Specification https://svgwg.org/svg2-draft/interact.html#ScriptEleme

Re: [blink-dev] Intent to Ship: Deprecate asynchronous range removal for Media Source Extensions

2025-05-14 Thread Philip Jägenstedt
LGTM3, and we have a feature flag / kill switch if this breaks something more than expected. On Wed, May 14, 2025 at 5:10 PM Chris Harrelson wrote: > LGTM2 to change the behavior. > > On Tue, May 13, 2025 at 12:11 PM Daniel Bratell > wrote: > >> LGTM1 to change the behaviour. >> >> /Daniel >> O

Re: [blink-dev] Intent to Ship: Fire error event instead of throwing for CSP blocked worker

2025-05-07 Thread Philip Jägenstedt
Hi Liang, https://chromestatus.com/metrics/feature/timeline/popularity/5356 is already somewhat high, but it is also an upper bound on the risk and probably not reflective of how many sites will be broken. Looking at a sample of sites that hit the use counter and seeing what the impact of the chan

Re: [blink-dev] Intent to Ship: Canvas Floating Point Color Types

2025-04-09 Thread Philip Jägenstedt
On Wed, Apr 9, 2025 at 9:31 PM ccameron chromium wrote: > > > On Wed, Apr 9, 2025 at 5:57 PM Philip Jägenstedt > wrote: > >> Hi Chris, >> >> Have the spec changes for this landed, or are there open PRs? >> > > All PRs have landed (and are now ref

Re: [blink-dev] Intent to Ship: Canvas Floating Point Color Types

2025-04-09 Thread Philip Jägenstedt
Hi Chris, Have the spec changes for this landed, or are there open PRs? Best regards, Philip On Wed, Apr 9, 2025 at 5:54 PM Daniel Bratell wrote: > LGTM2 because I don't believe that there are no web developer signals. > Surely there is demand for this? > > /Daniel > On 2025-04-09 17:33, Chris

Re: [blink-dev] Intent to Ship: JavaScript Promise Integration

2025-04-09 Thread Philip Jägenstedt
LGTM1, very exciting to see this ship! There are some apparent failures in https://wpt.fyi/results/wasm/jsapi/jspi, but this seems to be because of https://github.com/web-platform-tests/wpt.fyi/issues/4216, not real failures. On Tue, Apr 8, 2025 at 6:32 PM Chromestatus wrote: > Contact emails f

Re: [blink-dev] Re: Intent to Ship: H265 (HEVC) codec support in WebRTC

2025-03-11 Thread Philip Jägenstedt
LGTM1 with the same caveats as for MediaRecorder : - The approval is only for exposing OS-provided HEVC support, not for other OS-provided codecs, and not for browser-provided HEVC. - That there is a well

Re: [External] Re: [blink-dev] Re: Intent to Ship: H26x Codec support updates for MediaRecorder

2025-03-11 Thread Philip Jägenstedt
/chromium/src/+/main:third_party/blink/web_tests/external/wpt/mediacapture-record/MediaRecorder-canvas-media-source.https.html;l=16 >> and >> ISO/IEC 14496-15:2019 - Annex E. >> >> Best regards, >> Sida >> From: "Philip Jägenstedt" >> Date: Tue,

Re: [External] Re: [blink-dev] Re: Intent to Ship: H26x Codec support updates for MediaRecorder

2025-03-04 Thread Philip Jägenstedt
his intent? WebRTC comes to mind, but are there any others? > > > For video encoding context, there are three major API FYI: > >1. WebCodecs. >2. MediaRecorder. >3. WebRTC. > > > The HEVC support for the WebCodecs API has been enabled by default in > M13

Re: [blink-dev] Re: Intent to Ship: H26x Codec support updates for MediaRecorder

2025-02-19 Thread Philip Jägenstedt
Hi, The API owners (Dan, Alex, Vlad, Yoav, Mike, Chris, Daniel, me) discussed this today. We'd like to understand a bit better where HEVC is already supported and what contexts don't yet support it. As mentioned, HEVC (encode and decode) is already supported in WebCodecs. The tests on wpt.fyi are

Re: [blink-dev] Re: Intent to Ship: NavigateEvent sourceElement

2025-02-14 Thread Philip Jägenstedt
Correction, https://github.com/whatwg/html/pull/10898 was the spec PR. But everything still looks to be in good order. On Thu, Feb 13, 2025 at 9:02 PM Mike Taylor wrote: > LGTM3 > On 2/13/25 11:27 AM, Chris Harrelson wrote: > > LGTM2 > > On Thu, Feb 13, 2025 at 2:47 AM

Re: [blink-dev] Intent to Ship: Service Worker client URL ignore history.pushState changes

2025-02-13 Thread Philip Jägenstedt
LGTM2 Thanks Domenic for trying some searches. We really don't have a way to measure the risk of changes of string properties because we can't instrument the returned string and "follow it around" or reason about what code path is the expected one. I think digging deeper isn't justified given that

Re: [blink-dev] Re: Intent to Ship: NavigateEvent sourceElement

2025-02-13 Thread Philip Jägenstedt
LGTM1, a small but useful addition to the platform. The spec change was done in https://github.com/whatwg/html/pull/10971 and everything looks to be in good order. On Thu, Feb 13, 2025 at 5:35 AM Domenic Denicola wrote: > I'm recusing myself from this Intent, but one small comment about TAG > r

Re: [blink-dev] Intent to remove: navigator.xr.supportsSession

2025-02-13 Thread Philip Jägenstedt
https://chromestatus.com/metrics/feature/timeline/popularity/2416 on its own makes the risk look very tolerable, and together with the outreach to WebXR frameworks it seems like a safe move. LGTM2 with the reviews requested, as Dominik suggested. On Thu, Feb 13, 2025 at 5:01 AM Domenic Denicola

Re: [blink-dev] Intent to Prototype & Ship: safe-area-max-inset-* variables

2025-02-12 Thread Philip Jägenstedt
LGTM3 On Wed, Feb 12, 2025 at 5:07 PM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > LGTM2 > > On Wednesday, February 12, 2025 at 5:06:13 PM UTC+1 Mike Taylor wrote: > >> LGTM1 >> On 2/3/25 3:00 PM, Vladimir Levin wrote: >> >> >> >> On Mon, Feb 3, 2025 at 1:24 PM Victor Miura wrote: >>

Re: [blink-dev] Intent to Ship: CSS Logical Overflow

2025-02-11 Thread Philip Jägenstedt
LGTM1, I see that it was landed in WebKit just 2 days ago: https://github.com/WebKit/WebKit/pull/40302 On Mon, Feb 10, 2025 at 9:14 AM Rune Lillesveen wrote: > On Sat, Feb 8, 2025 at 7:26 PM Mike Taylor wrote: > >> On 2/7/25 8:19 AM, Rune Lillesveen wrote: >> 2 years ago Apple indicated that th

Re: [blink-dev] Intent to Ship: Protected Audience: Private Aggregation per-participant usage metrics

2025-01-29 Thread Philip Jägenstedt
LGTM3 On Wed, Jan 29, 2025 at 5:09 PM Chris Harrelson wrote: > LGTM2 > > On Wed, Jan 29, 2025 at 7:59 AM Vladimir Levin > wrote: > >> LGTM1 >> >> On Tuesday, January 21, 2025 at 12:59:08 PM UTC-5 morl...@google.com >> wrote: >> >>> So for explainer it's >>> https://github.com/WICG/turtledove/bl

Re: [blink-dev] Intent to Ship: Support non-special scheme URLs

2024-08-08 Thread Philip Jägenstedt
LGTM1, very happy to see this make progress! It's unfortunate that rolling this out with Finch and enterprise policy does not look feasible, but very good that we still have a kill switch. Keep a close eye on incoming bugs will also be important. Good luck! :D On Thu, Aug 8, 2024 at 10:09 AM Hay

Re: [blink-dev] Intent to Experiment: Reduce Accept-Language

2024-08-07 Thread Philip Jägenstedt
Looking at the alternatives considered , I wonder if you've also explored identifying common combinations of languages, and limiting the header to the most common current values of the heade

Re: [blink-dev] Intent to Ship: The Nested Declarations Rule

2024-08-06 Thread Philip Jägenstedt
LGTM1, this is important to do sooner rather than later, so that the current behavior is not locked in by site compat. Thank you for finding a solution that's acceptable to everyone! Given that this was discussed extensively in the CSSWG, I don't think we need to wait further on vendor positions.

Re: [blink-dev] Intent to Ship: Remove PointerEvent.getCoalescedEvents() from insecure contexts

2024-07-31 Thread Philip Jägenstedt
LGTM3. If it is possible to use a finch flag for this removal, please do, but if not please keep an eye out for any regression and revert at the first sign of trouble. On Wed, Jul 31, 2024 at 5:49 PM Chris Harrelson wrote: > LGTM2 > > On Wed, Jul 31, 2024 at 7:38 AM Mustaq Ahmed wrote: > >> On

Re: [blink-dev] Intent to Ship: Promise.try

2024-07-03 Thread Philip Jägenstedt
Thank you for the explanation, Shu-yu. LGTM1. I've filed https://github.com/tc39/proposal-promise-try/issues/21 about this being stage 3 so that the repo is updated. On Wed, Jul 3, 2024 at 4:42 PM Shu-yu Guo wrote: > > > On Tue, Jul 2, 2024 at 9:23 PM Domenic Denicola > wrote: > >> On Wed, Jul

Re: [blink-dev] Intent to Prototype and Ship: Standardized CSS zoom

2024-06-26 Thread Philip Jägenstedt
On Wed, Jun 26, 2024 at 5:48 PM Philip Jägenstedt wrote: > On Tue, Jun 25, 2024 at 10:35 PM Vladimir Levin > wrote: > >> >> >> On Tue, Jun 25, 2024 at 4:27 PM Stefan Zager wrote: >> >>> On Tue, Jun 25, 2024 at 8:26 AM Vladimir Levin >>>

Re: [blink-dev] Intent to Prototype and Ship: Standardized CSS zoom

2024-06-26 Thread Philip Jägenstedt
On Tue, Jun 25, 2024 at 10:35 PM Vladimir Levin wrote: > > > On Tue, Jun 25, 2024 at 4:27 PM Stefan Zager wrote: > >> On Tue, Jun 25, 2024 at 8:26 AM Vladimir Levin >> wrote: >> >>> >>> >>> On Mon, Jun 24, 2024 at 5:54 PM Stefan Zager >>> wrote: >>> Hey all, I recently took over

Re: [blink-dev] Intent to Ship: WebAuthn hints

2024-06-26 Thread Philip Jägenstedt
LGTM3 On Wed, Jun 26, 2024 at 5:37 PM Chris Harrelson wrote: > LGTM2 > > On Tue, Jun 25, 2024 at 10:44 AM Daniel Bratell > wrote: > >> LGTM1 >> >> /Daniel >> On 2024-06-19 23:15, Adam Langley wrote: >> >> On Mon, Jun 10, 2024 at 9:36 PM Yoav Weiss (@Shopify) < >> yoavwe...@chromium.org> wrote:

Re: [blink-dev] Intent to Ship: Snap Events

2024-06-05 Thread Philip Jägenstedt
Developer excitement about this is evident in https://github.com/w3c/csswg-drafts/issues/156. It was filed by a web developer and the 100 thumbs up are probably mostly from other web developers. These events seem like obvious missing functionality similar to the scrollend events, without the event

Re: [blink-dev] Re: Intent to Ship: SkipAd media session action

2024-06-05 Thread Philip Jägenstedt
Hi Jiaming, This feature has previously come across my radar as it appears in MDN to be implemented by both Firefox and Safari already: https://developer.mozilla.org/en-US/docs/Web/API/MediaSession/setActionHandler#browser_compatibility Is this accurate, is it in fact already implemented in Firef

Re: [blink-dev] Intent to Implement and Ship: Line-breakable ruby

2024-06-04 Thread Philip Jägenstedt
p:balance and text-wrap:pretty. I'll do: > - File a spec issue for them, and > - Make a non-tetative test for text-wrap:nowrap. > > > On Mon, Jun 3, 2024 at 5:57 PM Philip Jägenstedt > wrote: > >> LGTM1 >> >> This is a change of default behavior,

Re: [blink-dev] Intent to Implement and Ship: Line-breakable ruby

2024-06-03 Thread Philip Jägenstedt
LGTM1 This is a change of default behavior, but the previous behavior is likely very rare and it can be achieved using `text-wrap: nowrap`. Since the text-wrap part is important for adoption of this, can you check if text-wrap.tentative.html still needs to be tentative? The test has a comment abo

Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-23 Thread Philip Jägenstedt
on. I am not sure about WPT test coverage at the > moment (it's likely small), but for the time being I believe we can align > with Safari and FF. ChangSeok, do you agree? > > > > Dominik > > > > > > On Tue, May 21, 2024 at 3:43 PM Philip Jägenstedt > wrot

Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-23 Thread Philip Jägenstedt
On Wed, May 22, 2024 at 10:00 PM ChangSeok Oh wrote: > Hi Philip, > > I noticed that font-size-adjust-012.html, font-size-adjust-013.html, and > parts of font-size-adjust-computed.html (e.g., ch-width and ic-width) show > minor deviations from expected results. The exact issue with the WPT Linux

Re: [blink-dev] Re: Intent to Ship: Compute Pressure

2024-05-22 Thread Philip Jägenstedt
On Tue, May 21, 2024 at 9:39 AM Raphael Kubo da Costa wrote: > > Op 17-05-2024 om 16:59 schreef Philip Jägenstedt: > > What will be the behavior on Android, will the API appear to work but > > never invoke the observer callback? If so, would it make sense to > > disabl

Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-21 Thread Philip Jägenstedt
Hi ChangSeok, Thank you for working on this, it's great to see both more powerful typography control, and progress on Interop 2024. Can you say something about the remaining failures in WPT? font-size-adjust-012.html font-size-adjust-013.html both look like minor differences, but it seems like it

Re: [blink-dev] Intent to Ship: Deprecate Mutation Events

2024-05-19 Thread Philip Jägenstedt
Hi Mason, This is quite exciting! Mutation events is something I've long assumed we'd have to live with forever, but your findings here are extremely encouraging. Most compelling to me is (1) your analysis of UKM data and the lack of clear breakage on any of the ~30 checked sites, and (2) that dis

Re: [blink-dev] Re: Intent to Ship: Compute Pressure

2024-05-17 Thread Philip Jägenstedt
Hi Arnaud, I have a followup question about this. I assumed that the feature wouldn't be enabled on Android, but judging by Chromium source and wpt.fyi test results, at least the API surface is exposed: https://wpt.fyi/results/compute-pressure/idlharness.https.any.html?label=master&label=experimen

Re: [blink-dev] Intent to Ship: Automatic Fullscreen Content Setting

2024-05-17 Thread Philip Jägenstedt
Hi Mike, I think the use cases here are clear and skipping the user activation requirement is the only way to meet them. I believe that the biggest risk here is content written assuming this setting not working without it, and it being hard to understand why. In other words, debuggability and feat

Re: [blink-dev] Intent to Prototype and Ship: Align navigator.cookieEnabled with spec

2024-04-30 Thread Philip Jägenstedt
LGTM3 On Tue, Apr 30, 2024 at 6:49 PM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > LGTM2 > > On Tue, Apr 30, 2024 at 6:10 PM Rick Byers wrote: > >> Ah good point, thanks. Thanks for your attention to web compat detail >> here. Really any bug fix has the potential to be a significant

Re: [blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-04-24 Thread Philip Jägenstedt
Hi Yao, I see that https://github.com/WICG/shared-storage/pull/152 is still open, can that be landed before we ship this? Also, can you point to the tests for this change? Best regards, Philip On Fri, Apr 19, 2024 at 9:58 PM Josh Karlin wrote: > > > On Fri, Apr 19, 2024 at 1:59 PM Vladimir Le

Re: [blink-dev] Intent to Ship: Attribution Reporting Feature Bundle: Additional Verbose Debug Reports, Further Gating Source Verbose Debug Reports, Splitting the Attribution Rate Limit

2024-04-24 Thread Philip Jägenstedt
Hi Akash, Are https://wpt.fyi/results/attribution-reporting all of the tests for this feature and these changes? Do you expect that all of the tests there will be passing? I see that 3 of the tests time out which make it harder to understand the status. Is it possible to make these tests fail fas

Re: [blink-dev] Intent to Ship: URL.parse()

2024-04-24 Thread Philip Jägenstedt
LGTM3 On Wed, Apr 24, 2024 at 4:46 PM Jxck wrote: > @domenic > > I've updated finch name on ChromeStatus. > > Thanks > Jxck > > On Wednesday, April 24, 2024 at 12:45:52 PM UTC+9 Domenic Denicola wrote: > >> LGTM2 >> >> On Wed, Apr 24, 2024 at 1:50 AM Yoav Weiss (@Shopify) < >> yoavwe...@chromium

Re: [blink-dev] Intent to Deprecate and Remove: Deprecate the includeShadowRoots argument on DOMParser

2024-03-20 Thread Philip Jägenstedt
LGTM1 to remove without deprecation I looked through all 24 sites listed in https://chromestatus.com/metrics/feature/timeline/popularity/4455. 23 of them are the code from client-shim.js minified in various ways, and one site no longer has includeShadowRoots. On Wed, Mar 20, 2024 at 5:11 PM Mike

Re: [blink-dev] Intent to Deprecate and Remove: Deprecate the includeShadowRoots argument on DOMParser

2024-03-20 Thread Philip Jägenstedt
We indeed try to avoid open ended deprecation warnings with no planned milestone for removal. Given that the usage is still low (~0.01%) and that you found 8/8 sites analyzed were doing feature detection, this seems fairly low risk. I presume it's OK to gate this removal behind a flag, so that we

Re: [blink-dev] Re: Intent to implement and ship: Allow elements with CSS display:contents to be focusable

2024-03-20 Thread Philip Jägenstedt
The API owners touched on this today. Just a note that we consider it on hold until there's a reply to the questions about accessibility. On Wed, Jan 24, 2024 at 5:48 PM Philip Jägenstedt wrote: > On Wed, Jan 10, 2024 at 5:50 PM David Baron wrote: > >> >> >> On

Re: [blink-dev] Re: Intent to Ship: Compute Pressure

2024-03-15 Thread Philip Jägenstedt
On Fri, Mar 15, 2024 at 6:42 PM Raphael Kubo da Costa < raphael.kubo.da.co...@intel.com> wrote: > Philip Jägenstedt writes: > > > Taking a closer look, I think it's really because the tests depend on > > MojoJS, and if we exclude tentative tests > > < >

Re: [blink-dev] Re: Intent to Ship: Compute Pressure

2024-03-15 Thread Philip Jägenstedt
On Fri, Mar 15, 2024 at 4:11 PM Raphael Kubo da Costa < raphael.kubo.da.co...@intel.com> wrote: > Philip Jägenstedt writes: > > > Taking a look at https://wpt.fyi/results/compute-pressure I see that > most > > of the tests are tentative. Should they still be, or why do

Re: [blink-dev] Intent to Ship: Compute Pressure

2024-03-15 Thread Philip Jägenstedt
> to good arguments so please chime in. > > On Thu, Mar 14, 2024 at 11:51 PM Philip Jägenstedt > wrote: > > > > Thank you for sharing aggregated feedback, Ajay. > > > > I couldn't find any discussion about sampleRate vs an interval, so I've > filed htt

Re: [blink-dev] Intent to Ship: Compute Pressure

2024-03-14 Thread Philip Jägenstedt
Thank you for sharing aggregated feedback, Ajay. I couldn't find any discussion about sampleRate vs an interval, so I've filed https://github.com/w3c/compute-pressure/issues/253 with all the precedent for and against that I could find. Kenneth, Arnaud, can you look into this and decide whether to

Re: [blink-dev] Intent to Ship: Private Aggregation debug mode for auctionReportBuyers reporting

2024-03-13 Thread Philip Jägenstedt
LGTM3 I agree with Alex that we have a bad track record of "temporary" APIs on the web, but I'm comfortable with this given the particulars. A feature which is only a dictionary member is detectable (through a getter) but you have to do extra work and I don't recall ever seeing a problem from remo

Re: [blink-dev] Intent to ship: MP4 container support for MediaRecorder

2024-03-06 Thread Philip Jägenstedt
LGTM2 I think that https://wpt.fyi/results/mediacapture-record?label=master&label=experimental&aligned&q=mp4 are the relevant tests. LGTM assuming all of these tests pass with MediaRecorderEnableMp4Muxer enabled. If that's not the case, is there some functionality that won't be supported initially

Re: [blink-dev] Intent to Prototype and Ship: Standardized CSS zoom

2024-02-14 Thread Philip Jägenstedt
LGTM2 On Wed, Feb 14, 2024 at 11:53 PM Daniel Bratell wrote: > > LGTM1 > > /Daniel > > On 2024-02-09 20:24, 'Yotam Hacohen' via blink-dev wrote: > > > > On Thursday, February 8, 2024 at 6:46:00 PM UTC-8 Domenic Denicola wrote: > > On Fri, Feb 9, 2024 at 10:55 AM Yotam Hacohen wrote: > > Hey Domi

Re: [blink-dev] Intent to Ship: Support in Chrome for the VoiceIsolation getUserMedia constraint

2024-02-14 Thread Philip Jägenstedt
LGTM1, some comments inline. On Sat, Feb 3, 2024 at 6:15 AM Per Åhgren wrote: >> >> >> TAG review status >> >> Issues addressed >> This is somewhat at odds with the previous response. :) Did you intend to >> link a TAG review and forget? > > Sorry, my bad. I did not remove this from the template

Re: [blink-dev] Intent to Ship: CJK punctuation kerning: the CSS `text-spacing-trim` property

2024-02-13 Thread Philip Jägenstedt
LGTM2 I agree that it makes sense to wait with the shorthand until we support both of the longhand properties. Some developers may be surprised when text-spacing doesn't work but text-spacing-trim does, but it can be feature detected so I don't think it's worth delaying all 3 properties to ship to

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-02-01 Thread Philip Jägenstedt
a field on the chrome status entry? It doesn't show up for me. Or >> is this about emailing the list mentioned here >> <https://www.chromium.org/developers/enterprise-changes/#1-give-enterprises-visibility> >> ? >> >> Thanks, >> Thomas >> >>

Re: [blink-dev] Intent to Ship: CJK punctuation kerning: the CSS `text-spacing-trim` property

2024-02-01 Thread Philip Jägenstedt
As a data point, I see that the flag in STP is called "CSS text-spacing property", which suggests all 3 properties behind a single flag. It might not ship together, but it's a good guess. On Thu, Feb 1, 2024 at 12:02 PM Philip Jägenstedt wrote: > Hi Koji, > > Than

Re: [blink-dev] Intent to Ship: CJK punctuation kerning: the CSS `text-spacing-trim` property

2024-02-01 Thread Philip Jägenstedt
Hi Koji, Thanks for linking the tests, judging just by the test names it looks like many combinations of languages and fonts are tested. Some of the tests are failing though, is that expected? Also, I see that some of the tests don't actually use text-spacing-trim, are those just testing default

Re: [blink-dev] Intent to Ship: Element Reflection

2024-01-31 Thread Philip Jägenstedt
Hi Alice, For testing of these in WPT, do you have some details on what's missing? It's already possible to get the accessible name and role for an element: https://web-platform-tests.org/writing-tests/testdriver.html#accessibility I suspect that won't help, but there's an experimental/tentative

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-01-31 Thread Philip Jägenstedt
Apologies in advance for excessive paperwork, but can you also put https://chromestatus.com/feature/5111638103687168 through the process, requesting enterprise signoff in particular? Enterprise folks could depend on this and might need to take some extra action, and a "Feature deprecation" entry is

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-01-30 Thread Philip Jägenstedt
minimize the work for web authors as they switch away from > the API. > > On Fri, Jan 26, 2024 at 6:26 AM Philip Jägenstedt > wrote: > >> https://sites.google.com/a/chromium.org/dev/blink/launching-features >> doesn't give any guidance on the timeline, so let's

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-01-26 Thread Philip Jägenstedt
t; are using https://f.vimeocdn.com/p/4.27.1/js/vendor.module.js, one link > is also playing an overlay video intro. > > On Thu, Jan 25, 2024 at 12:25 AM Philip Jägenstedt > wrote: > >> I'm also happy to support a plan to deprecate and remove. The use counter >> that

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-01-25 Thread Philip Jägenstedt
ld I >>>>>> create a >>>>>> new feature (titled "Deprecation of HTMLVideoElement-specific Prefixed >>>>>> Fullscreen API")? I think the current ChromeStatus entry also covers this >>>>>> API >>>>>> <https

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-01-25 Thread Philip Jägenstedt
On Thu, Jan 25, 2024 at 2:00 AM Wesley Luyten wrote: > Wesley from Mux here. I saw the issue come by. > > We'd be happy those API's could get deprecated and unified into the new > one. > > Our Media Chrome (library, not browser) implementation handles this > gracefully, some code here > > https:/

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

2024-01-25 Thread Philip Jägenstedt
ies back in > Chrome 15, whereas a *deprecation/removal* has a different set of fields, > if I understand correctly. > > >> >> What's a reasonable sample size of HTTP Archive sites to audit? Should >> this be a complement/precursor to the proposed Deprecation Tri

Re: [blink-dev] Re: Intent to implement and ship: Allow elements with CSS display:contents to be focusable

2024-01-24 Thread Philip Jägenstedt
On Wed, Jan 10, 2024 at 5:50 PM David Baron wrote: > > > On Wed, Jan 10, 2024 at 11:14 AM Yoav Weiss > wrote: > >> >> >> On Tuesday, January 9, 2024 at 5:39:19 PM UTC+1 David Baron wrote: >> >> Contact emailsdba...@chromium.org >> >> ExplainerNone >> >> Specificationhttps://github.com/w3c/csswg-

Re: [blink-dev] Re: Intent to Ship: Close requests for CloseWatcher, , and popover=""

2024-01-11 Thread Philip Jägenstedt
> wrote: > >> LGTM3 >> >> I agree that introspection can be additive on top of what we want to ship >> here. >> >> On Wed, Oct 18, 2023 at 5:48 PM Philip Jägenstedt >> wrote: >> >>> The spec change has now landed, LGTM2. >>> >

Re: [blink-dev] Re: Intent to Ship: Import attributes 'with' syntax

2024-01-10 Thread Philip Jägenstedt
LGTM2 On Wed, Jan 10, 2024 at 5:16 PM Yoav Weiss wrote: > LGTM1 > > On Wed, Jan 10, 2024 at 5:08 PM Nicolò Ribaudo > wrote: > >> > Like other JS language changes, I'm guessing we expect developers to >> use UA sniffing to know where it's safe to ship this syntax? >> >> Yes -- given that this is

Re: [blink-dev] Re: Intent to Ship: Use specific fetch destination for JSON/CSS modules

2024-01-10 Thread Philip Jägenstedt
LGTM2, thanks for fixing this! On Wed, Jan 10, 2024 at 5:03 PM Yoav Weiss wrote: > LGTM1 > > > > On Wed, Jan 10, 2024 at 4:58 PM Nicolò Ribaudo > wrote: > >> Yes I made a mistake in the description. The destination for CSS modules >> is indeed "style", and not "css". Thanks for catching it! >>

Re: [blink-dev] Intent to Ship: field-sizing CSS property

2023-12-20 Thread Philip Jägenstedt
Hi Kent, I see that https://github.com/whatwg/html/pull/9903 is still open, do you expect to be able to land it soon? Given the positive review on https://github.com/WebKit/standards-positions/issues/231, perhaps requesting review from someone on the WebKit team would be fruitful? Best regards, P

Re: [blink-dev] Intent to Ship: Storage Buckets API

2023-12-18 Thread Philip Jägenstedt
On Fri, Dec 15, 2023 at 9:03 PM Evan Stade wrote: > Thanks all! > > On Wed, Dec 13, 2023 at 5:10 AM Philip Jägenstedt > wrote: > >> Hi Evan, >> >> Thanks for looking into this, and for answering some of my questions >> off-list. To summarize, eviction is

Re: [blink-dev] Intent to deprecate and remove import assertion 'assert' syntax

2023-12-14 Thread Philip Jägenstedt
On Wed, Dec 13, 2023 at 6:10 PM Shu-yu Guo wrote: > On Wed, Dec 13, 2023 at 9:03 AM Philip Jägenstedt > wrote: > >> LGTM2 for Mike's plan of deprecating for 3 milestones, doing outreach, >> and then revisiting this thread. >> >> If we still know of seriou

Re: [blink-dev] Intent to Ship: Navigational prefetch: follow redirects

2023-12-13 Thread Philip Jägenstedt
LGTM3 On Wed, Dec 13, 2023 at 3:11 AM Mike Taylor wrote: > LGTM2 > On 12/12/23 5:34 PM, Rick Byers wrote: > > Personally I'd consider this prefetch behavior change to be more of a UA > impl detail than a "web exposed API". I'm really glad you're covering this > in a spec and WPT in the hopes of

Re: [blink-dev] Intent to Ship: CSSKeyframesRule.length

2023-12-13 Thread Philip Jägenstedt
LGTM1 with or without a feature flag. I'm comfortable to LGTM this even without a flag because the length property was exposed in Gecko and WebKit

Re: [blink-dev] Intent to Ship: Storage Buckets API

2023-12-13 Thread Philip Jägenstedt
estdriver actions such as setting > permission state can enable a wide range of tests. In those cases the > calculus of cost vs reward is much more favorable. So I would assume that > changes to testdriver should meet a high bar of broad utility, similar to > how we treat core libra

Re: [blink-dev] Intent to Ship: Extension of WebDriver command for clicking on FedCM dialogs

2023-12-07 Thread Philip Jägenstedt
LGTM3 On Tue, Dec 5, 2023 at 7:58 PM Rick Byers wrote: > LGTM2 > > On Tue, Dec 5, 2023 at 12:31 PM Mike Taylor > wrote: > >> LGTM1 >> On 12/5/23 3:44 AM, 'Zachary Tan' via blink-dev wrote: >> >> My mistake - it is indeed without the "k", thanks for double checking. >> >> On Tue, Dec 5, 2023 at

Re: [blink-dev] Intent to Ship: Storage Buckets API

2023-12-01 Thread Philip Jägenstedt
rage/buckets/detached-iframe.https.html: > wpt_internal/storage/buckets/idlharness-worker.https.any.js: > wpt_internal/storage/buckets/opaque-origin.https.window.js: > wpt_internal/storage/buckets/resources/opaque-origin-sandbox.html: > wpt_internal/storage/buckets/storage_bucket_object.ten

Re: [blink-dev] Intent to Ship: Storage Buckets API

2023-11-29 Thread Philip Jägenstedt
t; > Hi Philip, > > thanks for pointing out those two oversights. I have fixed the checkboxes > on the chromestatus entry. It is in fact tested by WPT and supported on all > Blink platforms. > > On Wed, Nov 29, 2023 at 8:43 AM Philip Jägenstedt > wrote: > >> Hi Evan,

Re: [blink-dev] Intent to Ship: Document rules, response header, eagerness

2023-11-29 Thread Philip Jägenstedt
LGTM3 On Wed, Nov 29, 2023 at 5:55 PM Daniel Bratell wrote: > LGTM2 > > /Daniel > On 2023-11-23 10:11, Yoav Weiss wrote: > > LGTM1 > > These all seem like useful improvements! :) > > > On Wed, Nov 22, 2023 at 8:14 PM Jeremy Roman wrote: > >> >> >> On Wed, Nov 22, 2023 at 11:10 AM Yoav Weiss >>

Re: [blink-dev] Intent to Ship: Storage Buckets API

2023-11-29 Thread Philip Jägenstedt
Hi Evan, A few questions inline. On Tue, Nov 14, 2023 at 9:38 PM Evan Stade wrote: > > Will this feature be supported on all six Blink platforms (Windows, Mac, > Linux, Chrome OS, Android, and Android WebView)? > > No > Which platform will this not be supported on? > Is this feature fully te

Re: [blink-dev] Re: Intent to Ship: Document picture-in-picture: require user gesture for resize APIs

2023-11-29 Thread Philip Jägenstedt
LGTM2 On Wed, Nov 29, 2023 at 4:12 PM Yoav Weiss wrote: > LGTM1 > > On Wednesday, November 29, 2023 at 4:04:49 PM UTC+1 Tommy Steimel wrote: > >> Okay the security reviewer has now re-reviewed it given the updated >> information. Thanks! >> >> On Mon, Nov 27, 2023 at 11:55 PM Rick Byers wrote:

Re: [blink-dev] Intent to Prototype: @page margin boxes

2023-11-23 Thread Philip Jägenstedt
It's great to see a bug with so many stars (now 100!) being addressed. Thanks for filing the TAG review at https://github.com/w3ctag/design-reviews/issues/918 too! On Fri, Nov 3, 2023 at 2:19 PM Morten Stenshorne wrote: > Contact emailsmsten...@chromium.org > > Explainerhttps://github.com/msten

Re: [blink-dev] Intent to Ship: SpeechSynthesis and SpeechSynthesisVoice interface objects

2023-11-22 Thread Philip Jägenstedt
a bugfix > > On Wed, Jun 30, 2021 at 4:41 AM Daniel Bratell > wrote: > >> LGTM2 >> On 2021-06-30 01:40, TAMURA, Kent wrote: >> >> LGTM1. >> They should have interface objects, and the Gecko status is a good signal. >> >> On Wed, Jun 30, 2021 at

Re: [blink-dev] Re: PSA: Web contents will honor the Android OS bold text setting

2023-11-10 Thread Philip Jägenstedt
Hi Mark, There is certainly precedent for supporting OS-level settings like this, and doing it is important for the users who use the settings and expect consistent experience. As Dominik notes, most such modes are detectable, and for some the page can react to the preference using prefers-* media

Re: [EXTERNAL] Re: [blink-dev] Intent to Implement and Ship: Feature detection for supported clipboard formats

2023-11-01 Thread Philip Jägenstedt
LGTM2 This looks like a small addition that we should ship. It's tested and passing here: https://wpt.fyi/results/clipboard-apis/clipboard-item.https.html?label=experimental&label=master&aligned On Wed, Nov 1, 2023 at 4:43 PM Rick Byers wrote: > LGTM1 > > On Wed, Oct 25, 2023 at 4:33 PM 'Anupam

Re: [blink-dev] Intent to Ship: CSS masking

2023-10-27 Thread Philip Jägenstedt
LGTM1 Thanks for writing that up, Philip! I believe that should be helpful for release notes and MDN docs down the line. On Thu, Oct 26, 2023 at 7:20 PM 'Philip Rogers' via blink-dev < blink-dev@chromium.org> wrote: > > > On Wednesday, October 25, 2023 at 7:24:34 AM UTC-7 Mike Taylor wrote: > >

Re: [blink-dev] Re: Intent to Ship: WebGPU maxBindGroupsPlusVertexBuffers limit

2023-10-27 Thread Philip Jägenstedt
ative/Device.cpp;l=1808;drc=b6a33c6fb6097fb097b7e60ad63cb552724cf60e > In the meantime, we have web platform tests to check its existence: > https://chromium-review.googlesource.com/c/chromium/src/+/4952541/3/third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt > > > On Fri,

Re: [blink-dev] Re: Intent to Ship: WebGPU maxBindGroupsPlusVertexBuffers limit

2023-10-27 Thread Philip Jägenstedt
Hi François, Corentin, I greped for "maxBindGroupsPlusVertexBuffers" in a checkout of https://github.com/gpuweb/cts but couldn't find any tests. Should there be shared tests there? Best regards, Philip On Wed, Oct 25, 2023 at 4:25 PM Mike Taylor wrote: > LGTM2 > On 10/25/23 4:32 AM, 'François

Re: [blink-dev] Intent to Ship: CSS and Syntax for registered Custom Properties

2023-10-26 Thread Philip Jägenstedt
LGTM3 On Tue, Oct 24, 2023 at 5:28 PM Chris Harrelson wrote: > LGTM2 > > On Tue, Oct 24, 2023 at 8:27 AM Mike Taylor > wrote: > >> Understood - thanks! >> >> LGTM1 >> On 10/24/23 9:16 AM, Rune Lillesveen wrote: >> >> On Tue, Oct 24, 2023 at 1:58 AM Mike Taylor >> wrote: >> >>> Hey Rune, >>> On

  1   2   3   >