LGTM3 On Wed, May 28, 2025 at 5:23 PM Chris Harrelson <chris...@chromium.org> wrote:
> LGTM2 > > On Tue, May 27, 2025 at 7:35 AM Yoav Weiss (@Shopify) < > yoavwe...@chromium.org> wrote: > >> LGTM1 >> This seems like a small and useful addition to invoker commands. Thanks >> for adding it. >> >> On Fri, May 23, 2025, 07:01 Chromestatus <ad...@cr-status.appspotmail.com> >> wrote: >> >>> Contact emails lwar...@igalia.com >>> >>> Explainer https://github.com/whatwg/html/pull/11045 >>> >>> Specification >>> https://html.spec.whatwg.org/multipage/form-elements.html#attr-button-command-request-close-state >>> >>> Summary >>> >>> Dialog elements can be closed through a variety of mechanisms, sometimes >>> developers want to have the ability to prevent closure. To achieve this >>> dialogs fire a cancel event. Originally this was only fired via a close >>> request (e.g. ESC key press), recently a `requestClose()` JS function was >>> added which also fires the cancel event. The 'request-close' command brings >>> that new ability to the declarative invoker commands API. >>> >>> >>> Blink component Blink>DOM >>> <https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3EDOM%22> >>> >>> TAG review This is a minimal extension to the Invoker Commands API >>> which was tag reviewed. >>> >>> TAG review status Not applicable >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> >>> This is a new value for `command`, there shouldn't be any compat risks. >>> The interop risk is low, WebKit already has an implementation of this >>> addition as part of the (currently flagged) command invokers implementation. >>> >>> >>> *Gecko*: Positive ( >>> https://github.com/mozilla/standards-positions/issues/902) Supportive >>> of overall feature, I consider this addition to be small enough to not >>> warrant a separate position issue. >>> >>> *WebKit*: Positive ( >>> https://github.com/whatwg/html/pull/11045#issuecomment-2694671925) >>> >>> *Web developers*: No signals >>> >>> *Other signals*: >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> >>> >>> Debuggability >>> >>> None >>> >>> >>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>> Linux, ChromeOS, Android, and Android WebView)? Yes >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ? Yes >>> >>> >>> https://wpt.fyi/results/html/semantics/the-button-element/command-and-commandfor/on-dialog-behavior.html >>> >>> >>> Flag name on about://flags Experimental Web Platform Features >>> >>> Finch feature name HTMLCommandRequestClose >>> >>> Rollout plan Will ship enabled for all users >>> >>> Requires code in //chrome? False >>> >>> Tracking bug https://crbug.com/400647849 >>> >>> Availability expectation Feature is available on Web Platform mainline >>> within 12 months of launch in Chrome. >>> >>> Adoption expectation Feature is considered a best practice for some use >>> case within 12 months of reaching Web Platform baseline. >>> >>> Estimated milestones >>> Shipping on desktop 139 >>> DevTrial on desktop 136 >>> Shipping on Android 139 >>> DevTrial on Android 136 >>> Shipping on WebView 139 >>> >>> Anticipated spec changes >>> >>> Open questions about a feature may be a source of future web compat or >>> interop issues. Please list open issues (e.g. links to known github issues >>> in the project for the feature specification) whose resolution may >>> introduce web compat/interop risk (e.g., changing to naming or structure of >>> the API in a non-backward-compatible way). >>> >>> >>> Link to entry on the Chrome Platform Status >>> https://chromestatus.com/feature/5592399713402880?gate=6212275096256512 >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com>. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/68305599.2b0a0220.33c819.06fd.GAE%40google.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/68305599.2b0a0220.33c819.06fd.GAE%40google.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohS%2BcnfW8_SeocG7OGmxv7ZZOgDz0w3FUWScbJ04we1nVkw%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohS%2BcnfW8_SeocG7OGmxv7ZZOgDz0w3FUWScbJ04we1nVkw%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw_gpDRko_nPAjOkMcbUJM%3D417EpbdHS-c_i80qn8US3UQ%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw_gpDRko_nPAjOkMcbUJM%3D417EpbdHS-c_i80qn8US3UQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYc%3Dbj7HQcy4JT5mBpM%3DjnfVo_oQMf8uXLm5jTvcT%2BXPXw%40mail.gmail.com.
