[PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

2024-03-06 Thread Wayne Lin
..@ruhr-uni-bochum.de/ Cc: ly...@redhat.com Cc: imre.d...@intel.com Cc: sta...@vger.kernel.org Cc: regressi...@lists.linux.dev Signed-off-by: Wayne Lin --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +- drivers/gpu/drm/display/drm_dp_mst_topology.c | 4 +---

[PATCH 00/43] DC Patches March 18, 2024

2024-03-12 Thread Wayne Lin
This DC patchset brings improvements in multiple areas. In summary, we highlight: - Clear mpc_tree in init_pipes - Program pixclk according to dcn revision - Add stream clock source to DP DTO params - Enabling urgent latency adjustment for DCN35 - To adjust dprefclk by down spread percentage - Ad

[PATCH 01/43] drm/amd/display: Remove code duplication

2024-03-12 Thread Wayne Lin
From: Rodrigo Siqueira [Why & How] Remove redundant code Acked-by: Wayne Lin Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.

[PATCH 02/43] drm/amd/display: Remove wrong signal from vrr calculation

2024-03-12 Thread Wayne Lin
From: Rodrigo Siqueira In some of the merge conflict fixes, one '+' was accidentally left at the beginning of the line. Fortunately, this did not cause any major issues since it acted as a number signal. This commit addresses this issue by removing the extra '+'. Acked-by: W

[PATCH 03/43] drm/amd/display: Enable 2to1 ODM policy for DCN35

2024-03-12 Thread Wayne Lin
From: Rodrigo Siqueira [Why & How] Enable 2to1 ODM policy for DCN35 Acked-by: Wayne Lin Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/displa

[PATCH 04/43] drm/amd/display: Delete duplicated function prototypes

2024-03-12 Thread Wayne Lin
From: Alex Hung [Why & How] dcn32_smu_transfer_wm_table_dram_2_smu is defined twice so one is removed. Also adjust prototype orders. Acked-by: Wayne Lin Signed-off-by: Alex Hung --- .../drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr_smu_msg.h | 3 +-- 1 file changed, 1 insertion(+

[PATCH 05/43] drm/amd/display: Correct indentations and spaces

2024-03-12 Thread Wayne Lin
From: Alex Hung [Why & How] This fixes indentations and adjust spaces for better readability and code styles. Acked-by: Wayne Lin Signed-off-by: Alex Hung --- .../gpu/drm/amd/display/dc/bios/bios_parser.c | 1 + .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 15 --- .../displa

[PATCH 07/43] drm/amd/display: Move define to the proper header

2024-03-12 Thread Wayne Lin
From: Rodrigo Siqueira [Why & How] DCN3_16_MIN_COMPBUF_SIZE_KB is defined in the dcn316_resource.c file. This header fit better in the dcn31_fpu.h together with similar defines. Acked-by: Wayne Lin Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_f

[PATCH 06/43] drm/amd/display: Add the MALL size in the fallback function

2024-03-12 Thread Wayne Lin
From: Rodrigo Siqueira [Why & How] If the driver has issues retrieving the MALL size for the specific hardware, it might fail since the current value is set to zero. This commit addresses this issue by adding a simple constant value to give the drive a chance to start. Acked-by: Wayne

[PATCH 09/43] drm/amd/display: Remove legacy code

2024-03-12 Thread Wayne Lin
From: Rodrigo Siqueira [Why & How] Remove legacy code which is unnecessary. Acked-by: Wayne Lin Signed-off-by: Rodrigo Siqueira --- .../dc/resource/dcn314/dcn314_resource.c | 20 --- 1 file changed, 20 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/reso

[PATCH 08/43] drm/amd/display: Enable fast update for DCN314

2024-03-12 Thread Wayne Lin
From: Rodrigo Siqueira [Why & How] Enable legacy fast update for DCN314 Acked-by: Wayne Lin Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/resource/dc

[PATCH 10/43] drm/amd/display: correct hostvm flag

2024-03-12 Thread Wayne Lin
From: Sherry Wang [Why] Hostvm should be enabled/disabled accordding to the status of riommu_active, but hostvm always be disabled on DCN31 which causes underflow [How] Set correct hostvm flag on DCN31 Acked-by: Wayne Lin Signed-off-by: Sherry Wang --- drivers/gpu/drm/amd/display/dc

[PATCH 11/43] drm/amd/display: Comments adjustments

2024-03-12 Thread Wayne Lin
From: Rodrigo Siqueira [Why & How] This commit just drop some old comments and update a typo in another one. Acked-by: Wayne Lin Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH 12/43] drm/amd/display: Add missing registers and offset

2024-03-12 Thread Wayne Lin
From: Rodrigo Siqueira [Why & How] Registers and offset are missing. Add it back Acked-by: Wayne Lin Signed-off-by: Rodrigo Siqueira --- .../include/asic_reg/dcn/dcn_3_2_1_offset.h | 37 ++- .../include/asic_reg/dcn/dcn_3_2_1_sh_mask.h | 16 2 files changed

[PATCH 13/43] drm/amd/display: Fix noise issue on HDMI AV mute

2024-03-12 Thread Wayne Lin
Reviewed-by: Wenjing Liu Acked-by: Wayne Lin Signed-off-by: Leo Ma --- .../gpu/drm/amd/display/dc/hwss/dcn30/dcn30_hwseq.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss

[PATCH 14/43] drm/amd/display: skip forcing odm in minimal transition

2024-03-12 Thread Wayne Lin
ition state. [how] Backup stream ODM forcing option and clear it in minimal transition state. Once minimal transition state is released, we will restore the original debug option back. Reviewed-by: Samson Tam Acked-by: Wayne Lin Signed-off-by: Wenjing Liu --- drivers/gpu/drm/amd/display/dc/core

[PATCH 15/43] drm/amd/display: revert Exit idle optimizations before HDCP execution

2024-03-12 Thread Wayne Lin
From: Martin Leung why and how: causes black screen on PNP on DCN 3.5 This reverts commit 520b0596f978 ("drm/amd/display: Exit idle optimizations before HDCP execution") Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Nicholas Kazlauskas Acked-by:

[PATCH 16/43] drm/amd/display: Add debug option for idle reg checks

2024-03-12 Thread Wayne Lin
From: Nicholas Kazlauskas [Why] Leave disabled by default due to sequencing issues around power states where these flags aren't properly reset. [How] Allow re-enabling from DC debug option. Reviewed-by: Gabe Teeger Acked-by: Wayne Lin Signed-off-by: Nicholas Kazlauskas --- drivers/gp

[PATCH 18/43] drm/amd/display: To adjust dprefclk by down spread percentage

2024-03-12 Thread Wayne Lin
From: Zhongwei [Why] OLED panels show no display for large vtotal timings. [How] Check if spread spectrum is enabled and read from lut for spread spectrum percentage. Adjust dprefclk as required. Reviewed-by: Nicholas Kazlauskas Acked-by: Wayne Lin Signed-off-by: Zhongwei --- .../display

[PATCH 17/43] drm/amd/display: Revert Add left edge pixel + ODM pipe split

2024-03-12 Thread Wayne Lin
From: Gabe Teeger This reverts commit 97c109f498da ("drm/amd/display: Add left edge pixel for YCbCr422/420 + ODM pipe split") Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: George Shen Reviewed-by: Charlene Liu Reviewed-by: Jun Lei Acked-by:

[PATCH 19/43] drm/amd/display: Enabling urgent latency adjustment for DCN35

2024-03-12 Thread Wayne Lin
match the reference to existing ASIC that also see increased latency at low FCLK. Reviewed-by: Nicholas Kazlauskas Acked-by: Wayne Lin Signed-off-by: Nicholas Susanto --- drivers/gpu/drm/amd/display/dc/dml/dcn35/dcn35_fpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 20/43] drm/amd/display: Revert "Set the power_down_on_boot function pointer to null"

2024-03-12 Thread Wayne Lin
d-by: Nicholas Kazlauskas Reviewed-by: Charlene Liu Acked-by: Wayne Lin Signed-off-by: Ovidiu Bunea --- drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_init.c b/drivers/gpu/d

[PATCH 21/43] drm/amd/display: add stream clock source to DP DTO params

2024-03-12 Thread Wayne Lin
From: Dillon Varone [WHY&HOW] Stream clock source is a required parameter for DP DTO programming. Reviewed-by: Chris Park Acked-by: Wayne Lin Signed-off-by: Dillon Varone --- drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm

[PATCH 22/43] drm/amd/display: Program pixclk according to dcn revision

2024-03-12 Thread Wayne Lin
From: Dillon Varone [WHY&HOW] Pixel clock programming should be built per dcn revision, not hardcoded to use dcn20. Reviewed-by: Chris Park Acked-by: Wayne Lin Signed-off-by: Dillon Varone --- .../gpu/drm/amd/display/dc/resource/dcn20/dcn20_resource.c | 7 ++- 1 file change

[PATCH 23/43] drm/amd/display: clear mpc_tree in init_pipes

2024-03-12 Thread Wayne Lin
From: Samson Tam [Why] During init_pipes, otg master is not initialized. So mpc tree is still configured even if mpc bottom is not active [How] For pipes that have tg enabled, check their mpc tree and clear opp_list if mpc bottom is not active Reviewed-by: George Shen Acked-by: Wayne Lin

[PATCH 24/43] drm/amd/display: [FW Promotion] Release 0.0.208.0

2024-03-12 Thread Wayne Lin
From: Anthony Koo - Add a Replay residency mode which only calcuates the entry time based on replay state 0/1 switch. Acked-by: Wayne Lin Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 25/43] drm/amd/display: 3.2.276

2024-03-12 Thread Wayne Lin
/errors and remove redundant codes - Add missing registers and offset Acked-by: Wayne Lin Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index

[PATCH 26/43] drm/amd/display: Workaround register access in idle race with cursor

2024-03-12 Thread Wayne Lin
use a functional issue, just a (potential) redundant operation. Reviewed-by: Duncan Ma Acked-by: Wayne Lin Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 23 +++- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/dr

[PATCH 27/43] drm/amd/display: Revert Remove pixle rate limit for subvp

2024-03-12 Thread Wayne Lin
g. It also causes MPO to fail. We will temprarily revert this commit and investigate the root cause further. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Chaitanya Dhere Reviewed-by: Martin Leung Acked-by: Wayne Lin Signed-off-by: Wenjing Liu --- drivers/g

[PATCH 28/43] drm/amd/display: fix debug key not working on dml2

2024-03-12 Thread Wayne Lin
From: Charlene Liu [why] need to apply the debug key check for max displayclk. Reviewed-by: Chris Park Acked-by: Wayne Lin Signed-off-by: Charlene Liu --- drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/display

[PATCH 29/43] drm/amd/display: Power on VPG memory unconditionally if off

2024-03-12 Thread Wayne Lin
From: Dillon Varone [WHY&HOW] Even if memory lower power feature policy states that it is disabled, VPG memory should still be poweerd on if it is currently disabled when requested. Reviewed-by: Chris Park Acked-by: Wayne Lin Signed-off-by: Dillon Varone --- drivers/gpu/drm/amd/displa

[PATCH 30/43] drm/amd/display: Added debug prints for zstate_support and StutterPeriod

2024-03-12 Thread Wayne Lin
From: Natanel Roizenman Added debug prints for zstate_support and StutterPeriod in dcn35_decide_zstate_support for testing. Reviewed-by: Nicholas Kazlauskas Acked-by: Wayne Lin Signed-off-by: Natanel Roizenman --- drivers/gpu/drm/amd/display/dc/dml/dcn35/dcn35_fpu.c | 4 1 file changed

[PATCH 31/43] drm/amd/display: change aux_init to apu version

2024-03-12 Thread Wayne Lin
From: Charlene Liu [why] APU has different refclk as dGPU which is used for AUX_DPHY setup Reviewed-by: Chris Park Acked-by: Wayne Lin Signed-off-by: Charlene Liu --- drivers/gpu/drm/amd/display/dc/dcn31/dcn31_dio_link_encoder.c | 2 +- drivers/gpu/drm/amd/display/dc/dcn31

[PATCH 32/43] drm/amd/display: Increase Z8 watermark times.

2024-03-12 Thread Wayne Lin
From: Natanel Roizenman Increase Z8 watermark times from 210->250us and 320->350us. Reviewed-by: Nicholas Kazlauskas Acked-by: Wayne Lin Signed-off-by: Natanel Roizenman --- drivers/gpu/drm/amd/display/dc/dml/dcn35/dcn35_fpu.c | 4 ++-- drivers/gpu/drm/amd/display/dc/dml/

[PATCH 33/43] drm/amd/display: Prevent crash on bring-up

2024-03-12 Thread Wayne Lin
From: Chris Park [Why] Disabling stream encoder invokes a function that no longer exists in bring-up. [How] Check if the function declaration is NULL in disable stream encoder. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Charlene Liu Acked-by: Wayne Lin

[PATCH 34/43] drm/amd/display: increase bb clock for DCN351

2024-03-12 Thread Wayne Lin
From: Xi Liu [Why and how] Bounding box clocks for DCN351 should be increased as per request Reviewed-by: Swapnil Patel Acked-by: Wayne Lin Signed-off-by: Xi Liu --- .../amd/display/dc/dml/dcn351/dcn351_fpu.c| 90 --- 1 file changed, 76 insertions(+), 14 deletions

[PATCH 35/43] drm/amd/display: Detect and disallow idle reallow during reentrancy

2024-03-12 Thread Wayne Lin
unter that tracks the depth of the exit calls. Do not reallow until the counter is zero. Reviewed-by: Duncan Ma Acked-by: Wayne Lin Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 14 -- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h | 1 + 2 fil

[PATCH 36/43] drm/amd/display: Add optional optimization for IPS handshake

2024-03-12 Thread Wayne Lin
y if DMCUB is already in IPS2 since we know we need to exit. These are turned off by default. Reviewed-by: Duncan Ma Acked-by: Wayne Lin Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/dc.h | 1 + drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c| 7 +-- d

[PATCH 37/43] drm/amd/display: Enable optimized handshake for DCN35

2024-03-12 Thread Wayne Lin
From: Nicholas Kazlauskas [Why] To reduce the handshake overhead for static screen and video playback. [How] Flip the debug option to enable by default. Reviewed-by: Duncan Ma Acked-by: Wayne Lin Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/resource/dcn35

[PATCH 38/43] drm/amd/display: Remove unnecessary hard coded DPM states

2024-03-12 Thread Wayne Lin
From: Xi Liu [Why] The hard coded DPM states are only used to fix mismatch states numbers from FW. [How] Remove when not needed. Reviewed-by: Sung joon Kim Acked-by: Wayne Lin Signed-off-by: Xi Liu --- .../display/dc/dml2/dml2_translation_helper.c | 17 +++-- 1 file changed

[PATCH 39/43] drm/amd/display: Enable new interface design for alternate scrambling

2024-03-12 Thread Wayne Lin
From: Sung Joon Kim [why & how] To enable a new interface so alternate scrambling can be done via security module. Reviewed-by: Wenjing Liu Acked-by: Wayne Lin Signed-off-by: Sung Joon Kim --- drivers/gpu/drm/amd/display/dc/dc.h | 1 + .../gpu/drm/amd/display/dc/link/link_dp

[PATCH 40/43] drm/amd/display: Enable reallow for idle on DCN35

2024-03-12 Thread Wayne Lin
iewed-by: Duncan Ma Acked-by: Wayne Lin Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c b/drivers/gpu/drm/amd/di

[PATCH 41/43] drm/amd/display: fix a bug to dereference already freed old current state memory

2024-03-12 Thread Wayne Lin
l.org Reviewed-by: Josip Pavic Acked-by: Wayne Lin Signed-off-by: Wenjing Liu --- drivers/gpu/drm/amd/display/dc/core/dc.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c

[PATCH 42/43] drm/amd/display: Add TB_BORROWED_MAX definition

2024-03-12 Thread Wayne Lin
From: Chaitanya Dhere [Why & How] For DML2 to decouple it from other DML versions. Reviewed-by: Dillon Varone Acked-by: Wayne Lin Signed-off-by: Chaitanya Dhere --- drivers/gpu/drm/amd/display/dc/dml2/display_mode_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu

[PATCH 43/43] drm/amd/display: 3.2.277

2024-03-12 Thread Wayne Lin
- Fix problems for dmub idle power optimization Acked-by: Wayne Lin Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 673f36543f6c

[PATCH 0/3] Fix mst daisy chain light up issue after resume

2024-06-26 Thread Wayne Lin
rce should ignore the CSN event before source completeting topology probing during resume. Wayne Lin (3): drm/dp_mst: Fix all mstb marked as not probed after suspend/resume drm/dp_mst: Skip CSN if topology probing is not done yet drm/amd/display: Solve mst monitors blank out problem after resume

[PATCH 1/3] drm/dp_mst: Fix all mstb marked as not probed after suspend/resume

2024-06-26 Thread Wayne Lin
conditions. Cc: Lyude Paul Cc: Harry Wentland Cc: Jani Nikula Cc: Imre Deak Cc: Daniel Vetter Cc: sta...@vger.kernel.org Fixes: 37dfdc55ffeb ("drm/dp_mst: Cleanup drm_dp_send_link_address() a bit") Signed-off-by: Wayne Lin --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 4 ++-

[PATCH 2/3] drm/dp_mst: Skip CSN if topology probing is not done yet

2024-06-26 Thread Wayne Lin
: Harry Wentland Cc: Jani Nikula Cc: Imre Deak Cc: Daniel Vetter Cc: sta...@vger.kernel.org Signed-off-by: Wayne Lin --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu

[PATCH 3/3] drm/amd/display: Solve mst monitors blank out problem after resume

2024-06-26 Thread Wayne Lin
st in resume"). And adjust the reason to trigger dc_link_detect by DETECT_REASON_RESUMEFROMS3S4. Fixes: 202dc359adda ("drm/amd/display: Defer handling mst up request in resume") Signed-off-by: Wayne Lin --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 file changed

[PATCH 00/22] DC Patches July 29, 2024

2024-07-30 Thread Wayne Lin
This DC patchset brings improvements in multiple areas. In summary, we have: - Clean up some files style problems - Program the DET segment when initializing pipes in dcn10_hwseq - Fix overlay with pre-blend color processing - Disable SubVP if Hardware Rotation is Used - Fix few things in DML - Re

[PATCH 01/22] drm/amd/display: Add missing DCN314 to the DML Makefile

2024-07-30 Thread Wayne Lin
From: Rodrigo Siqueira Include display_mode_vba_314 and display_rq_dlg_calc_314 to the dml Makefile. Acked-by: Tom Chung Signed-off-by: Rodrigo Siqueira Signed-off-by: Wayne Lin --- drivers/gpu/drm/amd/display/dc/dml/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu

[PATCH 02/22] drm/amd/display: Cleanup dml2 and dc/resource Makefile

2024-07-30 Thread Wayne Lin
From: Rodrigo Siqueira Remove some useless lines from DC Makefiles. Acked-by: Tom Chung Signed-off-by: Rodrigo Siqueira Signed-off-by: Wayne Lin --- drivers/gpu/drm/amd/display/dc/dml2/Makefile | 2 -- drivers/gpu/drm/amd/display/dc/resource/Makefile | 2 -- 2 files changed, 4 deletions

[PATCH 03/22] drm/amd/display: Remove useless defines

2024-07-30 Thread Wayne Lin
From: Rodrigo Siqueira Remove __cplusplus defines added by accident. Acked-by: Tom Chung Signed-off-by: Rodrigo Siqueira Signed-off-by: Wayne Lin --- drivers/gpu/drm/amd/display/dc/spl/dc_spl.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/spl

[PATCH 04/22] drm/amd/display: Remove unused fields from dmub_cmd_update_dirty_rect_data

2024-07-30 Thread Wayne Lin
From: Rodrigo Siqueira Drop coasting_vtotal_high and pad from dmub_cmd_update_dirty_rect_data, since it is not used. Acked-by: Tom Chung Signed-off-by: Rodrigo Siqueira Signed-off-by: Wayne Lin --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 8 1 file changed, 8 deletions

[PATCH 05/22] drm/amd/display: Remove unused fields from dc_caps

2024-07-30 Thread Wayne Lin
From: Rodrigo Siqueira [Why & How] Identify few unused fileds in dc_caps. Remove them. Acked-by: Tom Chung Signed-off-by: Rodrigo Siqueira Signed-off-by: Wayne Lin --- drivers/gpu/drm/amd/display/dc/dc.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/displa

[PATCH 06/22] drm/amd/display: Add missing program DET segment call to pipe init

2024-07-30 Thread Wayne Lin
From: Rodrigo Siqueira Add a callback that program the DET segment when initializing pipes. Acked-by: Tom Chung Signed-off-by: Rodrigo Siqueira Signed-off-by: Wayne Lin --- drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers

[PATCH 07/22] drm/amd/display: Fix overlay with pre-blend color processing

2024-07-30 Thread Wayne Lin
ed-by: Rodrigo Siqueira Signed-off-by: Michael Strauss Signed-off-by: Wayne Lin --- drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c b/drivers/gpu/drm/amd/display/dc

[PATCH 08/22] drm/amd/display: Add stream and char control callback

2024-07-30 Thread Wayne Lin
From: Hansen Dsouza [why & how] Add new stream and char control functions based on DCCG spec Reviewed-by: Muhammad Ahmed Signed-off-by: Hansen Dsouza Signed-off-by: Wayne Lin --- .../amd/display/dc/dccg/dcn35/dcn35_dccg.c| 132 -- 1 file changed, 122 insertions(+)

[PATCH 09/22] drm/amd/display: fix a UBSAN warning in DML2.1

2024-07-30 Thread Wayne Lin
ize calculation. Reviewed-by: Rodrigo Siqueira Signed-off-by: Aurabindo Pillai Signed-off-by: Wayne Lin --- .../src/dml2_core/dml2_core_dcn4_calcs.c | 93 ++- 1 file changed, 49 insertions(+), 44 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2

[PATCH 10/22] drm/amd/display: Print Pcon FRL Link BW in Debug Message

2024-07-30 Thread Wayne Lin
Signed-off-by: Fangzhi Zuo Signed-off-by: Wayne Lin --- .../gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c b/drivers/gpu/drm/amd/display/dc/link/protocols

[PATCH 11/22] drm/amd/display: Disable SubVP if Hardware Rotation is Used

2024-07-30 Thread Wayne Lin
From: Austin Zheng [Why and How] SubVP is not supported when hardware rotation is being used Reviewed-by: Alvin Lee Signed-off-by: Austin Zheng Signed-off-by: Wayne Lin --- .../display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH 12/22] drm/amd/display: Assume 32 bpp cursor in DML21

2024-07-30 Thread Wayne Lin
From: Joshua Aberback [Why] Cursor size can change dynamically at runtime without re-validation, so DML should calculate with the max size cursor to cover all cases. Reviewed-by: Dillon Varone Signed-off-by: Joshua Aberback Signed-off-by: Wayne Lin --- .../dc/dml2/dml21

[PATCH 13/22] drm/amd/display: Force enable 3DLUT DMA check for dcn401 in DML

2024-07-30 Thread Wayne Lin
enable causes urgent latency to be budgeted properly into the prefetch schedule, avoiding the vulnerability. Reviewed-by: Alvin Lee Signed-off-by: Dillon Varone Signed-off-by: Wayne Lin --- .../amd/display/dc/dml2/dml21/dml21_translation_helper.c| 6 -- drivers/gpu/drm/amd/display/dc

[PATCH 14/22] drm/amd/display: Re-enable panel replay feature

2024-07-30 Thread Wayne Lin
From: Tom Chung [Why & How] Fixed the replay issues and now re-enable the panel replay feature. Reported-by: Arthur Borsboom Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3344 Reviewed-by: Sun peng Li Signed-off-by: Tom Chung Signed-off-by: Wayne Lin --- .../gpu/drm/amd/dis

[PATCH 15/22] drm/amd/display: Add clock control callbacks

2024-07-30 Thread Wayne Lin
From: Hansen Dsouza [why & how] Add clock source selection an control functions based on spec Reviewed-by: Muhammad Ahmed Signed-off-by: Hansen Dsouza Signed-off-by: Wayne Lin --- .../amd/display/dc/dccg/dcn35/dcn35_dccg.c| 281 -- 1 file changed, 252 insertions(+)

[PATCH 16/22] drm/amd/display: skip crtc power down when ips switch

2024-07-30 Thread Wayne Lin
From: Fudong Wang [Why & How] Add a dc debug option to keep crtc on when ips switch. Reviewed-by: Nicholas Kazlauskas Signed-off-by: Fudong Wang Signed-off-by: Wayne Lin --- drivers/gpu/drm/amd/display/dc/dc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/dis

[PATCH 17/22] drm/amd/display: Skip Recompute DSC Params if no Stream on Link

2024-07-30 Thread Wayne Lin
recompute should be skipped if no mode change detected on the new request. If detected, keep checking whether the stream is already on current state or not. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Rodrigo Siqueira Signed-off-by: Fangzhi Zuo Signed-off-by:

[PATCH 18/22] drm/amd/display: Address coverity change

2024-07-30 Thread Wayne Lin
From: Chris Park [Why] Coverity picks up a defect with regards to array underflow. [How] Address coverity issue as recommended. Reviewed-by: Leo Ma Signed-off-by: Chris Park Signed-off-by: Wayne Lin --- .../gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c | 6 -- 1 file changed

[PATCH 19/22] drm/amd/display: Add clock control callbacks

2024-07-30 Thread Wayne Lin
From: Hansen Dsouza [why & how] Add clock source selection control functions based on spec Reviewed-by: Muhammad Ahmed Signed-off-by: Hansen Dsouza Signed-off-by: Wayne Lin --- .../amd/display/dc/dccg/dcn35/dcn35_dccg.c| 153 +++--- 1 file changed, 99 insertions(+)

[PATCH 20/22] drm/amd/display: Revert Avoid overflow assignment

2024-07-30 Thread Wayne Lin
From: Gabe Teeger This reverts commit 4362962f41b8 ("drm/amd/display: Avoid overflow assignment in link_dp_cts") Due to regression causing DPMS hang. Reviewed-by: Alex Hung Signed-off-by: Gabe Teeger Signed-off-by: Wayne Lin --- drivers/gpu/drm/amd/display/dc/dc_

[PATCH 21/22] drm/amd/display: Add DML2.1 option to disable DRR clamped P-State Strategies

2024-07-30 Thread Wayne Lin
From: Dillon Varone [WHY & HOW] When DRR is active with variable refresh rate, add the ability to block DRR clamped P-State strategies (such as SubVP). Reviewed-by: Alvin Lee Signed-off-by: Dillon Varone Signed-off-by: Wayne Lin --- drivers/gpu/drm/amd/display/dc/

[PATCH 22/22] drm/amd/display: 3.2.295

2024-07-30 Thread Wayne Lin
replay feature - Fix null pointer dereference under mst+dsc Acked-by: Tom Chung Signed-off-by: Aric Cyr Signed-off-by: Wayne Lin --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd

[PATCH 00/46] DC Patches April 29, 2024

2024-04-24 Thread Wayne Lin
boot on 128b/132b encoding Swapnil Patel (1): drm/amd/display: Change ASSR disable sequence Wayne Lin (2): drm/amd/display: Remove unnecessary files drm/amd/display: Defer handling mst up request in resume Webb Chen (1): drm/amd/display: Revert "dc: Keep VBios pixel rate div setting

[PATCH 01/46] drm/amd/display: Do cursor programming with rest of pipe

2024-04-24 Thread Wayne Lin
p.org/drm/amd/-/issues/2186 Reviewed-by: Agustin Gutierrez Acked-by: Wayne Lin Signed-off-by: Harry Wentland --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 79 ++- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 4 +- .../amd/display/amdgpu_dm/amdgpu_dm_plane.h

[PATCH 02/46] drm/amd/display: Always use legacy way of setting cursor on DCE

2024-04-24 Thread Wayne Lin
: Agustin Gutierrez Reviewed-by: Sun peng Li Acked-by: Wayne Lin Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd

[PATCH 03/46] drm/amd/display: Add NULL pointer check for kzalloc

2024-04-24 Thread Wayne Lin
From: Hersen Wu [Why & How] Check return pointer of kzalloc before using it. Reviewed-by: Alex Hung Acked-by: Wayne Lin Signed-off-by: Hersen Wu --- .../gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c | 8 .../gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c

[PATCH 04/46] drm/amd/display: Check index msg_id before read or write

2024-04-24 Thread Wayne Lin
Siqueira Acked-by: Wayne Lin Signed-off-by: Alex Hung --- drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c index f7b5583ee609

[PATCH 05/46] drm/amd/display: Check pipe offset before setting vblank

2024-04-24 Thread Wayne Lin
From: Alex Hung pipe_ctx has a size of MAX_PIPES so checking its index before accessing the array. This fixes an OVERRUN issue reported by Coverity. Reviewed-by: Rodrigo Siqueira Acked-by: Wayne Lin Signed-off-by: Alex Hung --- .../drm/amd/display/dc/irq/dce110/irq_service_dce110.c| 8

[PATCH 06/46] drm/amd/display: Skip finding free audio for unknown engine_id

2024-04-24 Thread Wayne Lin
From: Alex Hung [WHY] ENGINE_ID_UNKNOWN = -1 and can not be used as an array index. Plus, it also means it is uninitialized and does not need free audio. [HOW] Skip and return NULL. This fixes 2 OVERRUN issues reported by Coverity. Reviewed-by: Rodrigo Siqueira Acked-by: Wayne Lin Signed

[PATCH 07/46] drm/amd/display: Fix overlapping copy within dml_core_mode_programming

2024-04-24 Thread Wayne Lin
From: Hersen Wu [WHY] &mode_lib->mp.Watermark and &locals->Watermark are the same address. memcpy may lead to unexpected behavior. [HOW] memmove should be used. Reviewed-by: Rodrigo Siqueira Acked-by: Wayne Lin Reviewed-by: Alex Hung Signed-off-by: Hersen Wu --- drive

[PATCH 08/46] drm/amd/display: Do not return negative stream id for array

2024-04-24 Thread Wayne Lin
Coverity. Reviewed-by: Rodrigo Siqueira Acked-by: Wayne Lin Signed-off-by: Alex Hung --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c

[PATCH 09/46] drm/amd/display: ASSERT when failing to find index by plane/stream id

2024-04-24 Thread Wayne Lin
size) instead. This fixes 4 OVERRUN and 2 NEGATIVE_RETURNS issues reported by Coverity. Reviewed-by: Rodrigo Siqueira Acked-by: Wayne Lin Signed-off-by: Alex Hung --- drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH 10/46] drm/amd/display: Remove unnecessary files

2024-04-24 Thread Wayne Lin
[Why & How] We accidentally upstream unnecessary files. Remove them. Reviewed-by: Tom Chung Signed-off-by: Wayne Lin --- drivers/gpu/drm/amd/display/dc/dpp/dcn10/CMakeLists.txt | 6 -- drivers/gpu/drm/amd/display/dc/dpp/dcn20/CMakeLists.txt | 5 - drivers/gpu/drm/amd/displa

[PATCH 11/46] drm/amd/display: Improve registers write

2024-04-24 Thread Wayne Lin
From: Rodrigo Siqueira Add REG_SEQ_SUBMIT and REG_SEQ_WAIT_DONE to optimize the burst write for the regama lut. Acked-by: Wayne Lin Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dpp/dcn10/dcn10_dpp_cm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 12/46] drm/amd/display: Add missing SMU version

2024-04-24 Thread Wayne Lin
From: Rodrigo Siqueira This commit add PP_SMU_VER_VG to the pp_smu_ver list. Acked-by: Wayne Lin Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dm_pp_smu.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dm_pp_smu.h b

[PATCH 13/46] drm/amd/display: Adjust codestyle for dcn31 and hdcp_msg

2024-04-24 Thread Wayne Lin
From: Rodrigo Siqueira This commit just update the code style in two if conditions and in an static array. Acked-by: Wayne Lin Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.c | 8 drivers/gpu/drm/amd/display/dc/hdcp/hdcp_msg.c | 2 +- 2

[PATCH 14/46] drm/amd/display: Add VCO speed parameter for DCN31 FPU

2024-04-24 Thread Wayne Lin
From: Rodrigo Siqueira Add VCO speed parameters in the bounding box array. Acked-by: Wayne Lin Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.c

[PATCH 15/46] drm/amd/display: Adjust functions prefix for some of the dcn301 fpu functions

2024-04-24 Thread Wayne Lin
From: Rodrigo Siqueira Add dcn301_fpu prefix to some of the FPU function with the required adjustments. Acked-by: Wayne Lin Signed-off-by: Rodrigo Siqueira --- .../amd/display/dc/dml/dcn301/dcn301_fpu.c| 4 ++-- .../amd/display/dc/dml/dcn301/dcn301_fpu.h| 7 +++ .../dc/resource

[PATCH 00/46] DC Patches April 29, 2024

2024-04-24 Thread Wayne Lin
boot on 128b/132b encoding Swapnil Patel (1): drm/amd/display: Change ASSR disable sequence Wayne Lin (2): drm/amd/display: Remove unnecessary files drm/amd/display: Defer handling mst up request in resume Webb Chen (1): drm/amd/display: Revert "dc: Keep VBios pixel rate div setting

[PATCH 01/46] drm/amd/display: Do cursor programming with rest of pipe

2024-04-24 Thread Wayne Lin
p.org/drm/amd/-/issues/2186 Reviewed-by: Agustin Gutierrez Acked-by: Wayne Lin Signed-off-by: Harry Wentland --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 79 ++- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 4 +- .../amd/display/amdgpu_dm/amdgpu_dm_plane.h

[PATCH 02/46] drm/amd/display: Always use legacy way of setting cursor on DCE

2024-04-24 Thread Wayne Lin
: Agustin Gutierrez Reviewed-by: Sun peng Li Acked-by: Wayne Lin Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd

[PATCH 03/46] drm/amd/display: Add NULL pointer check for kzalloc

2024-04-24 Thread Wayne Lin
From: Hersen Wu [Why & How] Check return pointer of kzalloc before using it. Reviewed-by: Alex Hung Acked-by: Wayne Lin Signed-off-by: Hersen Wu --- .../gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c | 8 .../gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c

[PATCH 04/46] drm/amd/display: Check index msg_id before read or write

2024-04-24 Thread Wayne Lin
Siqueira Acked-by: Wayne Lin Signed-off-by: Alex Hung --- drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c index f7b5583ee609

[PATCH 05/46] drm/amd/display: Check pipe offset before setting vblank

2024-04-24 Thread Wayne Lin
From: Alex Hung pipe_ctx has a size of MAX_PIPES so checking its index before accessing the array. This fixes an OVERRUN issue reported by Coverity. Reviewed-by: Rodrigo Siqueira Acked-by: Wayne Lin Signed-off-by: Alex Hung --- .../drm/amd/display/dc/irq/dce110/irq_service_dce110.c| 8

[PATCH 06/46] drm/amd/display: Skip finding free audio for unknown engine_id

2024-04-24 Thread Wayne Lin
From: Alex Hung [WHY] ENGINE_ID_UNKNOWN = -1 and can not be used as an array index. Plus, it also means it is uninitialized and does not need free audio. [HOW] Skip and return NULL. This fixes 2 OVERRUN issues reported by Coverity. Reviewed-by: Rodrigo Siqueira Acked-by: Wayne Lin Signed

[PATCH 07/46] drm/amd/display: Fix overlapping copy within dml_core_mode_programming

2024-04-24 Thread Wayne Lin
From: Hersen Wu [WHY] &mode_lib->mp.Watermark and &locals->Watermark are the same address. memcpy may lead to unexpected behavior. [HOW] memmove should be used. Reviewed-by: Rodrigo Siqueira Acked-by: Wayne Lin Reviewed-by: Alex Hung Signed-off-by: Hersen Wu --- drive

[PATCH 08/46] drm/amd/display: Do not return negative stream id for array

2024-04-24 Thread Wayne Lin
Coverity. Reviewed-by: Rodrigo Siqueira Acked-by: Wayne Lin Signed-off-by: Alex Hung --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c

[PATCH 09/46] drm/amd/display: ASSERT when failing to find index by plane/stream id

2024-04-24 Thread Wayne Lin
size) instead. This fixes 4 OVERRUN and 2 NEGATIVE_RETURNS issues reported by Coverity. Reviewed-by: Rodrigo Siqueira Acked-by: Wayne Lin Signed-off-by: Alex Hung --- drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH 10/46] drm/amd/display: Remove unnecessary files

2024-04-24 Thread Wayne Lin
[Why & How] We accidentally upstream unnecessary files. Remove them. Reviewed-by: Tom Chung Signed-off-by: Wayne Lin --- drivers/gpu/drm/amd/display/dc/dpp/dcn10/CMakeLists.txt | 6 -- drivers/gpu/drm/amd/display/dc/dpp/dcn20/CMakeLists.txt | 5 - drivers/gpu/drm/amd/displa

[PATCH 11/46] drm/amd/display: Improve registers write

2024-04-24 Thread Wayne Lin
From: Rodrigo Siqueira Add REG_SEQ_SUBMIT and REG_SEQ_WAIT_DONE to optimize the burst write for the regama lut. Acked-by: Wayne Lin Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dpp/dcn10/dcn10_dpp_cm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

  1   2   3   4   5   6   7   >