From: Michael Strauss <michael.stra...@amd.com>

[WHY]
Overlay works similarly to MPO, but uses global alpha on both planes and
sets the desktop as the rear plane instead of the front plane

[HOW]
Ensure that top plane isn't overlay by checking global alpha before
applying the previously added MPO fix

Reviewed-by: Rodrigo Siqueira <rodrigo.sique...@amd.com>
Signed-off-by: Michael Strauss <michael.stra...@amd.com>
Signed-off-by: Wayne Lin <wayne....@amd.com>
---
 drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c 
b/drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c
index 3cd584419b88..a7b5b25e3f34 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c
@@ -2586,8 +2586,11 @@ static bool dcn10_is_rear_mpo_fix_required(struct 
pipe_ctx *pipe_ctx, enum dc_co
 
                        while (top->top_pipe)
                                top = top->top_pipe; // Traverse to top pipe_ctx
-                       if (top->plane_state && top->plane_state->layer_index 
== 0)
-                               return true; // Front MPO plane not hidden
+                       if (top->plane_state && top->plane_state->layer_index 
== 0 && !top->plane_state->global_alpha)
+                               // Global alpha used by top plane for PIP 
overlay
+                               // Pre-multiplied/per-pixel alpha used by MPO
+                               // Check top plane's global alpha to ensure 
layer_index > 0 not caused by PIP
+                               return true; // MPO in use and front plane not 
hidden
                }
        }
        return false;
-- 
2.37.3

Reply via email to