[PATCH V4 2/3] drm/amdgpu: Optimize VM invalidation engine allocation and synchronize GPU TLB flush

From: "jesse.zh...@amd.com" - Modify the VM invalidation engine allocation logic to handle SDMA page rings. SDMA page rings now share the VM invalidation engine with SDMA gfx rings instead of allocating a separate engine. This change ensures efficient resource management and avoids the is

[PATCH v4 1/3] drm/amd/amdgpu: Increase max rings to enable SDMA page ring

From: "jesse.zh...@amd.com" Increase the maximum number of rings supported by the AMDGPU driver from 132 to 148. This change is necessary to enable support for the SDMA page ring. Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [drm:amdgpu_ring_test_helper] *ERROR* ring kiq_0.2.1.0 test failed (-110)

Hi Alex, Thanks for your prompt response. On Mon, Feb 24 2025, Alex Deucher wrote: > On Mon, Feb 24, 2025 at 8:51 AM Baruch Siach wrote: >> I see this failure on probe when trying to bring up amdgpu on a new arm64 >> platform. Kernel is v6.14-rc4, and aldebaran firmware is latest >> (linux-firm

[PATCH v3] drm/amdgpu: Trigger a wedged event for ring reset

Instead of only triggering a wedged event for complete GPU resets, trigger for ring resets. Regardless of the reset, it's useful for userspace to know that it happened because the kernel will reject further submissions from that app. Signed-off-by: André Almeida --- v3: do only for ring resets, n

[PATCH] MAINTAINERS: remove undeliverable entries in RADEON and AMDGPU DRM DRIVERS

While running: ./scripts/get_maintainer.pl \ drivers/gpu/drm/amd/display/amdgpu_dm \ --no-rolestats' For a list of Cc's, I got two undeliverable address errors from postmas...@amd.com: Xinhui Pan Hamza Mahfooz I tried to contact Alex Deucher and Christian König back in early Febru

[PATCH V4 3/3] drm/amdgpu/sdma_v4_4_2: update VM flush implementation for SDMA

From: "jesse.zh...@amd.com" This commit updates the VM flush implementation for the SDMA engine. - Added a new function `sdma_v4_4_2_get_invalidate_req` to construct the VM_INVALIDATE_ENG0_REQ register value for the specified VMID and flush type. This function ensures that all relevant pag

Re: [PATCH V4 3/3] drm/amdgpu/sdma_v4_4_2: update VM flush implementation for SDMA

On 2/25/2025 2:13 PM, jesse.zh...@amd.com wrote: > From: "jesse.zh...@amd.com" > > This commit updates the VM flush implementation for the SDMA engine. > > - Added a new function `sdma_v4_4_2_get_invalidate_req` to construct the > VM_INVALIDATE_ENG0_REQ > register value for the specified V

Re: [V7 02/45] drm/vkms: Round fixp2int conversion in lerp_u16

Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland fixp2int always rounds down, fixp2int_ceil rounds up. We need the new fixp2int_round. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland Reviewed-by: Louis Chauvet Hi, Can I extract this patch from the series and appl

Re: [V7 03/45] drm/vkms: Add kunit tests for VKMS LUT handling

Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland Debugging LUT math is much easier when we can unit test it. Add kunit functionality to VKMS and add tests for - get_lut_index - lerp_u16 Reviewed-by: Louis Chauvet Signed-off-by: Alex Hung Signed-off-by: Harry Wentland C

[PATCH] drm/amdgpu: Fix logic to fetch supported NPS modes

Correct the logic to find supported NPS modes from firmware. Signed-off-by: Lijo Lazar Reported-by: Ava Zhang Fixes: cdb41537812f ("drm/amdgpu: Use firmware supported NPS modes") --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/

Re: [V7 01/45] drm: Add helper for conversion from signed-magnitude

Le 24/02/2025 à 19:50, Alex Hung a écrit : On 2/24/25 09:07, Louis Chauvet wrote: Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland CTM values are defined as signed-magnitude values. Add a helper that converts from CTM signed-magnitude fixed point value to the twos-comple

Re: [V7 05/45] drm/colorop: Introduce new drm_colorop mode object

Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland This patches introduces a new drm_colorop mode object. This object represents color transformations and can be used to define color pipelines. We also introduce the drm_colorop_state here, as well as various helpers and state t

Re: [V7 07/45] drm/colorop: Add 1D Curve subtype

Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland Add a new drm_colorop with DRM_COLOROP_1D_CURVE with two subtypes: DRM_COLOROP_1D_CURVE_SRGB_EOTF and DRM_COLOROP_1D_CURVE_SRGB_INV_EOTF. Signed-off-by: Harry Wentland Co-developed-by: Alex Hung Signed-off-by: Alex Hung ---

Re: [V7 09/45] drm/colorop: Add BYPASS property

Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland We want to be able to bypass each colorop at all times. Introduce a new BYPASS boolean property for this. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland Reviewed-by: Louis Chauvet -- Louis Chauvet, Bootlin Embedde

Re: [V7 06/45] drm/colorop: Add TYPE property

Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland Add a read-only TYPE property. The TYPE specifies the colorop type, such as enumerated curve, 1D LUT, CTM, 3D LUT, PWL LUT, etc. For now we're only introducing an enumerated 1D LUT type to illustrate the concept. Signed-off-by

Re: [V7 10/45] drm/colorop: Add NEXT property

Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland We'll construct color pipelines out of drm_colorop by chaining them via the NEXT pointer. NEXT will point to the next drm_colorop in the pipeline, or by 0 if we're at the end of the pipeline. Signed-off-by: Alex Hung Signed-of

Re: [PATCH] drm/amd/display: Fix null check for pipe_ctx->plane_state in resource_build_scaling_params

On 2/23/25 23:32, Ma Ke wrote: Null pointer dereference issue could occur when pipe_ctx->plane_state is null. The fix adds a check to ensure 'pipe_ctx->plane_state' is not null before accessing. This prevents a null pointer dereference. Found by code review. Cc: sta...@vger.kernel.org Fixes:

[PATCH] drm/amdgpu: Decode deferred error type in aca bank parser

In the case of poison consumption's inband log, the error type need to be specified by checking the poison bit of status register. Signed-off-by: Xiang Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.h | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/gfx_v9

[PATCH] drm/amdgpu: Disable fru_id field in CPER section

The fru_id field is disabled cause of mis-matching defination between CPER spec and driver. Signed-off-by: Xiang Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_cper.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cper.c b/drivers/gpu/drm/am

[PATCH] drm/amdgpu: Fix parameter annotations for VCN clock gating functions

The previous references to a non-existent `adev` parameter have been removed & corrected to reflect the use of the `vinst` pointer, which points to the VCN instance structure, in the below files: - vcn_v1_0.c - vcn_v2_0.c - vcn_v3_0.c Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/vcn_v

[PATCH] drm/amdgpu: Fix parameter annotation in vcn_v5_0_0_is_idle

Update parameter description in the vcn_v5_0_0_is_idle function Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c:1231: warning: Function parameter or struct member 'ip_block' not described in 'vcn_v5_0_0_is_idle' drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c:1231: warning: Excess f

Re: [PATCH v5] drm/amdkfd: Fix Circular Locking Dependency in 'svm_range_cpu_invalidate_pagetables'

On 2025-02-24 9:08, Srinivasan Shanmugam wrote: > This commit addresses a circular locking dependency in the > svm_range_cpu_invalidate_pagetables function. The function previously > held a lock while determining whether to perform an unmap or eviction > operation, which could lead to deadlocks. >

[PATCH] drm/amd/amdgpu: Add support for xgmi_v6_4_1

Add support for xgmi_v6_4_1 and use it appropriate places Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/

RE: [PATCH] drm/amd/amdgpu: Add support for xgmi_v6_4_1

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Kamal, Asad Sent: Wednesday, February 26, 2025 13:51 To: amd-gfx@lists.freedesktop.org; Lazar, Lijo Cc: Zhang, Hawking ; Ma, Le ; Zhang, Morris ; Kamal, Asad ;

RE: [PATCH] drm/amdgpu: Disable fru_id field in CPER section

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Liu, Xiang(Dean) Sent: Wednesday, February 26, 2025 11:56 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao ; Liu, Xiang(Dean) Subject: [PATCH]

[PATCH 2/2] drm/amdgpu: Reinit FW shared flags on VCN v5.0.1

After a full device reset, shared memory region will clear out and it's not possible to reliably save the region in case of RAS errors. Reinitialize the flags if required. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c | 28 ++--- 1 file changed, 20 ins

[PATCH 1/2] drm/amdgpu: Use the right struct for VCN v5.0.1

VCN IP versions >= 5.0 uses VCN5 fw shared struct. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c index d29e8

[PATCH] drm/amd/pm: disable gfxoff on the specific sku

disable gfxoff on the specific sku based on the requirement. Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c index 8cfb07549f

[PATCH] drm/amdgpu: Decode deferred error type in aca bank parser

In the case of poison inband log, the error type need to be specified by checking the deferred or poison bit of status register. v2: check both deferred and poison bit Signed-off-by: Xiang Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.h | 6 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 4

Re: [PATCH] drm/amd/pm: disable gfxoff on the specific sku

On 2/26/2025 1:01 PM, Kenneth Feng wrote: > disable gfxoff on the specific sku based on the requirement. > > Signed-off-by: Kenneth Feng > --- > drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c

[PATCH] drm/amdgpu: Report generic instead of unknown boot time errors

Change the DMESG reporting of unknown errors to "Boot Controller Generic Error" to align with the RAS SPEC and provide more clarity to customers. Signed-off-by: Xiang Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +- 2 files changed, 3 inse

RE: [PATCH] drm/amdgpu: Report generic instead of unknown boot time errors

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Liu, Xiang(Dean) Sent: Wednesday, February 26, 2025 14:30 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Subedi, Rohit ; Liu, Xiang(Dean) Subject: [PAT

RE: [PATCH] drm/amdgpu: Decode deferred error type in aca bank parser

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Liu, Xiang(Dean) Sent: Wednesday, February 26, 2025 15:49 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao ; Liu, Xiang(Dean) Subject: [PATCH]

RE: [PATCH] drm/amdgpu: Decode deferred error type in aca bank parser

[AMD Official Use Only - AMD Internal Distribution Only] Shall we check (deferred || poison) bit to identify deferred errors during either poison creation or poison consumption events, and differentiate them from CE? Regards, Hawking -Original Message- From: Liu, Xiang(Dean) Sent: Wed

Re: [PATCH] drm/amd/display: fix type mismatch in CalculateDynamicMetadataParameters()

On 2/22/25 16:58, Vitaliy Shevtsov wrote: There is a type mismatch between what CalculateDynamicMetadataParameters() takes and what is passed to it. Currently this function accepts several args as signed long but it's called with unsigned integers. On some systems where long is 32 bits and one

[PATCH] drm/amdkfd: clamp queue size to minimum

If queue size is less than minimum, clamp it to minimum to prevent underflow when writing queue mqd. Signed-off-by: David Yat Sin --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 4 include/uapi/linux/kfd_ioctl.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/drivers/gpu/drm

Re: [PATCH] MAINTAINERS: remove undeliverable entries in RADEON and AMDGPU DRM DRIVERS

On Tue, Feb 25, 2025 at 05:10:03PM +0800, Mingcong Bai wrote: > While running: > > ./scripts/get_maintainer.pl \ > drivers/gpu/drm/amd/display/amdgpu_dm \ > --no-rolestats' > > For a list of Cc's, I got two undeliverable address errors from > postmas...@amd.com: > > Xinhui Pan > Ham

Re: [PATCH 10/63] dyndbg: silence debugs with no-change updates

Le 25/01/2025 à 07:45, Jim Cromie a écrit : In ddebug_apply_class_bitmap(), check for actual changes to the bits before announcing them, to declutter logs. no functional change. Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- lib/dynamic_debug.c | 12 +++- 1 file ch

Re: [PATCH 15/63] checkpatch: add an exception to the do-while wrapper advice

Le 25/01/2025 à 07:45, Jim Cromie a écrit : Several new DYNDBG_CLASSMAP_* macros (added in following commits) expand to multi-statement declarations, like module_param_named does. They are invoked in file-scope, not in function scope, and cannot be wrapped by a do-while, so add an exception by

Re: [PATCH 12/63] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap

Le 25/01/2025 à 07:45, Jim Cromie a écrit : old_bits arg is currently a pointer to the input bits, but this could allow inadvertent changes to the input by the fn. Disallow this. And constify new_bits while here. Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- lib/dynamic_de

Re: [PATCH 13/63] dyndbg: reduce verbose=3 messages in ddebug_add_module

Le 25/01/2025 à 07:45, Jim Cromie a écrit : When modprobing a module, dyndbg currently logs/says "add-module", and then "skipping" if the module has no prdbgs. Instead just check 1st and return quietly. no functional change Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- li

Re: [PATCH 16/63] dyndbg-API: replace DECLARE_DYNDBG_CLASSMAP

Le 25/01/2025 à 07:45, Jim Cromie a écrit : DECLARE_DYNDBG_CLASSMAP() has a design error; its usage fails a basic K&R rule: "define once, refer many times". It is used across DRM core & drivers, each use re-defines the classmap understood by that module; and all must match for the modules to

Re: [PATCH 08/63] dyndbg: drop NUM_TYPE_ARRAY

Le 25/01/2025 à 07:45, Jim Cromie a écrit : ARRAY_SIZE works here, since array decl is complete. no functional change Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- include/linux/dynamic_debug.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include

Re: [PATCH 06/63] dyndbg: ddebug_apply_class_bitmap - add module arg, select on it

Le 25/01/2025 à 07:45, Jim Cromie a écrit : Add param: query_module to ddebug_apply_class_bitmap(), and pass it thru to _ddebug_queries(), replacing NULL with query_module. This allows its caller to update just one module, or all (as currently). We'll use this later to propagate drm.debug to

Re: [PATCH 17/63] dyndbg: check DYNDBG_CLASSMAP_DEFINE args at compile-time

Le 25/01/2025 à 07:45, Jim Cromie a écrit : Add __DYNDBG_CLASSMAP_CHECK to implement these arg-checks at compile: 0 <= _base < 63 class_names is not empty class_names[0] is a string (class_names.length + _base) < 63 These compile-time checks will prevent severa

Re: [PATCH 19/63] dyndbg: make proper substructs in _ddebug_info

Le 25/01/2025 à 07:45, Jim Cromie a écrit : struct _ddebug_info's jobs is to enapsulate the __sections of dyndbg data from the linker. The data started as a single pair of fields: descs - ref'g an array of descriptors & num_descs - counting the "pertinent" descriptors. Then classes & num_cla

Re: [PATCH 18/63] dyndbg: add/use for_subvec() to reduce boilerplate

Le 25/01/2025 à 07:45, Jim Cromie a écrit : add for_subvec() macro to encapsulate a for-loop pattern thats used repeatedly to iterate over a boxed.vector of N elements. Signed-off-by: Jim Cromie Hi Jim, Do you think it is possible to move this patch earlier in the series, so you can use

Re: [V7 02/45] drm/vkms: Round fixp2int conversion in lerp_u16

Le 25/02/2025 à 12:28, Simon Ser a écrit : On Tuesday, February 25th, 2025 at 10:37, Louis Chauvet wrote: Can I extract this patch from the series and apply it on drm-misc-next? That sounds completely fine by me, and TBH it sounds like it could even be drm-misc-fixes material? Probably

Re: [PATCH 1/2] drm/amdgpu: Initialize RRMT status on JPEG v5.0.1

On 2/21/2025 8:52 PM, Lijo Lazar wrote: > Initialize RRMT enablement status from register. > > Signed-off-by: Lijo Lazar > --- > drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c | 3 +++ > drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.h | 5 - > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff -

Re: [V7 14/45] drm/vkms: Add enumerated 1D curve colorop

Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland This patch introduces a VKMS color pipeline that includes two drm_colorops for named transfer functions. For now the only ones supported are sRGB EOTF, sRGB Inverse EOTF, and a Linear TF. We will expand this in the future but I don

Re: [PATCH 04/63] dyndbg: make ddebug_class_param union members same size

Le 25/01/2025 à 07:45, Jim Cromie a écrit : struct ddebug_class_param keeps a ref to the state-storage of the param; make both class-types use the same unsigned long storage type. ISTM this is simpler and safer; it avoids an irrelevant difference, and if 2 users somehow get class-type mixed u

[PATCH] drm/amdgpu: Use wafl version for xgmi

XGMI and WAFL share the same versions. Use WAFL version if XGMI version is not present in discovery. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dis

Re: [PATCH] drm/amd/display: Remove unused optc3_fpu_set_vrr_m_const

Applied. Thanks! Alex On Mon, Feb 24, 2025 at 8:43 AM wrote: > > From: "Dr. David Alan Gilbert" > > The last use of optc3_fpu_set_vrr_m_const() was removed in 2022's > commit 64f991590ff4 ("drm/amd/display: Fix a compilation failure on PowerPC > caused by FPU code") > which removed the only ca

Re: [PATCH] MAINTAINERS: remove undeliverable entries in RADEON and AMDGPU DRM DRIVERS

On Tue, Feb 25, 2025 at 4:10 AM Mingcong Bai wrote: > > While running: > > ./scripts/get_maintainer.pl \ > drivers/gpu/drm/amd/display/amdgpu_dm \ > --no-rolestats' > > For a list of Cc's, I got two undeliverable address errors from > postmas...@amd.com: > > Xinhui Pan > Hamza Mahfooz

RE: [PATCH 2/2] drm/amdgpu/mes11: drop amdgpu_mes_suspend()/amdgpu_mes_resume() calls

[AMD Official Use Only - AMD Internal Distribution Only] This series looks good to me . Reviewed-by :Shaoyun.liu -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Tuesday, February 25, 2025 10:10 AM To: Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org Subject: Re: [

RE: [PATCH v3 4/4] drm/amdgpu: Calculate IP specific xgmi bandwidth

[Public] > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, February 25, 2025 1:46 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Deucher, Alexander > ; Kim, Jonathan > Subject: [PATCH v3 4/4] drm/amdgpu: Calculate IP specific xgmi bandwidth > > Use IP version speci

Re: [PATCH 0/2] Fit one IB struct amdgpu_job into a 512 byte slab

On 24/02/2025 12:06, Tvrtko Ursulin wrote: A lot of the workloads create jobs with just one IB and if we re-order some struct members we can stop that allocation spilling into the 1k SLAB bucket. Before: sizeof(struct amdgpu_job) + sizeof(struct amdgpu_ib) = 480 + 40 = 520 After: size

Re: [PATCH 28/63] dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API

Le 25/01/2025 à 07:45, Jim Cromie a écrit : move the DYNDBG_CLASSMAP_PARAM macro from test-dynamic-debug.c into the header, and refine it, by distinguishing the 2 use cases: 1.DYNDBG_CLASSMAP_PARAM_REF for DRM, to pass in extern __drm_debug by name. dyndbg keeps bits in it, so drm c

Re: [PATCH v4] drm/amd/display/dc: Refactor remove duplications

Applied. Thanks! Alex On Mon, Feb 24, 2025 at 8:55 PM Luan Icaro Pinto Arcanjo wrote: > > From: Luan Arcanjo > > All dce command_table_helper's shares a copy-pasted collection > of copy-pasted functions, which are: phy_id_to_atom, > clock_source_id_to_atom_phy_clk_src_id, and engine_bp_to_atom

[PATCH] drm/amdgpu: increase AMDGPU_MAX_RINGS

Increase it since a cper ring is introduced. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h index 52f7a9a79e7b..b4fd1e172

RE: [PATCH] drm/amdgpu: increase AMDGPU_MAX_RINGS

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Tuesday, February 25, 2025 19:21 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu: increase AMDG

Re: [PATCH 21/63] dyndbg: allow ddebug_add_module to fail

Le 25/01/2025 à 07:45, Jim Cromie a écrit : To prep for failing modprobe on classid conflicts, upgrade the call-chain around ddebug_add_module(), in 2 ways: 1. in ddebug_add_module() add local reserved_ids to accumulate reservations, pass it by ref to ddebug_attach_{,user_}module_classes() so

Re: [PATCH 20/63] dyndbg: drop premature optimization in ddebug_add_module

Le 25/01/2025 à 07:45, Jim Cromie a écrit : The class_ct var was added to avoid 2 function calls, but to do this it loops over all the module's debug callsites to determine the count. But it doesn't really help, so remove it. Signed-off-by: Jim Cromie Hi Jim, If you move the other patch e

Re: [PATCH 23/63] dyndbg: fail modprobe on ddebug_class_range_overlap()

Le 25/01/2025 à 07:45, Jim Cromie a écrit : 1. All classes used by a module (declared DYNDBG_CLASSMAP_{DEFINE,USE} by module code) must share 0..62 class-id space; ie their respective base,+length reservations shouldn't overlap. Overlaps would lead to unintended changes in ddebug enablements.

Re: [V7 03/45] drm/vkms: Add kunit tests for VKMS LUT handling

On 2025-02-25 04:51, Louis Chauvet wrote: > > > Le 20/12/2024 à 05:33, Alex Hung a écrit : >> From: Harry Wentland >> >> Debugging LUT math is much easier when we can unit test >> it. Add kunit functionality to VKMS and add tests for >>   - get_lut_index >>   - lerp_u16 >> >> Reviewed-by: Lou

Re: [PATCH 1/2] drm/amdgpu/userq: handle runtime pm

Ping? On Fri, Feb 21, 2025 at 9:51 AM Alex Deucher wrote: > > Take a reference when we create a queue and drop it > when we destroy the queue. We need to keep the device > active while user queues are active. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/mes_userqueue.c |

Re: [PATCH 2/2] drm/amdgpu/mes11: drop amdgpu_mes_suspend()/amdgpu_mes_resume() calls

Ping on this series? On Fri, Feb 21, 2025 at 9:59 AM Alex Deucher wrote: > > They are noops on GFX11 for most firmware versions. KFD already > handles its own queues and they should already be unmapped at this > point so even if this runs, it's not doing anything. > > Signed-off-by: Alex Deucher

Re: [PATCH] drm/amdgpu/vcn2.5: fix VCN stop logic

Ping? On Mon, Feb 24, 2025 at 2:39 PM Alex Deucher wrote: > > Need to make sure we call amdgpu_dpm_enable_vcn() > in vcn_v2_5_stop() at the end if there are errors > or DPG is enabled. > > Fixes: ebc25499de12 ("drm/amdgpu/vcn2.5: split code along instances") > Suggested-by: Boyuan Zhang > Signed

Re: [PATCH] drm/amdgpu/vcn2.5: fix VCN stop logic

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Boyuan Zhang From: Alex Deucher Sent: February 25, 2025 10:07 AM To: Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org ; Zhang, Boyuan Subject: Re: [PATCH]

RE: [PATCH 1/2] drm/amdgpu: Initialize RRMT status on JPEG v5.0.1

[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Friday, February 21, 2025 23:23 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Liu, Leo ; Sundararaju,

Re: [V7 02/45] drm/vkms: Round fixp2int conversion in lerp_u16

On 2025-02-25 09:05, Louis Chauvet wrote: > > > Le 25/02/2025 à 12:28, Simon Ser a écrit : >> On Tuesday, February 25th, 2025 at 10:37, Louis Chauvet >> wrote: >> >>> Can I extract this patch from the series and apply it on drm-misc-next? >> >> That sounds completely fine by me, and TBH it soun

Re: [V7 02/45] drm/vkms: Round fixp2int conversion in lerp_u16

On Tuesday, February 25th, 2025 at 15:43, Harry Wentland wrote: > > > We need to be a bit careful when merging patches from the same series > > > via multiple trees. Maybe we'll merge the colorop stuff via the amd > > > tree? I don't remember the rules around trees, and I don't know if it > > >

Re: [PATCH 11/63] dyndbg: tighten ddebug_class_name() 1st arg type

Le 25/01/2025 à 07:45, Jim Cromie a écrit : Change function's 1st arg-type, and deref in the caller. The fn doesn't need any other fields in the struct. no functional change. Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- lib/dynamic_debug.c | 10 +- 1 file changed

Re: [PATCH 05/63] dyndbg: replace classmap list with a vector

Le 25/01/2025 à 07:45, Jim Cromie a écrit : Classmaps are stored in an elf section/array, but are individually list-linked onto dyndbg's per-module ddebug_table for operation. This is unnecessary; even when ddebug_attach_classmap() is handling the builtin section (with classmaps for multiple

Re: [PATCH 09/63] dyndbg: reduce verbose/debug clutter

Le 25/01/2025 à 07:45, Jim Cromie a écrit : currently, for verbose=3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' dyndbg: flags=0x1 dyndbg: *flagsp=0x1 *maskp=0xfff

Re: [PATCH 07/63] dyndbg: split param_set_dyndbg_classes to _module & wrapper fns

Le 25/01/2025 à 07:45, Jim Cromie a écrit : Split api-fn: param_set_dyndbg_classes(), adding modname param and passing NULL in from api-fn. The new arg allows caller to specify that only one module is affected by a prdbgs update. This selectivity will be used later to narrow the scope of cha

Re: [V7 02/45] drm/vkms: Round fixp2int conversion in lerp_u16

Le 25/02/2025 à 15:45, Simon Ser a écrit : On Tuesday, February 25th, 2025 at 15:43, Harry Wentland wrote: We need to be a bit careful when merging patches from the same series via multiple trees. Maybe we'll merge the colorop stuff via the amd tree? I don't remember the rules around trees

Re: [PATCH] Support dmabuf IPC with amdgpu CRIU

Hi, On 31/01/2025 18:58, David Francis wrote: This patch (in combination with the accompanying CRIU patch) allows the amdgpu CRIU plugin to support dmabuf IPC. It includes - A new amdgpu ioctl (amdgpu_criu_op_ioctl), which has similar options to kfd_ioctl_criu, and accompanying struct

Re: [PATCH 03/63] dyndbg: reword "class unknown," to "class:_UNKNOWN_"

Le 25/01/2025 à 07:45, Jim Cromie a écrit : When a dyndbg classname is unknown to a kernel module (as before previous patch), the callsite is un-addressable via >control queries. The control-file displays this condition as "class unknown," currently. That spelling is sub-optimal/too-generic,

Re: [V7 18/45] drm/vkms: add 3x4 matrix in color pipeline

Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland We add two 3x4 matrices into the VKMS color pipeline. The reason we're adding matrices is so that we can test that application of a matrix and its inverse yields an output equal to the input image. One complication with the mat

Re: [V7 16/45] drm/colorop: Add 3x4 CTM type

Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland This type is used to support a 3x4 matrix in colorops. A 3x4 matrix uses the last column as a "bias" column. Some HW exposes support for 3x4. The calculation looks like: out matrixin |R| |0 1 2 3 | | R | |G|

Re: [V7 15/45] drm/vkms: Add kunit tests for linear and sRGB LUTs

Le 20/12/2024 à 05:33, Alex Hung a écrit : From: Harry Wentland Two tests are added to VKMS LUT handling: - linear - inv_srgb Reviewed-by: Louis Chauvet Signed-off-by: Alex Hung Signed-off-by: Harry Wentland --- v7: - Fix checkpatch warnings (Louis Chauvet) - Adde a commit messages

Re: [PATCH 02/63] test-dyndbg: fixup CLASSMAP usage error

Le 25/01/2025 à 07:45, Jim Cromie a écrit : A more careful reading of logging output from test_dynamic_debug.ko reveals: lib/test_dynamic_debug.c:103 [test_dynamic_debug]do_cats =pmf "doing categories\n" lib/test_dynamic_debug.c:105 [test_dynamic_debug]do_cats =p "LOW msg\n" class:MID lib/t

Re: [V7 02/45] drm/vkms: Round fixp2int conversion in lerp_u16

On Tuesday, February 25th, 2025 at 10:37, Louis Chauvet wrote: > Can I extract this patch from the series and apply it on drm-misc-next? That sounds completely fine by me, and TBH it sounds like it could even be drm-misc-fixes material? We need to be a bit careful when merging patches from the

RE: [PATCH] drm/amdgpu: Use wafl version for xgmi

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: Lazar, Lijo Sent: Tuesday, February 25, 2025 4:56 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Ma, Le ; Zhan

Re: [PATCH 01/63] docs/dyndbg: update examples \012 to \n

Le 25/01/2025 à 07:45, Jim Cromie a écrit : commit 47ea6f99d06e ("dyndbg: use ESCAPE_SPACE for cat control") changed the control-file to display format strings with "\n" rather than "\012". Update the docs to match the new reality. Signed-off-by: Jim Cromie Hi Jim, I think this patch is

RE: [PATCH] drm/amdgpu: Fix logic to fetch supported NPS modes

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Tuesday, February 25, 2025 19:03 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Lin, Amber ; Zhang, Ava Subject