[PATCH v1] drm/ci: increase timeout for all jobs

2024-08-20 Thread Vignesh Raman
Set the timeout of all drm-ci jobs to 1h30m since some jobs takes more than 1 hour to complete. Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/test.yml | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml index b6f

Re: [PATCH 04/86] drm: Add client-agnostic setup helper

2024-08-20 Thread Thomas Zimmermann
Hi Am 18.08.24 um 22:07 schrieb Laurent Pinchart: Hi Thomas, Thank you for the patch. On Fri, Aug 16, 2024 at 02:22:30PM +0200, Thomas Zimmermann wrote: DRM may support multiple in-kernel clients that run as soon as a DRM driver has been registered. To select the client(s) in a single place,

Re: [PATCH 28/86] drm/mi0283qt: Run DRM default client setup

2024-08-20 Thread Thomas Zimmermann
Hi Am 16.08.24 um 18:01 schrieb Noralf Trønnes: On 8/16/24 14:22, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmerma

RE: [PATCH 2/2] drm/amdgpu: Do core dump immediately when job tmo

2024-08-20 Thread Huang, Trigger
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: Khatri, Sunil > Sent: Monday, August 19, 2024 6:31 PM > To: Huang, Trigger ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH 2/2] drm/amdgpu: Do core dump immediately when j

Re: [PATCH 31/86] drm/panel/ili9341: Run DRM default client setup

2024-08-20 Thread Thomas Zimmermann
Hi Am 19.08.24 um 17:39 schrieb Neil Armstrong: On 16/08/2024 14:22, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmer

Re: [82/86] drm/i915: Move custom hotplug code into separate callback

2024-08-20 Thread Thomas Zimmermann
Hi Am 19.08.24 um 10:52 schrieb Sui Jingfeng: Hi, Thomas I love your patch, yet ... On 2024/8/16 20:23, Thomas Zimmermann wrote: i915's fbdev contains additional code for hotplugging a display that cannot be ported to the common fbdev client. Introduce the callback struct drm_fb_helper.fb_h

Re: [PATCH 04/86] drm: Add client-agnostic setup helper

2024-08-20 Thread Laurent Pinchart
Hi Thomas, On Tue, Aug 20, 2024 at 09:22:36AM +0200, Thomas Zimmermann wrote: > Am 18.08.24 um 22:07 schrieb Laurent Pinchart: > > On Fri, Aug 16, 2024 at 02:22:30PM +0200, Thomas Zimmermann wrote: > >> DRM may support multiple in-kernel clients that run as soon as a DRM > >> driver has been regis

Re: [PATCH 48/86] drm/xlnx: Run DRM default client setup

2024-08-20 Thread Thomas Zimmermann
Hi Am 18.08.24 um 22:19 schrieb Laurent Pinchart: Hi Thomas, Thank you for the patch. On Fri, Aug 16, 2024 at 02:23:14PM +0200, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can

Re: [PATCH 04/86] drm: Add client-agnostic setup helper

2024-08-20 Thread Thomas Zimmermann
Hi Am 20.08.24 um 09:40 schrieb Laurent Pinchart: The color format is really a user interface. I'd rather like to remove it from the implementation where possible. Do you mean the color mode ? If so I agree. Yeah, the "color mode". This number with inconsistent semantics. Best regards Thomas

[PATCH] drm/amdgpu/gfx9.4.3: Implement compute pipe reset

2024-08-20 Thread Prike Liang
Implement the compute pipe reset and driver will fallback to pipe reset when queue reset failed. Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 5 + drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 153 2 files changed, 138 insertions(+), 20 deletion

[PATCH] drm/amdgpu: Normalize reg offsets on JPEG v4.0.3

2024-08-20 Thread Lijo Lazar
Only local register offsets should be used on JPEG v4.0.3 as they cannot handle remote access to other AIDs. Since only local offsets are used, the special write to MCM_ADDR register is no longer needed. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 32 +++-

RE: [PATCH] drm/amdgpu/gfx9.4.3: Implement compute pipe reset

2024-08-20 Thread Ma, Le
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: amd-gfx On Behalf Of Prike > Liang > Sent: Tuesday, August 20, 2024 4:58 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Liang, Prike > > Subject: [PATCH] drm/amdgpu/gfx9.4.3: Implemen

RE: [PATCH] drm/amdgpu/gfx9.4.3: Implement compute pipe reset

2024-08-20 Thread Liang, Prike
[AMD Official Use Only - AMD Internal Distribution Only] > From: Ma, Le > Sent: Tuesday, August 20, 2024 5:38 PM > To: Liang, Prike ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: RE: [PATCH] drm/amdgpu/gfx9.4.3: Implement compute pipe reset > > [AMD Official Use Only - AMD I

[PATCH v2] drm/amdgpu/gfx9.4.3: Implement compute pipe reset

2024-08-20 Thread Prike Liang
Implement the compute pipe reset and driver will fallback to pipe reset when queue reset failed. Signed-off-by: Prike Liang --- v2: Convert the GC logic instance to physical instance in the register accessing process and use the dev_* print to specify the failed device. --- drivers/gpu/d

Re: [PATCH 40/86] drm/stm: Run DRM default client setup

2024-08-20 Thread Raphael Gallais-Pou
On 8/16/24 14:23, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Yannick Fertre > Cc: Raphael Ga

Re: [82/86] drm/i915: Move custom hotplug code into separate callback

2024-08-20 Thread Thomas Zimmermann
Hi Am 20.08.24 um 12:39 schrieb Sui Jingfeng: Besides, a lot of DRM driver instances has the DMA/2D acceleration hardware, promote it into drm_driver structure may has the potential to utilize hardware acceleration. Drivers will more easily to have custom implementation. I'm not 100% sure if

Re: [PATCH v2] drm/amdgpu/gfx9.4.3: Implement compute pipe reset

2024-08-20 Thread Lazar, Lijo
On 8/20/2024 4:01 PM, Prike Liang wrote: > Implement the compute pipe reset and driver will > fallback to pipe reset when queue reset failed. > > Signed-off-by: Prike Liang > --- > v2: Convert the GC logic instance to physical instance in the > register accessing process and > use the de

Re: [PATCH 32/86] drm/panel-mipi-dbi: Run DRM default client setup

2024-08-20 Thread Noralf Trønnes
On 8/16/24 14:22, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: "Noralf Trønnes" > --- Acked

Re: v6.11-rc4 amdgpu regression from v6.10.0

2024-08-20 Thread Andrew Worsley
I did a git bisect on from v6.10 .. v6.11-rc4 and found the exact change when the problem appeared (see below) The problem is introduced by this commit f9d8c5c7855d Author: Jack Xiao Date: Thu Apr 25 15:28:48 2024 +0800 drm/amdgpu/gfx: enable mes to map legacy queue support Enable me

Re: [PATCH 54/86] drm/gud: Run DRM default client setup

2024-08-20 Thread Noralf Trønnes
On 8/16/24 14:23, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: "Noralf Trønnes" > --- Acked

Re: v6.11-rc4 amdgpu regression from v6.10.0

2024-08-20 Thread Andrew Worsley
Ok - hacked out a patch that allows 6.11-rc4 to boot with out hanging - just disabling the "mes" stuff. See attached patch Yeah ! Andrew On Tue, 20 Aug 2024 at 00:13, Alex Deucher wrote: > > On Mon, Aug 19, 2024 at 9:55 AM Andrew Worsley wrote: > > > > The v6.11-rc4 linux hangs during amdgpu

Re: [82/86] drm/i915: Move custom hotplug code into separate callback

2024-08-20 Thread Sui Jingfeng
Hi, On 2024/8/20 15:39, Thomas Zimmermann wrote: Hi Am 19.08.24 um 10:52 schrieb Sui Jingfeng: Hi, Thomas I love your patch, yet ... On 2024/8/16 20:23, Thomas Zimmermann wrote: i915's fbdev contains additional code for hotplugging a display that cannot be ported to the common fbdev clie

Re: [PATCH 37/86] drm/repaper: Run DRM default client setup

2024-08-20 Thread Noralf Trønnes
On 8/16/24 14:23, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: "Noralf Trønnes" > --- Acked

Re: [PATCH 28/86] drm/mi0283qt: Run DRM default client setup

2024-08-20 Thread Noralf Trønnes
On 8/16/24 14:22, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: "Noralf Trønnes" > --- Acked

[bug report] drm/amdgpu/gfx11: add a mutex for the gfx semaphore

2024-08-20 Thread Dan Carpenter
Hello Alex Deucher, Commit 76acba7b7f12 ("drm/amdgpu/gfx11: add a mutex for the gfx semaphore") from Jul 12, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:4778 gfx_v11_0_request_gfx_index_mutex() warn: inconsistent

Re: v6.11-rc4 amdgpu regression from v6.10.0

2024-08-20 Thread Alex Deucher
+ Jack Looks like maybe some older firmware versions don't support this properly. @Jack Xiao Can you find out if there is a minimum firmware version needed for legacy queue mapping and add the appropriate check? @Andrew Worsley does it work correctly with a newer version of firmware? Thanks, A

Re: [PATCH v3 0/3] drm/amdgpu: Explicit sync for GEM VA operations

2024-08-20 Thread Sharma, Shashank
Hey Christian, On 19/08/2024 13:21, Christian König wrote: Am 19.08.24 um 09:21 schrieb Friedrich Vock: In Vulkan, it is the application's responsibility to perform adequate synchronization before a sparse unmap, replace or BO destroy operation. This adds an option to AMDGPU_VA_OPs to disable r

[PATCH] Revert "drm/ttm: increase ttm pre-fault value to PMD size"

2024-08-20 Thread Alex Deucher
This reverts commit 0ddd2ae586d28e521d37393364d989ce118802e0. This patch causes sluggishness and stuttering in graphical apps. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3564 Link: https://www.spinics.net/lists/dri-devel/msg457005.html Signed-off-by: Alex Deucher Cc: Zhu Lingshan C

Re: [PATCH v2] drm/amdgpu/gfx9.4.3: Implement compute pipe reset

2024-08-20 Thread Alex Deucher
On Tue, Aug 20, 2024 at 8:43 AM Lazar, Lijo wrote: > > > > On 8/20/2024 4:01 PM, Prike Liang wrote: > > Implement the compute pipe reset and driver will > > fallback to pipe reset when queue reset failed. > > > > Signed-off-by: Prike Liang > > --- > > v2: Convert the GC logic instance to physical

Re: [PATCH 2/2] drm/amdgpu: Do core dump immediately when job tmo

2024-08-20 Thread Alex Deucher
On Tue, Aug 20, 2024 at 3:30 AM Huang, Trigger wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > > -Original Message- > > From: Khatri, Sunil > > Sent: Monday, August 19, 2024 6:31 PM > > To: Huang, Trigger ; amd-gfx@lists.freedesktop.org > > Cc: Deucher, Alexander

[PATCH] drm/amd/gfx11: move the gfx mutex into the caller

2024-08-20 Thread Alex Deucher
Otherwise we can fail to drop the software mutex when we fail to take the hardware mutex. Fixes: 76acba7b7f12 ("drm/amdgpu/gfx11: add a mutex for the gfx semaphore") Reported-by: Dan Carpenter Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 7 +++ 1 file changed, 3

Re: [PATCH 2/2] drm/amdgpu: Do core dump immediately when job tmo

2024-08-20 Thread Khatri, Sunil
On 8/20/2024 7:36 PM, Alex Deucher wrote: On Tue, Aug 20, 2024 at 3:30 AM Huang, Trigger wrote: [AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Khatri, Sunil Sent: Monday, August 19, 2024 6:31 PM To: Huang, Trigger ; amd-gfx@lists.freedesktop.org C

Re: [PATCH 2/2] drm/amdgpu: Do core dump immediately when job tmo

2024-08-20 Thread Alex Deucher
On Tue, Aug 20, 2024 at 11:07 AM Khatri, Sunil wrote: > > > On 8/20/2024 7:36 PM, Alex Deucher wrote: > > On Tue, Aug 20, 2024 at 3:30 AM Huang, Trigger > > wrote: > >> [AMD Official Use Only - AMD Internal Distribution Only] > >> > >>> -Original Message- > >>> From: Khatri, Sunil > >>>

Re: [PATCH 2/2] drm/amdgpu: Do core dump immediately when job tmo

2024-08-20 Thread Khatri, Sunil
On 8/20/2024 1:00 PM, Huang, Trigger wrote: [AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Khatri, Sunil Sent: Monday, August 19, 2024 6:31 PM To: Huang, Trigger ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH 2/2] drm/am

Re: [PATCH] drm/amd/gfx11: move the gfx mutex into the caller

2024-08-20 Thread SRINIVASAN SHANMUGAM
On 8/20/2024 8:09 PM, Alex Deucher wrote: Otherwise we can fail to drop the software mutex when we fail to take the hardware mutex. Fixes: 76acba7b7f12 ("drm/amdgpu/gfx11: add a mutex for the gfx semaphore") Reported-by: Dan Carpenter Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amd

Re: [PATCH 2/2] drm/amdgpu: Do core dump immediately when job tmo

2024-08-20 Thread Alex Deucher
On Tue, Aug 20, 2024 at 11:31 AM Khatri, Sunil wrote: > > > On 8/20/2024 1:00 PM, Huang, Trigger wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > > >> -Original Message- > >> From: Khatri, Sunil > >> Sent: Monday, August 19, 2024 6:31 PM > >> To: Huang, Trigger ; am

Re: [PATCH 2/2] drm/amdgpu: Do core dump immediately when job tmo

2024-08-20 Thread Khatri, Sunil
On 8/20/2024 9:31 PM, Alex Deucher wrote: On Tue, Aug 20, 2024 at 11:31 AM Khatri, Sunil wrote: On 8/20/2024 1:00 PM, Huang, Trigger wrote: [AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Khatri, Sunil Sent: Monday, August 19, 2024 6:31 PM To: Hua

[PATCH] drm/amdgpu/gfx12: set UNORD_DISPATCH in compute MQDs

2024-08-20 Thread Alex Deucher
This needs to be set to 1 to avoid a potential deadlock in the GC 10.x and newer. On GC 9.x and older, this needs to be set to 0. This can lead to hangs in some mixed graphics and compute workloads. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3575 Signed-off-by: Alex Deucher --- dri

RE: [PATCH 12/13] drm/amd/display: Fix a typo in revert commit

2024-08-20 Thread Zuo, Jerry
[AMD Official Use Only - AMD Internal Distribution Only] Hi Jiri: Please kindly let me know the kernel branch you are using to validate the fix. I'll provide with two additional patches on top of ("drm/amd/display: Fix MST BW calculation Regression") Regards, Jerry > -Original Messag

Re: commit 9d8c094ddab0 breaks Xorg/xfce4

2024-08-20 Thread Mario Limonciello
On 8/1/2024 11:52, Bert Karwatzki wrote: Since linux-next-20240801 starting Xorg/xfce4 fails on my MSI Alpha15 Laptop. I bisected this to the following commit and reverting this in linux-next-20240801 fixes the issue for me. Gnome (with Xwayland) works as usual. 9d8c094ddab05db88d183ba82e23be80

[PATCH 1/2] drm/amdgpu: add experimental resets debug flag

2024-08-20 Thread Alex Deucher
Add this flag to enable experimental resets for testing before they are fully validated. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ++ 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/am

[PATCH 2/2] drm/amdgpu/gfx9: put queue resets behind a debug option

2024-08-20 Thread Alex Deucher
Pending extended validation. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 4 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 6 ++ 3 files changed, 14 insertions(+) diff --git a/drive

Re: Getting off this list

2024-08-20 Thread Lyude Paul
I can't tell you which list it specifically is, since you might be signed up on any of the email lists mentioned in the to/cc. But the relevant email headers that you can use to figure this out are here (this is from a totally unrelated email, and is just an example - you will have to look up the h

RE: [PATCH 6.10 090/263] drm/amdgpu/pm: Fix the param type of set_power_profile_mode

2024-08-20 Thread Deucher, Alexander
[Public] > -Original Message- > From: Jiri Slaby > Sent: Tuesday, August 20, 2024 12:39 AM > To: Deucher, Alexander ; Greg Kroah-Hartman > ; sta...@vger.kernel.org > Cc: patc...@lists.linux.dev; Sasha Levin ; Koenig, > Christian ; Pan, Xinhui ; > amd-gfx@lists.freedesktop.org > Subject: R

Re: [PATCH V2] video/aperture: match the pci device when calling sysfb_disable()

2024-08-20 Thread kernel test robot
Hi Alex, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on robh/for-next drm-misc/drm-misc-next linus/master v6.11-rc4 next-20240820] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

RE: [PATCH] drm/amdgpu/gfx12: set UNORD_DISPATCH in compute MQDs

2024-08-20 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, August 21, 2024 01:17 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/g

Re: [PATCH v5 36/44] drm/amd/display: add 3x4 matrix colorop

2024-08-20 Thread kernel test robot
Hi Harry, kernel test robot noticed the following build warnings: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.11-rc4 next-20240820] [cannot apply to drm

Re: [PATCH v5 20/44] drm/tests: Add a few tests around drm_fixed.h

2024-08-20 Thread kernel test robot
Hi Harry, kernel test robot noticed the following build errors: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.11-rc4 next-20240820] [If

Re: [PATCH 12/13] drm/amd/display: Fix a typo in revert commit

2024-08-20 Thread Jiri Slaby
On 20. 08. 24, 20:28, Zuo, Jerry wrote: [AMD Official Use Only - AMD Internal Distribution Only] Hi Jiri: Please kindly let me know the kernel branch you are using to validate the fix. I'll provide with two additional patches on top of ("drm/amd/display: Fix MST BW calculation Regressio

Re: [PATCH v5 28/44] drm/amd/display: Add support for sRGB Inverse EOTF in SHAPER block

2024-08-20 Thread kernel test robot
Hi Harry, kernel test robot noticed the following build warnings: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.11-rc4 next-20240820

[PATCH] drm/amdgpu: add list empty check to avoid null pointer issue

2024-08-20 Thread Yang Wang
Add list empty check to avoid null pointer issues in some corner cases. - list_for_each_entry_safe() Signed-off-by: Yang Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/amd