This DC patchset brings improvements in multiple areas. In summary, we have:
- Clean up some files style problems
- Program the DET segment when initializing pipes in dcn10_hwseq
- Fix overlay with pre-blend color processing
- Disable SubVP if Hardware Rotation is Used
- Fix few things in DML
- Re
From: Rodrigo Siqueira
Include display_mode_vba_314 and display_rq_dlg_calc_314 to the dml
Makefile.
Acked-by: Tom Chung
Signed-off-by: Rodrigo Siqueira
Signed-off-by: Wayne Lin
---
drivers/gpu/drm/amd/display/dc/dml/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/
From: Rodrigo Siqueira
Remove some useless lines from DC Makefiles.
Acked-by: Tom Chung
Signed-off-by: Rodrigo Siqueira
Signed-off-by: Wayne Lin
---
drivers/gpu/drm/amd/display/dc/dml2/Makefile | 2 --
drivers/gpu/drm/amd/display/dc/resource/Makefile | 2 --
2 files changed, 4 deletions(
From: Rodrigo Siqueira
Remove __cplusplus defines added by accident.
Acked-by: Tom Chung
Signed-off-by: Rodrigo Siqueira
Signed-off-by: Wayne Lin
---
drivers/gpu/drm/amd/display/dc/spl/dc_spl.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/spl/dc_s
From: Rodrigo Siqueira
Drop coasting_vtotal_high and pad from dmub_cmd_update_dirty_rect_data,
since it is not used.
Acked-by: Tom Chung
Signed-off-by: Rodrigo Siqueira
Signed-off-by: Wayne Lin
---
drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 8
1 file changed, 8 deletions(-)
From: Rodrigo Siqueira
[Why & How]
Identify few unused fileds in dc_caps. Remove them.
Acked-by: Tom Chung
Signed-off-by: Rodrigo Siqueira
Signed-off-by: Wayne Lin
---
drivers/gpu/drm/amd/display/dc/dc.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc
From: Rodrigo Siqueira
Add a callback that program the DET segment when initializing pipes.
Acked-by: Tom Chung
Signed-off-by: Rodrigo Siqueira
Signed-off-by: Wayne Lin
---
drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/g
From: Michael Strauss
[WHY]
Overlay works similarly to MPO, but uses global alpha on both planes and
sets the desktop as the rear plane instead of the front plane
[HOW]
Ensure that top plane isn't overlay by checking global alpha before
applying the previously added MPO fix
Reviewed-by: Rodrigo
From: Hansen Dsouza
[why & how]
Add new stream and char control functions based on DCCG spec
Reviewed-by: Muhammad Ahmed
Signed-off-by: Hansen Dsouza
Signed-off-by: Wayne Lin
---
.../amd/display/dc/dccg/dcn35/dcn35_dccg.c| 132 --
1 file changed, 122 insertions(+), 10 del
From: Aurabindo Pillai
When programming phantom pipe, since cursor_width is explicity set to 0,
this causes calculation logic to trigger overflow for an unsigned int
triggering the kernel's UBSAN check as below:
[ 40.962845] UBSAN: shift-out-of-bounds in
/tmp/amd.EfpumTkO/amd/amdgpu/../displa
From: Fangzhi Zuo
Under autonomous mode, source reads dpcd DP_PCON_HDMI_POST_FRL_STATUS
for the frl link status.
Without dsc passthrough, it serves as bw bottleneck on the entire link,
compared with the dp link from source to the converter where dsc is
available.
Reviewed-by: Rodrigo Siqueira
From: Austin Zheng
[Why and How]
SubVP is not supported when hardware rotation is being used
Reviewed-by: Alvin Lee
Signed-off-by: Austin Zheng
Signed-off-by: Wayne Lin
---
.../display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
From: Joshua Aberback
[Why]
Cursor size can change dynamically at runtime without re-validation,
so DML should calculate with the max size cursor to cover all cases.
Reviewed-by: Dillon Varone
Signed-off-by: Joshua Aberback
Signed-off-by: Wayne Lin
---
.../dc/dml2/dml21/dml21_translation_hel
From: Dillon Varone
[WHY]
Currently TR0 (trip 0) is not properly budgeting for urgent latency in
DML2.1. This results in overly aggressive prefetch schedules that are
vulnerable to request return jitter, resulting in severe underflow at
the start of the frame.
[HOW]
Forcing 3DLUT DMA check to en
From: Tom Chung
[Why & How]
Fixed the replay issues and now re-enable the panel replay feature.
Reported-by: Arthur Borsboom
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3344
Reviewed-by: Sun peng Li
Signed-off-by: Tom Chung
Signed-off-by: Wayne Lin
---
.../gpu/drm/amd/display/a
From: Hansen Dsouza
[why & how]
Add clock source selection an control functions based on spec
Reviewed-by: Muhammad Ahmed
Signed-off-by: Hansen Dsouza
Signed-off-by: Wayne Lin
---
.../amd/display/dc/dccg/dcn35/dcn35_dccg.c| 281 --
1 file changed, 252 insertions(+), 29 de
From: Fudong Wang
[Why & How]
Add a dc debug option to keep crtc on when ips switch.
Reviewed-by: Nicholas Kazlauskas
Signed-off-by: Fudong Wang
Signed-off-by: Wayne Lin
---
drivers/gpu/drm/amd/display/dc/dc.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc
From: Fangzhi Zuo
[why]
Encounter NULL pointer dereference uner mst + dsc setup.
BUG: kernel NULL pointer dereference, address: 0008
PGD 0 P4D 0
Oops: [#1] PREEMPT SMP NOPTI
CPU: 4 PID: 917 Comm: sway Not tainted 6.3.9-arch1-1 #1
124dc55df4f5272ccb409f39ef4872fc2b33
From: Chris Park
[Why]
Coverity picks up a defect with regards to array underflow.
[How]
Address coverity issue as recommended.
Reviewed-by: Leo Ma
Signed-off-by: Chris Park
Signed-off-by: Wayne Lin
---
.../gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c | 6 --
1 file changed,
From: Hansen Dsouza
[why & how]
Add clock source selection control functions based on spec
Reviewed-by: Muhammad Ahmed
Signed-off-by: Hansen Dsouza
Signed-off-by: Wayne Lin
---
.../amd/display/dc/dccg/dcn35/dcn35_dccg.c| 153 +++---
1 file changed, 99 insertions(+), 54 deleti
From: Gabe Teeger
This reverts commit 4362962f41b8 ("drm/amd/display: Avoid overflow assignment
in link_dp_cts")
Due to regression causing DPMS hang.
Reviewed-by: Alex Hung
Signed-off-by: Gabe Teeger
Signed-off-by: Wayne Lin
---
drivers/gpu/drm/amd/display/dc/dc_dp_types.h
From: Dillon Varone
[WHY & HOW]
When DRR is active with variable refresh rate, add the ability to block DRR
clamped P-State strategies (such as SubVP).
Reviewed-by: Alvin Lee
Signed-off-by: Dillon Varone
Signed-off-by: Wayne Lin
---
drivers/gpu/drm/amd/display/dc/dc.h
From: Aric Cyr
This version brings along following fixes:
- Clean up some files style problems
- Program the DET segment when initializing pipes in dcn10_hwseq
- Fix overlay with pre-blend color processing
- Disable SubVP if Hardware Rotation is Used
- Fix few things in DML
- Re-enable panel rep
Am 30.07.24 um 07:21 schrieb Sunil Khatri:
Problem:
Till now we are adding NOP packet one by one
i.e if we need N nop packets for padding we are adding
N NOP packets in the ring which does not use the HW
efficiently.
Solution:
Use the data block of the NOP packet for NOP packets
up to the max no
Am 30.07.24 um 08:44 schrieb Sunil Khatri:
There are some problem with existing amdgpu_reset_dump_register_list
debugfs node. It is supposed to read a list of registers but there
could be cases when the IP is not in correct power state. Register
read in such cases could lead to more problems.
Y
On Mon, Jul 29, 2024 at 10:00:00PM +0800, WangYuli wrote:
> The struct assertion is failed because sparse cannot parse
> `#pragma pack(push, 1)` and `#pragma pack(pop)` correctly.
> GCC's output is still 1-byte-aligned. No harm to memory layout.
>
> The error can be filtered out by sparse-diff, bu
On 16.07.24 19:33, Alex Deucher wrote:
> This reverts commit bc87d666c05a13e6d4ae1ddce41fc43d2567b9a2 and the
> register changes from commit 6d4279cb99ac4f51d10409501d29969f687ac8dc.
>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3478
> Cc: mikhail.v.gavri...@gmail.com
> Cc: Rodrigo S
Hi,
On 7/29/24 02:23, Christian König wrote:
> Am 26.07.24 um 14:52 schrieb Alex Deucher:
>> On Fri, Jul 26, 2024 at 3:05 AM Christian König
>> wrote:
>>> Am 25.07.24 um 20:09 schrieb Nikita Zhandarovich:
Several cs track offsets (such as 'track->db_s_read_offset')
either are initialize
On Tue, Jul 30, 2024 at 05:56:42AM +, Lin, Wayne wrote:
> [Public]
>
> Hi,
> Thanks for the report.
>
> Patch fa57924c76d995 ("drm/amd/display: Refactor function
> dm_dp_mst_is_port_support_mode()")
> is kind of correcting problems causing by commit:
> 4df96ba6676034 ("drm/amd/display: Add t
On 29.07.24 10:47, Christian Heusel wrote:
> On 24/07/29 10:35AM, Linux regression tracking (Thorsten Leemhuis) wrote:
>> [+Greg +stable]
>>
>> On 29.07.24 10:16, Lin, Wayne wrote:
>>>
>>> Thanks for the report.
>>>
>>> Patch fa57924c76d995 ("drm/amd/display: Refactor function
>>> dm_dp_mst_is_por
The struct assertion is failed because sparse cannot parse
`#pragma pack(push, 1)` and `#pragma pack(pop)` correctly.
GCC's output is still 1-byte-aligned. No harm to memory layout.
The error can be filtered out by sparse-diff, but sometimes
multiple lines queezed into one, making the sparse-diff
On Mon, Jul 29, 2024 at 10:31:38AM +0200, Linux regression tracking (Thorsten
Leemhuis) wrote:
> On 16.07.24 19:33, Alex Deucher wrote:
> > This reverts commit bc87d666c05a13e6d4ae1ddce41fc43d2567b9a2 and the
> > register changes from commit 6d4279cb99ac4f51d10409501d29969f687ac8dc.
> >
> > Close
July 29, 2024 at 11:15 AM, "Linux regression tracking (Thorsten Leemhuis)"
wrote:
>
> On 29.07.24 10:47, Christian Heusel wrote:
>
> >
> > On 24/07/29 10:35AM, Linux regression tracking (Thorsten Leemhuis) wrote:
> >
> > >
> > > [+Greg +stable]
> > >
> > > On 29.07.24 10:16, Lin, Wayne
[+Greg +stable]
On 29.07.24 10:16, Lin, Wayne wrote:
>
> Thanks for the report.
>
> Patch fa57924c76d995 ("drm/amd/display: Refactor function
> dm_dp_mst_is_port_support_mode()")
> is kind of correcting problems causing by commit:
> 4df96ba6676034 ("drm/amd/display: Add timing pixel encoding for
On 7/10/2024 10:27 PM, Easwar Hariharan wrote:
> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave"
> with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/,
> fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that
> the approved
The struct assertion is failed because sparse cannot parse
`#pragma pack(push, 1)` and `#pragma pack(pop)` correctly.
GCC's output is still 1-byte-aligned. No harm to memory layout.
The error can be filtered out by sparse-diff, but sometimes
multiple lines queezed into one, making the sparse-diff
On 24/07/29 10:35AM, Linux regression tracking (Thorsten Leemhuis) wrote:
> [+Greg +stable]
>
> On 29.07.24 10:16, Lin, Wayne wrote:
> >
> > Thanks for the report.
> >
> > Patch fa57924c76d995 ("drm/amd/display: Refactor function
> > dm_dp_mst_is_port_support_mode()")
> > is kind of correcting p
On Mon, Jul 29, 2024 at 08:43:05PM +0200, Christian König wrote:
> Am 26.07.24 um 16:21 schrieb Daniel Vetter:
> > On Fri, Jul 26, 2024 at 09:55:50AM +0200, Christian König wrote:
> > > The current implementation of drm_sched_start uses a hardcoded
> > > -ECANCELED to dispose of a job when the pare
[Public]
Thanks, Greg.
Will do.
Regards,
Wayne Lin
> -Original Message-
> From: Greg KH
> Sent: Tuesday, July 30, 2024 2:21 PM
> To: Lin, Wayne
> Cc: ke...@holm.dev; Linux regressions mailing list
> ; Deucher, Alexander
> ; Wu, Hersen ;
> sta...@vger.kernel.org; LKML ; ML dri-devel
> ;
On 7/30/2024 12:14 PM, Sunil Khatri wrote:
> There are some problem with existing amdgpu_reset_dump_register_list
> debugfs node. It is supposed to read a list of registers but there
> could be cases when the IP is not in correct power state. Register
> read in such cases could lead to more prob
Am 30.07.24 um 10:36 schrieb Daniel Vetter:
In the end you have a really nice circle dependency.
Maybe a follow up, so for arb robustness or vk context where we want the
context to die and refuse to accept any more jobs: We can get at that
error somehow? I think that's really the only worry I ha
Adding NOP packets one by one in the ring
does not use the CP efficiently.
Solution:
Use CP optimization while adding NOP packet's so PFP
can discard NOP packets based on information of count
from the Header instead of fetching all NOP packets
one by one.
Cc: Christian König
Cc: Pierre-Eric Pell
Am 30.07.24 um 14:43 schrieb Sunil Khatri:
Adding NOP packets one by one in the ring
does not use the CP efficiently.
Solution:
Use CP optimization while adding NOP packet's so PFP
can discard NOP packets based on information of count
from the Header instead of fetching all NOP packets
one by on
With -Werror:
In function ‘r100_cp_init_microcode’,
inlined from ‘r100_cp_init’ at drivers/gpu/drm/radeon/r100.c:1136:7:
include/linux/printk.h:465:44: error: ‘%s’ directive argument is null
[-Werror=format-overflow=]
465 | #define printk(fmt, ...) printk_index_wrap(_printk,
[AMD Official Use Only - AMD Internal Distribution Only]
One minor comment b. Either way Reviewed-by: Harish Kasiviswanathan
-Original Message-
From: amd-gfx On Behalf Of Jonathan Kim
Sent: Monday, July 22, 2024 2:57 PM
To: amd-gfx@lists.freedesktop.org
Cc: Kim, Jonathan ; Kim, Jonatha
From: Xiaogang Chen
When app unmap vm ranges(munmap) kfd/svm starts drain pending page fault and
not handle any incoming pages fault of this process until a deferred work item
got executed by default system wq. The time period of "not handle page fault"
can be long and is unpredicable. That is ad
1. Document how to use SMI system management interface to receive SVM
events, define string format macro for user mode.
2. Increase the event kfifo size, so less chance to drop event.
3. Output migrate end event with error code if migration failed.
4. Report dropped event count if fifo is full.
Ph
If page migration failed, also output migrate end event to match with
migrate start event, with failure error_code added to the end of the
migrate message macro. This will not break uAPI because application uses
old message macro sscanf drop and ignore the error_code.
Signed-off-by: Philip Yang
-
Add new SMI event to report the dropped event count when the event kfifo
is full.
When the kfifo has space for two events, generate a dropped event record
to report how many events were dropped, together with the next event to
add to kfifo.
After reading event out from kfifo, if there were events
SMI event fifo size 1KB was enough to report GPU vm fault or reset
event, increase it to 8KB to store about 100 migrate events, less chance
to drop the migrate events if lots of migration happened in the short
period of time. Add KFD prefix to the macro name.
Signed-off-by: Philip Yang
---
drive
Document how to use SMI system management interface to enable and
receive SVM events. Document SVM event triggers.
Define SVM events message string format macro that could be used by user
mode for sscanf to parse the event. Add it to uAPI header file to make
it obvious that is changing uAPI in fut
Video Format Data Blocks (VFDBs) contain the necessary information that
needs to be fed to the Optimized Video Timings (OVT) Algorithm.
Also, we require OVT support to cover modes that aren't supported by
earlier standards (e.g. CVT). So, parse all of the relevant VFDB data
and feed it to the OVT A
On 2024-07-26 11:30, Jonathan Kim wrote:
> Support per-queue reset for GFX9. The recommendation is for the driver
> to target reset the HW queue via a SPI MMIO register write.
>
> Since this requires pipe and HW queue info and MEC FW is limited to
> doorbell reports of hung queues after an unma
On 2024-07-26 11:30, Jonathan Kim wrote:
> In order to allow ROCm GDB to handle reset queues, raise an
> EC_QUEUE_RESET exception so that the debugger can subscribe and
> query this exception.
>
> Reset queues should still be considered suspendable with a status
> flag of KFD_DBG_QUEUE_RESET_MA
[Public]
> -Original Message-
> From: Kuehling, Felix
> Sent: Tuesday, July 30, 2024 6:07 PM
> To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: Re: [PATCH 1/2] drm/amdkfd: support per-queue reset on gfx9
>
>
> On 2024-07-26 11:30, Jonathan Kim wrote:
[Public]
> -Original Message-
> From: Kuehling, Felix
> Sent: Tuesday, July 30, 2024 6:17 PM
> To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: Re: [PATCH 2/2] drm/amdkfd: support the debugger during per-
> queue reset
>
>
>
> On 2024-07-26 11:30, Jon
Reviewed-by: Tom Chung
On 7/30/2024 12:11 PM, Srinivasan Shanmugam wrote:
This commit corrects the function comment for
'dpp401_dscl_program_isharp' in 'dcn401_dpp_dscl.c'. The comment
previously included a description for a non-existent parameter
'bs_coeffs_updated'. This parameter descriptio
[Public]
Thanks for the help Kevin! It looks good to me.
Regards,
Wayne Lin
> -Original Message-
> From: Kevin Holm
> Sent: Wednesday, July 31, 2024 2:54 AM
> To: sta...@vger.kernel.org
> Cc: regressi...@lists.linux.dev; amd-gfx@lists.freedesktop.org; ML dri-devel
> ; LKML ; Lin,
> Wayn
On 30. 07. 24, 8:00, Lin, Wayne wrote:
Thanks for the report!
We're going to revert it and cc to stable.
There is a fix btw:
https://gitlab.freedesktop.org/drm/amd/-/issues/3495#note_2501831
--
js
suse labs
Am 30.07.24 um 19:36 schrieb Nikita Zhandarovich:
On 7/29/24 11:12, Christian König wrote:
Am 29.07.24 um 20:04 schrieb Christian König:
Am 29.07.24 um 19:26 schrieb Nikita Zhandarovich:
Hi,
On 7/29/24 02:23, Christian König wrote:
Am 26.07.24 um 14:52 schrieb Alex Deucher:
On Fri, Jul 26,
60 matches
Mail list logo
