Signed-off-by: Chengming Gui
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index a9c853a..08f443f 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
+++ b
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function 'gfx_v8_0_pre_soft_reset':
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:4950:27: warning:
variable 'srbm_soft_reset' set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In f
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c: In function
'amdgpu_display_crtc_scaling_mode_fixup':
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:675:27: warning:
variable 'amdgpu_connector' set but not used [-Wunused-but-set-variable]
It never used s
I think it is better move it into amdgpu_device_need_post() as a negative
condition.
Thanks
JimQu
发件人: amd-gfx 代表 Quan, Evan
发送时间: 2018年12月10日 14:33:58
收件人: Xu, Feifei; amd-gfx@lists.freedesktop.org
抄送: Xu, Feifei
主题: RE: [PATCH] drm/amdgpu:skip ASIC_
It's not a core function, and the matching atomic functions are also
not in the core. Plus the suspend/resume helper is also already there.
Needs a tiny bit of open-coding, but less midlayer beats that I think.
Cc: Sam Bobroff
Signed-off-by: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Maxime Ripar
In fact, in multigpu cases, the original logical in
amdgpu_device_need_post()->amdgpu_atombios_scratch_need_asic_init() return TRUE.
The logical is to: read ATOM_S7_ASIC_INIT_COMPLETE_MASK bit which is notified
by BIOS to driver that if post is needed.
After the ASIC_INIT table moved to psp, tho
Having the probe helper stuff (which pretty much everyone needs) in
the drm_crtc_helper.h file (which atomic drivers should never need) is
confusing. Split them out.
To make sure I actually achieved the goal here I went through all
drivers. And indeed, all atomic drivers are now free of
drm_crtc_h
Having the probe helper stuff (which pretty much everyone needs) in
the drm_crtc_helper.h file (which atomic drivers should never need) is
confusing. Split them out.
To make sure I actually achieved the goal here I went through all
drivers. And indeed, all atomic drivers are now free of
drm_crtc_h
On Mon, Dec 10, 2018 at 11:11:33AM +0100, Daniel Vetter wrote:
> Having the probe helper stuff (which pretty much everyone needs) in
> the drm_crtc_helper.h file (which atomic drivers should never need) is
> confusing. Split them out.
>
> To make sure I actually achieved the goal here I went throu
Hi Feifei,
When PSP perform ASIC_INIT during the whole boot up period?
In S4, the asic will be reset, and it need be posted at the beginning of
resume. So it is better move the logic into amdgpu_device_need_post() if
ASIC_INIT is automatic performed by PSP during S4.
Thanks
JimQu
___
On 2018-12-07 11:01 a.m., Chunming Zhou wrote:
> Signed-off-by: Chunming Zhou
> ---
> include/drm-uapi/drm.h | 33 ++
> lib/igt_syncobj.c| 204 +++
> lib/igt_syncobj.h| 19 +
> tests/gem_ctx_bad_exec | Bin 0 -> 1284384 bytes
Please run
git rm tests/gem_ctx_bad_exe
Agree that if also need to skip ASIC_INIT in s3/s4 in driver, should do the
similar change as you mentioned. I am not quite sure the s3/s4 situation for
now. Though from test, it might be the same case.
Will get back from vbios and have corresponding change. Thanks.
发自我的 iPhone
> 在 2018年12月10日，
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Chengming Gui
> Sent: Monday, December 10, 2018 4:05 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Gui, Jack
> Subject: [PATCH] amd/amdgpu: fix typo about amdgpu_sriov_vf
>
Please add descri
Le lun. 10 déc. 2018 à 11:24, Thierry Reding
a écrit :
>
> On Mon, Dec 10, 2018 at 11:11:33AM +0100, Daniel Vetter wrote:
> > Having the probe helper stuff (which pretty much everyone needs) in
> > the drm_crtc_helper.h file (which atomic drivers should never need) is
> > confusing. Split them out
Hi,
This commit
commit e421c656beefa1044f65cf50d7a7455df60cd703
Refs: v4.20-rc3-530-ge421c656beef
Author: Tiecheng Zhou
AuthorDate: Fri Dec 7 09:11:35 2018 +0800
Commit: Tiecheng Zhou
CommitDate: Mon Dec 10 11:14:27 2018 +0800
drm/amdgpu: bypass RLC init under sriov fo
Jack already have a patch to fix this issue.
Thanks,
Ray
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of StDenis, Tom
> Sent: Monday, December 10, 2018 8:07 PM
> To: Zhou, Tiecheng ; amd-gfx mailing list g...@lists.freedesktop.org>
> Cc
On 10/12/2018 11:11, Daniel Vetter wrote:
> Having the probe helper stuff (which pretty much everyone needs) in
> the drm_crtc_helper.h file (which atomic drivers should never need) is
> confusing. Split them out.
>
> To make sure I actually achieved the goal here I went through all
> drivers. And
Le lun. 10 déc. 2018 à 12:10, Benjamin Gaignard
a écrit :
>
> Le lun. 10 déc. 2018 à 11:24, Thierry Reding
> a écrit :
> >
> > On Mon, Dec 10, 2018 at 11:11:33AM +0100, Daniel Vetter wrote:
> > > Having the probe helper stuff (which pretty much everyone needs) in
> > > the drm_crtc_helper.h file
Hi All,
The commit:
commit 62f65d3cb34a8300bf1e07fc478e03c3c02634d4
Refs: v4.20-rc3-524-g62f65d3cb34a
Author: Felix Kuehling
AuthorDate: Mon Nov 19 20:05:54 2018 -0500
Commit: Felix Kuehling
CommitDate: Fri Dec 7 17:17:11 2018 -0500
drm/amdgpu: Add KFD VRAM limit checking
We
vbios asic init will still work. It will wait on the psp init so I'd suggest
we just drop this patch to keep the code consistent. There are also possibly
some registers that are handled by vbios asic init rather than psp.
Alex
From: amd-gfx on behalf of Feif
On Mon, Dec 10, 2018 at 5:04 AM Daniel Vetter wrote:
>
> It's not a core function, and the matching atomic functions are also
> not in the core. Plus the suspend/resume helper is also already there.
>
> Needs a tiny bit of open-coding, but less midlayer beats that I think.
>
> Cc: Sam Bobroff
> S
But KFD still need to be notified during reset , the pre_reset call to KFD
will let KFD have a chance to suspend all the running process queues. Was
the reset works normally on SRIOV before the refactor change for XGMI support
? We shouldn't change the logic .
Regards
shaoyun.liu
-O
Do we still need the HSA_AMD option ?
Seems to me that KFD stopped being "something we only sometimes include" a long
time ago.
Thanks,
John
From: amd-gfx on behalf of StDenis, Tom
Sent: December 10, 2018 10:02 AM
To: Kuehling, Felix
Cc: Huang, JinHuiEric;
I got this compilation error message after I rebase this morning, do I miss
anything?
/home/yangp/git/compute_staging/kernel/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:
In function ‘gfx_v8_0_rlc_resume’:
/home/yangp/git/compute_staging/kernel/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:4071:6:
error: impl
Never mind, just saw the patch to fix the typo.
On 2018-12-10 1:07 p.m., Yang, Philip wrote:
I got this compilation error message after I rebase this morning, do I miss
anything?
/home/yangp/git/compute_staging/kernel/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:
In function ‘gfx_v8_0_rlc_resume’:
/ho
On Fri, Dec 7, 2018 at 3:40 AM Zhang, Jerry(Junwei) wrote:
>
> we can drop MC update patch, since a new fw could fix that.
Shouldn't we apply this as well for consistency?
Alex
>
> Regards,
> Jerry
>
> On 12/7/18 3:19 PM, Junwei Zhang wrote:
> > Some new variants require different firmwares.
>
KFD only works with x86_64. So we still need the switch to disable KFD
on i386 and other architectures that are not (yet) supported.
I'll look into a fix as soon as I can. Thanks for the heads up.
Regards,
Felix
On 2018-12-10 11:25 a.m., Bridgman, John wrote:
>
> Do we still need the HSA_AM
Expose sclk (gfx clock) and mclk (memory clock) via
hwmon compatible interface. hwmon does not actually
formally specify a frequency type attribute, but these
are compatible with the format of the other attributes
exposed via hwmon. Units are hertz.
freq1_input - GPU gfx/compute clock in hertz
f
This function was renamed in a previous commit. Update the stub
function name for builds with CONFIG_HSA_AMD disabled.
Fixes: 62f65d3cb34a ("drm/amdgpu: Add KFD VRAM limit checking")
Signed-off-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +-
1 file changed, 1 insertion(
Decauple sched threads stop and start and ring mirror
list handling from the policy of what to do about the
guilty jobs.
When stoppping the sched thread and detaching sched fences
from non signaled HW fenes wait for all signaled HW fences
to complete before rerunning the jobs.
v2: Fix resubmission
Expedite job deletion from ring mirror list to the HW fence signal
callback instead from finish_work, together with waiting for all
such fences to signal in drm_sched_stop we garantee that
already signaled job will not be processed twice.
Remove the sched finish fence callback and just submit finis
Acked-by: Andrey Grodzovsky
Andrey
On 12/10/2018 04:29 PM, Kuehling, Felix wrote:
> This function was renamed in a previous commit. Update the stub
> function name for builds with CONFIG_HSA_AMD disabled.
>
> Fixes: 62f65d3cb34a ("drm/amdgpu: Add KFD VRAM limit checking")
> Signed-off-by: Felix
This is a nice improvement from the last version. I still see some
potential problems. See inline ...
I'm skipping over the CS and GEM parts. I hope Christian can review
those parts.
On 2018-12-06 4:02 p.m., Yang, Philip wrote:
> Use HMM helper function hmm_vma_fault() to get physical pages backi
Thanks to Jack and Ray,
I'll pay more attention.
Tiecheng
-Original Message-
From: Huang, Ray
Sent: Monday, December 10, 2018 8:15 PM
To: StDenis, Tom ; Zhou, Tiecheng ;
amd-gfx mailing list
Cc: Deucher, Alexander ; Gui, Jack
Subject: RE: build broken on drm-next
Jack already have
Reviewed-by: Tiecheng Zhou
-Original Message-
From: amd-gfx On Behalf Of Gui, Jack
Sent: Monday, December 10, 2018 4:05 PM
To: amd-gfx@lists.freedesktop.org
Cc: Gui, Jack
Subject: [PATCH] amd/amdgpu: fix typo about amdgpu_sriov_vf
Signed-off-by: Chengming Gui
---
drivers/gpu/drm/amd/
Yeah, the asic need to be POST in S4/resume and runtime resume.
Thanks
JimQu
发件人: Xu, Feifei
发送时间: 2018年12月10日 18:42
收件人: Qu, Jim
抄送: Quan, Evan; amd-gfx@lists.freedesktop.org
主题: Re: 答复: [PATCH] drm/amdgpu:skip ASIC_INIT when posting card on vg20
Agree t
On 12/11/18 4:06 AM, Alex Deucher wrote:
On Fri, Dec 7, 2018 at 3:40 AM Zhang, Jerry(Junwei) wrote:
we can drop MC update patch, since a new fw could fix that.
Shouldn't we apply this as well for consistency?
I did apply it for simple test.
That looks no harm.
But confirmed the MC firmware
I don't think adding cb to sched job would work as soon as their lifetime is
different with fence.
Unless you make the sched job reference, otherwise we will get trouble sooner
or later.
-David
> -Original Message-
> From: amd-gfx On Behalf Of
> Andrey Grodzovsky
> Sent: Tuesday, Decem
Sriov should not call amdgpu_amdkfd_pre_reset inside amdgpu_device_lock_adev,
either amdgpu_amdkfd_post_reset inside amdgpu_device_unlock_adev.
In branch amd-staging-dkms-4.18, sriov already called amdgpu_amdkfd_pre_reset
and amdgpu_amdkfd_post_reset inside amdgpu_device_reset_sriov.
There 2 funct
39 matches
Mail list logo
