I think it is better move it into amdgpu_device_need_post() as a negative condition.
Thanks JimQu ________________________________________ 发件人: amd-gfx <[email protected]> 代表 Quan, Evan <[email protected]> 发送时间: 2018年12月10日 14:33:58 收件人: Xu, Feifei; [email protected] 抄送: Xu, Feifei 主题: RE: [PATCH] drm/amdgpu:skip ASIC_INIT when posting card on vg20 Reviewed-by: Evan Quan <[email protected]> > -----Original Message----- > From: amd-gfx <[email protected]> On Behalf Of > Feifei Xu > Sent: 2018年12月10日 14:17 > To: [email protected] > Cc: Xu, Feifei <[email protected]>; Quan, Evan <[email protected]> > Subject: [PATCH] drm/amdgpu:skip ASIC_INIT when posting card on vg20 > > On vega20, the job of executing the ASIC_INIT table when posting card is > moved to psp. Skip the atombios's ASIC_INIT on vega20 when posting card. > > Change-Id: Id1d3c0a0d19296d5ed804de7edf5b09b8d38c0a5 > Signed-off-by: Feifei Xu <[email protected]> > Tested-by: Candice Li <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index ef36cc595985..a375d2ac112f 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -2547,7 +2547,7 @@ int amdgpu_device_init(struct amdgpu_device > *adev, > amdgpu_device_detect_sriov_bios(adev); > > /* Post card if necessary */ > - if (amdgpu_device_need_post(adev)) { > + if ((adev->asic_type != CHIP_VEGA20) && > amdgpu_device_need_post(adev)) > +{ > if (!adev->bios) { > dev_err(adev->dev, "no vBIOS found\n"); > r = -EINVAL; > -- > 2.17.1 > > _______________________________________________ > amd-gfx mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
