I got this compilation error message after I rebase this morning, do I miss
anything?
/home/yangp/git/compute_staging/kernel/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:
In function ‘gfx_v8_0_rlc_resume’:
/home/yangp/git/compute_staging/kernel/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:4071:6:
error: implicit declaration of function ‘amdgpu_sriov’; did you mean
‘amdgpu_sriov_vf’? [-Werror=implicit-function-declaration]
if (amdgpu_sriov(adev)) {
^~~~~~~~~~~~
amdgpu_sriov_vf
cc1: some warnings being treated as errors
/home/yangp/git/compute_staging/kernel/scripts/Makefile.build:293: recipe for
target 'drivers/gpu/drm/amd/amdgpu/gfx_v8_0.o' failed
make[10]: *** [drivers/gpu/drm/amd/amdgpu/gfx_v8_0.o] Error 1
Philip
On 2018-12-07 10:33 a.m., Deucher, Alexander wrote:
Acked-by: Alex Deucher
<alexander.deuc...@amd.com><mailto:alexander.deuc...@amd.com>
________________________________
From: amd-gfx
<amd-gfx-boun...@lists.freedesktop.org><mailto:amd-gfx-boun...@lists.freedesktop.org>
on behalf of Tiecheng Zhou
<tiecheng.z...@amd.com><mailto:tiecheng.z...@amd.com>
Sent: Thursday, December 6, 2018 9:11:49 PM
To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Cc: Zhou, Tiecheng
Subject: [PATCH] drm/amdgpu: bypass RLC init under sriov for Tonga
SWDEV-173384: vm-mix reboot (4 VMs) fail on Tonga under sriov
Phenomena: there is compute_1.3.1 ring test fail on one VM
when it starts to do hw_init after it is rebooted
Root cause: RLC will go wrong in soft_reset under sriov
Workaround: init RLC csb, and skip RLC stop, reset, start
this is because GIM has already done
full initialization on RLC
refer to 'commit cfee05bc9057 ("drm/amdgpu:bypass RLC init for SRIOV")'
and 'commit f840cc5f8447 ("drm/amdgpu/sriov:init csb for gfxv9")'
Signed-off-by: Tiecehng Zhou
<tiecheng.z...@amd.com><mailto:tiecheng.z...@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index 1454fc3..a9c853a 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
@@ -4068,6 +4068,11 @@ static void gfx_v8_0_rlc_start(struct amdgpu_device
*adev)
static int gfx_v8_0_rlc_resume(struct amdgpu_device *adev)
{
+ if (amdgpu_sriov(adev)) {
+ gfx_v8_0_init_csb(adev);
+ return 0;
+ }
+
adev->gfx.rlc.funcs->stop(adev);
adev->gfx.rlc.funcs->reset(adev);
gfx_v8_0_init_pg(adev);
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
