On Wed, Oct 18, 2017 at 4:47 PM, Kuehling, Felix wrote:
>> Thanks Felix.
>> I'll add it to the next tree instead of the one from the patch-set.
>>
>> Oded
>
> I based this patch on your current amdkfd-next. Do you have another "next
> tree"?
No, that's fine.
I simply squashed this patch with the
Am 18.10.2017 um 18:58 schrieb Deucher, Alexander:
-Original Message-
From: Michel Dänzer [mailto:mic...@daenzer.net]
Sent: Wednesday, October 18, 2017 12:06 PM
To: Koenig, Christian; Alex Deucher
Cc: Deucher, Alexander; Dave Airlie; amd-gfx list; Maling list - DRI developers
Subject: Re:
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Pixel Ding
> Sent: Thursday, October 19, 2017 1:43 AM
> To: amd-gfx@lists.freedesktop.org; Deucher, Alexander
> Cc: Sun, Gary; Ding, Pixel
> Subject: [PATCH] drm/amdgpu: always consider virual
From: Michel Dänzer
If we hit a problem while setting up ShadowFB, just carrying on trying
to set up HW acceleration instead is unlikely to work.
(Ported from radeon commit 7d435354099119234d443b07e2df1c7b9f97cf3c)
Signed-off-by: Michel Dänzer
---
src/amdgpu_kms.c | 8
1 file changed
From: Michel Dänzer
We were trying to call acceleration specific functions from LeaveVT.
Instead, memset the scanout buffer to all 0 in LeaveVT and allocate a
new one in EnterVT.
Bugzilla: https://bugs.freedesktop.org/102948
Fixes: c16ff42f927d ("Make all active CRTCs scan out an all-black
From: Michel Dänzer
We were leaking the memory allocated by TimerSet.
Signed-off-by: Michel Dänzer
---
src/amdgpu_kms.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/amdgpu_kms.c b/src/amdgpu_kms.c
index 7d582095b..cb0fb3b57 100644
--- a/src/amdgpu_kms.c
+++ b/src/amdgpu_kms.c
@@ -16
From: Michel Dänzer
We were freeing it earlier but then still trying to access it in
AMDGPUFreeRec.
Signed-off-by: Michel Dänzer
---
src/amdgpu_kms.c | 2 ++
src/amdgpu_probe.c | 8 ++--
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/amdgpu_kms.c b/src/amdgpu_kms.c
in
From: Michel Dänzer
We were not doing so in all cases, leaking memory allocated by the
latter.
Signed-off-by: Michel Dänzer
---
src/drmmode_display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/drmmode_display.c b/src/drmmode_display.c
index 3cbf2bd7d..2cef93cdd
From: Michel Dänzer
We were leaking it.
Signed-off-by: Michel Dänzer
---
src/amdgpu_kms.c | 19 +--
src/amdgpu_probe.c | 6 --
2 files changed, 17 insertions(+), 8 deletions(-)
diff --git a/src/amdgpu_kms.c b/src/amdgpu_kms.c
index 44a99b564..7d582095b 100644
--- a/src/
From: Darren Salt
(Ported from amdgpu commit 2f72be038d22c54620e436af30121dd89f79a003)
Signed-off-by: Michel Dänzer
---
man/radeon.man | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/man/radeon.man b/man/radeon.man
index 9fd863f30..f4441c4b1 100644
--- a/man/radeon.man
From: Michel Dänzer
Not doing so resulted in DRI2 page flips not actually changing the FB
being scanned out, showing intermittent flicker of the "back" buffer
rendering.
Bugzilla: https://bugs.freedesktop.org/102643
Fixes: 55e513b978b2 "Use reference counting for tracking KMS framebuffer
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Michel Dänzer
> Sent: Thursday, October 19, 2017 12:03 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH xf86-video-amdgpu 2/2] Bail if there's a problem with
> ShadowFB
>
> From: Mich
From: "Leo (Sunpeng) Li"
Because of the following patch:
Leo (Sunpeng) LiMove copy_construct from state_alloc to atomic_check
We do not allocate the DC state within dm_atomic_state_alloc anymore.
Since this function is a part of the S3 resume code path, we should not
release the state when
* Fixed hotplug issue (mainly on HDMI, but affected DP as well)
* Use new DRM state iterators
* Couple of Dave's cleanups rerolled on new DML
* Bunch of Raven work
Anthony Koo (2):
drm/amd/display: Add APU cap in dc_caps
drm/amd/display: DMCU FW loading from PSP
Bhawanpreet Lakha (2):
d
From: "Leo (Sunpeng) Li"
undersacn -> underscan
Signed-off-by: Leo (Sunpeng) Li
Reviewed-by: Tony Cheng
Reviewed-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu
From: Dave Airlie
Use the correct for_each_new/old_* iterators instead of for_each_*
The following functions were considered:
amdgpu_dm_find_first_crtc_matching_connector: use for_each_new
- Old from_state_var flag was always choosing the new state
amdgpu_dm_display_resume: use for_each_ne
From: Yongqiang Sun
Program cursor attributes during set mode is only needed
in case of pipe slipt, bottom pipe should be programmed
same as top pipe. Need to program if address is 0.
Signed-off-by: Yongqiang Sun
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/displa
This reduces the code size.
This is basically a redo of Dave's change with the same name
on top of the latest DML.
Signed-off-by: Harry Wentland
---
.../gpu/drm/amd/display/dc/dml/display_mode_vba.c | 2 +
.../drm/amd/display/dc/dml/display_rq_dlg_calc.c | 2 +
.../amd/display/dc/dml/dml
From: Bhawanpreet Lakha
Fixes Nullptr error when trying 24BPP
Signed-off-by: Bhawanpreet Lakha
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/driver
From: Yongqiang Sun
Moved lock and unlock to apply_ctx_to_surface, since all
the front end programming is within apply_ctx_to_surface.
Signed-off-by: Yongqiang Sun
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 52 +--
From: "Leo (Sunpeng) Li"
Use dm_new_*_state and dm_old_*_state for their respective amdgpu_dm new
and old object states. Helps with readability, and enforces use of new
DRM api (choose either new, or old).
Signed-off-by: Leo (Sunpeng) Li
Reviewed-by: Sun peng Li
Acked-by: Harry Wentland
---
Having one struct on the stack was somewhat confusing. Also mention
that the whole function should eventually go.
Signed-off-by: Harry Wentland
Reviewed-by: Andrey Grodzovsky
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/
From: Dave Airlie
turns out to be a win to inline this.
Signed-off-by: Dave Airlie
Reviewed-by: Harry Wentland
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/dc/dml/dml_common_defs.c | 19 ---
drivers/gpu/drm/amd/display/dc/dml/dml_common_defs.h | 2 --
drivers/
From: "Leo (Sunpeng) Li"
This is a follow-up patch to:
Bhawanpreet LakhaAtomic freesync ASSERT fix
Changes:
- Combine to use one iterator
- Use new DRM iterators.
Signed-off-by: Leo (Sunpeng) Li
Reviewed-by: Bhawanpreet Lakha
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amd
Remove defines we no longer need
Signed-off-by: Harry Wentland
---
.../drm/amd/display/include/ddc_service_types.h| 33 --
1 file changed, 33 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/include/ddc_service_types.h
b/drivers/gpu/drm/amd/display/include/ddc_serv
From: Dave Airlie
This is unused code.
Signed-off-by: Dave Airlie
Reviewed-by: Harry Wentland
Signed-off-by: Alex Deucher
---
.../gpu/drm/amd/display/dc/dml/dml_common_defs.c | 33 --
.../gpu/drm/amd/display/dc/dml/dml_common_defs.h | 1 -
2 files changed, 34 deletio
From: "Leo (Sunpeng) Li"
in amdgpu_dm_atomic_commit_tail. Just use crtc instead.
Signed-off-by: Leo (Sunpeng) Li
Reviewed-by: Tony Cheng
Reviewed-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a
From: "Leo (Sunpeng) Li"
To conform to DRM's new API, we should not be accessing a DRM object's
internal state directly. Rather, the DRM for_each_old/new_* iterators,
and drm_atomic_get_old/new_* interface should be used.
This is an ongoing process. For now, update the DRM-facing atomic
function
From: Mikita Lipski
Registers added to definition list that are required
for multi display synchronization
Signed-off-by: Mikita Lipski
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
.../amd/display/dc/dcn10/dcn10_timing_generator.h | 33 --
1 file changed, 30 inse
C++ compilers don't like the implicit conversion
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/display/include/grph_object_id.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/include/grph_object_id.h
b/drivers/gpu/drm/amd/dis
Signed-off-by: Harry Wentland
Acked-by: Alex Deucher
---
.../gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 37 --
1 file changed, 13 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c
b/drivers/gpu/drm/amd/display/dc/dcn10/d
From: Jerry Zuo
Allocate memory for the second pipe allocate_mem_input() needs to
be done prior to program pipe front end. It shows sensitive to
Fiji. Failure to do so will cause error in allocate memory
allocate_mem_input() on the second connected display.
Signed-off-by: Jerry Zuo
Signed-off-
From: "Leo (Sunpeng) Li"
core_link_disable_stream should be called when the new stream is null
(i.e. want to disable). Modify the if condition to reflect that.
Signed-off-by: Leo (Sunpeng) Li
Reviewed-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 6 -
From: Bhawanpreet Lakha
Changes to atomic set property for freesync.
Now In set property, just set the freesync variables and return 0.
Based on the variables call mod_freesync_set_user_enable() inside
commit_tail
Signed-off-by: Bhawanpreet Lakha
Reviewed-by: Tony Cheng
Acked-by: Harry Wentla
From: Anthony Koo
Update the programming sequence to allow DMCU firmware to be loaded by
PSP. This code detects whether the firmware is loaded and does a check
to verify the expected interface version and checks for correct response
from micro controller.
Added registry key method to allow force
From: Yongqiang Sun
In case of pipe split, cursor position should also be
programmed as per cursor address.
Signed-off-by: Yongqiang Sun
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 7 ---
1 file changed, 4 insertions(+)
From: Yue Hin Lau
removing duplicate functions, renaming struct mi_regs, etc.
Signed-off-by: Yue Hin Lau
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 16 +-
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.h | 345 +++--
.../gpu/drm/amd/display/dc/dcn10/dcn10_resou
All files should have MIT headers.
Signed-off-by: Harry Wentland
---
.../gpu/drm/amd/display/dc/dml/display_mode_vba.c | 25 ++
.../gpu/drm/amd/display/dc/dml/display_mode_vba.h | 24 ++---
2 files changed, 46 insertions(+), 3 deletions(-)
diff --git a/driv
From: "Leo (Sunpeng) Li"
Use new_*_state and old_*_state for their respective new/old DRM object
states.
Signed-off-by: Leo (Sunpeng) Li
Reviewed-by: Tony Cheng
Reviewed-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 90 +++
1 file changed, 45
From: Anthony Koo
Some features should only be enabled on APUs or should not
be enabled on APUs.
Signed-off-by: Anthony Koo
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/core/dc.c| 1 +
drivers/gpu/drm/amd/display/dc/dc.h
From: "Leo (Sunpeng) Li"
This is a follow-up patch to:
Leo (Sunpeng) LiCleanup code that enables freesync
We should only add a stream to freesync if a modeset was requested, so
we don't fill the core freesync map with pointless streams.
Signed-off-by: Leo (Sunpeng) Li
Reviewed-by: Harry W
What is KFD eviction fence?
For KFD submissions are done by user mode process. If any of user mode
queues are active, KFD driver must ensure that all the BOs associated
with that process must be resident. This is ensured by adding a
blanket eviction fence to all of t
A single KFD eviction fence is attached to all the BOs of a process
including BOs imported. This fence ensures that all BOs belonging to
that process stays resident when the process queues are active.
Don't add this eviction fence to any sync object unless it is a move or
evict job. These jobs are
This fails to apply to drm-next even with 3-way merge enabled.
error: sha1 information is lacking or useless
(drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c).
error: could not build fake ancestor
Patch failed at 0011 drm/amd/display: Unify DRM state variable namings.
Tom
On 19/10/17 01:46
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Michel Dänzer
> Sent: Thursday, October 19, 2017 12:06 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH xf86-video-amdgpu 4/4] Always call drmModeFreeProperty
> after drmModeGetPropert
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Michel Dänzer
> Sent: Thursday, October 19, 2017 12:19 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH xf86-video-ati] Clarify when TearFree is automatically
> enabled.
>
> From: Dar
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Michel Dänzer
> Sent: Thursday, October 19, 2017 12:59 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH xf86-video-ati] Unreference pixmap's FB with EXA as well in
> radeon_set_pixmap_
Setting package power PID to 1 fixes performance drop caused by
updated SMU FW, before DPM is enabled.
Signed-off-by: Eric Huang
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
b/
Hi Dave,
Last set of features for 4.15. Highlights:
- Add a bo flag to allow buffers to opt out of implicit sync
- Add ctx priority setting interface
- Lots more powerplay cleanups
- Start to plumb through vram lost infrastructure for gpu reset
- ttm support for huge pages
- misc cleanups and bug
Setting package power PID to 1 fixes performance drop caused by
updated SMU FW, before DPM is enabled.
Signed-off-by: Eric Huang
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
On 2017-10-19 03:00 AM, Oded Gabbay wrote:
> On Wed, Oct 18, 2017 at 4:47 PM, Kuehling, Felix
> wrote:
>>> Thanks Felix.
>>> I'll add it to the next tree instead of the one from the patch-set.
>>>
>>> Oded
>> I based this patch on your current amdkfd-next. Do you have another "next
>> tree"?
> N
On 2017-10-19 01:46 PM, Harry Wentland wrote:
From: "Leo (Sunpeng) Li"
Because of the following patch:
Leo (Sunpeng) LiMove copy_construct from state_alloc to atomic_check
We do not allocate the DC state within dm_atomic_state_alloc anymore.
Since this function is a part of the S3 resu
Eric Huang (2):
drm/amd/powerplay: add one smc message for Vega10
drm/amd/powerplay: fix performance drop on Vega10
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 ++
drivers/gpu/drm/amd/powerplay/inc/vega10_ppsmc.h | 3 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
--
2
This is used to fix performance drop caused by updated SMU FW.
Signed-off-by: Eric Huang
---
drivers/gpu/drm/amd/powerplay/inc/vega10_ppsmc.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/inc/vega10_ppsmc.h
b/drivers/gpu/drm/amd/powerplay/in
From: Dave Airlie
I don't think this ioctl is in a Linus release yet.
Signed-off-by: Dave Airlie
---
include/uapi/drm/amdgpu_drm.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h
index ff01818..919248f 100644
--- a/include/uapi/
On Thu, Oct 19, 2017 at 8:52 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> I don't think this ioctl is in a Linus release yet.
>
> Signed-off-by: Dave Airlie
Reviewed-by: Alex Deucher
> ---
> include/uapi/drm/amdgpu_drm.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi
If no one review I’ll submit it soon
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Liu,
Monk
Sent: 2017年10月18日 18:11
To: amd-gfx@lists.freedesktop.org; Deucher, Alexander
; Koenig, Christian
Subject: Re: [PATCH 1/3] drm/amdgpu/sriov:now must reinit psp
can you help
”amdgpu_vf_error_put“ now is already changed to protected by SRIOV_VF(), so the
whole logic is okay
-Original Message-
From: Alex Deucher [mailto:alexdeuc...@gmail.com]
Sent: 2017年10月19日 10:58
To: Liu, Monk
Cc: amd-gfx list
Subject: Re: [PATCH 2/3] drm/amdgpu:fix vf_error_put
On Wed,
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Liu, Monk
> Sent: Thursday, October 19, 2017 10:51 PM
> To: Alex Deucher
> Cc: amd-gfx list
> Subject: RE: [PATCH 2/3] drm/amdgpu:fix vf_error_put
>
> ”amdgpu_vf_error_put“ now is already cha
I followed up on all of these.
Alex
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Liu,
Monk
Sent: Thursday, October 19, 2017 10:50 PM
To: amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH 1/3] drm/amdgpu/sriov:now must reinit psp
If no one review I’ll submit it soon
Thanks,
already addressed accordingly
From: Deucher, Alexander
Sent: 2017年10月20日 10:56
To: Liu, Monk ; amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH 1/3] drm/amdgpu/sriov:now must reinit psp
I followed up on all of these.
Alex
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On
cleanups, now only operate on the given ring
Change-Id: I42ee081696ac348660d38be68807f34090ffcce2
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++---
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 29 +++--
drivers/gpu/drm/amd/amdgpu/amdgpu_r
since gpu_scheduler source domain cannot access amdgpu variable
so need create the hang_limit membewr for sched, and it can
refer it for the upcoming GPU RESET patches
Change-Id: I977ae2717e55a8b87c59e58a288bffc3b458b653
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c |
Change-Id: I44019f6475b1eaaba55633cf5f8bb84284f19a2c
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
index f7fceb6..1d5cbe7 100644
--- a/dr
merge the setting guilty on context into this function
to avoid implement extra routine.
Change-Id: I7a0063464fdc85d5ac9080046380e745565ff540
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 4 ++--
drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 13 -
dri
for user context there will be a guilty pointer in entity
that points to the guilty member of its context, thus we
cant track if a given entity is not from kernel ctx and
if it is already marked guilty.
Change-Id: Ie0a30830d89f52a6c4a514e67206140698a46367
Signed-off-by: Monk Liu
---
drivers/gpu/
66 matches
Mail list logo
