Re: AMDGPU VCE 1: some info needed

2021-01-08 Thread Alexandre Demers
On Fri, 2021-01-08 at 15:00 -0500, Alex Deucher wrote: > On Fri, Jan 8, 2021 at 2:37 PM Alexandre Demers > wrote: > > > > > > On Fri, 2021-01-08 at 10:28 -0500, Alex Deucher wrote: > > > On Fri, Jan 8, 2021 at 3:11 AM Christian König > >

Re: AMDGPU VCE 1: some info needed

2021-01-08 Thread Alexandre Demers
On Fri, 2021-01-08 at 10:28 -0500, Alex Deucher wrote: > On Fri, Jan 8, 2021 at 3:11 AM Christian König > wrote: > > > > Hi Alexandre, > > > > Am 08.01.21 um 05:20 schrieb Alexandre Demers: > > > Hi there, > > > > > > Some of you may

AMDGPU VCE 1: some info needed

2021-01-07 Thread Alexandre Demers
f it applies? 5- Any chance to have some code reviewed even if it still doesn't work if I send it on this list? 6- I have some patches on the side to help document the code and define variables (even for Radeon), a few typos fixed, etc. Should I send them on this list? Cheers Alexandre De

[PATCH] drm/amdgpu: fix DRM_INFO flood if display core is not supported (bug 210921)

2021-01-07 Thread Alexandre Demers
This fix bug 210921 where DRM_INFO floods log when hitting an unsupported ASIC in amdgpu_device_asic_has_dc_support(). This info should be only called once. Signed-off-by: Alexandre Demers --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [RFC 0/7] UVD support for SI in amdgpu

2020-01-04 Thread Alexandre Demers
nd people missing the UVD and VCE features should be the ones overriding the default choice. But this may not work for the majority (I don't know) and I understand that radeon is still the default for GCN 1.0/1.1. Cheers, Alexandre Demers On 2019-12-05 10:32, Deucher, Alexander w

Re: [amdgpu] script to generate a VCE 1.0 amdgpu compatible firmware

2017-11-28 Thread Alexandre Demers
On 2017-11-23 00:53, Alexandre Demers wrote: > Hi, > > I just want to let you know that I'm still alive and still committed to > porting VCE 1.0 from radeon to amdgpu. However, for many reasons, I've > been pretty much unable to work on the code since my last communica

[amdgpu] script to generate a VCE 1.0 amdgpu compatible firmware

2017-11-22 Thread Alexandre Demers
D could release a new UVD firmware with header and correct 40bit addressing, could you ask if an official VCE 1.0 firmware with an official header (and whatever else could be needed) be released at the same time? Cheers -- Alexandre Demers ___ amd

[PATCH] drm/radeon: Small precision when failing to load UVD legacy firmware.

2017-09-08 Thread Alexandre Demers
Signed-off-by: Alexandre Demers --- drivers/gpu/drm/radeon/radeon_uvd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c index 7431eb4a11b7..b4fb07ad9f4a 100644 --- a/drivers/gpu/drm/radeon/radeon_uvd.c

Re: [PATCH 0/6] Ground foundation for VCE 1 implementation

2017-09-08 Thread Alexandre Demers
Oh and patch 3 "Small precision when failing to load legacy firmware" should have been a standalone patch, it is related to the radeon driver. I'll send it as so with drm/radeon in the title. Alexandre Demers On 2017-09-08 07:55, Alexandre Demers wrote: > Hi Christian! >

Re: [PATCH 0/6] Ground foundation for VCE 1 implementation

2017-09-08 Thread Alexandre Demers
ost the next series in the next few days as a RFC so others can help me go through. I just need to split the code in a few patches. Cheers, Alex > > Thanks, > Christian. > > Am 08.09.2017 um 04:48 schrieb Alexandre Demers: >> This is the foundation for VCE 1 implementation, mostl

[PATCH 1/6] Add initial VCE_V1_0 files.

2017-09-07 Thread Alexandre Demers
Signed-off-by: Alexandre Demers --- drivers/gpu/drm/amd/amdgpu/vce_v1_0.c | 384 ++ drivers/gpu/drm/amd/amdgpu/vce_v1_0.h | 29 +++ 2 files changed, 413 insertions(+) create mode 100644 drivers/gpu/drm/amd/amdgpu/vce_v1_0.c create mode 100644 drivers/gpu/drm

[PATCH 5/6] Add support for SI's VCE firmwares (with and without header)

2017-09-07 Thread Alexandre Demers
Inspired on how it is done under radeon for UVD firmwares. Signed-off-by: Alexandre Demers --- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 100 1 file changed, 75 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu

[PATCH 6/6] Fix indentation.

2017-09-07 Thread Alexandre Demers
Signed-off-by: Alexandre Demers --- drivers/gpu/drm/amd/amdgpu/si.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c index 08998639daeb..bb860faa8a95 100644 --- a/drivers/gpu/drm/amd/amdgpu/si.c +++ b/drivers

[PATCH 0/6] Ground foundation for VCE 1 implementation

2017-09-07 Thread Alexandre Demers
nce I don't have as much time as I'd like to work on VCE 1 for now, but this could help others to help me on the task. If you are not satisfied with this first series, this can also be considered as a RFC. Please, comment as needed. Alexandre Demers (6): Add initial VCE_V1_0 file

[PATCH 4/6] Moving read and write pointer functions from radeon to amdgpu

2017-09-07 Thread Alexandre Demers
Signed-off-by: Alexandre Demers --- drivers/gpu/drm/amd/amdgpu/vce_v1_0.c | 62 --- 1 file changed, 36 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v1_0.c index f541a4b5ac51..ab3b834758c6

[PATCH 3/6] Small precision when failing to load legacy firmware.

2017-09-07 Thread Alexandre Demers
Signed-off-by: Alexandre Demers --- drivers/gpu/drm/radeon/radeon_uvd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c index 7431eb4a11b7..b4fb07ad9f4a 100644 --- a/drivers/gpu/drm/radeon/radeon_uvd.c

[PATCH 2/6] Reorganize, rename, move and split some VCE 1 defines.

2017-09-07 Thread Alexandre Demers
For consistency with other files under amdgpu driver. Signed-off-by: Alexandre Demers --- drivers/gpu/drm/amd/amdgpu/si.c| 15 +++- drivers/gpu/drm/amd/amdgpu/si_dma.c| 5 +- drivers/gpu/drm/amd/amdgpu/si_ih.c | 21 +++--- drivers/gpu/drm/amd

Re: [PATCH 0/1] [rfc] Port UVD from radeon for SI

2017-09-03 Thread Alexandre Demers
ig one. It is easier to review, comment, test and isolate problems. Also, about the header you added to the UVD firmware, this is one way to do it, or you could backport how it is done under radeon. This is the path I've chosen for now under VCE. I'll give a look at yo

Re: Question about porting VCE1 to amdgpu

2017-06-27 Thread Alexandre Demers
keep you up to date. Alexandre On Wed, 14 Jun 2017 at 14:22 Deucher, Alexander wrote: > > > *From:* Alexandre Demers [mailto:alexandre.f.dem...@gmail.com] > *Sent:* Wednesday, June 14, 2017 1:30 PM > *To:* Deucher, Alexander; Christian König; Freedesktop - AMD-gfx > > > *

Re: Question about porting VCE1 to amdgpu

2017-06-14 Thread Alexandre Demers
On Wed, 14 Jun 2017 at 13:09 Deucher, Alexander wrote: > > > *From:* amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] *On Behalf > Of *Christian König > *Sent:* Wednesday, June 14, 2017 12:37 PM > *To:* Alexandre Demers; Freedesktop - AMD-gfx > *Subject:* Re: Question

Question about porting VCE1 to amdgpu

2017-06-14 Thread Alexandre Demers
e the last modifications need to be done? Thank you! Alexandre Demers ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu/powerplay: enable LEDs on Fiji boards

2017-02-23 Thread Alexandre Demers
On Thursday, February 23, 2017, Alex Deucher wrote: > On Thu, Feb 23, 2017 at 5:50 PM, Alexandre Demers > > wrote: > > First, sorry for not replying directly as I should normally, but I'm not > on > > my usual computer, so I can't. That being said... > > &

[PATCH] drm/amdgpu/powerplay: enable LEDs on Fiji boards

2017-02-23 Thread Alexandre Demers
config(hwmgr); *>* + PP_ASSERT_WITH_CODE(0 == result, *>* + "Failed to setup dpm led config", return result); * will always lead to "result" being set to 0... Am I missing something? Alexandre Demers __

amdgpu's dce_vX_0_afmt_setmode(): why so different from radeon's

2016-08-22 Thread Alexandre Demers
ces in the step order and even a few more registry read and write calls. Any clue will be welcomed. Cheers. -- Alexandre Demers ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH drm/amdgpu] Fix indentation in dce_v8_0_audio_write_sad_regs()

2016-08-22 Thread Alexandre Demers
@lists.freedesktop.org] On Behalf > > Of Alexandre Demers > > Sent: Sunday, August 21, 2016 8:38 PM > > To: amd-gfx@lists.freedesktop.org > > Subject: [PATCH drm/amdgpu] Fix indentation in > > dce_v8_0_audio_write_sad_regs() > > For these and future patches,

[PATCH drm/amdgpu] Use correct mask in dce_v8_0_afmt_setmode() and fix comment typos.

2016-08-21 Thread Alexandre Demers
We were using the same mask twice. Looking at radeon, it seems we should be using HDMI_AVI_INFO_CONT instead as the second mask. Being there, fix typos in comments and improved readability. I haven't looked at other DCEs, the mask may also be wrong for them. Signed-off-by: Alexandre D

[PATCH drm/amdgpu] Fix indentation in dce_v8_0_audio_write_sad_regs()

2016-08-21 Thread Alexandre Demers
Fixed indentation for readability. Signed-off-by: Alexandre Demers --- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c index 3ff1258..c7e5d5f

Re: radeon VS amdgpu: _afmt_init() behavior if kzalloc fails

2016-08-12 Thread Alexandre Demers
that amdgpu is > meant to support and it's not a critical bugfix (or API update) maybe time > is better spent getting support on the amdgpu side going for that hardware > instead. > > > Cheers, > > Tom > > > -- > *From:* Alexandre

Re: radeon VS amdgpu: _afmt_init() behavior if kzalloc fails

2016-08-12 Thread Alexandre Demers
lly speaking if during > module init a kmalloc of 100 bytes fails something bad is happening and you > want to abort init anyways (so failing to load just because part of DCE > fails is probably a good thing). > > > Tom > > > > > >

Re: radeon VS amdgpu: _afmt_init() behavior if kzalloc fails

2016-08-12 Thread Alexandre Demers
eaking if you fail to kmalloc a few bytes you've got bigger > problems to worry about than your audio not working ideally. > > > Tom > > > ------ > *From:* amd-gfx on behalf of > Alexandre Demers > *Sent:* Friday, August 12, 2016 11:43 > *To

radeon VS amdgpu: _afmt_init() behavior if kzalloc fails

2016-08-12 Thread Alexandre Demers
h is already ready if needed, I could send it later from home if the amdgpu's behavior is the one that we are looking for. Cheers, Alexandre Demers ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH drm/amdgpu] Fixing copy-paste errors and removing unneeded newlines

2016-08-10 Thread Alexandre Demers
Signed-off-by: Alexandre Demers --- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c index 4fdfab1..3ff1258 100644 --- a/drivers/gpu/drm/amd/amdgpu

Wrong shift in dce_v8_0_afmt_update_ACR() under dce_v8_0.c?

2016-08-08 Thread Alexandre Demers
of the same value): WREG32(mmHDMI_ACR_32_0 + offset, (acr.cts_32khz << HDMI_ACR_32_0__HDMI_ACR_CTS_32__SHIFT)); Cheers -- Alexandre Demers ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Implementations of missing dce6 functions: how should patches be organized?

2016-08-08 Thread Alexandre Demers
functions)? Thanks for your input. Alexandre Demers ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] Standardizing the info message for unimplemented functions

2016-08-08 Thread Alexandre Demers
On Mon, 8 Aug 2016 at 01:22 Huang Rui wrote: > On Sun, Aug 07, 2016 at 05:17:41PM -0400, Alexandre Demers wrote: > > Signed-off-by: Alexandre Demers > > > > --- > > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 22 +++--- > > 1 file change

[PATCH] Standardizing the info message for unimplemented functions

2016-08-07 Thread Alexandre Demers
Signed-off-by: Alexandre Demers --- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c index 07e0475..9e327be 100644 --- a/drivers/gpu

Re: Any chance of seeing a merge from drm-next-4.8-wip-si?

2016-08-03 Thread Alexandre Demers
t and/or track with people working on bringing GCN 1.0 (and 1.1) to the amdgpu driver (I'm able to compare the result of using radeon+modesetting VS amdgpu+modesetting to put aside bugs that could be related to modesetting itself). Cheers Alexandre Demers On 2016-08-01 17:14, Alex De

Re: Any chance of seeing a merge from drm-next-4.8-wip-si?

2016-08-01 Thread Alexandre Demers
Thank you for the update. I'll have a go on it and I'll be following what goes in it. Alexandre Demers On 2016-08-01 17:14, Alex Deucher wrote: On Mon, Aug 1, 2016 at 2:29 AM, Alexandre Demers wrote: Hi Alex, I'd like to know if there is any chance to see a merge / pull req

Any chance of seeing a merge from drm-next-4.8-wip-si?

2016-07-31 Thread Alexandre Demers
me to do it in comparison. Now, if I can be of any help, let me know, my R9 280X is waiting for some tests. Cheers, -- Alexandre Demers ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/radeon: drop confusing message about backlight control

2016-07-27 Thread Alexandre Demers
Reviewed-by: Alexandre Demers Alexandre Demers On 2016-07-27 16:44, Alex Deucher wrote: The message is harmless and confusing. On PX systems, there is one ATIF method, but potentially multiple GPUs leading to an error on the GPU with no backlight control. Bug: https://bugzilla.kernel.org

Re: [PATCH 1/3] drm/amdgpu: add bypass mode for vce3.0

2016-07-24 Thread Alexandre Demers
Please, keep a similar syntax to other functions and to the file name. "vce_v3_set_bypass_mode" should be "vce_v3_0_set_bypass_mode". Alexandre Demers On 2016-07-21 20:10, Eric Huang wrote: Looks good to me. Reviewed-by: Eric Huang Regards, Eric On 07/18/2016 12:

Re: [PATCH] amdgpu: expose the AMDGPU_GEM_CREATE_VRAM_CLEARED flag

2016-07-21 Thread Alexandre Demers
Forget my question, I just saw your other patches. ;) Alexandre Demers On 2016-07-22 02:32, Alexandre Demers wrote: Hi Flora. I suppose this addition preceeds AMDGPU_GEM_CREATE_VRAM_CLEARED's usage that will be introduced in upcoming patches? Could you fix the commit message VARM -&

Re: [PATCH] amdgpu: expose the AMDGPU_GEM_CREATE_VRAM_CLEARED flag

2016-07-21 Thread Alexandre Demers
Hi Flora. I suppose this addition preceeds AMDGPU_GEM_CREATE_VRAM_CLEARED's usage that will be introduced in upcoming patches? Could you fix the commit message VARM -> VRAM? With that fixed, you can add my Reviewed-by: Alexandre Demers Alexandre Demers On 2016-07-22 00:02, F