> On June 21, 2012, 2:08 p.m., Matěj Laitl wrote:
> > tests/core/collections/TestCollection.cpp, line 34
> > <http://git.reviewboard.kde.org/r/105166/diff/2/?file=70025#file70025line34>
> >
> > Strange indentation again. Hmm?
>
> Jasneet Bhatti
sses on my repository
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
/r/105166/diff/
Testing
---
Test passes on my repository
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
---
Test passes on my repository
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
tests/core/collections/TestQueryMaker.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105172/diff/
Testing
---
Able to build Amarok after writing the test
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://ma
tests/core/collections/MockQueryMaker.cpp PRE-CREATION
tests/core/collections/TestQueryMaker.h PRE-CREATION
tests/core/collections/TestQueryMaker.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105172/diff/
Testing (updated)
---
Test builds and runs fine
Thanks,
Jasneet
tests/core/collections/MockQueryMaker.cpp PRE-CREATION
tests/core/collections/TestQueryMaker.h PRE-CREATION
tests/core/collections/TestQueryMaker.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105172/diff/
Testing
---
Test builds and runs fine
Thanks,
Jasneet Bhatti
lly generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105172/#review15160
-------
On June 23, 2012, 7:05 p.m., Jasneet Bhatti wrote:
>
> ---
> This is an automatically generated e-mail.
/diff/
Testing
---
Test builds and runs fine
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
and runs fine
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
---
Builds and runs fine.
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
E-CREATION
tests/core/meta/support/TestMetaConstants.cpp PRE-CREATION
tests/mocks/MetaMock.h b478c87
Diff: http://git.reviewboard.kde.org/r/105424/diff/
Testing
---
Builds and runs fine.
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing l
://git.reviewboard.kde.org/r/105389/diff/
Testing
---
Builds and runs fine.
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
--
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105389/#review15334
---
On July 5, 2012, 12:07 a.m., Jasneet Bhatti wrote:
>
> ---
-CREATION
Diff: http://git.reviewboard.kde.org/r/105454/diff/
Testing
---
Builds, and runs fine
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
/
Testing
---
Builds and runs fine.
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
----------
On July 6, 2012, 8:54 a.m., Jasneet Bhatti wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105389/
>
,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
---------
On July 6, 2012, 5:38 p.m., Jasneet Bhatti wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105389/
>
Diff: http://git.reviewboard.kde.org/r/105497/diff/
Testing
---
Builds, links and runs fine.
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
/meta/support/CMakeLists.txt PRE-CREATION
tests/core/meta/support/TestMetaTrackKey.h PRE-CREATION
tests/core/meta/support/TestMetaTrackKey.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105454/diff/
Testing
---
Builds, and runs fine
Thanks,
Jasneet Bhatti
-CREATION
Diff: http://git.reviewboard.kde.org/r/105389/diff/
Testing
---
Builds and runs fine.
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
r *****
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
eet/amarok/tests/core/meta/support/TestMetaAlbumKey.cpp(104)]
PASS : TestMetaAlbumKey::testOperatorLessThan()
INFO : TestMetaAlbumKey::cleanupTestCase() entering
PASS : TestMetaAlbumKey::cleanupTestCase()
Totals: 4 passed, 0 failed, 0 skipped
* Finished testing of TestMetaAlbumKey *
testing of TestMetaTrackKey *
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
*
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
: TestMetaTrackKey::cleanupTestCase() entering
PASS : TestMetaTrackKey::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped
* Finished testing of TestMetaTrackKey *
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel
sed, 0 failed, 0 skipped
* Finished testing of TestMetaAlbumKey *
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
--
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105497/#review15794
-------
On July 14, 2012, 6:03 a.m., Jasneet Bhatti wrote:
>
> -
reply, visit:
http://git.reviewboard.kde.org/r/105454/#review16093
-------
On July 14, 2012, 4:06 a.m., Jasneet Bhatti wrote:
>
> ---
> This is an automatically generated e-m
visit:
http://git.reviewboard.kde.org/r/105497/#review16091
---
On July 14, 2012, 6:03 a.m., Jasneet Bhatti wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
::cleanupTestCase()
Totals: 8 passed, 0 failed, 0 skipped
* Finished testing of TestPrivateMetaRegistry *
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
---
Builds and runs fine. Just the image setting problem exists.
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
, 0 failed, 0 skipped
* Finished testing of TestPrivateMetaRegistry *
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
t:
http://git.reviewboard.kde.org/r/105525/#review16229
-------
On July 24, 2012, 4:32 p.m., Jasneet Bhatti wrote:
>
> ---
> This is an automatically generated e-
/lyrics/LyricsEngine.cpp
<http://git.reviewboard.kde.org/r/109470/#comment21854>
Indentation issue.
src/context/engines/lyrics/LyricsEngine.cpp
<http://git.reviewboard.kde.org/r/109470/#comment21855>
Spaces needed between brackets and function arguments.
src/context/engines/lyrics
ttp://git.reviewboard.kde.org/r/110426/#comment24195>
The problem seems to be here.
There's MagnatuneConfig.cpp here too. So you'll probably have to add
KWalletHelper.cpp to this list as well to link it properly.
- Jasneet Bhatti
On May 14, 2013, 6:13 p.m., Vedan
> On May 14, 2013, 6:43 p.m., Jasneet Bhatti wrote:
> > src/services/magnatune/CMakeLists.txt, line 19
> > <http://git.reviewboard.kde.org/r/110426/diff/1/?file=143704#file143704line19>
> >
> > The problem seems to be here.
> >
> > Th
ylist/PlaylistDock.h 897be1d
src/playlist/PlaylistDock.cpp b217e3c
Diff: http://git.reviewboard.kde.org/r/103960/diff/
Testing
---
I've tested this on ubuntu 11.10 with kubuntu-desktop and it seems to work fine.
Thanks,
Jasneet Bhatti
--
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103960/#review10581
---
On Feb. 13, 2012, 5:26 a.m., Jasneet Bhatti wrote:
>
> --
d it seems to work fine.
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
> On Feb. 13, 2012, 8:40 a.m., Matěj Laitl wrote:
> > src/playlist/PlaylistDock.cpp, line 327
> > <http://git.reviewboard.kde.org/r/103960/diff/1/?file=49412#file49412line327>
> >
> > Is there any specific reason this call is here?
>
> Jasneet Bhatti
th kubuntu-desktop and it seems to work fine.
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
sted this on ubuntu 11.10 with kubuntu-desktop and it seems to work fine.
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
ommunity.
On to the next one.
- Jasneet
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103960/#review10650
-------
On
Works fine for me.
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
Tested it on ubuntu 11.04 with kubuntu-desktop. Works fine for me.
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
I'm interested in working on "Project: Implement MediaArtStorageSpec" as a
GSoC project. I've read the information on the links provided on the page
https://bugs.kde.org/show_bug.cgi?id=296049 . What more do I need to study
and how should I go about working on this ?
___
On Sun, Mar 18, 2012 at 3:49 PM, Teo Mrnjavac wrote:
> On Sat, Mar 17, 2012 at 18:46, Jasneet Bhatti
> wrote:
> > I'm interested in working on "Project: Implement MediaArtStorageSpec" as
> a
> > GSoC project. I've read the information on the links prov
t.cpp 5e72e13
Diff: http://git.reviewboard.kde.org/r/104307/diff/
Testing
---
Tested it on ubuntu 11.04 with kubuntu-desktop. Works fine for me.
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/ma
an opportunity to remove these, too)
I don't completely understand the concept of DEBUG_BLOCKs. So I tried to
structure the function like other similar functions. How do you determine that
we are not debugging a piece of code, because there is debug() to output the
messages ? A
t.cpp 5e72e13
Diff: http://git.reviewboard.kde.org/r/104307/diff/
Testing
---
Tested it on ubuntu 11.04 with kubuntu-desktop. Works fine for me.
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/ma
src/widgets/BookmarkTriangle.cpp 4c59d42
src/widgets/SliderWidget.cpp 5e72e13
Diff: http://git.reviewboard.kde.org/r/104307/diff/
Testing
---
Tested it on ubuntu 11.04 with kubuntu-desktop. Works fine for me.
Thanks,
Jasneet Bhatti
___
A
t
> > actually debugging. (I know, it is in other methods here, you can take this
> > as an opportunity to remove these, too)
>
> Jasneet Bhatti wrote:
> I don't completely understand the concept of DEBUG_BLOCKs. So I tried to
> structure the function li
s/BookmarkTriangle.cpp, line 135
> > <http://git.reviewboard.kde.org/r/104307/diff/2/?file=54412#file54412line135>
> >
> > Minor things: trailing whitespace, excessive debugging.
Taken care of.
And finally, I apologize for the silly mistakes I made. I should have been m
ically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104307/#review11839
-------
On March 24, 2012, 12:03 p.m., Jasneet Bhatti wrote:
>
> ---
>
e swtich); I've
> > tried to upload updated patch here twice so that you can see the changes,
> > but it somehow doesn't show.
> >
> > Anyways, thanks and I'd be glad to commit more your review requests,
> > Jasneet, pick any little bug that a
I have been extremely busy with university exam preparations for the past
few days, so haven't been as active here as I've been before. But I've
written a sample test to demonstrate my test writing skills.
P.S. : This is just a sample test, so I've not put it up on the kde
reviewboard
Regards
Jas
: http://git.reviewboard.kde.org/r/105144/diff/
Testing
---
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
--
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105144/#review14402
---
On June 3, 2012, 3:45 p.m., Jasneet Bhatti wrote:
>
> --
/TestActionsCapability.cpp e69de29
Diff: http://git.reviewboard.kde.org/r/105144/diff/
Testing
---
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
105144/#review14420
---
On June 4, 2012, 10:53 a.m., Jasneet Bhatti wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://g
2efd1fe
tests/core/collections/TestCollection.h PRE-CREATION
tests/core/collections/TestCollection.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105166/diff/
Testing
---
Test passes on my repository
Thanks,
Jasneet Bhatti
rewritten in the
future
Diffs
-
tests/core/collections/TestQueryMaker.h PRE-CREATION
tests/core/collections/TestQueryMaker.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105172/diff/
Testing
---
Able to build Amarok after writing the test
Thanks,
Jasneet Bhatti
-CREATION
Diff: http://git.reviewboard.kde.org/r/105166/diff/
Testing
---
Test passes on my repository
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
---
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
://git.reviewboard.kde.org/r/105172/diff/
Testing
---
Able to build Amarok after writing the test
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
/
Testing
---
Unit Test builds and runs as desired
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
/capabilities/CMakeLists.txt e69de29
tests/core/capabilities/TestActionsCapability.h e69de29
tests/core/capabilities/TestActionsCapability.cpp e69de29
Diff: http://git.reviewboard.kde.org/r/105144/diff/
Testing
---
Thanks,
Jasneet Bhatti
tests/core/meta/TestMetaCapability.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105291/diff/
Testing
---
Unit Test builds and runs as desired
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https
ably because cmake
sometimes doesn't detect changes to cmake files and the older version had
several more link targets including this one.
- Jasneet
---
This is an automatically generated e-mail. To reply, visit:
http://
tests/core/capabilities/TestActionsCapability.h PRE-CREATION
tests/core/capabilities/TestActionsCapability.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105144/diff/
Testing
---
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
: http://git.reviewboard.kde.org/r/105306/diff/
Testing
---
Compiles, links and runs fine.
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
/CMakeLists.txt PRE-CREATION
tests/core/playlists/TestPlaylistFormat.h PRE-CREATION
tests/core/playlists/TestPlaylistFormat.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105306/diff/
Testing
---
Compiles, links and runs fine.
Thanks,
Jasneet Bhatti
ply, visit:
http://git.reviewboard.kde.org/r/105306/#review14910
-------
On June 20, 2012, 2:05 p.m., Jasneet Bhatti wrote:
>
> ---
> This is an automatically generated e-mail. To re
/playlists/TestPlaylistFormat.h PRE-CREATION
tests/core/playlists/TestPlaylistFormat.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105306/diff/
Testing
---
Compiles, links and runs fine.
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing
repository
Thanks,
Jasneet Bhatti
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
/core/collections/TestCollection.cpp, line 237
> > <http://git.reviewboard.kde.org/r/105166/diff/2/?file=70025#file70025line237>
> >
> > Same as comment for testIsWritable()
Working on it now.
- Jasneet
---
This is a
just dont
> > QCOMPARE( collection->usedCapacity(), 0.0 )? You really want to pretend
> > static_cast doesn't exist and use it only in at a least resort.
>
> Jasneet Bhatti wrote:
> 0.0 is a double and usedCapacity returns a float, so there was a warning
> on c
> On June 21, 2012, 2:08 p.m., Matěj Laitl wrote:
> > tests/core/collections/TestCollection.cpp, line 34
> > <http://git.reviewboard.kde.org/r/105166/diff/2/?file=70025#file70025line34>
> >
> > Strange indentation again. Hmm?
>
> Jasneet Bhatti
80 matches
Mail list logo
