----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105629/ -----------------------------------------------------------
Review request for Amarok, Matěj Laitl and Sven Krohlas. Description ------- Test for core/meta/support/MetaUtility THIS IS NOT YET COMPLETE. The testMprisMapFromTrack() and testMpris20MapFromTrack() test functions are not setting the cover image properly and I'm unable to understand why. I've added a couple of qDebug() statements to show the same. I'd be grateful if someone could tell me what the problem actually is. Everything else is working fine. Diffs ----- src/core-impl/collections/db/sql/SqlRegistry.h 8d80117 src/core/meta/support/MetaUtility.h c1ba442 src/core/meta/support/MetaUtility.cpp 133076b tests/core/meta/CMakeLists.txt 3ae78c9 tests/core/meta/support/CMakeLists.txt PRE-CREATION tests/core/meta/support/TestMetaUtility.h PRE-CREATION tests/core/meta/support/TestMetaUtility.cpp PRE-CREATION tests/data/cover/amarok.png PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105629/diff/ Testing ------- Builds and runs fine. Just the image setting problem exists. Thanks, Jasneet Bhatti
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
