----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110426/#review32518 -----------------------------------------------------------
src/services/magnatune/CMakeLists.txt <http://git.reviewboard.kde.org/r/110426/#comment24195> The problem seems to be here. There's MagnatuneConfig.cpp here too. So you'll probably have to add KWalletHelper.cpp to this list as well to link it properly. - Jasneet Bhatti On May 14, 2013, 6:13 p.m., Vedant Agarwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110426/ > ----------------------------------------------------------- > > (Updated May 14, 2013, 6:13 p.m.) > > > Review request for Amarok. > > > Description > ------- > > I have created a KWalletHelper class so that services like Maganatune, > Last.fm and GPodder can use this rather than duplicating code. > Currently the patch applies only to Magnatune. The KWalletHelper class > complies but it doesn't link properly to the MagnatuneConfig class. > > > Diffs > ----- > > src/CMakeLists.txt 4dcb316 > src/services/KWalletHelper.h e69de29 > src/services/KWalletHelper.cpp e69de29 > src/services/magnatune/CMakeLists.txt 91f24c0 > src/services/magnatune/MagnatuneConfig.h 552bcf8 > src/services/magnatune/MagnatuneConfig.cpp 5842c63 > > Diff: http://git.reviewboard.kde.org/r/110426/diff/ > > > Testing > ------- > > The KWalletHelper.cpp complies but fails to link to ManatuneConfig.cpp. > Output of "make" command: http://paste.kde.org/743792/ > > > Thanks, > > Vedant Agarwala > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
