[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-29 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/14879 Here is the releva

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-29 Thread Matheus Izvekov via cfe-commits
@@ -11714,13 +11714,37 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, return; } - case TemplateDeductionResult::InvalidExplicitArguments: + case TemplateDeductionResult::InvalidExplicitArguments: { assert(ParamD && "no parameter f

[clang] [CUDA] Precommit test for VTable codegen (PR #124983)

2025-01-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Anshil Gandhi (gandhi56) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/124983.diff 1 Files Affected: - (added) clang/test/CodeGenCUDA/increment-index-for-thunks.cu (+33) ``diff diff --git a/clang/test/Code

[clang] [clang][X86] Support __attribute__((model("small"/"large"))) (PR #124834)

2025-01-29 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks updated https://github.com/llvm/llvm-project/pull/124834 >From 7c40169ec7430ec64aaeb053e423eca1ceff7f0d Mon Sep 17 00:00:00 2001 From: Arthur Eubanks Date: Tue, 28 Jan 2025 20:36:58 + Subject: [PATCH 1/3] [clang][X86] Support __attribute__((model("small"/"large"

[clang] [clang][X86] Support __attribute__((model("small"/"large"))) (PR #124834)

2025-01-29 Thread Arthur Eubanks via cfe-commits
@@ -5,7 +5,7 @@ // RUN: %clang_cc1 -triple riscv64 -verify=expected,riscv64 -fsyntax-only %s // RUN: %clang_cc1 -triple x86_64 -verify=expected,x86_64 -fsyntax-only %s aeubanks wrote: does the change to this test make sense, or am I missing something that putti

[clang] [CUDA] Precommit test for VTable codegen (PR #124983)

2025-01-29 Thread Anshil Gandhi via cfe-commits
https://github.com/gandhi56 created https://github.com/llvm/llvm-project/pull/124983 None >From 0e2317ae0ef1377bc461e7e461bf3b699d75014d Mon Sep 17 00:00:00 2001 From: Anshil Gandhi Date: Tue, 28 Jan 2025 18:04:44 -0600 Subject: [PATCH] [CUDA] Precommit test for VTable codegen --- .../CodeGe

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-29 Thread Aidan Goldfarb via cfe-commits
@@ -11714,13 +11714,37 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, return; } - case TemplateDeductionResult::InvalidExplicitArguments: + case TemplateDeductionResult::InvalidExplicitArguments: { assert(ParamD && "no parameter f

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-29 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/121417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] abc8812 - [Clang][P1061] Add stuctured binding packs (#121417)

2025-01-29 Thread via cfe-commits
Author: Jason Rice Date: 2025-01-29T21:43:52+01:00 New Revision: abc8812df02599fc413d9ed77b992f8236ed2af9 URL: https://github.com/llvm/llvm-project/commit/abc8812df02599fc413d9ed77b992f8236ed2af9 DIFF: https://github.com/llvm/llvm-project/commit/abc8812df02599fc413d9ed77b992f8236ed2af9.diff LO

[clang] [Clang] Fixed invalid virtual copy constructor assertion (PR #124819)

2025-01-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Narayan (vortex73) Changes - [x] Fix crash on Clang's Assertion Trunk due to Virtual Copy Constructor Fixed #112909 --- Full diff: https://github.com/llvm/llvm-project/pull/124819.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaD

[clang] [Clang] Fixed invalid virtual copy constructor assertion (PR #124819)

2025-01-29 Thread via cfe-commits
https://github.com/vortex73 ready_for_review https://github.com/llvm/llvm-project/pull/124819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fixed invalid virtual copy constructor assertion (PR #124819)

2025-01-29 Thread via cfe-commits
https://github.com/vortex73 edited https://github.com/llvm/llvm-project/pull/124819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][X86] Support __attribute__((model("small"/"large"))) (PR #124834)

2025-01-29 Thread Arthur Eubanks via cfe-commits
@@ -2949,6 +2950,13 @@ static void handleSectionAttr(Sema &S, Decl *D, const ParsedAttr &AL) { } } +static bool isValidCodeModelAttr(Sema &S, StringRef Str) { + bool IsX8664Target = + S.Context.getTargetInfo().getTriple().getArch() == llvm::Triple::x86_64; + bool IsX

[clang] [llvm] [AMDGPU][True16][MC][CodeGen] true16 for v_alignbyte_b32 (PR #119750)

2025-01-29 Thread Brox Chen via cfe-commits
https://github.com/broxigarchen edited https://github.com/llvm/llvm-project/pull/119750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU][True16][MC][CodeGen] true16 for v_alignbyte_b32 (PR #119750)

2025-01-29 Thread Brox Chen via cfe-commits
https://github.com/broxigarchen edited https://github.com/llvm/llvm-project/pull/119750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Track function template instantiation from definition (PR #112241)

2025-01-29 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/112241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 07a0e2b - [clang] Track function template instantiation from definition (#112241)

2025-01-29 Thread via cfe-commits
Author: Matheus Izvekov Date: 2025-01-29T17:23:36-03:00 New Revision: 07a0e2be86f33beb6d519a3d466b95c2257e93cb URL: https://github.com/llvm/llvm-project/commit/07a0e2be86f33beb6d519a3d466b95c2257e93cb DIFF: https://github.com/llvm/llvm-project/commit/07a0e2be86f33beb6d519a3d466b95c2257e93cb.dif

[clang] [ExtractAPI] merge anon declarators even if they're array types (PR #120801)

2025-01-29 Thread via cfe-commits
https://github.com/QuietMisdreavus closed https://github.com/llvm/llvm-project/pull/120801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove the deprecated flag `-frelaxed-template-template-args`. (PR #111894)

2025-01-29 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/12682 Here is the r

[clang] [clang] Remove the deprecated flag `-frelaxed-template-template-args`. (PR #111894)

2025-01-29 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/10661 Here is the relevant piece of the build lo

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-29 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/122754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-29 Thread Matheus Izvekov via cfe-commits
@@ -11714,13 +11714,37 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, return; } - case TemplateDeductionResult::InvalidExplicitArguments: + case TemplateDeductionResult::InvalidExplicitArguments: { assert(ParamD && "no parameter f

[clang] a368402 - [ExtractAPI] merge anon declarators even if they're array types (#120801)

2025-01-29 Thread via cfe-commits
Author: QuietMisdreavus Date: 2025-01-29T13:03:33-07:00 New Revision: a368402d633098fc211c29f9726eef6e1874da5f URL: https://github.com/llvm/llvm-project/commit/a368402d633098fc211c29f9726eef6e1874da5f DIFF: https://github.com/llvm/llvm-project/commit/a368402d633098fc211c29f9726eef6e1874da5f.dif

[clang] [clang] Remove the deprecated flag `-frelaxed-template-template-args`. (PR #111894)

2025-01-29 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/111894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8a334af - [clang] Remove the deprecated flag `-frelaxed-template-template-args`. (#111894)

2025-01-29 Thread via cfe-commits
Author: Matheus Izvekov Date: 2025-01-29T16:57:05-03:00 New Revision: 8a334af417ff2ef49e0bc74f9421b4f3aa479805 URL: https://github.com/llvm/llvm-project/commit/8a334af417ff2ef49e0bc74f9421b4f3aa479805 DIFF: https://github.com/llvm/llvm-project/commit/8a334af417ff2ef49e0bc74f9421b4f3aa479805.dif

[clang] [Clang][counted_by] Refactor __builtin_dynamic_object_size on FAMs (PR #122198)

2025-01-29 Thread Bill Wendling via cfe-commits
bwendling wrote: Friendly ping for any further comments. https://github.com/llvm/llvm-project/pull/122198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][X86] Support __attribute__((model("small"/"large"))) (PR #124834)

2025-01-29 Thread Artem Belevich via cfe-commits
@@ -5,7 +5,7 @@ // RUN: %clang_cc1 -triple riscv64 -verify=expected,riscv64 -fsyntax-only %s // RUN: %clang_cc1 -triple x86_64 -verify=expected,x86_64 -fsyntax-only %s Artem-B wrote: nvptx does not *use* the code models, but CUDA compilation will *see* those a

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Devon Loehr via cfe-commits
https://github.com/DKLoehr updated https://github.com/llvm/llvm-project/pull/117622 >From 798b3f21593499194487c9877b8f4a3d9e44bb6e Mon Sep 17 00:00:00 2001 From: Devon Loehr Date: Thu, 21 Nov 2024 19:29:00 + Subject: [PATCH 1/4] Warn when unique objects might be duplicated in shared librar

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-29 Thread Aidan Goldfarb via cfe-commits
@@ -11714,13 +11714,37 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, return; } - case TemplateDeductionResult::InvalidExplicitArguments: + case TemplateDeductionResult::InvalidExplicitArguments: { assert(ParamD && "no parameter f

[clang] [clang][X86] Support __attribute__((model("small"/"large"))) (PR #124834)

2025-01-29 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks updated https://github.com/llvm/llvm-project/pull/124834 >From 7c40169ec7430ec64aaeb053e423eca1ceff7f0d Mon Sep 17 00:00:00 2001 From: Arthur Eubanks Date: Tue, 28 Jan 2025 20:36:58 + Subject: [PATCH 1/2] [clang][X86] Support __attribute__((model("small"/"large"

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-29 Thread Matheus Izvekov via cfe-commits
@@ -11714,13 +11714,38 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, return; } - case TemplateDeductionResult::InvalidExplicitArguments: + case TemplateDeductionResult::InvalidExplicitArguments: { assert(ParamD && "no parameter f

[clang] [clang][X86] Support __attribute__((model("small"/"large"))) (PR #124834)

2025-01-29 Thread Arthur Eubanks via cfe-commits
@@ -5,7 +5,7 @@ // RUN: %clang_cc1 -triple riscv64 -verify=expected,riscv64 -fsyntax-only %s // RUN: %clang_cc1 -triple x86_64 -verify=expected,x86_64 -fsyntax-only %s aeubanks wrote: I thought nvptx64 was the GPU-side of things, the GPU side is also using code

[clang] [clang] UEFI handle unsupported triples. (PR #124824)

2025-01-29 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. LGTM. Lets try to follow up w/ something on the llvm side too though. https://github.com/llvm/llvm-project/pull/124824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [Sema] do not destruct fields of unions (PR #122330)

2025-01-29 Thread Jameson Nash via cfe-commits
https://github.com/vtjnash updated https://github.com/llvm/llvm-project/pull/122330 >From 829e1c89ce869f782cb802a1d618003770c0d074 Mon Sep 17 00:00:00 2001 From: Jameson Nash Date: Thu, 9 Jan 2025 17:10:08 + Subject: [PATCH 1/2] [Sema] do not destruct fields of unions The C++ standard proh

[clang] [clang][SME] Account for C++ lambdas in SME builtin diagnostics (PR #124750)

2025-01-29 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. https://github.com/llvm/llvm-project/pull/124750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Devon Loehr via cfe-commits
@@ -0,0 +1,187 @@ +/** + * When building shared libraries, hidden objects which are defined in header + * files will be duplicated, with one copy in each shared library. If the object + * was meant to be globally unique (one copy per program), this can cause very + * subtle bugs.

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Devon Loehr via cfe-commits
https://github.com/DKLoehr edited https://github.com/llvm/llvm-project/pull/117622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-29 Thread Aidan Goldfarb via cfe-commits
https://github.com/AidanGoldfarb updated https://github.com/llvm/llvm-project/pull/122754 >From b6c576fb90362640b2fd4e41bd7f13dfee95d04d Mon Sep 17 00:00:00 2001 From: Aidan Date: Mon, 13 Jan 2025 11:53:39 -0500 Subject: [PATCH 01/23] initial template arg fix push --- .../clang/Basic/Diagnost

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Devon Loehr via cfe-commits
@@ -0,0 +1,187 @@ +/** + * When building shared libraries, hidden objects which are defined in header + * files will be duplicated, with one copy in each shared library. If the object + * was meant to be globally unique (one copy per program), this can cause very + * subtle bugs.

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Devon Loehr via cfe-commits
@@ -6153,6 +6153,15 @@ def warn_static_local_in_extern_inline : Warning< def note_convert_inline_to_static : Note< "use 'static' to give inline function %0 internal linkage">; +def warn_possible_object_duplication_mutable : Warning< + "%0 is mutable, has hidden visibility,

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Devon Loehr via cfe-commits
@@ -0,0 +1,187 @@ +/** + * When building shared libraries, hidden objects which are defined in header + * files will be duplicated, with one copy in each shared library. If the object + * was meant to be globally unique (one copy per program), this can cause very + * subtle bugs.

[clang] [ARM] Empty structs are 1-byte for C++ ABI (PR #124762)

2025-01-29 Thread Eli Friedman via cfe-commits
@@ -1144,6 +1144,12 @@ Arm and AArch64 Support * FUJITSU-MONAKA (fujitsu-monaka) +- The AArch64 calling convention for empty structs in C++ mode was changed to + pass them as if they have a size of 1 byte, matching the AAPCS64 + specification and GCC's implementation. The

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Devon Loehr via cfe-commits
@@ -13374,6 +13374,62 @@ void Sema::checkNonTrivialCUnion(QualType QT, SourceLocation Loc, .visit(QT, nullptr, false); } +bool Sema::GloballyUniqueObjectMightBeAccidentallyDuplicated( +const VarDecl *Dcl) { + if (!Dcl || !getLangOpts().CPlusPlus)

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Devon Loehr via cfe-commits
@@ -0,0 +1,187 @@ +/** + * When building shared libraries, hidden objects which are defined in header + * files will be duplicated, with one copy in each shared library. If the object + * was meant to be globally unique (one copy per program), this can cause very + * subtle bugs.

[clang] [ubsan] Connect -fsanitize-skip-hot-cutoff to LowerAllowCheckPass (PR #124857)

2025-01-29 Thread Thurston Dang via cfe-commits
https://github.com/thurstond updated https://github.com/llvm/llvm-project/pull/124857 >From 68246540d28c765af1fe4d61244e35cc8ff723cc Mon Sep 17 00:00:00 2001 From: Thurston Dang Date: Wed, 22 Jan 2025 18:59:07 + Subject: [PATCH 1/6] [ubsan] Connect -fsanitize-skip-hot-cutoff to LowerAllowC

[clang] [clang] Track function template instantiation from definition (PR #112241)

2025-01-29 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/112241 >From c1f3c40382b79a3aa3fb422b6f7382a1f7d7c6f5 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Sat, 28 Sep 2024 14:28:58 -0300 Subject: [PATCH] [clang] Track function template instantiation from definition

[clang] [RFC] Initial implementation of P2719 (PR #113510)

2025-01-29 Thread via cfe-commits
@@ -9712,19 +9712,34 @@ def warn_operator_new_returns_null : Warning< "%select{| or 'noexcept'}1">, InGroup; def err_operator_new_dependent_param_type : Error< - "%0 cannot take a dependent type as first parameter; " - "use size_t (%1) instead">; + "%select{|type aware}1

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-29 Thread via cfe-commits
cor3ntin wrote: > > Does this mean we should adjust the cxx_status page to not say Clang 20? I > > also see there is a conflict with the ReleaseNotes.md where it appears all > > of the C++2c items no longer exist. (I guess that is because it is for the > > next release.) > > Meh, let's assume

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #117437)

2025-01-29 Thread Erich Keane via cfe-commits
erichkeane wrote: I don't have a great solution for this unfortuantely, but `HasRebuiltInit` doesn't seem right to me, it looks like we're just trying to smuggle a bit around for a few . First, it doesn't seem clear to me why the 'rebuilt-ness' of an initializer should have anything to do wit

[clang] [llvm] [AMDGPU][True16][MC] true16 for v_alignbyte_b32 (PR #119750)

2025-01-29 Thread Brox Chen via cfe-commits
https://github.com/broxigarchen updated https://github.com/llvm/llvm-project/pull/119750 >From 68ba9f46992b683dcff947e929e5050691acf0f1 Mon Sep 17 00:00:00 2001 From: guochen2 Date: Thu, 12 Dec 2024 13:33:14 -0500 Subject: [PATCH 1/4] True16 for v_alignbyte_b32 in MC --- clang/lib/CodeGen/CGB

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-29 Thread Jason Rice via cfe-commits
ricejasonf wrote: >@ricejasonf let us know if you want us to merge on your behalf @cor3ntin When you think its ready, yes please. I think it requires write access. I fixed the conflict in the ReleaseNotes through Github's UI so that only my feature is under the C++2c features added. I assume o

[clang] [ubsan] Connect -fsanitize-skip-hot-cutoff to LowerAllowCheckPass (PR #124857)

2025-01-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a080498c92e4c00f099dab1a3d5dac48f14b7492 9a3ff427202d1e4cf089732c73d07c2fc90d83da --e

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-29 Thread via cfe-commits
cor3ntin wrote: > Does this mean we should adjust the cxx_status page to not say Clang 20? I > also see there is a conflict with the ReleaseNotes.md where it appears all of > the C++2c items no longer exist. (I guess that is because it is for the next > release.) Meh, let's assume 20 and we c

[clang] [ubsan] Connect -fsanitize-skip-hot-cutoff to LowerAllowCheckPass (PR #124857)

2025-01-29 Thread Thurston Dang via cfe-commits
@@ -795,12 +795,29 @@ static void addSanitizers(const Triple &TargetTriple, PB.registerOptimizerLastEPCallback(SanitizersCallback); } - if (LowerAllowCheckPass::IsRequested()) { + bool lowerAllowCheck = LowerAllowCheckPass::IsRequested(); + // Is there a non-zero cuto

[clang] [ubsan] Connect -fsanitize-skip-hot-cutoff to LowerAllowCheckPass (PR #124857)

2025-01-29 Thread Thurston Dang via cfe-commits
@@ -3614,29 +3614,35 @@ void CodeGenFunction::EmitCheck( llvm::Value *RecoverableCond = nullptr; llvm::Value *TrapCond = nullptr; bool NoMerge = false; + // Expand checks into: + // (Check1 || !allow_ubsan_check) && (Check2 || !allow_ubsan_check) ... + // We need sep

[clang] [ubsan] Connect -fsanitize-skip-hot-cutoff to LowerAllowCheckPass (PR #124857)

2025-01-29 Thread Thurston Dang via cfe-commits
@@ -3614,29 +3614,35 @@ void CodeGenFunction::EmitCheck( llvm::Value *RecoverableCond = nullptr; llvm::Value *TrapCond = nullptr; bool NoMerge = false; + // Expand checks into: + // (Check1 || !allow_ubsan_check) && (Check2 || !allow_ubsan_check) ... + // We need sep

[clang] [ubsan] Connect -fsanitize-skip-hot-cutoff to LowerAllowCheckPass (PR #124857)

2025-01-29 Thread Thurston Dang via cfe-commits
@@ -795,12 +795,29 @@ static void addSanitizers(const Triple &TargetTriple, PB.registerOptimizerLastEPCallback(SanitizersCallback); } - if (LowerAllowCheckPass::IsRequested()) { + bool lowerAllowCheck = LowerAllowCheckPass::IsRequested(); + // Is there a non-zero cuto

[clang] [ubsan] Connect -fsanitize-skip-hot-cutoff to LowerAllowCheckPass (PR #124857)

2025-01-29 Thread Thurston Dang via cfe-commits
@@ -795,12 +795,29 @@ static void addSanitizers(const Triple &TargetTriple, PB.registerOptimizerLastEPCallback(SanitizersCallback); } - if (LowerAllowCheckPass::IsRequested()) { + bool lowerAllowCheck = LowerAllowCheckPass::IsRequested(); + // Is there a non-zero cuto

[clang] [ubsan] Connect -fsanitize-skip-hot-cutoff to LowerAllowCheckPass (PR #124857)

2025-01-29 Thread Thurston Dang via cfe-commits
@@ -795,12 +795,29 @@ static void addSanitizers(const Triple &TargetTriple, PB.registerOptimizerLastEPCallback(SanitizersCallback); } - if (LowerAllowCheckPass::IsRequested()) { + bool lowerAllowCheck = LowerAllowCheckPass::IsRequested(); + // Is there a non-zero cuto

[clang] [ubsan] Connect -fsanitize-skip-hot-cutoff to LowerAllowCheckPass (PR #124857)

2025-01-29 Thread Thurston Dang via cfe-commits
https://github.com/thurstond updated https://github.com/llvm/llvm-project/pull/124857 >From 68246540d28c765af1fe4d61244e35cc8ff723cc Mon Sep 17 00:00:00 2001 From: Thurston Dang Date: Wed, 22 Jan 2025 18:59:07 + Subject: [PATCH 1/5] [ubsan] Connect -fsanitize-skip-hot-cutoff to LowerAllowC

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-29 Thread Jason Rice via cfe-commits
ricejasonf wrote: @cor3ntin > Now that the Clang 20 branch has happened, I think we should go ahead with > that PR Does this mean we should adjust the cxx_status page to not say Clang 20? I also see there is a conflict with the ReleaseNotes.md where it appears all of the C++2c items no long

[clang] [clang] UEFI handle unsupported triples. (PR #124824)

2025-01-29 Thread via cfe-commits
https://github.com/Prabhuk updated https://github.com/llvm/llvm-project/pull/124824 >From 270c260ba8160c71c6602fcb91a635368ee09a88 Mon Sep 17 00:00:00 2001 From: Prabhu Karthikeyan Rajasekaran Date: Tue, 28 Jan 2025 19:07:06 + Subject: [PATCH 1/7] [clang] Abort on unsupported uefi triples.

[clang] [CUDA] Emit NULL in VTable in the last resort (PR #124687)

2025-01-29 Thread Anshil Gandhi via cfe-commits
https://github.com/gandhi56 closed https://github.com/llvm/llvm-project/pull/124687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix smart pointer accessor caching to handle aliases (PR #124964)

2025-01-29 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/124964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[HIP] Use original file path for CUID" (#108771) (PR #111885)

2025-01-29 Thread Artem Belevich via cfe-commits
@@ -1,13 +1,15 @@ // Check CUID generated by hash. // The same CUID is generated for the same file with the same options. +// RUN: cd %S + // RUN: %clang -### -x hip --target=x86_64-unknown-linux-gnu --no-offload-new-driver \ // RUN: --offload-arch=gfx906 -c -nogpuinc -no

[clang] [AArch64] Add MSVC mangling for the __mfp8 type (PR #124968)

2025-01-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Momchil Velikov (momchil-velikov) Changes Fixes #124907 --- Full diff: https://github.com/llvm/llvm-project/pull/124968.diff 2 Files Affected: - (modified) clang/lib/AST/MicrosoftMangle.cpp (+5) - (added) clang/test/CodeGenCXX/aarch64

[clang] [AArch64] Add MSVC mangling for the __mfp8 type (PR #124968)

2025-01-29 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov created https://github.com/llvm/llvm-project/pull/124968 Fixes #124907 >From e490f9684aa8784299a9195a195433270f2cec79 Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Wed, 29 Jan 2025 18:31:18 + Subject: [PATCH] [AArch64] Add MSVC mangling for the __

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Hans Wennborg via cfe-commits
@@ -3661,6 +3661,12 @@ class Sema final : public SemaBase { NonTrivialCUnionContext UseContext, unsigned NonTrivialKind); + /// Certain globally-unique variables might be accidentally duplicated if + /// built into mu

[clang] [clang][dataflow] Fix smart pointer accessor caching to handle aliases (PR #124964)

2025-01-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jan Voung (jvoung) Changes Check the canonical type in the matchers to handle aliases. For example std::optional uses add_pointer_t<...>. --- Full diff: https://github.com/llvm/llvm-project/pull/124964.diff 2 Files Affected: - (modifie

[clang] [clang][dataflow] Fix smart pointer accessor caching to handle aliases (PR #124964)

2025-01-29 Thread Jan Voung via cfe-commits
https://github.com/jvoung ready_for_review https://github.com/llvm/llvm-project/pull/124964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] UEFI handle unsupported triples. (PR #124824)

2025-01-29 Thread via cfe-commits
https://github.com/Prabhuk updated https://github.com/llvm/llvm-project/pull/124824 >From 270c260ba8160c71c6602fcb91a635368ee09a88 Mon Sep 17 00:00:00 2001 From: Prabhu Karthikeyan Rajasekaran Date: Tue, 28 Jan 2025 19:07:06 + Subject: [PATCH 1/5] [clang] Abort on unsupported uefi triples.

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Hans Wennborg via cfe-commits
@@ -0,0 +1,187 @@ +/** + * When building shared libraries, hidden objects which are defined in header + * files will be duplicated, with one copy in each shared library. If the object + * was meant to be globally unique (one copy per program), this can cause very + * subtle bugs.

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Hans Wennborg via cfe-commits
@@ -0,0 +1,187 @@ +/** + * When building shared libraries, hidden objects which are defined in header + * files will be duplicated, with one copy in each shared library. If the object + * was meant to be globally unique (one copy per program), this can cause very + * subtle bugs.

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Hans Wennborg via cfe-commits
@@ -0,0 +1,187 @@ +/** + * When building shared libraries, hidden objects which are defined in header + * files will be duplicated, with one copy in each shared library. If the object + * was meant to be globally unique (one copy per program), this can cause very + * subtle bugs.

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Hans Wennborg via cfe-commits
@@ -0,0 +1,187 @@ +/** + * When building shared libraries, hidden objects which are defined in header + * files will be duplicated, with one copy in each shared library. If the object + * was meant to be globally unique (one copy per program), this can cause very + * subtle bugs.

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Hans Wennborg via cfe-commits
@@ -6153,6 +6153,15 @@ def warn_static_local_in_extern_inline : Warning< def note_convert_inline_to_static : Note< "use 'static' to give inline function %0 internal linkage">; +def warn_possible_object_duplication_mutable : Warning< + "%0 is mutable, has hidden visibility,

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Hans Wennborg via cfe-commits
@@ -508,6 +508,10 @@ New Compiler Flags - clang-cl and clang-dxc now support ``-fdiagnostics-color=[auto|never|always]`` in addition to ``-f[no-]color-diagnostics``. +- The ``-Wunique-object-duplication`` warning has been added to warn about objects zmodem

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Hans Wennborg via cfe-commits
@@ -6153,6 +6153,15 @@ def warn_static_local_in_extern_inline : Warning< def note_convert_inline_to_static : Note< "use 'static' to give inline function %0 internal linkage">; +def warn_possible_object_duplication_mutable : Warning< + "%0 is mutable, has hidden visibility,

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-29 Thread Hans Wennborg via cfe-commits
@@ -13374,6 +13374,62 @@ void Sema::checkNonTrivialCUnion(QualType QT, SourceLocation Loc, .visit(QT, nullptr, false); } +bool Sema::GloballyUniqueObjectMightBeAccidentallyDuplicated( +const VarDecl *Dcl) { + if (!Dcl || !getLangOpts().CPlusPlus)

[clang] [llvm] [DRAFT] Root SIgnatures add parser (PR #118895)

2025-01-29 Thread via cfe-commits
https://github.com/joaosaffran closed https://github.com/llvm/llvm-project/pull/118895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fixed UnresolvedLookupExpr propagating into the codegen phase (PR #124609)

2025-01-29 Thread via cfe-commits
https://github.com/TilakChad edited https://github.com/llvm/llvm-project/pull/124609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix smart pointer accessor caching to handle aliases (PR #124964)

2025-01-29 Thread Jan Voung via cfe-commits
https://github.com/jvoung created https://github.com/llvm/llvm-project/pull/124964 Check the canonical type in the matchers to handle aliases. For example std::optional uses add_pointer_t<...>. >From f5414bee931510d530c440f0590226367ba7913c Mon Sep 17 00:00:00 2001 From: Jan Voung Date: Wed,

[clang] [Driver] Teach Barmetal toolchain about GCC installation(1/3) (PR #121829)

2025-01-29 Thread Garvit Gupta via cfe-commits
quic-garvgupt wrote: Gentle Ping again! https://github.com/llvm/llvm-project/pull/121829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [Clang] Remove ARCMigrate (PR #119269)

2025-01-29 Thread Argyrios Kyrtzidis via cfe-commits
https://github.com/akyrtzi approved this pull request. https://github.com/llvm/llvm-project/pull/119269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Fix typo "tranpose" (PR #124929)

2025-01-29 Thread Jay Foad via cfe-commits
https://github.com/jayfoad closed https://github.com/llvm/llvm-project/pull/124929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] aa29521 - Fix typo "tranpose" (#124929)

2025-01-29 Thread via cfe-commits
Author: Jay Foad Date: 2025-01-29T17:49:54Z New Revision: aa2952165cd1808dab2bb49b97becc097f4c9cac URL: https://github.com/llvm/llvm-project/commit/aa2952165cd1808dab2bb49b97becc097f4c9cac DIFF: https://github.com/llvm/llvm-project/commit/aa2952165cd1808dab2bb49b97becc097f4c9cac.diff LOG: Fix

[clang] [llvm] [AMDGPU][True16][MC] true16 for v_alignbyte_b32 (PR #119750)

2025-01-29 Thread Brox Chen via cfe-commits
https://github.com/broxigarchen converted_to_draft https://github.com/llvm/llvm-project/pull/119750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU][True16][MC] true16 for v_alignbyte_b32 (PR #119750)

2025-01-29 Thread Brox Chen via cfe-commits
https://github.com/broxigarchen updated https://github.com/llvm/llvm-project/pull/119750 >From 68ba9f46992b683dcff947e929e5050691acf0f1 Mon Sep 17 00:00:00 2001 From: guochen2 Date: Thu, 12 Dec 2024 13:33:14 -0500 Subject: [PATCH 1/4] True16 for v_alignbyte_b32 in MC --- clang/lib/CodeGen/CGB

[clang] [llvm] [mlir] Fix typo "tranpose" (PR #124929)

2025-01-29 Thread Aart Bik via cfe-commits
https://github.com/aartbik approved this pull request. https://github.com/llvm/llvm-project/pull/124929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Fix typo "tranpose" (PR #124929)

2025-01-29 Thread Aart Bik via cfe-commits
@@ -1269,7 +1269,7 @@ struct LinalgOpRewriter : public OpRewritePattern { AffineExpr i, j, k; bindDims(getContext(), i, j, k); -// TODO: more robust patterns, tranposed versions, more kernels, +// TODO: more robust patterns, transposed versions, more kernels,

[clang] [TBAA] Don't emit pointer-tbaa for void pointers. (PR #122116)

2025-01-29 Thread John McCall via cfe-commits
@@ -2489,6 +2489,81 @@ are listed below. $ clang -fuse-ld=lld -Oz -Wl,--icf=safe -fcodegen-data-use code.cc +Strict Aliasing +--- + +The C and C++ standards require accesses to objects in memory to use l-values of +an appropriate type for the object. This is

[clang] [clang] Return larger CXX records in memory (PR #120670)

2025-01-29 Thread Pranav Kant via cfe-commits
pranavk wrote: Oops. Too bad. I didn't realize we branched off release/20.x Anyhow, I made necessary tweaks to now make it a LLVM 21 feature. > There is a X86 Support section It feels more appropriate to put this in "ABI changes section" than "X86 support" since it's not a "support". But I a

[clang] [TBAA] Don't emit pointer-tbaa for void pointers. (PR #122116)

2025-01-29 Thread John McCall via cfe-commits
https://github.com/rjmccall commented: Last minute re-read caught a couple slip-ups, and yeah, as mentioned, please feel free to augment this with other relevant information for users. Also, I'm definitely not sure the separate clang-cl section is worth keeping; it's pretty short, and any extr

[clang] [clang] Return larger CXX records in memory (PR #120670)

2025-01-29 Thread Pranav Kant via cfe-commits
https://github.com/pranavk updated https://github.com/llvm/llvm-project/pull/120670 >From 2c049c1a377e0b9142d4dcb8682ea27837750810 Mon Sep 17 00:00:00 2001 From: Pranav Kant Date: Fri, 20 Dec 2024 02:17:23 + Subject: [PATCH] [clang] Return larger CXX records in memory We incorrectly return

[clang] [TBAA] Don't emit pointer-tbaa for void pointers. (PR #122116)

2025-01-29 Thread John McCall via cfe-commits
@@ -2489,6 +2489,81 @@ are listed below. $ clang -fuse-ld=lld -Oz -Wl,--icf=safe -fcodegen-data-use code.cc +Strict Aliasing +--- + +The C and C++ standards require accesses to objects in memory to use l-values of +an appropriate type for the object. This is

[clang] [TBAA] Don't emit pointer-tbaa for void pointers. (PR #122116)

2025-01-29 Thread John McCall via cfe-commits
@@ -2489,6 +2489,81 @@ are listed below. $ clang -fuse-ld=lld -Oz -Wl,--icf=safe -fcodegen-data-use code.cc +Strict Aliasing +--- + +The C and C++ standards require accesses to objects in memory to use l-values of +an appropriate type for the object. This is

[clang] [TBAA] Don't emit pointer-tbaa for void pointers. (PR #122116)

2025-01-29 Thread John McCall via cfe-commits
https://github.com/rjmccall edited https://github.com/llvm/llvm-project/pull/122116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Refactor: removed typos in 'AllowedTypes' option in various checks (PR #122957)

2025-01-29 Thread via cfe-commits
github-actions[bot] wrote: @vbvictor Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build

[clang-tools-extra] [clang-tidy] Refactor: removed typos in 'AllowedTypes' option in various checks (PR #122957)

2025-01-29 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank closed https://github.com/llvm/llvm-project/pull/122957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 15412d7 - [clang-tidy] Refactor: remove typos in 'AllowedTypes' option in various checks (#122957)

2025-01-29 Thread via cfe-commits
Author: Baranov Victor Date: 2025-01-29T12:30:56-05:00 New Revision: 15412d735a4f3e85b1c68025ca28d5671fde7b47 URL: https://github.com/llvm/llvm-project/commit/15412d735a4f3e85b1c68025ca28d5671fde7b47 DIFF: https://github.com/llvm/llvm-project/commit/15412d735a4f3e85b1c68025ca28d5671fde7b47.diff

  1   2   3   4   5   6   7   8   9   10   >