erichkeane wrote:

I don't have a great solution for this unfortuantely, but `HasRebuiltInit` 
doesn't seem right to me, it looks like we're just trying to smuggle a bit 
around for a few .  First, it doesn't seem clear to me why the 'rebuilt-ness' 
of an initializer should have anything to do with anything.  

Second, whether or not it was rebuilt should be a property of that expression 
perhaps?  The init itself should know whether it needs to be built again or not.

I honestly don't think I understand the requirement well enough, but I DO think 
this looks/smells incorrect here.  It seems to me the static analyzer should be 
responsible for this perhaps, and not the AST.  But again, it isn't clear to me 
that is the case.

https://github.com/llvm/llvm-project/pull/117437
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to