Bug#1078858: w1retap: Correct Appstream metainfo, drop desktop type

On 16 Jan 2025, at 10:30, Petter Reinholdtsen wrote: > Anything I can do to help get this fix into unstable? Hi Petter, Thanks for the reminder to get this done, and thanks for the upload! Kind Regards Tom

[COSE] Re: [IANA #1410887] expert review for draft-ietf-cose-tsa-tst-header-parameter (cose)

On Fri, 17 Jan 2025 at 19:49, Carsten Bormann wrote: > > On 17. Jan 2025, at 19:23, Thomas Fossati wrote: > > > > Hi Carsten, > > > > On Wed, 15 Jan 2025 at 16:55, Carsten Bormann wrote: > >> > >> On 2025-01-13, at 21:27, Thomas Fossati wrote: &g

Re: [Rd] as.data.frame() methods for model objects

d confidence intervals for model + estimates. } \section{Using time series}{ Considerable care is needed when using \code{lm} with time series. De : Martin Maechler [mailto:maech...@stat.math.ethz.ch] Envoyé : vendredi 17 janvier 2025 17:04 À : SOEIRO Thomas Cc : r-devel@r-project.o

Re: consumer replication net recovering

I have not experienced the master crashing but I have also experienced stalled replication regularly over the last 2 years. We’ve been on 2.46 and have keep alive enabled. We were hoping an upgrade would resolve the problem but it seems to exist on latest versions as well. I am also on aws ec2 inst

[PATCH] hw/i386/pc: Fix crash that occurs when introspecting TYPE_PC_MACHINE machines

ch listener functions must never be installed from an instance_init function. Let's do it from pc_basic_device_init() instead - this function is called from the MachineClass->init() function instead, i.e. guaranteed to be only called once in the lifetime of a QEMU process. Resolves: https:

Re: [PATCH 08/21] hw/net/e1000: Remove unused E1000_FLAG_MAC flag

On 17/01/2025 17.41, Philippe Mathieu-Daudé wrote: On 17/1/25 09:58, Thomas Huth wrote: On 16/01/2025 00.22, Philippe Mathieu-Daudé wrote: E1000_FLAG_MAC was only used by the hw_compat_2_4[] array, via the 'extra_mac_registers=off' property. We removed all machines using that a

Re: [PATCH 08/21] hw/net/e1000: Remove unused E1000_FLAG_MAC flag

On 17/01/2025 17.41, Philippe Mathieu-Daudé wrote: On 17/1/25 09:58, Thomas Huth wrote: On 16/01/2025 00.22, Philippe Mathieu-Daudé wrote: E1000_FLAG_MAC was only used by the hw_compat_2_4[] array, via the 'extra_mac_registers=off' property. We removed all machines using that a

[pve-devel] applied-series: [PATCH qemu-server/docs v4 00/16] adapt to changes in QEMU machine version deprecation/removal

Am 17.01.25 um 15:24 schrieb Fiona Ebner: > Changes in v4: > * dropped already applied patch > * move import for get_host_arch() to earlier patch where it is already needed > * squash rename and move patches for get_command_for_arch() together > * rename machine_version_at_least -> is_machine_versi

Re: [PATCH 10/21] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_DISABLE_PCIE definition

On 17/01/2025 17.43, Philippe Mathieu-Daudé wrote: On 17/1/25 10:08, Thomas Huth wrote: On 16/01/2025 00.22, Philippe Mathieu-Daudé wrote: VIRTIO_PCI_FLAG_DISABLE_PCIE was only used by the hw_compat_2_4[] array, via the 'x-disable-pcie=false' property. We removed all machines using

Re: [PATCH 10/21] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_DISABLE_PCIE definition

On 17/01/2025 17.43, Philippe Mathieu-Daudé wrote: On 17/1/25 10:08, Thomas Huth wrote: On 16/01/2025 00.22, Philippe Mathieu-Daudé wrote: VIRTIO_PCI_FLAG_DISABLE_PCIE was only used by the hw_compat_2_4[] array, via the 'x-disable-pcie=false' property. We removed all machines using

Re: migration to is-kea (was Re: FAI for Linux on Apple Silicon?)

ISC DHCP is well established. Although it's deprecated it will be used for many more years. Many people/companies rely on it and can not easily switch to another software, so IMO there will be people that will fix bugs if they arise. -- reagrds Thomas

[COSE] Re: [IANA #1410887] expert review for draft-ietf-cose-tsa-tst-header-parameter (cose)

Hi Carsten, On Wed, 15 Jan 2025 at 16:55, Carsten Bormann wrote: > > On 2025-01-13, at 21:27, Thomas Fossati wrote: > > > > As noted in Shuping's ARTART review [1], table 1 contains a typo: > > "3161-tcc" should read "3161-ttc" instead. > >

[COSE] Re: [IANA #1410887] expert review for draft-ietf-cose-tsa-tst-header-parameter (cose)

hi Francesca, On Wed, 15 Jan 2025 at 10:41, Francesca Palombini wrote: > > Thanks Thomas. I have reviewed the registration request and I don’t see any > issues, approved pending IESG approval. I was considering the codepoint, and > given how I expect these parameters to contain

[tmux/tmux] 9260f5: Do not update focus on client's without a session.

Log Message: --- Do not update focus on client's without a session. Commit: 58392d29da8f35ab3d943efd9a412f3ce6cc2cec https://github.com/tmux/tmux/commit/58392d29da8f35ab3d943efd9a412f3ce6cc2cec Author: Thomas Adam Date: 2025-01-17 (Fri, 17 Jan 2025) Changed

Re: Trouble with knitr in LyX 2.4.3

36 PM To: Thomas Philips ; lyx-users@lists.lyx.org Cc: Doug Martin ; Stoyan Stoyanov Subject: Re: Trouble with knitr in LyX 2.4.3 Le 17/01/2025 à 18:01, Thomas Philips a écrit : > Hello JMarc, > I found the following system variables (see below). Interestingly the R > folders does not show

[kmymoney] [Bug 498703] Kmymoney crashes when posting NEW stock purchases if the transaction-date pre-dates the stock's creation date.

https://bugs.kde.org/show_bug.cgi?id=498703 Thomas Baumgart changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution

[kmymoney] [Bug 498703] Kmymoney crashes when posting NEW stock purchases if the transaction-date pre-dates the stock's creation date.

https://bugs.kde.org/show_bug.cgi?id=498703 Thomas Baumgart changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution

Re: (tomcat) branch main updated: Improve EL Identifier tests

e0da738a9a Improve EL Identifier tests e0da738a9a is described below commit e0da738a9afbfd85d407bb0b7759f85a5ba087b2 Author: Mark Thomas AuthorDate: Fri Jan 17 17:40:52 2025 + Improve EL Identifier tests Test valid and non-valid characters. Tests can only run on versions of

migration to is-kea (was Re: FAI for Linux on Apple Silicon?)

or the isc-dhcp. You can also use dnsmasq if you like. -- best regards Thomas

[Wikisource-l] Fw: Re: Re: Wikisource reader app

r outreach and visibility, maybe building on OPDS instead of doing something bespoke would allow to reuse even more code? Congrats again, Thomas [1] https://specs.opds.io/ [2] https://en.wikisource.org/wiki/Help:OPDS > > Le vendredi 17 janvier 2025 à 15:37, Magnus Manske > a écri

Re: Trouble with knitr in LyX 2.4.3

Hello JMarc, I found the following system variables (see below). Interestingly the R folders does not show up on any of the three lines. Also, some of the items (Python39) have long been gone, apparently with no ill effect. I also did a search for Rscript.exe (see screenshot below). It shows up

CVS commit: src/doc

Module Name:src Committed By: wiz Date: Fri Jan 17 16:13:25 UTC 2025 Modified Files: src/doc: 3RDPARTY Log Message: doc/3RDPARTY: restore mozilla-rootcerts section To generate a diff of this commit: cvs rdiff -u -r1.2071 -r1.2072 src/doc/3RDPARTY Please note that diffs

CVS commit: src/doc

Module Name:src Committed By: wiz Date: Fri Jan 17 16:13:25 UTC 2025 Modified Files: src/doc: 3RDPARTY Log Message: doc/3RDPARTY: restore mozilla-rootcerts section To generate a diff of this commit: cvs rdiff -u -r1.2071 -r1.2072 src/doc/3RDPARTY Please note that diffs

Re: [pve-devel] [PATCH qemu-server] api: vmlist: add plugged cpu count to vmlist table

Am 17.01.25 um 16:10 schrieb Daniel Kral: > What do you think about fixing the problem from the other side: I could > do a follow up where it's not possible to actively assign a VM more > resources than currently available, since it would not boot anyway? I > think there's a negligible amount of

Re: (tomcat) branch 9.0.x updated: Fix logic issue

On 17/01/2025 14:34, r...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 5b003

Re: [PATCH 1/3 v3] hrtimers: Force migrate away hrtimers queued after CPUHP_AP_HRTIMERS_DYING

On Fri, Jan 17 2025 at 15:11, Frederic Weisbecker wrote: > Le Thu, Jan 16, 2025 at 11:59:48AM +0100, Thomas Gleixner a écrit : >> > + if (enqueue_hrtimer(timer, new_base, mode)) >> > + smp_call_function_single_async(cpu, &new_cpu_base->csd); >>

Re: RFR: 8346123: [REDO] NMT should not use ThreadCritical [v17]

On Fri, 17 Jan 2025 14:37:49 GMT, Robert Toyonaga wrote: >> Robert Toyonaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> revert back to using a flag. > > Thank you everyone for your feedback and time reviewing this! @roberttoyonaga H

Re: Trouble with knitr in LyX 2.4.3

if my problem is an isolated one, or if others have experienced it and resolved it in some way. Sincerely, Tom From: Scott Kostyshak Sent: Friday, January 17, 2025 2:21 AM To: Thomas Philips Cc: lyx-users@lists.lyx.org; Tianqi Wang; 'Stoyan Stoyanov&#x

Re: [Rd] as.data.frame() methods for model objects

profiling to be done... term estimate std.error statisticp.value conf.low conf.high 1 (Intercept) 1.076887 0.1226144 0.6041221 0.54849393 0.8468381 1.369429 2 woolB 1.076887 0.1226144 0.6041221 0.54849393 0.8468381 1.369429 3tensionM 1.248849 0.1501714 1.479790

Re: FAI for Linux on Apple Silicon?

/srv/tftp/grub/ >> # chmod a+r /srv/fai/nfsroot/boot/initrd* > Shouldn't the second command change the copy, not the source of the initrd? Yep, that a fault. Correct is: # chmod a+r /srv/tftp/grub/initrd* -- regards Thomas

Hotfix release for Wicket 10?

Hi all, https://issues.apache.org/jira/browse/WICKET-7140 is quite a serious bug and in my opinion no one should be using Wicket 10.3.0. Should we do a hotfix release 10.3.1 or release 10.4.0 with the small number of changes we have now? Best, Thomas

Re: [pve-devel] [PATCH qemu-server v2 16/18] machine: rename machine_version() function to machine_version_at_least()

Am 17.01.25 um 14:33 schrieb Fiona Ebner: > Am 17.01.25 um 13:39 schrieb Thomas Lamprecht: >> Am 16.01.25 um 12:50 schrieb Fiona Ebner: >>> diff --git a/PVE/QemuServer/Machine.pm b/PVE/QemuServer/Machine.pm >>> index 9b18cf6e..6398e756 100644 >>> --- a/PVE

RE: [RFC] PR81358: Enable automatic linking of libatomic

Hi Prathamesh! On 2025-01-10T04:17:52+, Prathamesh Kulkarni wrote: >> -Original Message- >> From: Thomas Schwinge >> Sent: 07 January 2025 17:45 >> On 2024-12-20T15:37:42+, Prathamesh Kulkarni >> wrote: >> > [...] copying libatomic.a ov

[pve-devel] applied: [PATCH qemu v3 01/18] adapt machine version deprecation for Proxmox VE

Am 17.01.25 um 13:08 schrieb Fiona Ebner: > In commit a35f8577a0 ("include/hw: add macros for deprecation & > removal of versioned machines"), a new machine version deprecation and > removal policy was introduced. After only 3 years a machine version > will be deprecated while being removed after 6

Re: [pve-devel] [PATCH qemu/qemu-server/docs v3 00/18] adapt to changes in QEMU machine version deprecation/removal

Am 17.01.25 um 13:07 schrieb Fiona Ebner: > Changes in v3: > * improve code readibility for Windows machine version fallback change > my v2 review got a bit interrupted so I was to slow before you sent v3. I sent the rest of the stuff I noticed out only now for the v2 thread, but AFAICT it still

Re: [pve-devel] [PATCH docs v2 18/18] qm: machine version: document support in PVE

Am 16.01.25 um 12:50 schrieb Fiona Ebner: > Elaborate on new QEMU machine version removal policy and how PVE will > support machine versions. Make sure to also mention the years, so that > users immediately have a good idea for how long it will be. > > Signed-off-by: Fiona Ebner > --- > > Change

Re: [PATCH] of: address: Unify resource bounds overflow checking

On Fri, Jan 17, 2025 at 12:23:53PM +0530, Basharath Hussain Khaja wrote: > >> >> Thomas Weißschuh writes: > >> >> > The members "start" and "end" of struct resource are of type > >> >> > "resource_size_t" whi

Re: [pve-devel] [PATCH qemu-server v2 16/18] machine: rename machine_version() function to machine_version_at_least()

Am 16.01.25 um 12:50 schrieb Fiona Ebner: > The old name does not make it clear what exactly the function does. > > Signed-off-by: Fiona Ebner > --- > PVE/QemuServer.pm | 4 ++-- > PVE/QemuServer/Machine.pm | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/PVE/

Re: [systemd-devel] Template unit : specifier validity

On 1/17/25 11:20 AM, Tomasz Pala wrote: On Thu, Jan 16, 2025 at 19:29:28 +0100, Thomas HUMMEL wrote: I thought in my case it did not work because journald showed a dependency error but, with systemd on debug mode I could see it was an For the future: if you need to see expanded (%s) and

Re: [VOTE] TomEE Quartz Shade 2.5.0

+1 Am Fr., 17. Jan. 2025 um 13:27 Uhr schrieb Richard Zowalla : > Here is my own +1 (binding) > > > Am 10.01.2025 um 13:04 schrieb Richard Zowalla : > > > > Hi folks, > > > > I have posted a first release candidate for the updated Quartz Shade in > Version 2.5.0 > > > > The SVN repo was migrated

Re: [pve-devel] [PATCH qemu-server v2 03/18] move get_command_for_arch() helper to helpers module

Am 16.01.25 um 12:50 schrieb Fiona Ebner: > diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm > index 72a46a0a..d58bad2b 100644 > --- a/PVE/QemuServer/Helpers.pm > +++ b/PVE/QemuServer/Helpers.pm > @@ -19,6 +19,19 @@ windows_version > > my $nodename = PVE::INotify::nodename(); >

Re: [pve-devel] [PATCH qemu-server v2 04/18] helpers: improve name for variable for mapping arch to binary

Am 16.01.25 um 12:50 schrieb Fiona Ebner: > Signed-off-by: Fiona Ebner > --- > PVE/QemuServer/Helpers.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm > index d58bad2b..be10a92a 100644 > --- a/PVE/QemuServer/Hel

Re: FAI for Linux on Apple Silicon?

d* It' more than a year ago, that I've test this. Please sent me any feeback. I will try to build a FAI-CD for ARM64 in the next days. -- best regards Thomas

Re: [PATCH 0/3] Remove deprecated machines pc-i440fx-2.4 up to pc-i440fx-2.12

On 17/01/2025 12.07, Daniel P. Berrangé wrote: On Fri, Jan 17, 2025 at 11:27:35AM +0100, Thomas Huth wrote: While our new auto-disablement of old machine types will only kick in with the next (v10.1) release, the pc-i440fx-2.* machine types have been explicitly marked as deprecated via our old

Re: [PATCH 0/3] Remove deprecated machines pc-i440fx-2.4 up to pc-i440fx-2.12

On 17/01/2025 12.07, Daniel P. Berrangé wrote: On Fri, Jan 17, 2025 at 11:27:35AM +0100, Thomas Huth wrote: While our new auto-disablement of old machine types will only kick in with the next (v10.1) release, the pc-i440fx-2.* machine types have been explicitly marked as deprecated via our old

Re: [PATCH v4 2/5] drm: adp: Add Apple Display Pipe driver

uot;failed to create crtc"); + return ret; + } + + adp->encoder.possible_crtcs = ALL_CRTCS; + ret = drm_simple_encoder_init(drm, &adp->encoder, DRM_MODE_ENCODER_DSI); Please do not use drm_simple_encoder_init(). It was a bad idea and is deprecated. Open codi

[PATCH 7/8] drm/ast: Merge TX-chip detection code for Gen4 and later

Gens 4 to 6 and Gen7 use the same pattern for detecting the installed TX chips. Merge the code into a single branch. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/ast

[PATCH 3/8] drm/ast: Refactor ast_post_gpu() by Gen

Reorganize ast_post_gpu() so that it first branches by Gen and then by config mode and TX chip. This will later make it possible to split up the function by Gen. The helper ast_init_3rdtx() only handles Gen4 and Gen5, so leave it out from the other Gens. Signed-off-by: Thomas Zimmermann

[PATCH 2/8] drm/ast: Detect DRAM before TX-chip

Move DRAM detection before TX-chip detection. Both steps are independent from each other. Detection of the TX-chip is now next to posting those chips, which can be done in a single step. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 4 +--- 1 file changed, 1 insertion

[PATCH 0/8] drm/ast: Reorganize TX-chip detection and init

. Tested on AST 1100, 2300, 2500 and 2600. Thomas Zimmermann (8): drm/ast: Detect wide-screen support before creating modeset pipeline drm/ast: Detect DRAM before TX-chip drm/ast: Refactor ast_post_gpu() by Gen drm/ast: Initialize ASTDP in ast_post_gpu() drm/ast: Hide Gens 1 to 3 TX detection

[PATCH 4/8] drm/ast: Initialize ASTDP in ast_post_gpu()

errors is questionable behavior. With the refactoring, failing to initialize the ASTDP will also fail probing the driver. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.c | 6 +- drivers/gpu/drm/ast/ast_drv.h | 2 +- drivers/gpu/drm/ast/ast_main.c | 19

[PATCH 5/8] drm/ast: Hide Gens 1 to 3 TX detection in branch

on later generations. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c index 474eb255b325b..50b57bc15d53c 100644

[PATCH 1/8] drm/ast: Detect wide-screen support before creating modeset pipeline

Wide-screen support is relevant for mode validation. Do not detect it before setting up the mode-setting pipeline. Gets the function call out of the way of other initialization code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH 6/8] drm/ast: Align Gen1 DVO detection to register manual

Align variable names and register constants for TX-chip detection to the names in the register manual. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 6 +++--- drivers/gpu/drm/ast/ast_reg.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu

[PATCH 8/8] drm/ast: Only warn about unsupported TX chips on Gen4 and later

Only Gen4 and later read the installed TX chip from the SoC. So only warn on those generations about unsupported chips. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 40 +++--- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a

[PATCH 3/3] tests/qtest/test-x86-cpuid-compat: Replaced the removed pc-i440fx-2.* machines

Since the pc-i440fx-2.* machine types have been removed, let's run the tests with the corresponding q35 machine types instead (until those get removed, too, then we have to remove the tests completely). Signed-off-by: Thomas Huth --- tests/qtest/test-x86-cpuid-compat.c

[PATCH 2/3] hw/i386/pc_piix: Remove pc-i440fx-2.4 up to pc-i440fx-2.12

These machines have explicitly been marked as deprecated in QEMU 9.1, so it should be fine to remove these antique versioned machine types two releases later in 10.0. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 7 --- docs/about/removed-features.rst | 4 +- docs/interop

[PATCH 2/3] hw/i386/pc_piix: Remove pc-i440fx-2.4 up to pc-i440fx-2.12

These machines have explicitly been marked as deprecated in QEMU 9.1, so it should be fine to remove these antique versioned machine types two releases later in 10.0. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 7 --- docs/about/removed-features.rst | 4 +- docs/interop

[PATCH 0/3] Remove deprecated machines pc-i440fx-2.4 up to pc-i440fx-2.12

will still have at least a small benefit of accelerating our CI a little bit (since we don't have to run tests for these old machine types anymore). Thomas Huth (3): tests/qtest/test-x86-cpuid-compat: Remove tests related to pc-i440fx-2.3 hw/i386/pc_piix: Remove pc-i440fx-2.4 up

[PATCH 3/3] tests/qtest/test-x86-cpuid-compat: Replaced the removed pc-i440fx-2.* machines

Since the pc-i440fx-2.* machine types have been removed, let's run the tests with the corresponding q35 machine types instead (until those get removed, too, then we have to remove the tests completely). Signed-off-by: Thomas Huth --- tests/qtest/test-x86-cpuid-compat.c

[PATCH 1/3] tests/qtest/test-x86-cpuid-compat: Remove tests related to pc-i440fx-2.3

The pc-i440fx-2.3 machine type has been removed in commit 46a2bd5257 ("hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine") already, so these tests are just dead code by now. Signed-off-by: Thomas Huth --- tests/qtest/test-x86-cpuid-compat.c | 18 -- 1 file c

[PATCH 1/3] tests/qtest/test-x86-cpuid-compat: Remove tests related to pc-i440fx-2.3

The pc-i440fx-2.3 machine type has been removed in commit 46a2bd5257 ("hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine") already, so these tests are just dead code by now. Signed-off-by: Thomas Huth --- tests/qtest/test-x86-cpuid-compat.c | 18 -- 1 file c

[PATCH 0/3] Remove deprecated machines pc-i440fx-2.4 up to pc-i440fx-2.12

will still have at least a small benefit of accelerating our CI a little bit (since we don't have to run tests for these old machine types anymore). Thomas Huth (3): tests/qtest/test-x86-cpuid-compat: Remove tests related to pc-i440fx-2.3 hw/i386/pc_piix: Remove pc-i440fx-2.4 up

Re: [pve-devel] [PATCH qemu-server v2 12/18] machine: get vm machine: fallback to creation QEMU version for windows starting with 9.1

Am 17.01.25 um 10:27 schrieb Fiona Ebner: > Am 17.01.25 um 10:19 schrieb Thomas Lamprecht: >> But wouldn't the machine version jump from 5.1 to creation-QEMU with your >> change for any VM that was created via CLI/API without explicit machine >> version but with the c

Re: [PATCH 17/21] hw/scsi/vmw_pvscsi: Remove PVSCSI_COMPAT_DISABLE_PCIE_BIT definition

ot;, PVSCSIState, compat_flags, -PVSCSI_COMPAT_DISABLE_PCIE_BIT, false), }; While you're at it, I think this was the last user of compat_flags, so you could remove that compat_flags field from the struct, too, now? Thomas

Re: [PATCH 17/21] hw/scsi/vmw_pvscsi: Remove PVSCSI_COMPAT_DISABLE_PCIE_BIT definition

ot;, PVSCSIState, compat_flags, -PVSCSI_COMPAT_DISABLE_PCIE_BIT, false), }; While you're at it, I think this was the last user of compat_flags, so you could remove that compat_flags field from the struct, too, now? Thomas

Re: [PATCH 17/21] hw/scsi/vmw_pvscsi: Remove PVSCSI_COMPAT_DISABLE_PCIE_BIT definition

vmstate_pci_device, PCIDevice), +VMSTATE_STRUCT(parent_obj, PVSCSIState, 0, + vmstate_pci_device, PCIDevice), I think this is wrong, too. pvscsi_vmstate_test_pci_device() should return false for modern machines, so this should be removed instead? Thomas

Re: [PATCH 17/21] hw/scsi/vmw_pvscsi: Remove PVSCSI_COMPAT_DISABLE_PCIE_BIT definition

vmstate_pci_device, PCIDevice), +VMSTATE_STRUCT(parent_obj, PVSCSIState, 0, + vmstate_pci_device, PCIDevice), I think this is wrong, too. pvscsi_vmstate_test_pci_device() should return false for modern machines, so this should be removed instead? Thomas

Re: [pve-devel] [PATCH qemu-server v2 12/18] machine: get vm machine: fallback to creation QEMU version for windows starting with 9.1

nit, if there will be a v3 I'd adapt the subject to: machine: fallback to creation QEMU version for windows starting with 9.1 The additional tag did not provide much useful additional info IMO and made the subject rather long. Am 16.01.25 um 12:50 schrieb Fiona Ebner: > Starting from QEMU 9.1, p

Re: [PATCH 16/21] hw/scsi/vmw_pvscsi: Remove PVSCSI_COMPAT_OLD_PCI_CONFIGURATION definition

PROP_BIT("x-disable-pcie", PVSCSIState, compat_flags, PVSCSI_COMPAT_DISABLE_PCIE_BIT, false), }; Does this compile? I think you missed a spot that uses PVSCSI_USE_OLD_PCI_CONFIGURATION in pvscsi_realizefn() ? Thomas

Re: [PATCH 16/21] hw/scsi/vmw_pvscsi: Remove PVSCSI_COMPAT_OLD_PCI_CONFIGURATION definition

PROP_BIT("x-disable-pcie", PVSCSIState, compat_flags, PVSCSI_COMPAT_DISABLE_PCIE_BIT, false), }; Does this compile? I think you missed a spot that uses PVSCSI_USE_OLD_PCI_CONFIGURATION in pvscsi_realizefn() ? Thomas

Re: [PATCH 12/21] hw/i386/x86: Remove X86MachineClass::save_tsc_khz field

/i386/x86.c | 1 - target/i386/machine.c | 5 ++--- 3 files changed, 2 insertions(+), 9 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 12/21] hw/i386/x86: Remove X86MachineClass::save_tsc_khz field

/i386/x86.c | 1 - target/i386/machine.c | 5 ++--- 3 files changed, 2 insertions(+), 9 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 10/21] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_DISABLE_PCIE definition

PER_VQ_BIT, VIRTIO_PCI_FLAG_ATS_BIT, VIRTIO_PCI_FLAG_INIT_DEVERR_BIT, I assume it's ok that the other following bits change their value here? If so: Reviewed-by: Thomas Huth

Re: [PATCH 10/21] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_DISABLE_PCIE definition

PER_VQ_BIT, VIRTIO_PCI_FLAG_ATS_BIT, VIRTIO_PCI_FLAG_INIT_DEVERR_BIT, I assume it's ok that the other following bits change their value here? If so: Reviewed-by: Thomas Huth

Re: [PATCH 09/21] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_MIGRATE_EXTRA definition

ing site: static bool virtio_extra_state_needed(void *opaque) { VirtIODevice *vdev = opaque; BusState *qbus = qdev_get_parent_bus(DEVICE(vdev)); VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus); return k->has_extra_state && k->has_extra_state(qbus->parent); } ... this will return now false instead of true, so I think your patch here is wrong? Thomas

Re: [PATCH 09/21] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_MIGRATE_EXTRA definition

ing site: static bool virtio_extra_state_needed(void *opaque) { VirtIODevice *vdev = opaque; BusState *qbus = qdev_get_parent_bus(DEVICE(vdev)); VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus); return k->has_extra_state && k->has_extra_state(qbus->parent); } ... this will return now false instead of true, so I think your patch here is wrong? Thomas

Re: [PATCH 08/21] hw/net/e1000: Remove unused E1000_FLAG_MAC flag

markflag(MAC), -[PTC511] = markflag(MAC),[PTC1023] = markflag(MAC), -[PTC1522] = markflag(MAC),[MPTC]= markflag(MAC), -[BPTC]= markflag(MAC), I think this is wrong. All those registers should still be marked with MAC_ACCESS_FLAG_NEEDED, shouldn't they? Thom

Re: [PATCH 08/21] hw/net/e1000: Remove unused E1000_FLAG_MAC flag

markflag(MAC), -[PTC511] = markflag(MAC),[PTC1023] = markflag(MAC), -[PTC1522] = markflag(MAC),[MPTC]= markflag(MAC), -[BPTC]= markflag(MAC), I think this is wrong. All those registers should still be marked with MAC_ACCESS_FLAG_NEEDED, shouldn't they? Thom

Re: [PATCH 03/21] hw/i386/pc: Remove PCMachineClass::broken_reserved_end field

/i386/pc.c | 13 + 2 files changed, 5 insertions(+), 9 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 03/21] hw/i386/pc: Remove PCMachineClass::broken_reserved_end field

/i386/pc.c | 13 + 2 files changed, 5 insertions(+), 9 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 01/21] hw/i386/pc: Remove unused pc_compat_2_3 declarations

ass_init(ObjectClass *oc, void *data) \ { \ Reviewed-by: Thomas Huth

Re: [PATCH 01/21] hw/i386/pc: Remove unused pc_compat_2_3 declarations

ass_init(ObjectClass *oc, void *data) \ { \ Reviewed-by: Thomas Huth

Re: Trouble passing through backslash in URL path

James, A comment and a question. You are talking about the servlet path here. Path parameters are something different (.../path-segment;path-param-name=path-param-value/...) Which operating system are you using? Mark 16 Jan 2025 15:38:50 James Matlik : Thank you for responding, Chris.

Re: [PATCH-for-10.1 v2 00/13] hw/arm: Remove virt-2.6 up to virt-2.12 machines

On 17/01/2025 09.09, Daniel P. Berrangé wrote: On Fri, Jan 17, 2025 at 07:47:15AM +0100, Thomas Huth wrote: On 16/01/2025 22.13, Philippe Mathieu-Daudé wrote: Hi Peter, On 16/1/25 15:59, Philippe Mathieu-Daudé wrote: The versioned 'virt' machines up to 2.12 been marked as depr

Re: [mailop] FYI: nixspam RBL has shutdown

gle translate seems to do a proper job if you want to read it in English. TLDR in Manuel Schmitt's words; The regulatory frenzy of the EU and the legislator in general was the only reason for this decision. The list is now emptied and they will implement RFC 6471 proposals for shutting it d

Re: [PATCH-for-10.1 v2 00/13] hw/arm: Remove virt-2.6 up to virt-2.12 machines

y (via commit https://gitlab.com/qemu-project/qemu/-/commit/ce80c4fa6ff ), and thus they have been deprecated since two releases already. So it should be fine to remove them now, shouldn't it? Thomas

Re: [emacs-tangents] 2025-01-13 Emacs news

Sacha Chua writes: > * Recursive project search in Emacs (17:57) >> https://www.youtube.com/watch?v=1jBbVUnNbDU Instead of the advising, why not customize xref-show-xrefs-function? Btw there's 'C-x x u' if it's only needed selectively. And it seemed like 'C-x C-SPC' could be used instead of a c

Trouble with knitr in LyX 2.4.3

s just fine for her. Is this a Windows issue, a TeX Live issue (I have installed the complete Tex Live distribution) or something more subtle? Sincerely and with many thanks in advance Thomas Philips -- lyx-users mailing list lyx-users@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-users

[PULL] drm-xe-fixes

Hi Dave, Simona! The hopefully last drm-xe-fixes for 6.13 It's a little bigger than I was hoping for but nothing that really stands out. Thanks, Thomas drm-xe-fixes-2025-01-16: Driver Changes: - Add steering info support for GuC register lists (Jesus Narvaez) - Add means to wait for rese

[PULL] drm-xe-fixes

Hi Dave, Simona! The hopefully last drm-xe-fixes for 6.13 It's a little bigger than I was hoping for but nothing that really stands out. Thanks, Thomas drm-xe-fixes-2025-01-16: Driver Changes: - Add steering info support for GuC register lists (Jesus Narvaez) - Add means to wait for rese

[PULL] drm-xe-fixes

Hi Dave, Simona! The hopefully last drm-xe-fixes for 6.13 It's a little bigger than I was hoping for but nothing that really stands out. Thanks, Thomas drm-xe-fixes-2025-01-16: Driver Changes: - Add steering info support for GuC register lists (Jesus Narvaez) - Add means to wait for rese

Re: [PATCH v2 1/2] qemuxmlconftest: Drop s390-default-cpu-...ccw-virtio-2.7 test cases

On 16/01/2025 12.25, Michal Privoznik wrote: In its upstream commit [1], qemu dropped s390-2.7 machine type, then in commit [2] the s390-2.8 machine type was dropped. But as Thomas Huth pointed out, any machine type that's older than 6 years is subject to removal [3]. This means, any ma

Re: [PATCH-for-10.1 v2 10/13] hw/arm/virt: Remove deprecated virt-2.11 machine

now be removed. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 10 -- 1 file changed, 10 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH-for-10.1 v2 12/13] hw/arm/virt: Remove deprecated virt-2.12 machine

now be removed. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 11 --- 1 file changed, 11 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH-for-10.1 v2 09/13] hw/arm/virt: Remove deprecated virt-2.10 machine

now be removed. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 9 - 1 file changed, 9 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH-for-10.1 v2 06/13] hw/arm/virt: Remove deprecated virt-2.8 machine

now be removed. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 13 - 1 file changed, 13 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH-for-10.1 v2 08/13] hw/arm/virt: Remove deprecated virt-2.9 machine

now be removed. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 7 --- 1 file changed, 7 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH] libfortran: fix conversion of UNSIGNED(kind=16) to decimal in output [PR118406]

lot for finding and fixing this! Best regards Thomas

Re: [PATCH] libfortran: fix conversion of UNSIGNED(kind=16) to decimal in output [PR118406]

lot for finding and fixing this! Best regards Thomas

  1   2   3   4   5   6   7   8   9   10   >