Am 17.01.25 um 14:33 schrieb Fiona Ebner:
> Am 17.01.25 um 13:39 schrieb Thomas Lamprecht:
>> Am 16.01.25 um 12:50 schrieb Fiona Ebner:
>>> diff --git a/PVE/QemuServer/Machine.pm b/PVE/QemuServer/Machine.pm
>>> index 9b18cf6e..6398e756 100644
>>> --- a/PVE/QemuServer/Machine.pm
>>> +++ b/PVE/QemuServer/Machine.pm
>>> @@ -136,7 +136,7 @@ sub extract_version {
>>> return;
>>> }
>>>
>>> -sub machine_version {
>>> +sub machine_version_at_least {
>>
>> maybe use the chance and prefix with is_ to make this even more clear, i.e.
>> is_version_at_least or to be very verbose: is_version_greater_or_equal (no
>> hard feelings there though).
>
> Okay, but I'd rather not drop the "machine" from the function name. We
> have a lot of different versions floating around so even though this is
> already in the machine module, I'd still like to mention it explicitly
> in the function name to reduce potential for accidental re-use for other
> kinds of versions.
Yeah, I actually agree here 100%, that was just an oversight on my side
when writing this.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
