[webkit-changes] [WebKit/WebKit] b446f6: [WPE] WPE Platform: WPEMonitor should return the p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b446f6062ccc15d5911e5260df58882c5fad580e https://github.com/WebKit/WebKit/commit/b446f6062ccc15d5911e5260df58882c5fad580e Author: Carlos Garcia Campos Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebKit/WPEPlatform/wpe/WPEMonitor.cpp M Source/WebKit/WPEPlatform/wpe/drm/WPEMonitorDRM.cpp M Source/WebKit/WPEPlatform/wpe/wayland/WPEMonitorWayland.cpp Log Message: --- [WPE] WPE Platform: WPEMonitor should return the position and size in logical coordinates https://bugs.webkit.org/show_bug.cgi?id=272580 Reviewed by Alejandro G. Castro. Apply the monitor scale when setting the size and position and update the documentation to clarify we use logical coordianates. * Source/WebKit/WPEPlatform/wpe/WPEMonitor.cpp: (wpe_monitor_class_init): * Source/WebKit/WPEPlatform/wpe/drm/WPEMonitorDRM.cpp: (wpeMonitorDRMCreate): * Source/WebKit/WPEPlatform/wpe/wayland/WPEMonitorWayland.cpp: Canonical link: https://commits.webkit.org/277485@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8d7ece: [JHBuild] Upgrade 'libdrm' module to version '2.4....
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8d7eceb1f07dd13e4e2195f14d02fc27489a87a9 https://github.com/WebKit/WebKit/commit/8d7eceb1f07dd13e4e2195f14d02fc27489a87a9 Author: Diego Pino Garcia Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Tools/gtk/jhbuild.modules M Tools/jhbuild/jhbuild-minimal.modules M Tools/wpe/jhbuild.modules Log Message: --- [JHBuild] Upgrade 'libdrm' module to version '2.4.113' https://bugs.webkit.org/show_bug.cgi?id=272518 Reviewed by Carlos Garcia Campos. Changeset '277428@main' makes use of function 'drmGetFormatName', which is only available since libdrm version '2.4.113'. * Tools/gtk/jhbuild.modules: * Tools/jhbuild/jhbuild-minimal.modules: * Tools/wpe/jhbuild.modules: Canonical link: https://commits.webkit.org/277486@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7e1ce4: [Navigation] Throw exceptions in navigation method...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7e1ce4ca4dde839299bd340169b10fdd6cdd6e65 https://github.com/WebKit/WebKit/commit/7e1ce4ca4dde839299bd340169b10fdd6cdd6e65 Author: Rob Buis Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-already-detached-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-detach-in-serialization-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/traverseTo-already-detached-expected.txt M Source/WebCore/bindings/IDLTypes.h M Source/WebCore/bindings/js/JSDOMConvertPromise.h M Source/WebCore/bindings/js/JSDOMPromiseDeferredForward.h M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm M Source/WebCore/bindings/scripts/IDLAttributes.json M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/Navigation.idl Log Message: --- [Navigation] Throw exceptions in navigation methods if in detached state https://bugs.webkit.org/show_bug.cgi?id=269987 Reviewed by Darin Adler. The back/forward/traverseTo implementation needs to check whether the document is fully active and throw an exception if not [1]. Similar rules apply to reload [2] and navigate [3]. To fix the frame/document detachment, add an IDL attribute [BypassDocumentFullyActiveCheck], which ignores the script execution context being suspended and avoids the ASSERT in DOMPromise::promise(). This behaviour matches callPromiseFunction, which simply returns the JSPromise and ignores the script execution context. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#performing-a-navigation-api-traversal (step 5) [2] https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigation-reload (step 5) [3] https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigation-navigate (step 7) * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-already-detached-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-detach-in-serialization-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/traverseTo-already-detached-expected.txt: * Source/WebCore/bindings/IDLTypes.h: * Source/WebCore/bindings/js/JSDOMConvertPromise.h: (WebCore::JSConverter>::convert): * Source/WebCore/bindings/js/JSDOMPromiseDeferredForward.h: * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (GetBaseIDLType): * Source/WebCore/bindings/scripts/IDLAttributes.json: * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::reload): (WebCore::Navigation::navigate): (WebCore::Navigation::performTraversal): (WebCore::Navigation::updateCurrentEntry): * Source/WebCore/page/Navigation.idl: Canonical link: https://commits.webkit.org/277487@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f3b3dd: [GStreamer][WebCodecs] AV1 (with dav1d) decoding f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f3b3ddc4d2361ad0e9c4ba0ab2356254ad4f758f https://github.com/WebKit/WebKit/commit/f3b3ddc4d2361ad0e9c4ba0ab2356254ad4f758f Author: Philippe Normand Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations R LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_av1-expected.txt R LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_av1-expected.txt M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp Log Message: --- [GStreamer][WebCodecs] AV1 (with dav1d) decoding fixes https://bugs.webkit.org/show_bug.cgi?id=272642 Reviewed by Xabier Rodriguez-Calvar. The decoder tests were failing mostly due to incomplete colorimetry handling in dav1ddec, which was fixed upstream. The low-latency decoding test was failing because we were not configuring the decoder to internally use a single thread. The parser was discarding corrupted frames, leading to another test failure, so it was removed from the harnessed pipeline (the decoder rejects corrupted frames already). * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_av1-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_av1-expected.txt: Removed. * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::configureVideoDecoderForHarnessing): * Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp: (WebCore::GStreamerInternalVideoDecoder::GStreamerInternalVideoDecoder): Canonical link: https://commits.webkit.org/277488@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 904f76: [GTK][WPE] Make GLFence usable with ANGLE EGL cont...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 904f76a8f8a60978baef2a1fb255a330e61fbdf2 https://github.com/WebKit/WebKit/commit/904f76a8f8a60978baef2a1fb255a330e61fbdf2 Author: Miguel Gomez Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/egl/GLContext.cpp M Source/WebCore/platform/graphics/egl/GLContext.h M Source/WebCore/platform/graphics/egl/GLFence.cpp Log Message: --- [GTK][WPE] Make GLFence usable with ANGLE EGL contexts https://bugs.webkit.org/show_bug.cgi?id=272581 Reviewed by Carlos Garcia Campos. Adapt GLFence to use only EGL/GL calls so it doesn't require a current GLContext. Also, take advantage of the static methods in GLContext to parse the version and extension strings. * Source/WebCore/platform/graphics/egl/GLContext.cpp: (WebCore::GLContext::versionFromString): (WebCore::GLContext::version): * Source/WebCore/platform/graphics/egl/GLContext.h: * Source/WebCore/platform/graphics/egl/GLFence.cpp: (WebCore::isGLFenceSyncSupported): (WebCore::GLFence::create): Canonical link: https://commits.webkit.org/277489@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ca3c7e: Add myself (Jani Hautakangas) to contributors.json
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ca3c7e1932b68b03559fbfda202b92a9500d7b11 https://github.com/WebKit/WebKit/commit/ca3c7e1932b68b03559fbfda202b92a9500d7b11 Author: Jani Hautakangas Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M metadata/contributors.json Log Message: --- Add myself (Jani Hautakangas) to contributors.json https://bugs.webkit.org/show_bug.cgi?id=272658 Reviewed by Carlos Garcia Campos. * metadata/contributors.json: Canonical link: https://commits.webkit.org/277490@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c482c9: [WGSL] shader, validation, shader_io, id:* is failing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c482c958a01575be223137f2235c82ce9884770a https://github.com/WebKit/WebKit/commit/c482c958a01575be223137f2235c82ce9884770a Author: Tadeu Zagallo Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: A LayoutTests/http/tests/webgpu/webgpu/shader/validation/decl/override-expected.txt A LayoutTests/http/tests/webgpu/webgpu/shader/validation/shader_io/id-expected.txt M Source/WebGPU/WGSL/AttributeValidator.cpp Log Message: --- [WGSL] shader,validation,shader_io,id:* is failing https://bugs.webkit.org/show_bug.cgi?id=272536 rdar://126286458 Reviewed by Mike Wyrzykowski. The id attribute validation was missing the upper bound check. * LayoutTests/http/tests/webgpu/webgpu/shader/validation/decl/override-expected.txt: Added. * LayoutTests/http/tests/webgpu/webgpu/shader/validation/shader_io/id-expected.txt: Added. * Source/WebGPU/WGSL/AttributeValidator.cpp: (WGSL::AttributeValidator::visit): Canonical link: https://commits.webkit.org/277492@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9c724a: [WebGPU] Update CTS tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9c724a5a370ceefab8cfa944920c4f800d0a08c9 https://github.com/WebKit/WebKit/commit/9c724a5a370ceefab8cfa944920c4f800d0a08c9 Author: Tadeu Zagallo Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M LayoutTests/http/tests/webgpu/common/framework/fixture.js M LayoutTests/http/tests/webgpu/common/framework/test_config.js M LayoutTests/http/tests/webgpu/common/internal/logging/log_message.js M LayoutTests/http/tests/webgpu/common/internal/logging/logger.js M LayoutTests/http/tests/webgpu/common/internal/logging/result.js M LayoutTests/http/tests/webgpu/common/internal/logging/test_case_recorder.js M LayoutTests/http/tests/webgpu/common/internal/query/query.js M LayoutTests/http/tests/webgpu/common/internal/test_group.js M LayoutTests/http/tests/webgpu/common/internal/version.js M LayoutTests/http/tests/webgpu/common/internal/websocket_logger.js M LayoutTests/http/tests/webgpu/common/runtime/helper/options.js M LayoutTests/http/tests/webgpu/common/runtime/helper/test_worker-worker.js M LayoutTests/http/tests/webgpu/common/runtime/helper/test_worker.js M LayoutTests/http/tests/webgpu/common/runtime/helper/utils_worker.js M LayoutTests/http/tests/webgpu/common/runtime/helper/wrap_for_worker.js M LayoutTests/http/tests/webgpu/common/runtime/wpt.js M LayoutTests/http/tests/webgpu/common/util/util.js M LayoutTests/http/tests/webgpu/cts-chunked2sec.https.html M LayoutTests/http/tests/webgpu/cts.https.html M LayoutTests/http/tests/webgpu/external/petamoriken/float16/float16.d.js M LayoutTests/http/tests/webgpu/external/petamoriken/float16/float16.d.js.map M LayoutTests/http/tests/webgpu/external/petamoriken/float16/float16.js M LayoutTests/http/tests/webgpu/external/petamoriken/float16/float16.js.map M LayoutTests/http/tests/webgpu/resources/README.md M LayoutTests/http/tests/webgpu/resources/cache/hashes.json M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/acos.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/acosh.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/asin.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/asinh.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/atan.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/atan2.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/atanh.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/binary/af_addition.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/binary/af_matrix_addition.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/binary/f16_division.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/bitcast.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/ceil.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/cos.bin A LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/derivatives.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/distance.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/exp.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/exp2.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/floor.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/fract.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/frexp.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/inverseSqrt.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/ldexp.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/length.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/log.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/log2.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/normalize.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/pow.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/saturate.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/sin.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/sqrt.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/step.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/tan.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/tanh.bin M LayoutTests/http/tests/webgpu/resources/cac
[webkit-changes] [WebKit/WebKit] fea3b3: Support willReadFrequently for CanvasRenderingCont...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fea3b372b1651a492a3a7f314b3120b5da15518b https://github.com/WebKit/WebKit/commit/fea3b372b1651a492a3a7f314b3120b5da15518b Author: Carlos Garcia Campos Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/fast/canvas/canvas-will-read-frequently-expected.txt A LayoutTests/fast/canvas/canvas-will-read-frequently.html M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d-getcontext-options.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d-getcontext-options.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d-getcontext-options-expected.txt M LayoutTests/inspector/canvas/recording-2d-frameCount-expected.txt M LayoutTests/inspector/canvas/recording-2d-full-expected.txt M LayoutTests/inspector/canvas/recording-2d-memoryLimit-expected.txt M LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-frameCount-expected.txt M LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-full-expected.txt M LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-memoryLimit-expected.txt M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/gtk/inspector/canvas/context-attributes-expected.txt A PerformanceTests/Canvas/getImageDataCPU.html A PerformanceTests/Canvas/getImageDataGPU.html M Source/JavaScriptCore/inspector/protocol/Canvas.json M Source/WebCore/html/CanvasBase.cpp M Source/WebCore/html/canvas/CanvasRenderingContext.cpp M Source/WebCore/html/canvas/CanvasRenderingContext.h M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h M Source/WebCore/html/canvas/CanvasRenderingContext2DSettings.h M Source/WebCore/html/canvas/CanvasRenderingContext2DSettings.idl M Source/WebCore/inspector/InspectorCanvas.cpp Log Message: --- Support willReadFrequently for CanvasRenderingContext2D https://bugs.webkit.org/show_bug.cgi?id=244117 Reviewed by Darin Adler. It's used to indicate there will be frequent get image data operations, in which case an accelerated canvas can be slower than unaccelerated one. This patch turns off hardware acceleration for the 2D canvas when willReadFrequently is true in settings. See https://html.spec.whatwg.org/multipage/canvas.html#concept-canvas-will-read-frequently Test: fast/canvas/canvas-will-read-frequently.html * LayoutTests/TestExpectations: Skip the test in all platforms. * LayoutTests/fast/canvas/canvas-will-read-frequently-expected.txt: Added. * LayoutTests/fast/canvas/canvas-will-read-frequently.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d-getcontext-options.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d-getcontext-options.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d-getcontext-options-expected.txt: * LayoutTests/inspector/canvas/recording-2d-frameCount-expected.txt: * LayoutTests/inspector/canvas/recording-2d-full-expected.txt: * LayoutTests/inspector/canvas/recording-2d-memoryLimit-expected.txt: * LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-frameCount-expected.txt: * LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-full-expected.txt: * LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-memoryLimit-expected.txt: * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/gtk/inspector/canvas/context-attributes-expected.txt: * PerformanceTests/Canvas/getImageDataCPU.html: Added. * PerformanceTests/Canvas/getImageDataGPU.html: Added. * Source/JavaScriptCore/inspector/protocol/Canvas.json: * Source/WebCore/html/CanvasBase.cpp: (WebCore::CanvasBase::allocateImageBuffer const): * Source/WebCore/html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::willReadFrequently const): * Source/WebCore/html/canvas/CanvasRenderingContext.h: * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::willReadFrequently const): * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h: * Source/WebCore/html/canvas/CanvasRenderingContext2DSettings.h: * Source/WebCore/html/canvas/CanvasRenderingContext2DSettings.idl: * Source/WebCore/inspector/InspectorCanvas.cpp: (WebCore::buildObjectForCanvasContextAttributes): Canonical link: https://commits.webkit.org/277494@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.
[webkit-changes] [WebKit/WebKit] 930c92: [GTK][WPE] Sync WebGL content with fences when ava...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 930c92835e20e92630212bd77890bd5bd7d7ae9d https://github.com/WebKit/WebKit/commit/930c92835e20e92630212bd77890bd5bd7d7ae9d Author: Miguel Gomez Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp M Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.h M Source/WebCore/platform/graphics/nicosia/NicosiaGCGLANGLELayer.cpp M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h M Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.cpp M Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h M Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp M Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.h Log Message: --- [GTK][WPE] Sync WebGL content with fences when available https://bugs.webkit.org/show_bug.cgi?id=272663 Reviewed by Carlos Garcia Campos. Create a fence for each WebGL frame that's generated. The fence is passed together with the buffer through the proxy to the compositor. During the composition, before painting the buffer there's a wait for the fence to ensure that the WebGL is finished. * Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp: (WebCore::GraphicsContextGLGBM::prepareForDisplay): * Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.h: * Source/WebCore/platform/graphics/nicosia/NicosiaGCGLANGLELayer.cpp: (Nicosia::GCGLANGLELayer::swapBuffersIfNeeded): * Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp: (WebCore::GraphicsContextGLTextureMapperANGLE::prepareForDisplay): * Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h: * Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.cpp: (WebCore::TextureMapperPlatformLayerBuffer::paintToTextureMapper): * Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h: (WebCore::TextureMapperPlatformLayerBuffer::setFence): * Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp: (WebCore::TextureMapperPlatformLayerProxyDMABuf::DMABufLayer::paintToTextureMapper): * Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.h: Canonical link: https://commits.webkit.org/277495@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c0cc4c: [Skia] Add support for non-accelerated offscreen c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c0cc4c7874ba0bbea8c59af39f378f10b1aa62d6 https://github.com/WebKit/WebKit/commit/c0cc4c7874ba0bbea8c59af39f378f10b1aa62d6 Author: Carlos Garcia Campos Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebCore/html/CanvasBase.cpp M Source/WebCore/platform/graphics/nicosia/NicosiaImageBufferPipe.cpp Log Message: --- [Skia] Add support for non-accelerated offscreen canvas https://bugs.webkit.org/show_bug.cgi?id=272664 Reviewed by Miguel Gomez. Accelerated offscreen canvas requires more work to support different skia GL contexts per thread, so fo nor we can use non-accelerated canvas to make offscreen canvas work. * Source/WebCore/html/CanvasBase.cpp: (WebCore::CanvasBase::shouldAccelerate const): * Source/WebCore/platform/graphics/nicosia/NicosiaImageBufferPipe.cpp: (Nicosia::NicosiaImageBufferPipeSource::handle): Canonical link: https://commits.webkit.org/277496@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e4f6b0: Reformat ApplePayModifier-disbursementPaymentReque...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e4f6b08021ef8934c105eb356aafb8efee70190d https://github.com/WebKit/WebKit/commit/e4f6b08021ef8934c105eb356aafb8efee70190d Author: Robin Malhotra Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https.html Log Message: --- Reformat ApplePayModifier-disbursementPaymentRequest.https.html https://bugs.webkit.org/show_bug.cgi?id=272649 rdar://126446654 Reviewed by Abrar Rahman Protyasha. Just ran a formatter * LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https.html: Canonical link: https://commits.webkit.org/277497@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bffda8: [WebGPU] shader, execution, expression, binary, ai_ari...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bffda80ff3ade29d8e40f3615d3e5d4e9c549135 https://github.com/WebKit/WebKit/commit/bffda80ff3ade29d8e40f3615d3e5d4e9c549135 Author: Tadeu Zagallo Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: A LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/ai_arithmetic-expected.txt A LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/ai_comparison-expected.txt A LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/bitcast-expected.txt A LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/ai_arithmetic-expected.txt A LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/ai_assignment-expected.txt A LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/ai_complement-expected.txt M Source/WebGPU/WGSL/ConstantFunctions.h M Source/WebGPU/WGSL/Lexer.cpp M Source/WebGPU/WGSL/Lexer.h M Source/WebGPU/WGSL/Parser.cpp M Source/WebGPU/WGSL/Token.h M Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp Log Message: --- [WebGPU] shader,execution,expression,binary,ai_arithmetic:addition_scalar_vector:* appears to hang https://bugs.webkit.org/show_bug.cgi?id=272574 rdar://126331501 Reviewed by Mike Wyrzykowski. There 2 bugs in this test: - the constant shift left builtin incorrectly reported an overflow on abstract integers due to using a 32 bit value for the mask it uses to validate - the lexer used a double to represent all literal values, which can not represent all 64-bit integers All of the new abstract integer CTS tests are now passing. I also added the expectations for the bitcast test which includes some cases for abstract integers. * LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/ai_arithmetic-expected.txt: Added. * LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/ai_comparison-expected.txt: Added. * LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/bitcast-expected.txt: Added. * LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/ai_arithmetic-expected.txt: Added. * LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/ai_assignment-expected.txt: Added. * LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/ai_complement-expected.txt: Added. * Source/WebGPU/WGSL/ConstantFunctions.h: (WGSL::CONSTANT_FUNCTION): * Source/WebGPU/WGSL/Lexer.cpp: (WGSL::Lexer::lexNumber): * Source/WebGPU/WGSL/Lexer.h: (WGSL::Lexer::makeFloatToken): (WGSL::Lexer::makeIntegerToken): (WGSL::Lexer::makeLiteralToken): Deleted. * Source/WebGPU/WGSL/Parser.cpp: (WGSL::Parser::parsePrimaryExpression): * Source/WebGPU/WGSL/Token.h: (WGSL::Token::Token): (WGSL::Token::operator=): * Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp: (TestWGSLAPI::checkSingleIntegerLiteral): (TestWGSLAPI::checkSingleFloatLiteral): (TestWGSLAPI::checkNextTokenIsIntegerLiteral): (TestWGSLAPI::checkNextTokenIsFloatLiteral): (TestWGSLAPI::TEST(WGSLLexerTests, SingleTokens)): (TestWGSLAPI::TEST(WGSLLexerTests, ComputeShader)): (TestWGSLAPI::TEST(WGSLLexerTests, GraphicsShader)): (TestWGSLAPI::TEST(WGSLLexerTests, TriangleVert)): (TestWGSLAPI::checkSingleLiteral): Deleted. (TestWGSLAPI::checkNextTokenIsLiteral): Deleted. Canonical link: https://commits.webkit.org/277498@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 897c8c: Updated Swedish translation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 897c8cea2788fcf23fc0da6b4b9d4b987f984398 https://github.com/WebKit/WebKit/commit/897c8cea2788fcf23fc0da6b4b9d4b987f984398 Author: Michael Catanzaro Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebCore/platform/gtk/po/sv.po Log Message: --- Updated Swedish translation https://bugs.webkit.org/show_bug.cgi?id=272303 Unreviewed translation update. * Source/WebCore/platform/gtk/po/sv.po: Canonical link: https://commits.webkit.org/277499@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 040cad: REGRESSION(272180@main): Crash in CSSCalcOperation...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 040cadd0e752cb1b5b307278fbd635097c729efd https://github.com/WebKit/WebKit/commit/040cadd0e752cb1b5b307278fbd635097c729efd Author: Antti Koivisto Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-computed.html M Source/WebCore/css/BasicShapeFunctions.cpp M Source/WebCore/platform/Length.cpp M Source/WebCore/platform/Length.h Log Message: --- REGRESSION(272180@main): Crash in CSSCalcOperationNode::simplifyRecursive with xywh() and rect() clip-paths https://bugs.webkit.org/show_bug.cgi?id=270296 rdar://123508905 Reviewed by Darin Adler. Clip path serialization produces inset() values which requires constructing calc expressions if the original values are not insets. The code for this didn't work correctly if the values were calc expressions thenselves. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-computed-expected.txt: The results are correct though FAILs because they are not maximally simplified. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-computed.html: Update from the WPT repo. * Source/WebCore/css/BasicShapeFunctions.cpp: Use the existing convertTo100PercentMinusLength instead of trying to do this manually. (WebCore::valueForBasicShape): * Source/WebCore/platform/Length.cpp: (WebCore::convertTo100PercentMinusLengthSum): Add a separate dual-argument version. This is needed so we can do some manual simplification (see the comment). * Source/WebCore/platform/Length.h: Canonical link: https://commits.webkit.org/277500@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 21426d: REGRESSION(271848@main): "Watch later" checkbox on...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 21426dee35a1783145f695ceed7defb1d464652e https://github.com/WebKit/WebKit/commit/21426dee35a1783145f695ceed7defb1d464652e Author: Antti Koivisto Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: A LayoutTests/fast/block/positioning/simple-out-of-flow-percent-height-expected.html A LayoutTests/fast/block/positioning/simple-out-of-flow-percent-height.html M Source/WebCore/rendering/RenderBlockFlow.cpp Log Message: --- REGRESSION(271848@main): "Watch later" checkbox on youtube.com mis-renders https://bugs.webkit.org/show_bug.cgi?id=272665 rdar://125644808 Reviewed by Alan Baradlay. Percent height out-of-flow positioned boxes taking the fast path may end up with miscomputed height. * LayoutTests/fast/block/positioning/simple-out-of-flow-percent-height-expected.html: Added. * LayoutTests/fast/block/positioning/simple-out-of-flow-percent-height.html: Added. * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::layoutModernLines): Disable the out-of-flow fast path if there are percent height boxes. The problem is that the fast path does a synchronous layout for these boxes before the height of the parent is computed. The synchronous layout itself is a workaround but fixing it may be more complicated. Canonical link: https://commits.webkit.org/277501@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 866b41: [Remote Inspection] Tune viewport area ratio size ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 866b410bceb84beb179dff08a712f1c00c962ecd https://github.com/WebKit/WebKit/commit/866b410bceb84beb179dff08a712f1c00c962ecd Author: Wenson Hsieh Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebCore/page/ElementTargetingController.cpp M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm A Tools/TestWebKitAPI/Tests/WebKitCocoa/element-targeting-6.html Log Message: --- [Remote Inspection] Tune viewport area ratio size thresholds to be less restrictive on mobile sites https://bugs.webkit.org/show_bug.cgi?id=272654 rdar://126271452 Reviewed by Abrar Rahman Protyasha. Currently, the constants used to identify absolutely-positioned or in-flow candidates when finding targets have been (for the most part) tested against desktop content on macOS. However, these thresholds are slightly too restrictive on mobile, where potential targets tend to fill a larger portion of the viewport. To account for this, this patch turns the 5 constant values below into linearly-interpolated values, depending on the viewport area. At roughly desktop-class viewport areas, these are equivalent to their current values; on mobile, these are tuned to be relatively larger. ``` Form FactorArea Max AbsPos Max In-FlowMin In-FlowMax NearbyMax Adj. Area --- Desktop80 0.750 0.500 0.005 0.250 0.250 Mobile 20 1.000 1.000 0.010 0.500 0.300 ``` * Source/WebCore/page/ElementTargetingController.cpp: (WebCore::linearlyInterpolatedViewportRatio): (WebCore::maximumAreaRatioForAbsolutelyPositionedContent): (WebCore::maximumAreaRatioForInFlowContent): (WebCore::maximumAreaRatioForNearbyTargets): (WebCore::minimumAreaRatioForInFlowContent): (WebCore::maximumAreaRatioForTrackingAdjustmentAreas): Turn all of these hard-coded constants into helper functions that take the current viewport size as input, and return linearly-interpolated values, clamped to the given minimum/maximum values. (WebCore::inflatedClientRectForAdjustmentRegionTracking): (WebCore::ElementTargetingController::findTargets): Make an additional adjustment: treat candidates with no children as targets, even if they're above size thresholds. * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm: (-[WKWebView expectSingleTargetedSelector:at:]): Pull this testing helper out of `ElementTargeting.ParentRelativeSelectors` and into a helper method in a testing category on `TestWKWebView`, so that we can use it from both of the below tests. (TestWebKitAPI::TEST(ElementTargeting, ParentRelativeSelectors)): (TestWebKitAPI::TEST(ElementTargeting, TargetInFlowElements)): * Tools/TestWebKitAPI/Tests/WebKitCocoa/element-targeting-6.html: Added. Canonical link: https://commits.webkit.org/277502@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 626da6: [WebGPU] https://playcanvas.github.io/#/misc/spine...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 626da617fd7b0bf6cdefde971c4e594f52e65bf4 https://github.com/WebKit/WebKit/commit/626da617fd7b0bf6cdefde971c4e594f52e65bf4 Author: Mike Wyrzykowski Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp Log Message: --- [WebGPU] https://playcanvas.github.io/#/misc/spineboy fails because sampler is not compatible with sampler_comparison https://bugs.webkit.org/show_bug.cgi?id=272599 Reviewed by Dan Glastonbury. We are only supposed to validate BindGroupLayout compatibility with 'statically used' variables in the WGSL source, not all of the variables which exist. In this case, PlayCanvas has a mismatch, but they don't use the variable in the shader, so it shouldn't be a validation error. * Source/WebGPU/WGSL/GlobalVariableRewriter.cpp: (WGSL::RewriteGlobalVariables::insertStructs): Canonical link: https://commits.webkit.org/277503@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 220970: [Gardening]: [ MacOS x86_64 ] imported/w3c/web-pla...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 220970a1dc93d09ab4982a925d207a31b7403323 https://github.com/WebKit/WebKit/commit/220970a1dc93d09ab4982a925d207a31b7403323 Author: Jay Stfleur Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: [ MacOS x86_64 ] imported/w3c/web-platform-tests/svg/painting/reftests/percentage-attribute.svg is a consistent image failure https://bugs.webkit.org/show_bug.cgi?id=126489323 rdar://126489323 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/277504@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 453783: Expand use of WKBundlePagePostMessageWithAsyncRepl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 453783344f766c0d7498541a692c0e9a1951f5fc https://github.com/WebKit/WebKit/commit/453783344f766c0d7498541a692c0e9a1951f5fc Author: Alex Christensen Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h M Tools/WebKitTestRunner/TestController.cpp M Tools/WebKitTestRunner/TestController.h M Tools/WebKitTestRunner/TestInvocation.cpp M Tools/WebKitTestRunner/TestInvocation.h M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm Log Message: --- Expand use of WKBundlePagePostMessageWithAsyncReply in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=272593 rdar://126361971 Reviewed by Sihui Liu and Charlie Wolfe. This makes tests work better with site isolation because the reply is sent to the process that made the request, instead of always sending the reply to the main frame's process. Most of this PR is just plumbing to get the call in the UI process, get the reply, send it to the web process, and process it into a form that JS can receive in the web process. I also reduced duplicate implementations of TestController::getAllStorageAccessEntries. I verified this works correctly by running the 1 test that uses getAllStorageAccessEntries: http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): (WTR::asyncReplyHandler): (WTR::postMessageWithAsyncReply): * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h: * Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::stringArrayToJS): (WTR::TestRunner::getAllStorageAccessEntries): (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback): Deleted. * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h: * Tools/WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPlatformWebView): (WTR::TestController::createWebViewWithOptions): (WTR::TestController::didReceiveAsyncMessageFromInjectedBundle): (WTR::getAllStorageAccessEntriesCallback): (WTR::TestController::getAllStorageAccessEntries): (WTR::GetAllStorageAccessEntriesCallbackContext::GetAllStorageAccessEntriesCallbackContext): Deleted. * Tools/WebKitTestRunner/TestController.h: * Tools/WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): (WTR::TestInvocation::didReceiveAllStorageAccessEntries): Deleted. * Tools/WebKitTestRunner/TestInvocation.h: * Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::getAllStorageAccessEntries): Deleted. Canonical link: https://commits.webkit.org/277505@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cfa9ad: [GTK][WPE] Unreviewed build fix for Ubuntu 20.04 a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cfa9adfee2d5bbbc00179f3e783b08668e129846 https://github.com/WebKit/WebKit/commit/cfa9adfee2d5bbbc00179f3e783b08668e129846 Author: Vitaly Dyachkov Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake Log Message: --- [GTK][WPE] Unreviewed build fix for Ubuntu 20.04 after 277428@main `drmGetFormatName()` was added to `libdrm` in version 2.4.113. The latest version available in Ubuntu 20.04 repos is 2.4.107. * Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp: (WebKit::renderBufferFormat): * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: Canonical link: https://commits.webkit.org/277506@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 08a6dd: [Gardening]: REGRESSION (277328@main): [ MacOS WK1...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 08a6dd7d8007f30396ac789f7b95008d62e8a535 https://github.com/WebKit/WebKit/commit/08a6dd7d8007f30396ac789f7b95008d62e8a535 Author: Jay Stfleur Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [Gardening]: REGRESSION (277328@main): [ MacOS WK1 ] fast/canvas/offscreen-nested-worker-serialization.html is a constant timeout https://bugs.webkit.org/show_bug.cgi?id=126461671 rdar://126461671 Unreviewed test gardening. Updating test expectation to skip test. * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/277507@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5ec5a2: Adopt std::span in more places
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5ec5a2c519e1e62d602d432ad243edf1641bd920 https://github.com/WebKit/WebKit/commit/5ec5a2c519e1e62d602d432ad243edf1641bd920 Author: Chris Dumez Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/JavaScriptCore/API/JSValueRef.cpp M Source/JavaScriptCore/API/glib/JSCValue.cpp M Source/JavaScriptCore/interpreter/Interpreter.cpp M Source/JavaScriptCore/runtime/ISO8601.cpp M Source/JavaScriptCore/runtime/Identifier.h M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp M Source/JavaScriptCore/runtime/JSONObject.cpp M Source/JavaScriptCore/runtime/LiteralParser.h M Source/JavaScriptCore/runtime/ParseInt.h M Source/WebCore/css/parser/CSSParserFastPaths.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/html/parser/HTMLSrcsetParser.cpp M Source/WebCore/html/parser/ParsingUtilities.h Log Message: --- Adopt std::span in more places https://bugs.webkit.org/show_bug.cgi?id=272656 Reviewed by Darin Adler. * Source/JavaScriptCore/API/JSValueRef.cpp: (JSValueMakeFromJSONString): * Source/JavaScriptCore/interpreter/Interpreter.cpp: (JSC::eval): (JSC::Interpreter::executeProgram): * Source/JavaScriptCore/runtime/ISO8601.cpp: (JSC::ISO8601::parseDecimalInt32): (JSC::ISO8601::handleFraction): (JSC::ISO8601::parseTimeSpec): (JSC::ISO8601::parseDate): * Source/JavaScriptCore/runtime/Identifier.h: (JSC::parseIndex): * Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp: (JSC::isInfinity): (JSC::jsBinaryIntegerLiteral): (JSC::jsOctalIntegerLiteral): (JSC::jsHexIntegerLiteral): (JSC::jsStrDecimalLiteral): (JSC::toDouble): (JSC::jsToNumber): (JSC::parseFloat): (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/JSONObject.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): (JSC::JSONParse): (JSC::JSONParseWithException): * Source/JavaScriptCore/runtime/LiteralParser.h: (JSC::LiteralParser::LiteralParser): (JSC::LiteralParser::Lexer::Lexer): * Source/WebCore/css/parser/CSSParserFastPaths.cpp: (WebCore::transformCanLikelyUseFastPath): (WebCore::parseSimpleTransformList): (WebCore::parseSimpleTransform): * Source/WebCore/dom/Document.cpp: (WebCore::isValidNameNonASCII): (WebCore::isValidNameASCII): (WebCore::Document::isValidName): * Source/WebCore/html/parser/HTMLSrcsetParser.cpp: (WebCore::appendDescriptorAndReset): (WebCore::parseImageCandidatesFromSrcsetAttribute): Canonical link: https://commits.webkit.org/277508@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3c2c89: WebKit process termination with xpc_connection_kil...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3c2c899f692d5278142b9c476868672da9ae8e04 https://github.com/WebKit/WebKit/commit/3c2c899f692d5278142b9c476868672da9ae8e04 Author: Per Arne Vollan Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebKit/Platform/cocoa/XPCUtilities.h M Source/WebKit/Platform/cocoa/XPCUtilities.mm M Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm M Source/WebKit/Shared/Cocoa/XPCEndpoint.mm M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm Log Message: --- WebKit process termination with xpc_connection_kill does not always work https://bugs.webkit.org/show_bug.cgi?id=272669 rdar://126479653 Reviewed by Chris Dumez. WebKit process termination with xpc_connection_kill does not always work. We are currently seeing flaky termination behavior on macOS, where the child processes are not always terminated successfully. Additionally, on iOS, the XPC connection has become anonymous due to migration to extensions for WebKit processes, and xpc_connection_kill does not support anonymous connections. This patch addresses this issue by creating and sending a XPC message to the child process to request termination. This has a high chance of success, since we know that the XPC connection termination watchdog is holding a background assertion on the process, so it is not suspended. Additionally, the XPC message is being handled on the XPC event handler thread, which is handling very few messages, so it is very unlikely that it is blocked and cannot handle the message. This gives the process a chance to exit cleanly and send a reply back. If the UI process does not receive the expected reply, it will try calling xpc_connection_kill. * Source/WebKit/Platform/cocoa/XPCUtilities.h: * Source/WebKit/Platform/cocoa/XPCUtilities.mm: (WebKit::terminateWithReason): (WebKit::handleXPCExitMessage): * Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm: (WebKit::AuthenticationManager::initializeConnection): * Source/WebKit/Shared/Cocoa/XPCEndpoint.mm: (WebKit::XPCEndpoint::XPCEndpoint): * Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm: (WebKit::XPCServiceEventHandler): Canonical link: https://commits.webkit.org/277509@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bbd3a8: [Unified PDF] Data Detectors are offset from detec...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bbd3a8dd40bdb2cbbe6d8f20cf98bf18ee430619 https://github.com/WebKit/WebKit/commit/bbd3a8dd40bdb2cbbe6d8f20cf98bf18ee430619 Author: Aditya Keerthi Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [Unified PDF] Data Detectors are offset from detected items on embedded PDFs https://bugs.webkit.org/show_bug.cgi?id=272684 rdar://126232906 Reviewed by Abrar Rahman Protyasha. 276131@main added support for Data Detectors for Unified PDF. However, the geometry used for highlights was using the plugin's coordinate space. This is incorrect for embedded PDFs, as the `PageOverlay` uses `OverlayType::Document`. Fix by ensuring all highlight geometry uses the main frame's contents coordinate space. * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: (WebKit::PDFPluginBase::lastKnownMousePositionInView const): (WebKit::PDFPluginBase::mousePositionInView const): Deleted. Revert the change made in 276131@main, as this method now has a single use, inside the same class. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm: (WebKit::PDFDataDetectorOverlayController::createPlatformDataDetectorHighlight const): (WebKit::PDFDataDetectorOverlayController::handleMouseEvent): (WebKit::PDFDataDetectorOverlayController::handleDataDetectorAction): Click information should be in the window's coordinate space. (WebKit::PDFDataDetectorOverlayController::didInvalidateHighlightOverlayRects): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::mainFrameView const): Expose the main frame's `FrameView`, so that the overlay controller can get the `visibleContentRect`, and convert between coordinate spaces. (WebKit::UnifiedPDFPlugin::rectForSelectionInMainFrameContentsSpace const): Similar to `ServicesOverlayController`, the only way to convert to document coordinates is to call `contentsToWindow` and then `windowToContents`. (WebKit::UnifiedPDFPlugin::rectForSelectionInPluginSpace const): Deleted. Canonical link: https://commits.webkit.org/277510@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8d67eb: Unreviewed CLoop build fix
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8d67ebc14bf4e30058763fe654172a82deb74aa1 https://github.com/WebKit/WebKit/commit/8d67ebc14bf4e30058763fe654172a82deb74aa1 Author: Justin Michaud Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WTF/wtf/PlatformEnable.h Log Message: --- Unreviewed CLoop build fix https://bugs.webkit.org/show_bug.cgi?id=272701 rdar://126506006 Unreviewed build fix. * Source/WTF/wtf/PlatformEnable.h: Canonical link: https://commits.webkit.org/277511@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 40f801: sequence should map to Ref, not RefPtr
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40f8011866933c1c5c07169d4fe5ef141ed18a1c https://github.com/WebKit/WebKit/commit/40f8011866933c1c5c07169d4fe5ef141ed18a1c Author: Sam Weinig Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebCore/Modules/WebGPU/GPUPipelineLayoutDescriptor.h M Source/WebCore/Modules/WebGPU/GPUQueue.cpp M Source/WebCore/Modules/WebGPU/GPUQueue.h M Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.cpp M Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.h M Source/WebCore/Modules/applepay/ApplePayCouponCodeUpdate.h M Source/WebCore/Modules/applepay/ApplePayPaymentAuthorizationResult.h M Source/WebCore/Modules/applepay/ApplePayPaymentMethodUpdate.h M Source/WebCore/Modules/applepay/ApplePaySetup.cpp M Source/WebCore/Modules/applepay/ApplePaySetupWebCore.h M Source/WebCore/Modules/applepay/ApplePayShippingContactUpdate.h M Source/WebCore/Modules/applepay/PaymentCoordinator.cpp M Source/WebCore/Modules/applepay/PaymentCoordinator.h M Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h M Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp M Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.h M Source/WebCore/Modules/async-clipboard/Clipboard.cpp M Source/WebCore/Modules/async-clipboard/Clipboard.h M Source/WebCore/Modules/gamepad/Navigator+Gamepad.idl M Source/WebCore/Modules/mediasession/MediaSession.cpp M Source/WebCore/Modules/mediasession/MediaSession.h M Source/WebCore/Modules/mediastream/MediaStream.cpp M Source/WebCore/Modules/mediastream/MediaStream.h M Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp M Source/WebCore/Modules/mediastream/PeerConnectionBackend.h M Source/WebCore/Modules/mediastream/RTCConfiguration.h M Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp M Source/WebCore/Modules/mediastream/RTCPeerConnection.h M Source/WebCore/Modules/mediastream/RTCRtpScriptTransform.cpp M Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp M Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.h M Source/WebCore/Modules/mediastream/RTCTrackEvent.cpp M Source/WebCore/Modules/mediastream/RTCTrackEvent.h M Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp M Source/WebCore/Modules/notifications/Notification.cpp M Source/WebCore/Modules/webxr/WebXRFrame.cpp M Source/WebCore/Modules/webxr/WebXRFrame.h M Source/WebCore/Modules/webxr/WebXRInputSourceArray.cpp M Source/WebCore/Modules/webxr/WebXRInputSourceArray.h M Source/WebCore/Modules/webxr/XRInputSourcesChangeEvent.cpp M Source/WebCore/Modules/webxr/XRInputSourcesChangeEvent.h M Source/WebCore/Modules/webxr/XRRenderStateInit.h M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/bindings/IDLTypes.h M Source/WebCore/bindings/js/IDBBindingUtilities.cpp M Source/WebCore/bindings/js/JSDOMConvertSequences.h M Source/WebCore/bindings/js/JSElementCustom.cpp M Source/WebCore/bindings/js/JSElementInternalsCustom.cpp M Source/WebCore/bindings/js/SerializedScriptValue.cpp M Source/WebCore/bindings/js/SerializedScriptValue.h M Source/WebCore/css/CSSStyleSheetObservableArray.cpp M Source/WebCore/css/CSSStyleSheetObservableArray.h M Source/WebCore/css/FontFaceSet.cpp M Source/WebCore/css/FontFaceSet.h M Source/WebCore/css/typedom/transform/CSSTransformValue.cpp M Source/WebCore/css/typedom/transform/CSSTransformValue.h M Source/WebCore/dom/AbortSignal.cpp M Source/WebCore/dom/AbortSignal.h M Source/WebCore/dom/BroadcastChannel.cpp M Source/WebCore/dom/CustomElementDefaultARIA.cpp M Source/WebCore/dom/CustomElementDefaultARIA.h M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h M Source/WebCore/dom/ElementInternals.cpp M Source/WebCore/dom/ElementInternals.h M Source/WebCore/dom/GetHTMLOptions.h M Source/WebCore/dom/MessageEvent.cpp M Source/WebCore/dom/MessageEvent.h M Source/WebCore/dom/MessagePort.cpp M Source/WebCore/dom/MessagePort.h M Source/WebCore/dom/TreeScope.cpp M Source/WebCore/dom/TreeScope.h M Source/WebCore/editing/MarkupAccumulator.cpp M Source/WebCore/editing/MarkupAccumulator.h M Source/WebCore/editing/markup.cpp M Source/WebCore/editing/markup.h M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.h M Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp M Source/WebCore/inspector/InspectorAuditAccessibilityObject.h M Source/WebCore/page/LocalDOMWindow.cpp
[webkit-changes] [WebKit/WebKit] 3499eb: Rename parameter fontWeight to slope
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3499eb5b0abf7693c18e1aac2c17a0f6a57bad3c https://github.com/WebKit/WebKit/commit/3499eb5b0abf7693c18e1aac2c17a0f6a57bad3c Author: Noriaki Watanabe Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/FontSelectionAlgorithm.h Log Message: --- Rename parameter fontWeight to slope https://bugs.webkit.org/show_bug.cgi?id=269134 Reviewed by Tim Nguyen. This patch is just rename of `fontWeight` to `slope`. * Source/WebCore/platform/graphics/FontSelectionAlgorithm.h: (WebCore::isItalic): Canonical link: https://commits.webkit.org/277513@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d6540a: Regression(277427@main) Crash under AuxiliaryProce...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d6540a38e780083381887f821396c17f3b8391f0 https://github.com/WebKit/WebKit/commit/d6540a38e780083381887f821396c17f3b8391f0 Author: Chris Dumez Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebKit/Shared/AuxiliaryProcess.h M Source/WebKit/Shared/AuxiliaryProcess.messages.in M Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm M Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h M Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm Log Message: --- Regression(277427@main) Crash under AuxiliaryProcessProxy::notifyPreferencesChanged() https://bugs.webkit.org/show_bug.cgi?id=272695 rdar://126492909 Reviewed by Per Arne Vollan. We were using a HashMap to store preferences whose key was a std::pair. The first String was the domain and the second the preference name. However, for global preferences, the domain is null, causing a crash when hashing the key. To address an issue, we now store global preferences in a separate HashMap. * Source/WebKit/Shared/AuxiliaryProcess.h: * Source/WebKit/Shared/AuxiliaryProcess.messages.in: * Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm: (WebKit::AuxiliaryProcess::preferencesDidUpdate): * Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp: (WebKit::AuxiliaryProcessProxy::didChangeThrottleState): * Source/WebKit/UIProcess/AuxiliaryProcessProxy.h: * Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm: (WebKit::AuxiliaryProcessProxy::notifyPreferencesChanged): Canonical link: https://commits.webkit.org/277514@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 701085: [Site Isolation] Send editing commands to the proc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7010858c424812ec045664b054911473dc672ab9 https://github.com/WebKit/WebKit/commit/7010858c424812ec045664b054911473dc672ab9 Author: Charlie Wolfe Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- [Site Isolation] Send editing commands to the process hosting the focused frame https://bugs.webkit.org/show_bug.cgi?id=272655 rdar://126459110 Reviewed by Alex Christensen. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::executeEditCommand): * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST(SiteIsolation, SelectAll)): Canonical link: https://commits.webkit.org/277515@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5cdeb9: [JSC] Do not take concurrent JS lock on CodeBlock ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5cdeb9ec81887f1cdaae3780fb7d4bbbfc2ac8b8 https://github.com/WebKit/WebKit/commit/5cdeb9ec81887f1cdaae3780fb7d4bbbfc2ac8b8 Author: Yusuke Suzuki Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/JavaScriptCore/bytecode/CallLinkInfo.cpp M Source/JavaScriptCore/bytecode/CallLinkInfo.h M Source/JavaScriptCore/bytecode/CodeBlock.cpp M Source/JavaScriptCore/bytecode/CodeBlock.h Log Message: --- [JSC] Do not take concurrent JS lock on CodeBlock when repatching DirectCall on the main thread https://bugs.webkit.org/show_bug.cgi?id=272699 rdar://problem/126505237 Reviewed by Justin Michaud. Stop taking a ConcurrentJSLock for DirectCall repatching since this is happening on the main thread. * Source/JavaScriptCore/bytecode/CallLinkInfo.cpp: (JSC::DirectCallLinkInfo::retrieveCodeBlock): (JSC::DirectCallLinkInfo::retrieveCodePtr): (JSC::DirectCallLinkInfo::repatchSpeculatively): (JSC::DirectCallLinkInfo::validateSpeculativeRepatchOnMainThread): (JSC::DirectCallLinkInfo::retrieveCallInfo): Deleted. * Source/JavaScriptCore/bytecode/CallLinkInfo.h: * Source/JavaScriptCore/bytecode/CodeBlock.cpp: (JSC::CodeBlock::addressForCallConcurrently const): * Source/JavaScriptCore/bytecode/CodeBlock.h: Canonical link: https://commits.webkit.org/277516@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 095cf6: [Gardening]: REGRESSION (277494@main): [ MacOS ] i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 095cf6f551beabffb41284d1d46cc7567367a801 https://github.com/WebKit/WebKit/commit/095cf6f551beabffb41284d1d46cc7567367a801 Author: Jay Stfleur Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: REGRESSION (277494@main): [ MacOS ] inspector/canvas/context-attributes.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=126509990 rdar://126509990 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/277517@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 24afea: Add FIXME in `CSS*` IDL files and comments
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 24afea6105eb95fb3cf0acb2509cc7eec1242157 https://github.com/WebKit/WebKit/commit/24afea6105eb95fb3cf0acb2509cc7eec1242157 Author: Ahmad Saleem Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebCore/css/CSSConditionRule.idl M Source/WebCore/css/CSSContainerRule.idl M Source/WebCore/css/CSSFontFaceRule.idl M Source/WebCore/css/CSSFontFeatureValuesRule.idl M Source/WebCore/css/CSSFontPaletteValuesRule.idl M Source/WebCore/css/CSSGroupingRule.idl M Source/WebCore/css/CSSImportRule.idl M Source/WebCore/css/CSSKeyframeRule.idl M Source/WebCore/css/CSSKeyframesRule.idl M Source/WebCore/css/CSSLayerBlockRule.idl M Source/WebCore/css/CSSLayerStatementRule.idl M Source/WebCore/css/CSSMediaRule.idl M Source/WebCore/css/CSSPageRule.idl M Source/WebCore/css/CSSPropertyRule.idl M Source/WebCore/css/CSSRule.idl M Source/WebCore/css/CSSRuleList.idl M Source/WebCore/css/CSSScopeRule.idl M Source/WebCore/css/CSSStyleDeclaration.idl M Source/WebCore/css/CSSStyleSheet.idl M Source/WebCore/css/CSSSupportsRule.idl M Source/WebCore/css/DOMCSSCustomPropertyDescriptor.idl M Source/WebCore/css/DOMMatrix.idl M Source/WebCore/css/DOMMatrix2DInit.idl M Source/WebCore/css/DOMMatrixInit.idl M Source/WebCore/css/FontFace.idl M Source/WebCore/css/FontFaceSet.idl M Source/WebCore/css/LinkStyle.idl M Source/WebCore/css/MediaList.idl M Source/WebCore/css/MediaQueryList.idl M Source/WebCore/css/MediaQueryListEvent.idl M Source/WebCore/css/StyleSheet.idl M Source/WebCore/css/StyleSheetList.idl Log Message: --- Add FIXME in `CSS*` IDL files and comments https://bugs.webkit.org/show_bug.cgi?id=265327 Reviewed by Anne van Kesteren. This patch is to add FIXME links and web specification URLs for quick reference. * Source/WebCore/css/CSSConditionRule.idl: * Source/WebCore/css/CSSContainerRule.idl: * Source/WebCore/css/CSSFontFaceRule.idl: * Source/WebCore/css/CSSFontFeatureValuesRule.idl: * Source/WebCore/css/CSSFontPaletteValuesRule.idl: * Source/WebCore/css/CSSGroupingRule.idl: * Source/WebCore/css/CSSImportRule.idl: * Source/WebCore/css/CSSKeyframeRule.idl: * Source/WebCore/css/CSSKeyframeRule.idl: * Source/WebCore/css/CSSLayerBlockRule.idl: * Source/WebCore/css/CSSLayerStatementRule.idl: * Source/WebCore/css/CSSMediaRule.idl: * Source/WebCore/css/CSSPageRule.idl: * Source/WebCore/css/CSSPropertyRule.idl: * Source/WebCore/css/CSSRule.idl: * Source/WebCore/css/CSSRuleList.idl: * Source/WebCore/css/CSSScopeRule.idl: * Source/WebCore/css/CSSStyleDeclaration.idl: * Source/WebCore/css/CSSStyleSheet.idl: * Source/WebCore/css/CSSSupportsRule.idl: * Source/WebCore/css/DOMCSSCustomPropertyDescriptor.idl: * Source/WebCore/css/DOMMatrix.idl: * Source/WebCore/css/DOMMatrix2DInit.idl: * Source/WebCore/css/DOMMatrixInit.idl: * Source/WebCore/css/FontFace.idl: * Source/WebCore/css/FontFaceSet.idl: * Source/WebCore/css/LinkStyle.idl: * Source/WebCore/css/MediaList.idl: * Source/WebCore/css/MediaQueryList.idl: * Source/WebCore/css/MediaQueryListEvent.idl: * Source/WebCore/css/StyleSheet.idl: * Source/WebCore/css/StyleSheetList.idl: Canonical link: https://commits.webkit.org/277518@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 60e7ce: Adopt smart pointers for updateLayoutIgnorePending...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 60e7ce5c20bc02a0b06942cec2e35457ab9bce50 https://github.com/WebKit/WebKit/commit/60e7ce5c20bc02a0b06942cec2e35457ab9bce50 Author: Rob Buis Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/dom/Element.cpp M Source/WebCore/editing/CustomUndoStep.cpp M Source/WebCore/editing/DeleteSelectionCommand.cpp M Source/WebCore/html/HTMLButtonElement.cpp M Source/WebCore/html/HTMLFormElement.cpp M Source/WebCore/html/HTMLTextFormControlElement.cpp M Source/WebCore/html/ValidatedFormListedElement.cpp M Source/WebCore/page/FocusController.cpp M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/TextIndicator.cpp M Source/WebCore/page/UndoItem.h M Source/WebCore/svg/SVGLocatable.cpp Log Message: --- Adopt smart pointers for updateLayoutIgnorePendingStylesheets calls https://bugs.webkit.org/show_bug.cgi?id=272673 Reviewed by Chris Dumez. Adopt smart pointers for updateLayoutIgnorePendingStylesheets calls. * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::ComputedStyleExtractor::propertyValue const): * Source/WebCore/dom/Element.cpp: (WebCore::Element::getClientRects): * Source/WebCore/editing/CustomUndoStep.cpp: (WebCore::CustomUndoStep::unapply): (WebCore::CustomUndoStep::reapply): * Source/WebCore/editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::fixupWhitespace): * Source/WebCore/html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): * Source/WebCore/html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::requestSubmit): (WebCore::HTMLFormElement::reportValidity): * Source/WebCore/html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::setSelectionRange): * Source/WebCore/html/ValidatedFormListedElement.cpp: (WebCore::ValidatedFormListedElement::reportValidity): * Source/WebCore/page/FocusController.cpp: (WebCore::FocusController::findFocusableElementDescendingIntoSubframes): (WebCore::FocusController::advanceFocusDirectionallyInContainer): * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::scrollElementToRect): (WebCore::LocalFrameView::performFixedWidthAutoSize): * Source/WebCore/page/TextIndicator.cpp: (WebCore::initializeIndicator): * Source/WebCore/page/UndoItem.h: (WebCore::UndoItem::protectedDocument const): * Source/WebCore/svg/SVGLocatable.cpp: (WebCore::SVGLocatable::computeCTM): Canonical link: https://commits.webkit.org/277519@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 993b28: [WebGPU] https://playcanvas.github.io/#/animation/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 993b28656376d856853bb8a6214829dedab9ee4e https://github.com/WebKit/WebKit/commit/993b28656376d856853bb8a6214829dedab9ee4e Author: Mike Wyrzykowski Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebGPU/WebGPU/CommandEncoder.h M Source/WebGPU/WebGPU/CommandEncoder.mm M Source/WebGPU/WebGPU/RenderPassEncoder.mm Log Message: --- [WebGPU] https://playcanvas.github.io/#/animation/blend-trees-* are not loading https://bugs.webkit.org/show_bug.cgi?id=272617 Reviewed by Tadeu Zagallo. Clear operation was done incorrectly leading to Metal validation error failures in some PlayCanvas examples. * Source/WebGPU/WebGPU/CommandEncoder.h: * Source/WebGPU/WebGPU/CommandEncoder.mm: (WebGPU::loadAction): (WebGPU::storeAction): (WebGPU::CommandEncoder::runClearEncoder): (WebGPU::CommandEncoder::beginRenderPass): * Source/WebGPU/WebGPU/RenderPassEncoder.mm: (WebGPU::m_maxDrawCount): (WebGPU::RenderPassEncoder::endPass): Canonical link: https://commits.webkit.org/277520@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 84ebf5: heap-use-after-free | Style::Resolver::setViewTran...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 84ebf5141996487b18210ca5c38429477fc7eb23 https://github.com/WebKit/WebKit/commit/84ebf5141996487b18210ca5c38429477fc7eb23 Author: Tim Nguyen Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: A LayoutTests/fast/css/view-transitions-update-pseudo-element-crash-expected.txt A LayoutTests/fast/css/view-transitions-update-pseudo-element-crash.html M Source/WebCore/dom/ViewTransition.cpp Log Message: --- heap-use-after-free | Style::Resolver::setViewTransitionStyles; WebCore::ViewTransition::updatePseudoElementStyles; WebCore::ViewTransition::activateViewTransition https://bugs.webkit.org/show_bug.cgi?id=272709 rdar://125944789 Reviewed by Chris Dumez. Adopt `Ref` smart pointer to fix the UAF. * LayoutTests/fast/css/view-transitions-update-pseudo-element-crash-expected.txt: Added. * LayoutTests/fast/css/view-transitions-update-pseudo-element-crash.html: Added. * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::setupDynamicStyleSheet): (WebCore::ViewTransition::updatePseudoElementStyles): Canonical link: https://commits.webkit.org/277521@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d6d7fc: NEW TEST (277048@main): [ Sonoma WK1 ] 2X imported...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d6d7fca5ebf8e4f5daad54158947b3f0792ecd81 https://github.com/WebKit/WebKit/commit/d6d7fca5ebf8e4f5daad54158947b3f0792ecd81 Author: Jay Stfleur Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- NEW TEST (277048@main): [ Sonoma WK1 ] 2X imported/w3c/web-platform-tests/web-animations/animation-model/side-effects-of-animations are consistent failures https://bugs.webkit.org/show_bug.cgi?id=272718 rdar://126517188 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/277522@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 98fb77: [Site Isolation] Popup menus are incorrectly offset
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 98fb7757cc6a4966bd71a0105938f6f97d9e8abe https://github.com/WebKit/WebKit/commit/98fb7757cc6a4966bd71a0105938f6f97d9e8abe Author: Charlie Wolfe Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.cpp Log Message: --- [Site Isolation] Popup menus are incorrectly offset https://bugs.webkit.org/show_bug.cgi?id=272694 rdar://126497992 Reviewed by Alex Christensen. When a popup menu is opened from an isolated iframe the menu will be offset because iframe processes cannot convert to root view coordinates. To convert to root view coordinates we need to convert from the parent of each root frame. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showPopupMenuFromFrame): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.cpp: (WebKit::WebPopupMenu::show): Canonical link: https://commits.webkit.org/277523@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 02f471: Remove new passes from test262 expectations
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 02f471e34f5612ccd9546a9a4615fc7d22980561 https://github.com/WebKit/WebKit/commit/02f471e34f5612ccd9546a9a4615fc7d22980561 Author: Ross Kirsling Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M JSTests/test262/expectations.yaml Log Message: --- Remove new passes from test262 expectations https://bugs.webkit.org/show_bug.cgi?id=272719 Unreviewed test gardening. * JSTests/test262/expectations.yaml: Remove 10 tests which the bot considers "newly passing". Canonical link: https://commits.webkit.org/277524@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 87aaaf: Fix "Unkown" typo in ScreenCaptureKitCaptureSource.mm
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 87aaafb1c0c5bfd13282b76c9df1ea9047d1dca5 https://github.com/WebKit/WebKit/commit/87aaafb1c0c5bfd13282b76c9df1ea9047d1dca5 Author: Chris Dumez Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm Log Message: --- Fix "Unkown" typo in ScreenCaptureKitCaptureSource.mm https://bugs.webkit.org/show_bug.cgi?id=272712 rdar://125260065 Reviewed by Darin Adler. * Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm: (WebCore::ScreenCaptureKitCaptureSource::startContentStream): Canonical link: https://commits.webkit.org/277525@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4b1613: [JSC] `Set#symmetricDifference` should call `this....
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4b16138ae6dd3449c3b7b5a7c17f67a69b40d340 https://github.com/WebKit/WebKit/commit/4b16138ae6dd3449c3b7b5a7c17f67a69b40d340 Author: Sosuke Suzuki Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: A JSTests/stress/set-prototype-symmetricDifference-mutate-this.js M JSTests/test262/expectations.yaml M Source/JavaScriptCore/builtins/SetPrototype.js Log Message: --- [JSC] `Set#symmetricDifference` should call `this.has` in each iteration https://bugs.webkit.org/show_bug.cgi?id=272679 Reviewed by Yusuke Suzuki. According to the spec[1](7.b.iv), `SetDataHas` in each iteration of `Set#symmetricDifference` should be called on `O`, not on `resultSetData`. [1]: https://tc39.es/proposal-set-methods/#sec-set.prototype.symmetricdifference * JSTests/stress/set-prototype-symmetricDifference-mutate-this.js: Added. (shouldBe): (const.setB.has): (const.setB.keys): * JSTests/test262/expectations.yaml: * Source/JavaScriptCore/builtins/SetPrototype.js: (symmetricDifference): Canonical link: https://commits.webkit.org/277526@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 908ce1: Remove legacy serialization infrastructure startin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 908ce185ca46f4abbf99e821bd312442abe80bfb https://github.com/WebKit/WebKit/commit/908ce185ca46f4abbf99e821bd312442abe80bfb Author: Alex Christensen Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WTF/wtf/ArgumentCoder.h M Source/WTF/wtf/PlatformHave.h M Source/WebKit/Platform/IPC/Decoder.h Log Message: --- Remove legacy serialization infrastructure starting with Cocoa platform https://bugs.webkit.org/show_bug.cgi?id=272703 rdar://126508648 Reviewed by Brady Eidson. This is the first step towards removing legacy encoding. Cocoa's data structures have migrated to *.serialization.in with a few exceptions that have been handled manually. Other platforms still have a small amount of work to do, but this will help clarify what is needed. * Source/WTF/wtf/ArgumentCoder.h: * Source/WTF/wtf/PlatformHave.h: * Source/WebKit/Platform/IPC/Decoder.h: (IPC::Decoder::decode): Canonical link: https://commits.webkit.org/277527@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0080e4: [Site Isolation] System popup menus cannot be reop...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0080e4eb3dcbd3b488c21ec68b893b3d13b68aa5 https://github.com/WebKit/WebKit/commit/0080e4eb3dcbd3b488c21ec68b893b3d13b68aa5 Author: Charlie Wolfe Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- [Site Isolation] System popup menus cannot be reopened after being closed https://bugs.webkit.org/show_bug.cgi?id=272696 rdar://126500622 Reviewed by Alex Christensen. When a system popup menu is closed a message is sent to the web process to indicate that it has been dismissed. This message should be sent to the web process the popup is open in, not always the main frame process. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::Internals::valueChangedForPopupMenu): Canonical link: https://commits.webkit.org/277528@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 79238c: [JetStream2] Update Public JetStream to version 2.2
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 79238c6cece35bc955045d5f26206a120280288f https://github.com/WebKit/WebKit/commit/79238c6cece35bc955045d5f26206a120280288f Author: Michael Saboff Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: A Websites/browserbench.org/JetStream2.2/ARES-6/Air/README.md A Websites/browserbench.org/JetStream2.2/ARES-6/Air/airjs-tests.yaml A Websites/browserbench.org/JetStream2.2/ARES-6/Air/all.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/allocate_stack.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/arg.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/basic_block.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/benchmark.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/code.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/custom.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/frequented_block.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/insertion_set.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/inst.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/liveness.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/make_dist.sh A Websites/browserbench.org/JetStream2.2/ARES-6/Air/opcode.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/payload-airjs-ACLj8C.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/payload-gbemu-executeIteration.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/payload-imaging-gaussian-blur-gaussianBlur.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/payload-typescript-scanIdentifier.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/reg.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/stack_slot.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/stress-test.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/strip-hash.rb A Websites/browserbench.org/JetStream2.2/ARES-6/Air/symbols.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/test.html A Websites/browserbench.org/JetStream2.2/ARES-6/Air/test.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/tmp.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/tmp_base.js A Websites/browserbench.org/JetStream2.2/ARES-6/Air/util.js A Websites/browserbench.org/JetStream2.2/ARES-6/Babylon/AUTHORS A Websites/browserbench.org/JetStream2.2/ARES-6/Babylon/air-blob.js A Websites/browserbench.org/JetStream2.2/ARES-6/Babylon/babylon-blob.js A Websites/browserbench.org/JetStream2.2/ARES-6/Babylon/basic-blob.js A Websites/browserbench.org/JetStream2.2/ARES-6/Babylon/benchmark.js A Websites/browserbench.org/JetStream2.2/ARES-6/Babylon/index.js A Websites/browserbench.org/JetStream2.2/ARES-6/Babylon/inspector-blob.js A Websites/browserbench.org/JetStream2.2/ARES-6/Basic/ast.js A Websites/browserbench.org/JetStream2.2/ARES-6/Basic/basic-tests.yaml A Websites/browserbench.org/JetStream2.2/ARES-6/Basic/basic.js A Websites/browserbench.org/JetStream2.2/ARES-6/Basic/benchmark.js A Websites/browserbench.org/JetStream2.2/ARES-6/Basic/caseless_map.js A Websites/browserbench.org/JetStream2.2/ARES-6/Basic/lexer.js A Websites/browserbench.org/JetStream2.2/ARES-6/Basic/number.js A Websites/browserbench.org/JetStream2.2/ARES-6/Basic/parser.js A Websites/browserbench.org/JetStream2.2/ARES-6/Basic/random.js A Websites/browserbench.org/JetStream2.2/ARES-6/Basic/state.js A Websites/browserbench.org/JetStream2.2/ARES-6/Basic/stress-test.js A Websites/browserbench.org/JetStream2.2/ARES-6/Basic/test.html A Websites/browserbench.org/JetStream2.2/ARES-6/Basic/test.js A Websites/browserbench.org/JetStream2.2/ARES-6/Basic/util.js A Websites/browserbench.org/JetStream2.2/ARES-6/ml/benchmark.js A Websites/browserbench.org/JetStream2.2/ARES-6/ml/index.js A Websites/browserbench.org/JetStream2.2/JetStream.css A Websites/browserbench.org/JetStream2.2/JetStream2Logo.svg A Websites/browserbench.org/JetStream2.2/JetStreamDriver.js A Websites/browserbench.org/JetStream2.2/LuaJSFight/hello_world.js A Websites/browserbench.org/JetStream2.2/LuaJSFight/list_search.js A Websites/browserbench.org/JetStream2.2/LuaJSFight/lists.js A Websites/browserbench.org/JetStream2.2/LuaJSFight/richards.js A Websites/browserbench.org/JetStream2.2/LuaJSFight/string_lists.js A Websites/browserbench.org/JetStream2.2/Octane/box2d.js A Websites/browserbench.org/JetStream2.2/Octane/code-first-load.js A Websites/browserbench.org/JetStream2.2/Octane/crypto.js A Websites/browserbench.org/JetStream2.2/Octane/deltablue.js A Websites/browserbench.org/JetStream2.2/Octane/earley-boyer.js A Websites/browserbench.org/JetStream2.2/Octane/gbemu-part1.js A Websites/browserbench.org/JetStream2.2/Octane/gbemu-part2.js A Websites/browserbench.org/JetStream2.2/Oct
[webkit-changes] [WebKit/WebKit] 8df490: REGRESSION [ iOS ] 5X TestWebKitAPI.CopyRTF.Strips...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8df4906592e14d06bf448b40c426081479e8f931 https://github.com/WebKit/WebKit/commit/8df4906592e14d06bf448b40c426081479e8f931 Author: Ryosuke Niwa Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Tools/Scripts/webkitpy/port/darwin.py Log Message: --- REGRESSION [ iOS ] 5X TestWebKitAPI.CopyRTF.Strips are crashing and failing https://bugs.webkit.org/show_bug.cgi?id=272239 rdar://125982015 Reviewed by Wenson Hsieh, Tim Horton and Chris Dumez. Set __XPC___XPC_DYLD_LIBRARY_PATH and __XPC___XPC_DYLD_FRAMEWORK_PATH so that nsattributedstringagent will launch WebKit processes with _XPC_DYLD_LIBRARY_PATH and _XPC_DYLD_FRAMEWORK_PATH set. * Tools/Scripts/webkitpy/port/darwin.py: (DarwinPort.environment_for_api_tests): Canonical link: https://commits.webkit.org/277530@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 939e70: URL::setHostAndPort() needs to be aware of host de...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 939e7000670a9204a8b03f31f9ebd252d7486a1f https://github.com/WebKit/WebKit/commit/939e7000670a9204a8b03f31f9ebd252d7486a1f Author: Anne van Kesteren Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M LayoutTests/fast/dom/DOMURL/set-href-attribute-host-expected.txt M LayoutTests/fast/dom/DOMURL/set-href-attribute-host.html M LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt M LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host.html M LayoutTests/fast/dom/set-document-location-host-to-unaccepted-values-expected.txt M LayoutTests/fast/dom/set-document-location-host-to-unaccepted-values.html M LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_include=file-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/a-element_include=file-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/resources/setters_tests.json M LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json M LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_include=file-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_include=file-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker_exclude=(file_javascript_mailto)-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any_exclude=(file_javascript_mailto)-expected.txt M Source/WTF/wtf/URL.cpp M Source/WTF/wtf/URL.h M Source/WebCore/dom/Document.cpp M Source/WebCore/html/URLDecomposition.cpp M Source/WebCore/loader/DocumentLoader.cpp Log Message: --- URL::setHostAndPort() needs to be aware of host delimiters https://bugs.webkit.org/show_bug.cgi?id=270425 rdar://124363495 Reviewed by Alex Christensen. URL::setHostAndPort() didn't have the delimiter check from URL::setHost(). However, once you pull that in URLDecomposition::setHost() (which calls URL::setHostAndPort()) starts doing the wrong thing. So this moves its logic into URL::setHostAndPort(). Similar to how URLDecomposition::setHostname() and URL::setHost() already share most of their logic. Then, for two special callers of URL::setHostAndPort() that want to remove the host and port only, this adds URL::removeHostAndPort() that does just that as the new URL::setHostAndPort() doesn't quite do what they want anymore. This synchronizes with web-platform-tests up to and including this PR: https://github.com/web-platform-tests/wpt/pull/45688 * LayoutTests/fast/dom/DOMURL/set-href-attribute-host-expected.txt: * LayoutTests/fast/dom/DOMURL/set-href-attribute-host.html: * LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: * LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host.html: * LayoutTests/fast/dom/set-document-location-host-to-unaccepted-values-expected.txt: * LayoutTests/fast/dom/set-document-location-host-to-unaccepted-values.html: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_include=file-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element_include=file-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/resources/setters_tests.json: * LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_include=file-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_include=file-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any_exclude=(file_javascript_mailto)-expected.txt: * Source/WTF/wtf/URL.cpp: (WTF::countASCIIDigits): (WTF::URL::setHostAndPort): (WTF::URL::removeHostAndPort): * Source/WTF/wtf/URL.h: * Source/WebCore/dom/Document.cpp: (WebCore::Document::setURL): * Source/WebCore/html/URLDecomposition.cpp: (WebCore::URLDecomposition::setHost): (WebCore::countASCIIDigits): Deleted. * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::DocumentLoader::willSendRequest): Canonical link: https://commits.webkit.org/277531@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ec49bb: [MSE] Decoding errors when appending segment with ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ec49bb21041cfed7ffb5227ecf637c9e3ea2e594 https://github.com/WebKit/WebKit/commit/ec49bb21041cfed7ffb5227ecf637c9e3ea2e594 Author: Carlos Bentzen Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: A LayoutTests/media/media-source/media-source-samples-out-of-order-erase-sync-frames-expected.txt A LayoutTests/media/media-source/media-source-samples-out-of-order-erase-sync-frames.html M Source/WebCore/platform/graphics/SourceBufferPrivate.cpp Log Message: --- [MSE] Decoding errors when appending segment with B-frames and previous segment ends with an I-frame https://bugs.webkit.org/show_bug.cgi?id=272521 Reviewed by Xabier Rodriguez-Calvar. When a segment containing B-frames is appended, WebKit has logic to erase frames from the previous segment and avoid decoding glitches (219507@main). However, the current logic falls short in one edge case: if the previous segment ends with an I-frame in the overlap region to be erased. If the demuxer honors ISOBMFF edit lists, then the first I-frame from an incoming segment with B-frames can be placed earlier in decoding order than the last (I-)frame from the previous segment (potentially with different resolution), and that last I-frame doesn't get erased, and will be pushed for decoding. This confuses the decoder and the following P/B frames will fail to decode or decode incorrectly with artifacts due to missing/incorrect reference frame. This patch fixes this edge case by allowing I-frames to be erased from the track buffer only if they are presented earlier than the incoming I-frame. We remove frames from the track buffer until we find an I-frame that is presented later than the incoming I-frame. This handles the case when we get multiple I-frames in the overlapping area, as exercised in the layout test. Credit to Vivek Arumugam for initially finding the bug and investigating this. This patch builds on top of a patch he proposed. * LayoutTests/media/media-source/media-source-samples-out-of-order-erase-sync-frames-expected.txt: Added. * LayoutTests/media/media-source/media-source-samples-out-of-order-erase-sync-frames.html: Added. * Source/WebCore/platform/graphics/SourceBufferPrivate.cpp: (WebCore::SourceBufferPrivate::processMediaSample): Canonical link: https://commits.webkit.org/277532@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
