Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 21426dee35a1783145f695ceed7defb1d464652e
https://github.com/WebKit/WebKit/commit/21426dee35a1783145f695ceed7defb1d464652e
Author: Antti Koivisto <an...@apple.com>
Date: 2024-04-15 (Mon, 15 Apr 2024)
Changed paths:
A
LayoutTests/fast/block/positioning/simple-out-of-flow-percent-height-expected.html
A LayoutTests/fast/block/positioning/simple-out-of-flow-percent-height.html
M Source/WebCore/rendering/RenderBlockFlow.cpp
Log Message:
-----------
REGRESSION(271848@main): "Watch later" checkbox on youtube.com mis-renders
https://bugs.webkit.org/show_bug.cgi?id=272665
rdar://125644808
Reviewed by Alan Baradlay.
Percent height out-of-flow positioned boxes taking the fast path may end up
with miscomputed height.
*
LayoutTests/fast/block/positioning/simple-out-of-flow-percent-height-expected.html:
Added.
* LayoutTests/fast/block/positioning/simple-out-of-flow-percent-height.html:
Added.
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutModernLines):
Disable the out-of-flow fast path if there are percent height boxes. The
problem is that the fast path
does a synchronous layout for these boxes before the height of the parent is
computed.
The synchronous layout itself is a workaround but fixing it may be more
complicated.
Canonical link: https://commits.webkit.org/277501@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
