Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bffda80ff3ade29d8e40f3615d3e5d4e9c549135
https://github.com/WebKit/WebKit/commit/bffda80ff3ade29d8e40f3615d3e5d4e9c549135
Author: Tadeu Zagallo <tzaga...@apple.com>
Date: 2024-04-15 (Mon, 15 Apr 2024)
Changed paths:
A
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/ai_arithmetic-expected.txt
A
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/ai_comparison-expected.txt
A
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/bitcast-expected.txt
A
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/ai_arithmetic-expected.txt
A
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/ai_assignment-expected.txt
A
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/ai_complement-expected.txt
M Source/WebGPU/WGSL/ConstantFunctions.h
M Source/WebGPU/WGSL/Lexer.cpp
M Source/WebGPU/WGSL/Lexer.h
M Source/WebGPU/WGSL/Parser.cpp
M Source/WebGPU/WGSL/Token.h
M Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp
Log Message:
-----------
[WebGPU]
shader,execution,expression,binary,ai_arithmetic:addition_scalar_vector:*
appears to hang
https://bugs.webkit.org/show_bug.cgi?id=272574
rdar://126331501
Reviewed by Mike Wyrzykowski.
There 2 bugs in this test:
- the constant shift left builtin incorrectly reported an overflow on abstract
integers due to using a 32 bit value for the mask it uses to validate
- the lexer used a double to represent all literal values, which can not
represent
all 64-bit integers
All of the new abstract integer CTS tests are now passing. I also added the
expectations for the bitcast test which includes some cases for abstract
integers.
*
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/ai_arithmetic-expected.txt:
Added.
*
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/ai_comparison-expected.txt:
Added.
*
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/bitcast-expected.txt:
Added.
*
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/ai_arithmetic-expected.txt:
Added.
*
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/ai_assignment-expected.txt:
Added.
*
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/ai_complement-expected.txt:
Added.
* Source/WebGPU/WGSL/ConstantFunctions.h:
(WGSL::CONSTANT_FUNCTION):
* Source/WebGPU/WGSL/Lexer.cpp:
(WGSL::Lexer<T>::lexNumber):
* Source/WebGPU/WGSL/Lexer.h:
(WGSL::Lexer::makeFloatToken):
(WGSL::Lexer::makeIntegerToken):
(WGSL::Lexer::makeLiteralToken): Deleted.
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parsePrimaryExpression):
* Source/WebGPU/WGSL/Token.h:
(WGSL::Token::Token):
(WGSL::Token::operator=):
* Tools/TestWebKitAPI/Tests/WGSL/LexerTests.cpp:
(TestWGSLAPI::checkSingleIntegerLiteral):
(TestWGSLAPI::checkSingleFloatLiteral):
(TestWGSLAPI::checkNextTokenIsIntegerLiteral):
(TestWGSLAPI::checkNextTokenIsFloatLiteral):
(TestWGSLAPI::TEST(WGSLLexerTests, SingleTokens)):
(TestWGSLAPI::TEST(WGSLLexerTests, ComputeShader)):
(TestWGSLAPI::TEST(WGSLLexerTests, GraphicsShader)):
(TestWGSLAPI::TEST(WGSLLexerTests, TriangleVert)):
(TestWGSLAPI::checkSingleLiteral): Deleted.
(TestWGSLAPI::checkNextTokenIsLiteral): Deleted.
Canonical link: https://commits.webkit.org/277498@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
